From 21895cb2a15fc21f750fc10c78e9bbad4fa496a6 Mon Sep 17 00:00:00 2001 From: rohanlahori Date: Tue, 22 Oct 2024 02:00:58 +0530 Subject: [PATCH 1/3] reverted folder count changes --- frontend/src/HomePage/Folders.jsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/frontend/src/HomePage/Folders.jsx b/frontend/src/HomePage/Folders.jsx index 8818e65be6..15780cbe5a 100644 --- a/frontend/src/HomePage/Folders.jsx +++ b/frontend/src/HomePage/Folders.jsx @@ -316,11 +316,7 @@ export const Folders = function Folders({ className="flex-grow-1 tj-folder-list tj-text-xsm" data-cy={`${folder.name.toLowerCase().replace(/\s+/g, '-')}-name`} > - {folder.id === activeFolder.id ? ( - {`${folder.name}${folder.count > 0 ? ` (${activeFolderAppCount})` : ''}`} - ) : ( - {`${folder.name}${folder.count > 0 ? ` (${folder.count})` : ''}`} - )} + {`${folder.name}${folder.count > 0 ? ` (${folder.count})` : ''}`} {(canDeleteFolder || canUpdateFolder) && ( From 7f0a3b145f98e04b5ca54211a7ce6db6b01c7d0c Mon Sep 17 00:00:00 2001 From: rohanlahori Date: Tue, 22 Oct 2024 10:46:29 +0530 Subject: [PATCH 2/3] reverted folder count changes --- frontend/src/HomePage/Folders.jsx | 6 ------ frontend/src/HomePage/HomePage.jsx | 1 - 2 files changed, 7 deletions(-) diff --git a/frontend/src/HomePage/Folders.jsx b/frontend/src/HomePage/Folders.jsx index 15780cbe5a..e62bc1c919 100644 --- a/frontend/src/HomePage/Folders.jsx +++ b/frontend/src/HomePage/Folders.jsx @@ -25,7 +25,6 @@ export const Folders = function Folders({ canDeleteFolder, canCreateApp, darkMode, - searchedAppCount, }) { const [isLoading, setLoadingStatus] = useState(foldersLoading); const [showInput, setShowInput] = useState(false); @@ -41,14 +40,10 @@ export const Folders = function Folders({ const [activeFolder, setActiveFolder] = useState(currentFolder || {}); const [filteredData, setFilteredData] = useState(folders); const [errorText, setErrorText] = useState(''); - const [activeFolderAppCount, setActiveFolderAppCount] = useState(activeFolder.count); const navigate = useNavigate(); const { t } = useTranslation(); const { updateSidebarNAV } = useContext(BreadCrumbContext); - useEffect(() => { - setActiveFolderAppCount(searchedAppCount); - }, [searchedAppCount]); useEffect(() => { setLoadingStatus(foldersLoading); // eslint-disable-next-line react-hooks/exhaustive-deps @@ -111,7 +106,6 @@ export const Folders = function Folders({ updateSidebarNAV(folder?.name ?? 'All apps'); //update the url query parameter with folder name updateFolderQuery(folder?.name); - setActiveFolderAppCount(folder.count); } function updateFolderQuery(name) { diff --git a/frontend/src/HomePage/HomePage.jsx b/frontend/src/HomePage/HomePage.jsx index 15219269e0..9f93dfdf8c 100644 --- a/frontend/src/HomePage/HomePage.jsx +++ b/frontend/src/HomePage/HomePage.jsx @@ -843,7 +843,6 @@ class HomePageComponent extends React.Component { canUpdateFolder={this.canUpdateFolder()} darkMode={this.props.darkMode} canCreateApp={this.canCreateApp()} - searchedAppCount={this.state.searchedAppCount} /> From 016ae90f3817ea2fc30f1bce869d61755b445552 Mon Sep 17 00:00:00 2001 From: rohanlahori Date: Tue, 22 Oct 2024 10:58:34 +0530 Subject: [PATCH 3/3] removed dropdown for all apps --- .../AddEditResourcePermissionsModal.jsx | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/frontend/src/ManageGranularAccess/AddEditResourceModal/AddEditResourcePermissionsModal.jsx b/frontend/src/ManageGranularAccess/AddEditResourceModal/AddEditResourcePermissionsModal.jsx index e70441a58e..783b008051 100644 --- a/frontend/src/ManageGranularAccess/AddEditResourceModal/AddEditResourcePermissionsModal.jsx +++ b/frontend/src/ManageGranularAccess/AddEditResourceModal/AddEditResourcePermissionsModal.jsx @@ -171,14 +171,16 @@ function AddEditResourcePermissionsModal({ - + {isCustom && ( + + )}