Elgato_dark/Terasology
1
0
Fork 0
mirror of https://github.com/MovingBlocks/Terasology synced 2026-05-24 09:28:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: add private serialisation cases to type serialiser tests (#5217)

Browse source
This commit is contained in:
BenjaminAmos 2024-03-08 08:37:57 +00:00 committed by GitHub
parent 23b83d6a38
commit ed7a3d64e4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
engine-tests/src/test/java/org/terasology/engine/persistence/serializers/TypeSerializerTest.java
View file

@ -110,15 +110,19 @@ void testJsonSerializeDeserialize() throws IOException {
assertEquals(INSTANCE, deserializedInstance);
}
@SuppressWarnings("PMD.UnusedPrivateField")
public static final class SomeClass<T> {
@SerializedName("generic-t")
public T data;
public List<T> list = Lists.newArrayList();
public Set<Animal<?>> animals = Sets.newHashSet();
public Animal<T> singleAnimal;
@SerializedName("private-generic-t")
private final T privateData;
SomeClass(T data) {
this.data = data;
this.privateData = data;
}
@Override

27
subsystems/TypeHandlerLibrary/src/test/java/org/terasology/persistence/typeHandling/coreTypes/factories/ObjectFieldMapTypeHandlerFactoryTest.java
View file

@ -55,6 +55,16 @@ public void testMultiTypeClassTypeHandlerCreationViaFactory() {
assertTrue(typeHandler.get() instanceof ObjectFieldMapTypeHandler);
}
@Test
@DisplayName("Test that type handler is correctly created via type handler factory")
public void testMixedVisibilityTypeClassTypeHandlerCreationViaFactory() {
Optional<TypeHandler<PublicPrivateMixedClass<Integer, List<Integer>>>> typeHandler =
typeHandlerFactory.create(new TypeInfo<PublicPrivateMixedClass<Integer, List<Integer>>>() { }, context);
assertTrue(typeHandler.isPresent());
assertTrue(typeHandler.get() instanceof ObjectFieldMapTypeHandler);
}
@Test
@DisplayName("Test implicit type handler loading for plain old java objects (pojo)")
public void testPojo() {
@ -91,6 +101,18 @@ public void testMultipleObjectsOfSameType() {
verify(typeHandlerLibrary, never()).getTypeHandler((TypeInfo<Object>) any());
}
@Test
@DisplayName("Test implicit type handler loading for multiple objects of same type but differing visibility")
public void testMixedVisibilityMultipleObjectsOfSameType() {
typeHandlerFactory.create(new TypeInfo<PublicPrivateMixedClass<Integer, Integer>>() { }, context);
// Verify that the Integer TypeHandler loading was called on the TypeHandlerLibrary
verify(typeHandlerLibrary, times(1)).getTypeHandler((Type) any());
verify(typeHandlerLibrary, times(1)).getTypeHandler(eq(TypeInfo.of(Integer.class).getType()));
verify(typeHandlerLibrary, never()).getTypeHandler((Class<Object>) any());
verify(typeHandlerLibrary, never()).getTypeHandler((TypeInfo<Object>) any());
}
@Test
@DisplayName("Test implicit type handler loading for multiple objects of different type")
public void testMultipleObjectsOfDifferentType() {
@ -113,6 +135,11 @@ private static class MultiTypeClass<T, U> {
public U u;
}
private static class PublicPrivateMixedClass<T, U> {
public T t;
private U u;
}
@edu.umd.cs.findbugs.annotations.SuppressFBWarnings(
value = "UUF_UNUSED_FIELD",
justification = "Direct member access is not expected. TypeHandler factory dynamically loads type handlers on type handler" +