mirror of
https://github.com/open-metadata/OpenMetadata
synced 2026-05-24 09:39:11 +00:00
* chore(ingestion): drop pylint, expand ruff to Stage 2c
Replace pylint with a coherent ruff-only stack (Stage 2c of the modernize
roadmap). Pylint is dropped from dev deps and CI workflows; ruff selected
ruleset expanded to ~22 families covering style, bug catchers, hygiene,
and the pylint port (PLE/PLC/PLW/PLR with the noisy "too-many-X"
complexity caps + magic-value disabled).
What's selected (with rationale in pyproject.toml):
E, W, F, I, N — style + correctness baseline + naming
UP — pyupgrade (py>=3.10 modernizations)
B, C4, C90, RET, SIM, TRY — bug catchers
PIE, ICN, T20, TC, TID, PTH, PERF — hygiene
PLE, PLC, PLW, PLR — pylint port (PLR complexity caps ignored)
RUF — ruff-native (incl. RUF100 unused-noqa)
What's removed:
- .pylintrc (root) — duplicate of the ingestion pylint config
- [tool.pylint.*] block in ingestion/pyproject.toml (~140 lines)
- ingestion/plugins/{print_checker,import_checker}.py + tests + README
(replaced by built-in T20 + TID251 banned-api respectively)
- pylint dep from ingestion/setup.py and openmetadata-airflow-apis/pyproject.toml
- `make lint` Makefile target + the pylint invocation in py_format_check
- dead pylint TODO comment + ignored test entry in noxfile.py
Cwd-stable config: ruff is invoked both from the repo root (pre-commit,
CI) and from ingestion/ (`make py_format_check`). The `src`,
`extend-exclude`, and per-file-ignores entries are listed twice — once
relative to ingestion/ and once with the `ingestion/` prefix — so
first-party isort detection and exclusions match in both invocations.
Grandfathering: ran `ruff check --add-noqa` once + format-stable
iteration. ~12,130 noqa directives across ~1,400 files. Cleanup is
deferred to follow-up PRs that drop noqas one rule at a time.
Documentation sweep: replaced `make lint` references in CLAUDE.md,
AGENTS.md, DEVELOPER.md, copilot-instructions, and 6 SKILL files with
the apply+verify shape `make py_format && make py_format_check`.
`make py_format` is NOT a strict superset of pylint — it only applies
auto-fixable violations; `make py_format_check` catches the rest.
Basedpyright baseline regenerated: ruff format reflowed multi-line
signatures in ~70 files, shifting type-error column positions. The
basedpyright baseline matches by (file path, error code, range), so
column shifts caused 19 entries to mis-align. Net diff is small
(154 lines in/out of the 13MB baseline.json) — purely positional.
Verified locally:
- make py_format_check → All checks passed
- nox --no-venv -s static-checks → 0 errors, 0 warnings, 0 notes
* chore(ingestion): finish ruff swap — nox lint session + skill docs
Three remaining stale-tooling references after Stage 2c:
- `ingestion/noxfile.py` `lint` session was still calling `black --check`,
`isort --check-only`, `pycln --diff`. Those tools aren't installed
anywhere (we dropped them from dev deps). Replace with the ruff
equivalents that mirror `make py_format_check`.
- `skills/standards/code_style.md`: stack listed as `black + isort +
pycln`; line length claimed 88 (black default). Both wrong: stack is
ruff, line length is 120.
- `skills/connector-building/SKILL.md`: `make py_format` comment said
`# black + isort + pycln`. Same swap.
* chore(ingestion): keep main's baseline + globally ignore TRY400
Per gitar-bot's review on PR #27774:
1. Main's PR #27728 promoted ~60 `logger.warning()` → `logger.error()`
inside `except` blocks. Those changes landed on main with their own
baseline updates. Our PR doesn't promote anything — the merge from
origin/main brought those `error` calls along with their baseline
entries.
The bot interpreted the `# noqa: TRY400` we added next to those lines
as us silencing the rule case-by-case. Cleaner: globally ignore
TRY400 in pyproject.toml, with a comment explaining why the codebase's
`logger.error(...)` + separate `logger.debug(traceback.format_exc())`
pattern is intentional. Strip ~430 per-line `# noqa: TRY400` markers
from source.
2. Document that `S101` in `per-file-ignores` is a forward-looking
entry — flake8-bandit (`S`) is not yet selected, so the rule is
no-op today; the entry stays so when `S` lands later, tests don't
immediately error.
Reverts the platform pin and Linux Docker–generated baseline. Keep
main's baseline intact and let CI surface the exact column-shifted
entries; the team will decide whether to fix in-place (revert format
on affected files) or add per-line `# pyright: ignore` markers.
* chore(ingestion): regen baseline for new connector type debt
Main's baseline was stale relative to recently-added connectors
(McpConnection, CustomDriveConnection) that lack common attributes
like `hostPort`, `database`, `catalog` etc. — all sites that access
those attributes via the union-typed `serviceConnection.root.config`
fire `reportAttributeAccessIssue` errors that aren't baselined.
71 errors + 58 warnings absorbed. Local macOS regen; pushing to see
CI's drift count. Per the basedpyright-baseline-and-ci PR experience,
macOS↔Linux column drift on this size of regen has historically been
1-7 residuals.
136 lines
4.7 KiB
Python
136 lines
4.7 KiB
Python
# Copyright 2025 Collate
|
|
# Licensed under the Collate Community License, Version 1.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
# https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/LICENSE
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""
|
|
Protobuf parser tests
|
|
"""
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
from metadata.generated.schema.entity.data.table import Column
|
|
from metadata.parsers.protobuf_parser import ProtobufParser, ProtobufParserConfig
|
|
from metadata.utils.messaging_utils import merge_and_clean_protobuf_schema
|
|
|
|
|
|
@pytest.fixture(scope="class")
|
|
def protobuf_base_path(worker_id):
|
|
worker_suffix = f"_{worker_id}" if worker_id != "master" else ""
|
|
return f"/tmp/protobuf_openmetadata{worker_suffix}"
|
|
|
|
|
|
@pytest.fixture(scope="class")
|
|
def sample_protobuf_schema():
|
|
return """
|
|
syntax = "proto3";
|
|
package persons;
|
|
enum Gender {
|
|
M = 0; // male
|
|
F = 1; // female
|
|
O = 2; // other
|
|
}
|
|
|
|
message Result {
|
|
string url = 1;
|
|
string title = 2;
|
|
repeated string snippets = 3;
|
|
}
|
|
|
|
message PersonInfo {
|
|
int32 age = 1; // age in years
|
|
Gender gender = 2;
|
|
Result gender_new = 3;
|
|
int32 height = 4; // height in cm
|
|
fixed32 height_new = 5; // height in cm
|
|
bool my_bool = 6;
|
|
repeated string repeated_string = 7;
|
|
}
|
|
"""
|
|
|
|
|
|
@pytest.fixture(scope="class")
|
|
def protobuf_parser(sample_protobuf_schema, protobuf_base_path):
|
|
schema_name = "person_info"
|
|
return ProtobufParser(
|
|
config=ProtobufParserConfig(
|
|
schema_name=schema_name,
|
|
schema_text=sample_protobuf_schema,
|
|
base_file_path=protobuf_base_path,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="class")
|
|
def parsed_schema(protobuf_parser):
|
|
return protobuf_parser.parse_protobuf_schema()
|
|
|
|
|
|
@pytest.mark.usefixtures("parsed_schema")
|
|
class ProtobufParserTests:
|
|
"""
|
|
Check methods from protobuf_parser.py
|
|
"""
|
|
|
|
def test_schema_name(self, parsed_schema):
|
|
assert parsed_schema[0].name.root == "PersonInfo"
|
|
|
|
def test_schema_type(self, parsed_schema):
|
|
assert parsed_schema[0].dataType.name == "RECORD"
|
|
|
|
def test_field_names(self, parsed_schema):
|
|
field_names = {str(field.name.root) for field in parsed_schema[0].children}
|
|
assert field_names == {
|
|
"height",
|
|
"gender",
|
|
"age",
|
|
"gender_new",
|
|
"height_new",
|
|
"my_bool",
|
|
"repeated_string",
|
|
}
|
|
|
|
def test_field_types(self, parsed_schema):
|
|
field_types = {str(field.dataType.name) for field in parsed_schema[0].children}
|
|
assert field_types == {"INT", "ENUM", "RECORD", "FIXED", "STRING", "BOOLEAN"}
|
|
|
|
def test_column_types(self, protobuf_parser):
|
|
parsed_schema = protobuf_parser.parse_protobuf_schema(cls=Column)
|
|
field_types = {str(field.dataType.name) for field in parsed_schema[0].children}
|
|
assert field_types == {"INT", "ENUM", "RECORD", "STRING", "BOOLEAN"}
|
|
|
|
def test_complex_protobuf_schema_files(self, protobuf_base_path):
|
|
"""
|
|
We'll read the files under ./ingestion/tests/unit/resources/protobuf_parser and parse them
|
|
This will be similar in way to how we get the data from kafka source
|
|
"""
|
|
resource_path = f"{os.path.dirname(__file__)}/resources/protobuf_parser/" # noqa: PTH120
|
|
schema_name = "employee"
|
|
file_list = os.listdir(resource_path) # noqa: PTH208
|
|
schema_text = ""
|
|
for file_name in file_list:
|
|
file_path = os.path.join(resource_path, file_name) # noqa: PTH118
|
|
with open(file_path, "r") as file: # noqa: PTH123
|
|
schema_text = schema_text + file.read()
|
|
schema_text = merge_and_clean_protobuf_schema(schema_text)
|
|
protobuf_parser = ProtobufParser(
|
|
config=ProtobufParserConfig(
|
|
schema_name=schema_name,
|
|
schema_text=schema_text,
|
|
base_file_path=protobuf_base_path,
|
|
)
|
|
)
|
|
parsed_schema = protobuf_parser.parse_protobuf_schema()
|
|
assert parsed_schema[0].name.root == "Employee"
|
|
assert len(parsed_schema[0].children) == 4
|
|
assert parsed_schema[0].children[3].name.root == "contact"
|
|
assert parsed_schema[0].children[3].children[0].name.root == "email"
|
|
assert parsed_schema[0].children[3].children[1].name.root == "phone"
|