mirror of
https://github.com/open-metadata/OpenMetadata
synced 2026-05-24 09:39:11 +00:00
e9c87c6adb
* chore(ingestion): drop pylint, expand ruff to Stage 2c
Replace pylint with a coherent ruff-only stack (Stage 2c of the modernize
roadmap). Pylint is dropped from dev deps and CI workflows; ruff selected
ruleset expanded to ~22 families covering style, bug catchers, hygiene,
and the pylint port (PLE/PLC/PLW/PLR with the noisy "too-many-X"
complexity caps + magic-value disabled).
What's selected (with rationale in pyproject.toml):
E, W, F, I, N — style + correctness baseline + naming
UP — pyupgrade (py>=3.10 modernizations)
B, C4, C90, RET, SIM, TRY — bug catchers
PIE, ICN, T20, TC, TID, PTH, PERF — hygiene
PLE, PLC, PLW, PLR — pylint port (PLR complexity caps ignored)
RUF — ruff-native (incl. RUF100 unused-noqa)
What's removed:
- .pylintrc (root) — duplicate of the ingestion pylint config
- [tool.pylint.*] block in ingestion/pyproject.toml (~140 lines)
- ingestion/plugins/{print_checker,import_checker}.py + tests + README
(replaced by built-in T20 + TID251 banned-api respectively)
- pylint dep from ingestion/setup.py and openmetadata-airflow-apis/pyproject.toml
- `make lint` Makefile target + the pylint invocation in py_format_check
- dead pylint TODO comment + ignored test entry in noxfile.py
Cwd-stable config: ruff is invoked both from the repo root (pre-commit,
CI) and from ingestion/ (`make py_format_check`). The `src`,
`extend-exclude`, and per-file-ignores entries are listed twice — once
relative to ingestion/ and once with the `ingestion/` prefix — so
first-party isort detection and exclusions match in both invocations.
Grandfathering: ran `ruff check --add-noqa` once + format-stable
iteration. ~12,130 noqa directives across ~1,400 files. Cleanup is
deferred to follow-up PRs that drop noqas one rule at a time.
Documentation sweep: replaced `make lint` references in CLAUDE.md,
AGENTS.md, DEVELOPER.md, copilot-instructions, and 6 SKILL files with
the apply+verify shape `make py_format && make py_format_check`.
`make py_format` is NOT a strict superset of pylint — it only applies
auto-fixable violations; `make py_format_check` catches the rest.
Basedpyright baseline regenerated: ruff format reflowed multi-line
signatures in ~70 files, shifting type-error column positions. The
basedpyright baseline matches by (file path, error code, range), so
column shifts caused 19 entries to mis-align. Net diff is small
(154 lines in/out of the 13MB baseline.json) — purely positional.
Verified locally:
- make py_format_check → All checks passed
- nox --no-venv -s static-checks → 0 errors, 0 warnings, 0 notes
* chore(ingestion): finish ruff swap — nox lint session + skill docs
Three remaining stale-tooling references after Stage 2c:
- `ingestion/noxfile.py` `lint` session was still calling `black --check`,
`isort --check-only`, `pycln --diff`. Those tools aren't installed
anywhere (we dropped them from dev deps). Replace with the ruff
equivalents that mirror `make py_format_check`.
- `skills/standards/code_style.md`: stack listed as `black + isort +
pycln`; line length claimed 88 (black default). Both wrong: stack is
ruff, line length is 120.
- `skills/connector-building/SKILL.md`: `make py_format` comment said
`# black + isort + pycln`. Same swap.
* chore(ingestion): keep main's baseline + globally ignore TRY400
Per gitar-bot's review on PR #27774:
1. Main's PR #27728 promoted ~60 `logger.warning()` → `logger.error()`
inside `except` blocks. Those changes landed on main with their own
baseline updates. Our PR doesn't promote anything — the merge from
origin/main brought those `error` calls along with their baseline
entries.
The bot interpreted the `# noqa: TRY400` we added next to those lines
as us silencing the rule case-by-case. Cleaner: globally ignore
TRY400 in pyproject.toml, with a comment explaining why the codebase's
`logger.error(...)` + separate `logger.debug(traceback.format_exc())`
pattern is intentional. Strip ~430 per-line `# noqa: TRY400` markers
from source.
2. Document that `S101` in `per-file-ignores` is a forward-looking
entry — flake8-bandit (`S`) is not yet selected, so the rule is
no-op today; the entry stays so when `S` lands later, tests don't
immediately error.
Reverts the platform pin and Linux Docker–generated baseline. Keep
main's baseline intact and let CI surface the exact column-shifted
entries; the team will decide whether to fix in-place (revert format
on affected files) or add per-line `# pyright: ignore` markers.
* chore(ingestion): regen baseline for new connector type debt
Main's baseline was stale relative to recently-added connectors
(McpConnection, CustomDriveConnection) that lack common attributes
like `hostPort`, `database`, `catalog` etc. — all sites that access
those attributes via the union-typed `serviceConnection.root.config`
fire `reportAttributeAccessIssue` errors that aren't baselined.
71 errors + 58 warnings absorbed. Local macOS regen; pushing to see
CI's drift count. Per the basedpyright-baseline-and-ci PR experience,
macOS↔Linux column drift on this size of regen has historically been
1-7 residuals.
73 lines
2.4 KiB
Python
73 lines
2.4 KiB
Python
"""Run test case result resource load test"""
|
|
|
|
import csv
|
|
import os
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest import TestCase, skipIf
|
|
|
|
import yaml
|
|
|
|
from ingestion.tests.load.utils import run_load_test
|
|
|
|
|
|
def run_all_resources(summary_file: str, locust_file: str):
|
|
"""Test test case result resource"""
|
|
args = [
|
|
"locust",
|
|
"--headless",
|
|
"-H",
|
|
"http://localhost:8585",
|
|
"--user",
|
|
os.getenv("LOCUST_USER", "50"),
|
|
"--spawn-rate",
|
|
"1",
|
|
"-f",
|
|
str(locust_file),
|
|
"--run-time",
|
|
os.getenv("LOCUST_RUNTIME", "1m"),
|
|
"--only-summary",
|
|
"--csv",
|
|
str(summary_file),
|
|
]
|
|
|
|
run_load_test(args)
|
|
|
|
|
|
class TestAllResources(TestCase):
|
|
"""Test class to run all resources load test"""
|
|
|
|
@skipIf(sys.version_info < (3, 9), "locust is not supported on python 3.8")
|
|
def test_all_resources(self):
|
|
"""Test all resources"""
|
|
directory = Path(__file__).parent
|
|
test_resources_dir = directory.joinpath("test_resources")
|
|
|
|
locust_file = test_resources_dir.joinpath("all_resources.py")
|
|
summary_file = directory.parent.joinpath("load/summaries/all_")
|
|
manifest_file = test_resources_dir.joinpath("manifest.yaml")
|
|
|
|
run_all_resources(str(summary_file), str(locust_file))
|
|
|
|
with open(manifest_file, "r", encoding="utf-8") as f: # noqa: PTH123
|
|
manifest = yaml.safe_load(f)
|
|
|
|
with open(str(summary_file) + "_stats.csv", "r", encoding="utf-8") as f: # noqa: PTH123
|
|
reader = csv.DictReader(f)
|
|
|
|
for row in reader:
|
|
name = row.get("Name")
|
|
if name in manifest:
|
|
resource = manifest.get(name)
|
|
type_ = resource.get("type")
|
|
if type_ == row.get("Type"):
|
|
for metric, threshold in resource.items():
|
|
with self.subTest(stat=metric, resource=name, type_=type_):
|
|
stat = row.get(metric)
|
|
if stat:
|
|
stat = int(stat)
|
|
self.assertLessEqual(
|
|
stat,
|
|
threshold,
|
|
msg=f"{metric} for {name} is greater than threshold",
|
|
)
|