mirror of
https://github.com/open-metadata/OpenMetadata
synced 2026-05-24 09:39:11 +00:00
* chore(ingestion): replace black/isort/pycln with ruff - Swap formatter + import-sorter + unused-import tooling for ruff (line-length 120, target py3.10) in ingestion + openmetadata-airflow-apis - Drop dead [tool.mypy] config; basedpyright is the active type checker - Bump requires-python to >=3.10 to match noxfile and CLAUDE.md (3.9 is documented as broken on Mac in noxfile.py) - Bump pre-commit-hooks v2.3 -> v5.0; the new check-json catches four pre-existing JSON issues now excluded with an inline TODO - Update Makefile py_format / py_format_check targets to call ruff * chore(ingestion): grandfather ruff lint violations and apply ruff format - 253 noqa markers added via 'ruff check --add-noqa' across 128 files, freezing existing violations so this PR is a tooling-only swap. Per-rule cleanup tracked in the TODO comment in ingestion/pyproject.toml. - Bulk reformat from black 22.3 -> ruff format @ line-length 120. Cosmetic only: imports balanced (-32/+32), structural keywords balanced (-2221/+2221), no logic changes. - Star-import rules (F403/F405) globally ignored; refactoring wildcard imports across connectors is a separate effort. * chore(ingestion): fix pylint findings surfaced after ruff format - filters.py: drop redundant parens around re.match(...) in `if` (C0325 superfluous-parens) — exposed when ruff format unwrapped them - nosql_adaptor.py: move `# pylint: disable=unused-argument` from the `column:` line to the `def` line so it covers `table` too (W0613) — scope was line-based, lost when ruff split params onto multiple lines - action1xx.py: replace `arguments-differ` with `signature-differs` in the disable directive (was always wrong code) and drop the now-useless `unused-argument` suppression (I0021) * fix(ingestion): make ruff extend-exclude robust to multi-root invocations CI's `make py_format_check` runs from the repo root and passes both `ingestion/` and `./openmetadata-airflow-apis/` to ruff in a single invocation. With multiple root paths, ruff's parallel file discovery races on extend-exclude matching against the project root, so files under `ingestion/src/metadata/generated/` were intermittently scanned and produced ~830 I001 violations. 20-run repro: 10/20 fail without the fix, 20/20 pass with the fix. Each excluded directory now appears twice in extend-exclude: - the project-root-relative pattern (cwd = ingestion/) - the prefixed pattern (cwd = repo root, multi-root invocation) * chore(ingestion): address gitar-bot findings + cross-version pylint disable - openmetadata-airflow-apis/pyproject.toml: switch coverage to module-name source + [tool.coverage.paths] glob remap (matches the ingestion pattern). Drops the hardcoded `env/lib/python3.9/site-packages/...` source path, which broke after the requires-python bump to 3.10. (Finding 1) - ingestion/setup.py: remove dead python_version<'3.9' / >='3.9' guards on mysql-connector-python and testcontainers; promote locust to a regular test dep (was conditionally added under sys.version_info >= (3, 9)). Also remove the now-unused `import sys`. (Finding 3) - ingestion/src/metadata/great_expectations/action1xx.py: cover both arguments-differ (great_expectations 0.18.x parent) and signature-differs (great_expectations 1.x parent) in the pylint disable comment, since CI installs 0.18.x and local often has 1.x. unused-argument covers the unused action_context. The opposite rule fires as I0021 useless-suppression on each environment, which is informational and does not affect pylint's exit code.
227 lines
8.3 KiB
Python
227 lines
8.3 KiB
Python
# Copyright 2025 Collate
|
|
# Licensed under the Collate Community License, Version 1.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
# https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/LICENSE
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""
|
|
Jsonschema parser tests
|
|
"""
|
|
|
|
from unittest import TestCase
|
|
|
|
from metadata.generated.schema.entity.data.table import Column
|
|
from metadata.parsers.json_schema_parser import parse_json_schema
|
|
|
|
|
|
class JsonSchemaParserTests(TestCase):
|
|
"""
|
|
Check methods from json_schema_parser.py
|
|
"""
|
|
|
|
sample_json_schema = """{
|
|
"$id": "https://example.com/person.schema.json",
|
|
"$schema": "https://json-schema.org/draft/2020-12/schema",
|
|
"title": "Person",
|
|
"type": "object",
|
|
"properties": {
|
|
"firstName": {
|
|
"type": "string",
|
|
"title": "First Name",
|
|
"description": "The person's first name."
|
|
},
|
|
"lastName": {
|
|
"type": "string",
|
|
"title": "Last Name",
|
|
"description": "The person's last name."
|
|
},
|
|
"age": {
|
|
"description": "Age in years which must be equal to or greater than zero.",
|
|
"type": "integer",
|
|
"title": "Person Age",
|
|
"minimum": 0
|
|
}
|
|
}
|
|
}"""
|
|
|
|
sample_postgres_json_schema = """{
|
|
"title": "review_details",
|
|
"type": "object",
|
|
"properties":
|
|
{
|
|
"staff": {
|
|
"title": "staff",
|
|
"type": "array",
|
|
"properties": {}
|
|
},
|
|
"services": {
|
|
"title": "services",
|
|
"type": "object",
|
|
"properties": {
|
|
"lunch": {
|
|
"title": "lunch",
|
|
"type": "string",
|
|
"properties": {}
|
|
},
|
|
"check_in": {
|
|
"title": "check_in",
|
|
"type": "string",
|
|
"properties": {}
|
|
},
|
|
"check_out": {
|
|
"title": "check_out",
|
|
"type": "string",
|
|
"properties": {}
|
|
},
|
|
"additional_services": {
|
|
"title": "additional_services",
|
|
"type": "array",
|
|
"properties": {}
|
|
}
|
|
}
|
|
},
|
|
"overall_experience": {
|
|
"title": "overall_experience",
|
|
"type": "string"
|
|
}
|
|
}
|
|
}"""
|
|
|
|
sample_array_json_schema = """
|
|
{
|
|
"$schema": "http://json-schema.org/draft-07/schema#",
|
|
"type": "object",
|
|
"properties": {
|
|
"firstName": {
|
|
"type": "string"
|
|
},
|
|
"lastName": {
|
|
"type": "string"
|
|
},
|
|
"age": {
|
|
"type": "integer"
|
|
},
|
|
"address": {
|
|
"type": "object",
|
|
"properties": {
|
|
"streetAddress": {
|
|
"type": "string"
|
|
},
|
|
"city": {
|
|
"type": "string"
|
|
},
|
|
"state": {
|
|
"type": "string"
|
|
},
|
|
"postalCode": {
|
|
"type": "string"
|
|
}
|
|
},
|
|
"required": [
|
|
"streetAddress",
|
|
"city",
|
|
"state",
|
|
"postalCode"
|
|
]
|
|
},
|
|
"phoneNumbers": {
|
|
"type": "array",
|
|
"items": {
|
|
"type": "object",
|
|
"properties": {
|
|
"type": {
|
|
"type": "string"
|
|
},
|
|
"number": {
|
|
"type": "string"
|
|
}
|
|
},
|
|
"required": [
|
|
"type",
|
|
"number"
|
|
]
|
|
}
|
|
},
|
|
"hobbies": {
|
|
"type": "array",
|
|
"items": {
|
|
"type": "string"
|
|
}
|
|
}
|
|
},
|
|
"required": [
|
|
"firstName",
|
|
"lastName",
|
|
"age",
|
|
"address",
|
|
"phoneNumbers"
|
|
]
|
|
}
|
|
"""
|
|
|
|
parsed_schema = parse_json_schema(sample_json_schema)
|
|
parsed_postgres_schema = parse_json_schema(sample_postgres_json_schema, Column)
|
|
parsed_array_schema = parse_json_schema(sample_array_json_schema)
|
|
|
|
def test_schema_name(self):
|
|
self.assertEqual(self.parsed_schema[0].name.root, "Person")
|
|
|
|
def test_schema_type(self):
|
|
self.assertEqual(self.parsed_schema[0].dataType.name, "RECORD")
|
|
|
|
def test_field_names(self):
|
|
field_names = {str(field.name.root) for field in self.parsed_schema[0].children}
|
|
self.assertEqual(field_names, {"firstName", "lastName", "age"})
|
|
|
|
# validate display names
|
|
field_display_names = {str(field.displayName) for field in self.parsed_schema[0].children}
|
|
self.assertEqual(field_display_names, {"First Name", "Last Name", "Person Age"})
|
|
|
|
def test_field_types(self):
|
|
field_types = {str(field.dataType.name) for field in self.parsed_schema[0].children}
|
|
self.assertEqual(field_types, {"INT", "STRING"})
|
|
|
|
def test_field_descriptions(self):
|
|
field_descriptions = {str(field.description.root) for field in self.parsed_schema[0].children}
|
|
self.assertEqual(
|
|
field_descriptions,
|
|
{
|
|
"The person's first name.",
|
|
"The person's last name.",
|
|
"Age in years which must be equal to or greater than zero.",
|
|
},
|
|
)
|
|
|
|
def test_parse_postgres_json_fields(self):
|
|
self.assertEqual(self.parsed_postgres_schema[0].name.root, "review_details")
|
|
self.assertEqual(self.parsed_postgres_schema[0].children[0].name.root, "staff")
|
|
self.assertEqual(self.parsed_postgres_schema[0].children[1].name.root, "services")
|
|
self.assertEqual(self.parsed_postgres_schema[0].children[1].children[0].name.root, "lunch")
|
|
self.assertEqual(self.parsed_postgres_schema[0].children[1].dataType.name, "RECORD")
|
|
self.assertEqual(len(self.parsed_postgres_schema[0].children), 3)
|
|
self.assertEqual(len(self.parsed_postgres_schema[0].children[1].children), 4)
|
|
|
|
def test_parse_postgres_json_fields(self): # noqa: F811
|
|
self.assertEqual(self.parsed_array_schema[0].name.root, "default")
|
|
self.assertEqual(len(self.parsed_array_schema[0].children), 6)
|
|
|
|
# Validate the complex array datatype
|
|
self.assertEqual(self.parsed_array_schema[0].children[4].name.root, "phoneNumbers")
|
|
self.assertEqual(self.parsed_array_schema[0].children[4].dataType.name, "ARRAY")
|
|
self.assertEqual(self.parsed_array_schema[0].children[4].dataTypeDisplay, "ARRAY<RECORD>")
|
|
self.assertEqual(len(self.parsed_array_schema[0].children[4].children), 2)
|
|
self.assertEqual(self.parsed_array_schema[0].children[4].children[0].name.root, "type")
|
|
self.assertEqual(self.parsed_array_schema[0].children[4].children[0].dataType.name, "STRING")
|
|
self.assertEqual(self.parsed_array_schema[0].children[4].children[1].name.root, "number")
|
|
self.assertEqual(self.parsed_array_schema[0].children[4].children[1].dataType.name, "STRING")
|
|
|
|
# Validate the primitive array datatype
|
|
self.assertEqual(self.parsed_array_schema[0].children[5].name.root, "hobbies")
|
|
self.assertEqual(self.parsed_array_schema[0].children[5].dataType.name, "ARRAY")
|
|
self.assertEqual(self.parsed_array_schema[0].children[5].dataTypeDisplay, "ARRAY<STRING>")
|
|
self.assertIsNone(self.parsed_array_schema[0].children[5].children)
|