mirror of
https://github.com/open-metadata/OpenMetadata
synced 2026-05-24 09:39:11 +00:00
* chore(ingestion): drop pylint, expand ruff to Stage 2c
Replace pylint with a coherent ruff-only stack (Stage 2c of the modernize
roadmap). Pylint is dropped from dev deps and CI workflows; ruff selected
ruleset expanded to ~22 families covering style, bug catchers, hygiene,
and the pylint port (PLE/PLC/PLW/PLR with the noisy "too-many-X"
complexity caps + magic-value disabled).
What's selected (with rationale in pyproject.toml):
E, W, F, I, N — style + correctness baseline + naming
UP — pyupgrade (py>=3.10 modernizations)
B, C4, C90, RET, SIM, TRY — bug catchers
PIE, ICN, T20, TC, TID, PTH, PERF — hygiene
PLE, PLC, PLW, PLR — pylint port (PLR complexity caps ignored)
RUF — ruff-native (incl. RUF100 unused-noqa)
What's removed:
- .pylintrc (root) — duplicate of the ingestion pylint config
- [tool.pylint.*] block in ingestion/pyproject.toml (~140 lines)
- ingestion/plugins/{print_checker,import_checker}.py + tests + README
(replaced by built-in T20 + TID251 banned-api respectively)
- pylint dep from ingestion/setup.py and openmetadata-airflow-apis/pyproject.toml
- `make lint` Makefile target + the pylint invocation in py_format_check
- dead pylint TODO comment + ignored test entry in noxfile.py
Cwd-stable config: ruff is invoked both from the repo root (pre-commit,
CI) and from ingestion/ (`make py_format_check`). The `src`,
`extend-exclude`, and per-file-ignores entries are listed twice — once
relative to ingestion/ and once with the `ingestion/` prefix — so
first-party isort detection and exclusions match in both invocations.
Grandfathering: ran `ruff check --add-noqa` once + format-stable
iteration. ~12,130 noqa directives across ~1,400 files. Cleanup is
deferred to follow-up PRs that drop noqas one rule at a time.
Documentation sweep: replaced `make lint` references in CLAUDE.md,
AGENTS.md, DEVELOPER.md, copilot-instructions, and 6 SKILL files with
the apply+verify shape `make py_format && make py_format_check`.
`make py_format` is NOT a strict superset of pylint — it only applies
auto-fixable violations; `make py_format_check` catches the rest.
Basedpyright baseline regenerated: ruff format reflowed multi-line
signatures in ~70 files, shifting type-error column positions. The
basedpyright baseline matches by (file path, error code, range), so
column shifts caused 19 entries to mis-align. Net diff is small
(154 lines in/out of the 13MB baseline.json) — purely positional.
Verified locally:
- make py_format_check → All checks passed
- nox --no-venv -s static-checks → 0 errors, 0 warnings, 0 notes
* chore(ingestion): finish ruff swap — nox lint session + skill docs
Three remaining stale-tooling references after Stage 2c:
- `ingestion/noxfile.py` `lint` session was still calling `black --check`,
`isort --check-only`, `pycln --diff`. Those tools aren't installed
anywhere (we dropped them from dev deps). Replace with the ruff
equivalents that mirror `make py_format_check`.
- `skills/standards/code_style.md`: stack listed as `black + isort +
pycln`; line length claimed 88 (black default). Both wrong: stack is
ruff, line length is 120.
- `skills/connector-building/SKILL.md`: `make py_format` comment said
`# black + isort + pycln`. Same swap.
* chore(ingestion): keep main's baseline + globally ignore TRY400
Per gitar-bot's review on PR #27774:
1. Main's PR #27728 promoted ~60 `logger.warning()` → `logger.error()`
inside `except` blocks. Those changes landed on main with their own
baseline updates. Our PR doesn't promote anything — the merge from
origin/main brought those `error` calls along with their baseline
entries.
The bot interpreted the `# noqa: TRY400` we added next to those lines
as us silencing the rule case-by-case. Cleaner: globally ignore
TRY400 in pyproject.toml, with a comment explaining why the codebase's
`logger.error(...)` + separate `logger.debug(traceback.format_exc())`
pattern is intentional. Strip ~430 per-line `# noqa: TRY400` markers
from source.
2. Document that `S101` in `per-file-ignores` is a forward-looking
entry — flake8-bandit (`S`) is not yet selected, so the rule is
no-op today; the entry stays so when `S` lands later, tests don't
immediately error.
Reverts the platform pin and Linux Docker–generated baseline. Keep
main's baseline intact and let CI surface the exact column-shifted
entries; the team will decide whether to fix in-place (revert format
on affected files) or add per-line `# pyright: ignore` markers.
* chore(ingestion): regen baseline for new connector type debt
Main's baseline was stale relative to recently-added connectors
(McpConnection, CustomDriveConnection) that lack common attributes
like `hostPort`, `database`, `catalog` etc. — all sites that access
those attributes via the union-typed `serviceConnection.root.config`
fire `reportAttributeAccessIssue` errors that aren't baselined.
71 errors + 58 warnings absorbed. Local macOS regen; pushing to see
CI's drift count. Per the basedpyright-baseline-and-ci PR experience,
macOS↔Linux column drift on this size of regen has historically been
1-7 residuals.
141 lines
5.5 KiB
Python
141 lines
5.5 KiB
Python
# Copyright 2025 Collate
|
|
# Licensed under the Collate Community License, Version 1.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
# https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/LICENSE
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
"""
|
|
Test that SQASampler truncates oversized cell values during fetch_sample_data.
|
|
"""
|
|
|
|
import os
|
|
from unittest.mock import patch
|
|
from uuid import uuid4
|
|
|
|
from sqlalchemy import TEXT, Column, Integer, String
|
|
from sqlalchemy.orm import declarative_base
|
|
|
|
from metadata.generated.schema.entity.data.table import Column as EntityColumn
|
|
from metadata.generated.schema.entity.data.table import ColumnName, DataType, Table
|
|
from metadata.generated.schema.entity.services.connections.database.sqliteConnection import (
|
|
SQLiteConnection,
|
|
SQLiteScheme,
|
|
)
|
|
from metadata.sampler.sqlalchemy.sampler import SQASampler
|
|
from metadata.utils.constants import SAMPLE_DATA_MAX_CELL_LENGTH
|
|
|
|
Base = declarative_base()
|
|
|
|
|
|
class HugeTextTable(Base):
|
|
__tablename__ = "huge_text"
|
|
id = Column(Integer, primary_key=True)
|
|
name = Column(String(256))
|
|
body = Column(TEXT)
|
|
|
|
|
|
class TestSQASamplerTruncation:
|
|
"""Verify that fetch_sample_data truncates values that exceed SAMPLE_DATA_MAX_CELL_LENGTH."""
|
|
|
|
db_path = os.path.join(os.path.dirname(__file__), f"{os.path.splitext(__file__)[0]}.db") # noqa: PTH118, PTH120, PTH122
|
|
sqlite_conn = SQLiteConnection(
|
|
scheme=SQLiteScheme.sqlite_pysqlite,
|
|
databaseMode=db_path + "?check_same_thread=False",
|
|
)
|
|
|
|
table_entity = Table(
|
|
id=uuid4(),
|
|
name="huge_text",
|
|
columns=[
|
|
EntityColumn(name=ColumnName("id"), dataType=DataType.INT),
|
|
EntityColumn(name=ColumnName("name"), dataType=DataType.STRING),
|
|
EntityColumn(name=ColumnName("body"), dataType=DataType.STRING),
|
|
],
|
|
)
|
|
|
|
@classmethod
|
|
def setup_class(cls):
|
|
with patch.object(SQASampler, "build_table_orm", return_value=HugeTextTable):
|
|
cls.sampler = SQASampler(
|
|
service_connection_config=cls.sqlite_conn,
|
|
ometa_client=None,
|
|
entity=None,
|
|
)
|
|
engine = cls.sampler.session_factory().get_bind()
|
|
HugeTextTable.__table__.create(bind=engine)
|
|
|
|
oversized = "x" * (SAMPLE_DATA_MAX_CELL_LENGTH + 50_000)
|
|
at_limit = "y" * SAMPLE_DATA_MAX_CELL_LENGTH
|
|
small = "z" * 100
|
|
|
|
with cls.sampler.session_factory() as session:
|
|
session.add_all(
|
|
[
|
|
HugeTextTable(name="oversized", body=oversized),
|
|
HugeTextTable(name="at_limit", body=at_limit),
|
|
HugeTextTable(name="small", body=small),
|
|
HugeTextTable(name="null_body", body=None),
|
|
]
|
|
)
|
|
session.commit()
|
|
|
|
@classmethod
|
|
def teardown_class(cls):
|
|
cls.sampler.close()
|
|
if os.path.exists(cls.db_path): # noqa: PTH110
|
|
os.remove(cls.db_path) # noqa: PTH107
|
|
|
|
def test_fetch_sample_data_truncates_oversized_cells(self):
|
|
sample_data = self.sampler.fetch_sample_data()
|
|
|
|
for row in sample_data.rows:
|
|
for cell in row:
|
|
if isinstance(cell, str):
|
|
assert len(cell) <= SAMPLE_DATA_MAX_CELL_LENGTH
|
|
|
|
def test_oversized_body_is_truncated_to_limit(self):
|
|
sample_data = self.sampler.fetch_sample_data()
|
|
|
|
body_idx = next(i for i, col in enumerate(sample_data.columns) if str(col.root) == "body")
|
|
oversized_row = next(row for row in sample_data.rows if row[1] == "oversized")
|
|
assert len(oversized_row[body_idx]) == SAMPLE_DATA_MAX_CELL_LENGTH
|
|
|
|
def test_value_at_limit_is_not_truncated(self):
|
|
sample_data = self.sampler.fetch_sample_data()
|
|
|
|
body_idx = next(i for i, col in enumerate(sample_data.columns) if str(col.root) == "body")
|
|
at_limit_row = next(row for row in sample_data.rows if row[1] == "at_limit")
|
|
assert len(at_limit_row[body_idx]) == SAMPLE_DATA_MAX_CELL_LENGTH
|
|
|
|
def test_small_value_is_unchanged(self):
|
|
sample_data = self.sampler.fetch_sample_data()
|
|
|
|
body_idx = next(i for i, col in enumerate(sample_data.columns) if str(col.root) == "body")
|
|
small_row = next(row for row in sample_data.rows if row[1] == "small")
|
|
assert small_row[body_idx] == "z" * 100
|
|
|
|
def test_null_value_is_preserved(self):
|
|
sample_data = self.sampler.fetch_sample_data()
|
|
|
|
body_idx = next(i for i, col in enumerate(sample_data.columns) if str(col.root) == "body")
|
|
null_row = next(row for row in sample_data.rows if row[1] == "null_body")
|
|
assert null_row[body_idx] is None
|
|
|
|
def test_user_query_truncates_oversized_cells(self):
|
|
with patch.object(SQASampler, "build_table_orm", return_value=HugeTextTable):
|
|
sampler = SQASampler(
|
|
service_connection_config=self.sqlite_conn,
|
|
ometa_client=None,
|
|
entity=None,
|
|
sample_query="SELECT id, name, body FROM huge_text",
|
|
)
|
|
sample_data = sampler.fetch_sample_data()
|
|
|
|
for row in sample_data.rows:
|
|
for cell in row:
|
|
if isinstance(cell, str):
|
|
assert len(cell) <= SAMPLE_DATA_MAX_CELL_LENGTH
|