Commit graph

4 commits

Author SHA1 Message Date
Teddy
6cc7c24278
ISSUE #2681 - Add Missing test parameters in PSQL (#25323)
* fix(dq): psql migration for row insert test parameters

* fix(dq): use name and add trailing new line

* Fix description formatting in postDataMigrationSQLScript.sql

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-01-16 12:09:15 +01:00
Teddy
2dbf5ed0b4
#24641: fix MySQL data_diff URL to include database (#25047)
* fix(ingestion): include database in MySQL data_diff URL (#24641)

The data_diff library requires MySQL URLs to specify a database in the
path (e.g., mysql://user:pass@host:port/database). Without this, the
table diff test fails with "MySQL URL must specify a database" error.

This fix adds MySQL and MariaDB to the list of dialects that need the
schema (which is the database in MySQL's terminology) included in the
URL path.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: conflicts with recent changes

* chore: translated missing arabic entries

* fix: conditional logic issue

* chore: fix failing tests

* style: ran java linting

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-08 16:12:52 +01:00
Teddy
acc0d9d887
ISSUE #2552-CLT - Data Diff Improvements (#24904)
* fix: updated logic for diff

* fix: exclude schema test case value from graph

* fix: exclude schema test case value from graph

* fix: updated schema for easy retrieval of pk and unique key

* fix: added additional sample data

* fix: python tests

* fix: ran python linting

* Addressing feedback

Co-authored-by: TeddyCr <TeddyCr@users.noreply.github.com>

* Revert "Addressing feedback"

This reverts commit 1d1b8f33bb.

Co-authored-by: TeddyCr <TeddyCr@users.noreply.github.com>

* Addressing feedback

Co-authored-by: TeddyCr <TeddyCr@users.noreply.github.com>

* address comments

* chore: address comments and fix tests

* chore: fix failing tests

---------

Co-authored-by: Gitar <noreply@gitar.ai>
Co-authored-by: TeddyCr <TeddyCr@users.noreply.github.com>
Co-authored-by: Harshit Shah <harshit.shah@getcollate.io>
Co-authored-by: Harshit Shah <dinkushah169@gmail.com>
2026-01-08 10:46:44 +01:00
Teddy
50541759a9
fix: Handle special characters in passwords for TableDiff URL parsing (#25038)
* fix: Handle special characters in passwords for TableDiff URL parsing

Fixes #24164

Replace urlparse with SQLAlchemy's make_url to properly handle special
characters (like ']', '[', '@', '#', '!') in database credentials when
building connection URLs for the Data Quality TableDiff test.

Python's urllib.parse.urlparse() incorrectly interprets ']' as the end
of an IPv6 literal, causing "Invalid IPv6 URL" errors when passwords
contain such characters.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: logic in implementation causing tests to fail

* chore: devex scripts

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-06 08:18:08 +01:00