From 03c5d4f6dcb099ed7ef93c67f7837bb67b2688fa Mon Sep 17 00:00:00 2001 From: Sriharsha Chintalapani Date: Fri, 15 May 2026 10:21:42 -0700 Subject: [PATCH] fix(rdf): make buildPredicateInList public so JenaFusekiStorage can use it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit JenaFusekiStorage (org.openmetadata.service.rdf.storage) lives in a different package than RdfRepository (org.openmetadata.service.rdf), so the package-private buildPredicateInList helper introduced in 857c09 couldn't be called from JenaFusekiStorage.bulkStoreRelationships — CI was failing with: [ERROR] JenaFusekiStorage.java:[606,51] buildPredicateInList(Set) is not public in RdfRepository; cannot be accessed from outside package Promote it to public alongside RELATIONSHIP_HOOK_PREDICATES (which is the only data this helper renders) so the cross-package call resolves. Local javac across the touched RDF files now reports zero new errors; the only remaining build failures are the pre-existing es.co.elastic.clients shading issues unrelated to this PR. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../main/java/org/openmetadata/service/rdf/RdfRepository.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java index efe2318bb7b..2582558f902 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java @@ -430,7 +430,9 @@ public class RdfRepository { } // Build a comma-separated ", , ..." for SPARQL `?p IN (...)` lists. - static String buildPredicateInList(Set uris) { + // public so JenaFusekiStorage (in storage subpackage) can reuse the same + // RELATIONSHIP_HOOK_PREDICATES rendering for its per-source DELETE filter. + public static String buildPredicateInList(Set uris) { StringBuilder sb = new StringBuilder(); boolean first = true; for (String uri : uris) {