Elgato_dark/OfficeCLI
1
0
Fork 0
mirror of https://github.com/iOfficeAI/OfficeCLI synced 2026-04-21 13:37:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(xlsx): write internal hyperlinks (#Sheet!A1) as location attr

Browse source 
Round-14 audit bug H1: hyperlinks to any '#'-prefixed target (sheet cell
reference or named range) were serialized as TargetMode=External
relationships pointing at a URI starting with '#'. Real Excel rendered
them as broken external links. Internal targets now use the inline
<x:hyperlink location='...'/> form with no relationship, matching Excel's
canonical output.
This commit is contained in:
zmworm 2026-04-18 04:45:03 +08:00
parent ee0285833f
commit 60e1455170
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/officecli/Handlers/Excel/ExcelHandler.Set.cs
View file

@ -1399,8 +1399,6 @@ public partial class ExcelHandler
}
else
{
var hlUri = new Uri(value, UriKind.RelativeOrAbsolute);
var hlRel = worksheet.AddHyperlinkRelationship(hlUri, isExternal: true);
if (hyperlinksEl == null)
{
hyperlinksEl = new Hyperlinks();
@ -1409,7 +1407,24 @@ public partial class ExcelHandler
hyperlinksEl.Elements<Hyperlink>()
.Where(h => h.Reference?.Value?.Equals(cellRef, StringComparison.OrdinalIgnoreCase) == true)
.ToList().ForEach(h => h.Remove());
hyperlinksEl.AppendChild(new Hyperlink { Reference = cellRef.ToUpperInvariant(), Id = hlRel.Id });
if (value.StartsWith("#"))
{
// Internal target (sheet cell or named range) is
// written as an in-document hyperlink via the
// `location` attribute, no relationship/target.
var location = value.Substring(1);
hyperlinksEl.AppendChild(new Hyperlink
{
Reference = cellRef.ToUpperInvariant(),
Location = location
});
}
else
{
var hlUri = new Uri(value, UriKind.RelativeOrAbsolute);
var hlRel = worksheet.AddHyperlinkRelationship(hlUri, isExternal: true);
hyperlinksEl.AppendChild(new Hyperlink { Reference = cellRef.ToUpperInvariant(), Id = hlRel.Id });
}
}
break;
}