mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-14 21:08:48 +00:00
f15b167e85
Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
105 lines
3.5 KiB
Objective-C
105 lines
3.5 KiB
Objective-C
/**
|
|
* Copyright (c) 2016-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "IGListSectionControllerInternal.h"
|
|
|
|
#import <IGListKit/IGListMacros.h>
|
|
#import <IGListKit/IGListAssert.h>
|
|
|
|
static NSString * const kIGListSectionControllerThreadKey = @"kIGListSectionControllerThreadKey";
|
|
|
|
@interface IGListSectionControllerThreadContext : NSObject
|
|
@property (nonatomic, weak) UIViewController *viewController;
|
|
@property (nonatomic, weak) id<IGListCollectionContext> collectionContext;
|
|
@end
|
|
@implementation IGListSectionControllerThreadContext
|
|
@end
|
|
|
|
static NSMutableArray<IGListSectionControllerThreadContext *> *threadContextStack(void) {
|
|
IGAssertMainThread();
|
|
NSMutableDictionary *threadDictionary = [[NSThread currentThread] threadDictionary];
|
|
NSMutableArray *stack = threadDictionary[kIGListSectionControllerThreadKey];
|
|
if (stack == nil) {
|
|
stack = [NSMutableArray new];
|
|
threadDictionary[kIGListSectionControllerThreadKey] = stack;
|
|
}
|
|
return stack;
|
|
}
|
|
|
|
void IGListSectionControllerPushThread(UIViewController *viewController, id<IGListCollectionContext> collectionContext) {
|
|
IGListSectionControllerThreadContext *context = [IGListSectionControllerThreadContext new];
|
|
context.viewController = viewController;
|
|
context.collectionContext = collectionContext;
|
|
|
|
[threadContextStack() addObject:context];
|
|
}
|
|
|
|
void IGListSectionControllerPopThread(void) {
|
|
NSMutableArray *stack = threadContextStack();
|
|
IGAssert(stack.count > 0, @"IGListSectionController thread stack is empty");
|
|
[stack removeLastObject];
|
|
}
|
|
|
|
@implementation IGListSectionController
|
|
|
|
- (instancetype)init {
|
|
if (self = [super init]) {
|
|
IGListSectionControllerThreadContext *context = [threadContextStack() lastObject];
|
|
_viewController = context.viewController;
|
|
_collectionContext = context.collectionContext;
|
|
|
|
if (_collectionContext == nil) {
|
|
IGLKLog(@"Warning: Creating %@ outside of -[IGListAdapterDataSource listAdapter:sectionControllerForObject:]. Collection context and view controller will be set later.",
|
|
NSStringFromClass([self class]));
|
|
}
|
|
|
|
_minimumInteritemSpacing = 0.0;
|
|
_minimumLineSpacing = 0.0;
|
|
_inset = UIEdgeInsetsZero;
|
|
_section = NSNotFound;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (NSInteger)numberOfItems {
|
|
return 1;
|
|
}
|
|
|
|
- (CGSize)sizeForItemAtIndex:(NSInteger)index {
|
|
return CGSizeZero;
|
|
}
|
|
|
|
- (__kindof UICollectionViewCell *)cellForItemAtIndex:(NSInteger)index {
|
|
IGFailAssert(@"Section controller %@ must override %s:", self, __PRETTY_FUNCTION__);
|
|
return nil;
|
|
}
|
|
|
|
- (void)didUpdateToObject:(id)object {}
|
|
|
|
- (void)didSelectItemAtIndex:(NSInteger)index {}
|
|
|
|
- (void)didDeselectItemAtIndex:(NSInteger)index {}
|
|
|
|
- (void)didHighlightItemAtIndex:(NSInteger)index {}
|
|
|
|
- (void)didUnhighlightItemAtIndex:(NSInteger)index {}
|
|
|
|
- (BOOL)canMoveItemAtIndex:(NSInteger)index {
|
|
return NO;
|
|
}
|
|
|
|
- (BOOL)canMoveItemAtIndex:(NSInteger)sourceItemIndex toIndex:(NSInteger)destinationItemIndex {
|
|
return [self canMoveItemAtIndex:sourceItemIndex];
|
|
}
|
|
|
|
- (void)moveObjectFromIndex:(NSInteger)sourceIndex toIndex:(NSInteger)destinationIndex {
|
|
IGFailAssert(@"Section controller %@ must override %s if interactive reordering is enabled.", self, __PRETTY_FUNCTION__);
|
|
}
|
|
|
|
@end
|