mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-19 07:18:26 +00:00
08bf69cc2f
Summary: ## Changes in this pull request Issue fixed: https://github.com/Instagram/IGListKit/issues/1275 This PR is straintforward solution as mentioned in https://github.com/Instagram/IGListKit/issues/1275. When I finished it, I realized that it is not a problem in `IGListCollectionViewLayout Partial Optimization` and `IGListBindingSectionController` deserved it. Maybe `IGListCollectionViewLayout` is rarely used because of great builtin UICollectionViewFlowLayout or cells in section rarely need changing their sizes in practices. Despite it is not `IGListCollectionViewLayout`'s fault, I think it can be more optimized against `invalidateLayoutWithContext`. I would like to make an another PR to optimize it. Due to this PR just giving a proposed solution, it lacks of adding tests and changing log. When this solution is accepted, I would like to complete these todos. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1285 Reviewed By: candance Differential Revision: D15592807 Pulled By: lorixx fbshipit-source-id: ae06abce896341509de4f3dfb73b3a7bc0a68c51 |
||
|---|---|---|
| .. | ||
| IGLayoutTestDataSource.h | ||
| IGLayoutTestDataSource.m | ||
| IGLayoutTestItem.h | ||
| IGLayoutTestItem.m | ||
| IGLayoutTestSection.h | ||
| IGLayoutTestSection.m | ||
| IGListAdapterUpdateTester.h | ||
| IGListAdapterUpdateTester.m | ||
| IGListTestAdapterDataSource.h | ||
| IGListTestAdapterDataSource.m | ||
| IGListTestAdapterHorizontalDataSource.h | ||
| IGListTestAdapterHorizontalDataSource.m | ||
| IGListTestAdapterReorderingDataSource.h | ||
| IGListTestAdapterReorderingDataSource.m | ||
| IGListTestAdapterStackedReorderingDataSource.h | ||
| IGListTestAdapterStackedReorderingDataSource.m | ||
| IGListTestAdapterStoryboardDataSource.h | ||
| IGListTestAdapterStoryboardDataSource.m | ||
| IGListTestContainerSizeSection.h | ||
| IGListTestContainerSizeSection.m | ||
| IGListTestHorizontalSection.h | ||
| IGListTestHorizontalSection.m | ||
| IGListTestOffsettingLayout.h | ||
| IGListTestOffsettingLayout.m | ||
| IGListTestSection.h | ||
| IGListTestSection.m | ||
| IGListTestStoryboardSection.h | ||
| IGListTestStoryboardSection.m | ||
| IGListTestUICollectionViewDataSource.h | ||
| IGListTestUICollectionViewDataSource.m | ||
| IGTestBindingWithoutDeselectionDelegate.h | ||
| IGTestBindingWithoutDeselectionDelegate.m | ||
| IGTestCell.h | ||
| IGTestCell.m | ||
| IGTestDelegateController.h | ||
| IGTestDelegateController.m | ||
| IGTestDelegateDataSource.h | ||
| IGTestDelegateDataSource.m | ||
| IGTestDiffingDataSource.h | ||
| IGTestDiffingDataSource.m | ||
| IGTestDiffingObject.h | ||
| IGTestDiffingObject.m | ||
| IGTestDiffingSectionController.h | ||
| IGTestDiffingSectionController.m | ||
| IGTestInvalidateLayoutDataSource.h | ||
| IGTestInvalidateLayoutDataSource.m | ||
| IGTestInvalidateLayoutObject.h | ||
| IGTestInvalidateLayoutObject.m | ||
| IGTestInvalidateLayoutSectionController.h | ||
| IGTestInvalidateLayoutSectionController.m | ||
| IGTestNibSupplementaryView.h | ||
| IGTestNibSupplementaryView.m | ||
| IGTestNumberBindableCell.h | ||
| IGTestNumberBindableCell.m | ||
| IGTestObject.h | ||
| IGTestObject.m | ||
| IGTestReorderableSection.h | ||
| IGTestReorderableSection.m | ||
| IGTestSingleItemDataSource.h | ||
| IGTestSingleItemDataSource.m | ||
| IGTestSingleNibItemDataSource.h | ||
| IGTestSingleNibItemDataSource.m | ||
| IGTestSingleStoryboardItemDataSource.h | ||
| IGTestSingleStoryboardItemDataSource.m | ||
| IGTestSingleWithoutDeselectionDelegate.h | ||
| IGTestSingleWithoutDeselectionDelegate.m | ||
| IGTestStackedDataSource.h | ||
| IGTestStackedDataSource.m | ||
| IGTestStoryboardCell.h | ||
| IGTestStoryboardCell.m | ||
| IGTestStoryboardSupplementarySource.h | ||
| IGTestStoryboardSupplementarySource.m | ||
| IGTestStoryboardSupplementaryView.h | ||
| IGTestStoryboardSupplementaryView.m | ||
| IGTestStoryboardViewController.h | ||
| IGTestStoryboardViewController.m | ||
| IGTestStringBindableCell.h | ||
| IGTestStringBindableCell.m | ||
| IGTestSupplementarySource.h | ||
| IGTestSupplementarySource.m | ||