A data-driven UICollectionView framework for building fast and flexible lists.
Find a file
Sash Zats d220f8a73f Fix re-entrance + caching when using IGListCollectionViewLayout
Summary:
The issue I've been seeing is that list kit would not recalculate layout for when collection view bounds would change

IGListCollectionViewLayout has code to invalidate layout when collection view size chances however it would not happen without explicitly calling `….collectionViewLayout invalidateLayout];`

It appears that in the loop of calculating the layout we would accidentally call the code that would start caching existing layout data (not calculated at the point of call) and cache the value

This does not seem to happen all the time, however moving the cache purge to the end of layout calculation loop seems reasonable since at this point we have the new values that can't be known to the cache

As long as the consumer uses `IGListCollectionViewLayout` explicitly or implicitly through convenience initialize of `IGListCollectionView` this fix should work as is

Reviewed By: fabiomassimo

Differential Revision: D50197736

fbshipit-source-id: cb6d818f8be965f2e6ba494ffea083a6ab35682d
2023-10-12 07:55:34 -07:00
.github Update build environment to latest OS versions 2023-04-17 20:41:49 -07:00
docs Updated copyright symbol in documentation 2023-04-07 01:58:02 -07:00
Examples Refine "Load More" view controller for iPad 2023-07-25 09:17:11 -07:00
Guides Improve SwiftPM support (#1546) 2023-03-06 23:29:41 -08:00
IGListKit.xcodeproj Update iOS deployment target to silence Xcode 15 warnings (#1589) 2023-10-11 21:26:38 -07:00
remodel-plugin Standarize the copyright notice in all source files 2023-04-06 02:44:16 -07:00
Resources Create binding and modeling guide/tutorial 2017-08-21 14:46:53 -07:00
scripts Add IGListBindingSingleSectionController to public headers 2023-04-20 14:26:11 -07:00
Source Fix re-entrance + caching when using IGListCollectionViewLayout 2023-10-12 07:55:34 -07:00
spm/Sources Add symlink for new IGListArrayUtilsInternal.m (#1591) 2023-10-11 21:26:45 -07:00
Tests Add coverage for minium invalidated section in IGListCollectionViewLayout 2023-10-11 22:30:36 -07:00
.gitignore Improve SwiftPM support (#1546) 2023-03-06 23:29:41 -08:00
.slather.yml Omit the test suite from code coverage stats 2023-04-17 20:41:49 -07:00
.swiftlint.yml Updated and reintegrated Danger into GitHub Actions CI 2023-02-28 18:53:02 -08:00
CHANGELOG.md fix crash when calling reloadObjects during an update 2023-07-07 11:36:50 -07:00
CODE_OF_CONDUCT.md Adopt Contributor Covenant 2019-08-29 23:20:54 -07:00
Dangerfile Updated and reintegrated Danger into GitHub Actions CI 2023-02-28 18:53:02 -08:00
Gemfile Add explicit activesupport version as CocoaPods dependency (#1590) 2023-10-11 21:30:06 -07:00
IGListDiffKit.podspec Update deployment targets to silence Xcode 14 warnings (#1573) 2023-05-01 22:48:23 -07:00
IGListKit.podspec Update deployment targets to silence Xcode 14 warnings (#1573) 2023-05-01 22:48:23 -07:00
IGListSwiftKit.podspec Update deployment targets to silence Xcode 14 warnings (#1573) 2023-05-01 22:48:23 -07:00
LICENSE.md Standarize the copyright notice in all source files 2023-04-06 02:44:16 -07:00
Package.swift Update deployment targets to silence Xcode 14 warnings (#1573) 2023-05-01 22:48:23 -07:00
Podfile Update deployment targets to silence Xcode 14 warnings (#1573) 2023-05-01 22:48:23 -07:00
README.md Update deployment targets to silence Xcode 14 warnings (#1573) 2023-05-01 22:48:23 -07:00
README.zh.md Update deployment targets to silence Xcode 14 warnings (#1573) 2023-05-01 22:48:23 -07:00

Build Status Coverage Status Pods Version Platforms Carthage Compatible


A data-driven UICollectionView framework for building fast and flexible lists.

Main Features
🙅 Never call performBatchUpdates(_:, completion:) or reloadData() again
🏠 Better architecture with reusable cells and components
🔠 Create collections with multiple data types
🔑 Decoupled diffing algorithm
Fully unit tested
🔍 Customize your diffing behavior for your models
📱 Simply UICollectionView at its core
🚀 Extendable API
🐦 Written in Objective-C with full Swift interop support

IGListKit is built and maintained with ❤️ by Instagram engineering. We use the open source version main branch in the Instagram app.

Multilingual translation

Chinese README

Requirements

  • Xcode 11.0+
  • iOS 11.0+
  • tvOS 11.0+
  • macOS 10.13+ (diffing algorithm components only)
  • Interoperability with Swift 3.0+

Installation

CocoaPods

The preferred installation method is with CocoaPods. Add the following to your Podfile:

pod 'IGListKit', '~> 4.0.0'

Carthage

For Carthage, add the following to your Cartfile:

github "Instagram/IGListKit" ~> 4.0.0

Swift Package Manager

For Swift Package Manager:

To integrate using Xcode:

File -> Swift Packages -> Add Package Dependency

Enter package URL: https://github.com/Instagram/IGListKit, and select the latest release.

For advanced usage, see our Installation Guide.

Getting Started

Try out IGListKit by opening any of the sample apps available in the Examples directory.

Documentation

You can find the docs here. Documentation is generated with jazzy and hosted on GitHub-Pages.

To regenerate docs, run ./scripts/build_docs.sh from the root directory in the repo.

Vision

For the long-term goals and "vision" of IGListKit, please read our Vision doc.

Contributing

Please see the CONTRIBUTING file for how to help. At Instagram, we sync the open source version of IGListKit daily, so we're always testing the latest changes. But that requires all changes be thoroughly tested and follow our style guide.

We have a set of starter tasks that are great for beginners to jump in on and start contributing.

License

IGListKit is MIT-licensed.

The files in the /Examples/ directory are licensed under a separate license as specified in each file. Documentation is licensed CC-BY-4.0.

Copyright © Meta Platforms, Inc • Terms of UsePrivacy Policy