mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-24 09:48:21 +00:00
8676a3e6b9
Some checks failed
IGListKit CI / Unit Test macOS (push) Has been cancelled
IGListKit CI / Unit Test iOS (push) Has been cancelled
IGListKit CI / Unit Test tvOS (push) Has been cancelled
IGListKit CI / CocoaPods Lint (push) Has been cancelled
IGListKit CI / Verify generate_spm_sources_layout.sh is not broken (push) Has been cancelled
IGListKit CI / Verify SPM build by invoking `xcodebuild` on Package.swift (push) Has been cancelled
IGListKit CI / Verify Carthage build XCFramework (push) Has been cancelled
IGListKit CI / Build Examples and UI tests. (push) Has been cancelled
IGListKit CI / Run Danger (push) Has been cancelled
Summary: ## Plan This module doesn't need A/B testing and will be migrated directly. ## This Diff Removes the `__covariant ObjectType : id<IGListDiffable>` lightweight generic type parameter from `IGListBindingSectionController`. Swift generic types cannot be exposed to ObjC, so any generic ObjC class must lose its type parameter when converted to Swift. This degenerification is a required prerequisite for future Swift migration. Changes: - Removed the generic type parameter from the class header, replacing `ObjectType` with `id<IGListDiffable>` in the `object` property declaration - Removed the generic specialization from the `IGContentAppreciationGiftSectionController` subclass header - Simplified 87 Swift files that referenced `ListBindingSectionController<ListDiffable>` or `ListBindingSectionController<any ListDiffable>` or other specializations to plain `ListBindingSectionController` - Added ObjC casts at 3 callsites where the `.object` property was used with specialized type access (`IGAudioSearchResultsViewController.mm`, `IGDSShowcaseListExampleModel.m`) - Added Swift casts at callsites in `BCNComposerPostSectionController`, `BCNComposerViewController`, `BCNPostingStatusDatasource`, `BCNComposerAssetSectionController`, and `GiftsFeedSectionController` where `.object` was accessed as the previously-specialized type Differential Revision: D104311510 fbshipit-source-id: 6f54a761aa70fc39ffcd789fe74e3d83609ef61f |
||
|---|---|---|
| .. | ||
| With Composable Layout | ||
| DemoSectionController.swift | ||
| DisplaySectionController.swift | ||
| EmbeddedSectionController.swift | ||
| ExpandableSectionController.swift | ||
| FeedItemSectionController.swift | ||
| GridSectionController.swift | ||
| HorizontalSectionController.swift | ||
| LabelSectionController.swift | ||
| ListeningSectionController.swift | ||
| LoadingSectionController.swift | ||
| MonthSectionController.swift | ||
| PersonSectionController.h | ||
| PersonSectionController.m | ||
| PostSectionController.h | ||
| PostSectionController.m | ||
| PostSectionController.swift | ||
| RemoveSectionController.swift | ||
| ReorderableSectionController.swift | ||
| SearchSectionController.swift | ||
| SelfSizingSectionController.swift | ||
| StoryboardLabelSectionController.swift | ||
| UserSectionController.swift | ||
| WorkingRangeSectionController.swift | ||