mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-22 16:58:23 +00:00
9c37fbf8a4
Summary: Removing the assert and handling `nil` section controllers. This wont effect Swift code which demands a non-optional section controller, but Objective-C is more nuanced. There is evidence that some callers do not have a default state and are returning `nil`. Unfortunately this will [OOB here](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListSectionMap.m#L63) if using the original `objects` array provided by the data source. Instead we prune the array, only allowing in objects that have a matching section controller. Fixes t15773862 internally. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/488 Reviewed By: dshahidehpour Differential Revision: D4553886 Pulled By: rnystrom fbshipit-source-id: a473a99b5eb513e4b610019dba0394a014193fc4 |
||
|---|---|---|
| .. | ||
| Assets | ||
| Objects | ||
| IGListAdapterE2ETests.m | ||
| IGListAdapterProxyTests.m | ||
| IGListAdapterStoryboardTests.m | ||
| IGListAdapterTests.m | ||
| IGListAdapterUpdaterTests.m | ||
| IGListBatchUpdateDataTests.m | ||
| IGListCollectionViewLayoutTests.m | ||
| IGListCollectionViewTests.m | ||
| IGListDiffResultTests.m | ||
| IGListDiffSwiftTests.swift | ||
| IGListDiffTests.h | ||
| IGListDiffTests.m | ||
| IGListDisplayHandlerTests.m | ||
| IGListKitTests-Bridging-Header.h | ||
| IGListSectionMapTests.m | ||
| IGListSingleNibItemControllerTests.m | ||
| IGListSingleSectionControllerTests.m | ||
| IGListSingleStoryboardItemControllerTests.m | ||
| IGListStackSectionControllerTests.m | ||
| IGListWorkingRangeHandlerTests.m | ||
| IGReloadDataUpdaterTests.m | ||
| Info.plist | ||