IGListKit/Tests/IGListBatchUpdateDataTests.m
Ryan Nystrom 5eca718ea7 Drop section moves if they are also deleted or inserted
Summary:
Issue fixed: #430

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
Closes https://github.com/Instagram/IGListKit/pull/577

Differential Revision: D4768612

Pulled By: rnystrom

fbshipit-source-id: 6a2024101411302446cc2b7843fa175cd43a1562
2017-03-23 22:31:38 -07:00

136 lines
8.3 KiB
Objective-C

/**
* Copyright (c) 2016-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*/
#import <XCTest/XCTest.h>
#import "IGListBatchUpdateData.h"
#import "IGListMoveIndexPathInternal.h"
// IGListMoveIndexInternal.h
@interface IGListMoveIndex (Private)
- (instancetype)initWithFrom:(NSInteger)from to:(NSInteger)to;
@end
@interface IGListBatchUpdateDataTests : XCTestCase
@end
@implementation IGListBatchUpdateDataTests
static NSIndexSet *indexSet(NSArray<NSNumber *> *arr) {
NSMutableIndexSet *set = [NSMutableIndexSet new];
for (NSNumber *n in arr) {
[set addIndex:[n integerValue]];
}
return set;
}
static NSIndexPath *newPath(NSInteger section, NSInteger item) {
return [NSIndexPath indexPathForItem:item inSection:section];
}
static IGListMoveIndexPath *newMovePath(NSInteger fromSection, NSInteger fromItem, NSInteger toSection, NSInteger toItem) {
return [[IGListMoveIndexPath alloc] initWithFrom:newPath(fromSection, fromItem) to:newPath(toSection, toItem)];
}
static IGListMoveIndex *newMove(NSInteger from, NSInteger to) {
return [[IGListMoveIndex alloc] initWithFrom:from to:to];
}
- (void)test_whenEmptyUpdates_thatResultExists {
IGListBatchUpdateData *result = [[IGListBatchUpdateData alloc] initWithInsertSections:indexSet(@[])
deleteSections:indexSet(@[])
moveSections:[NSSet new]
insertIndexPaths:[NSSet new]
deleteIndexPaths:[NSSet new]
moveIndexPaths:[NSSet new]];
XCTAssertNotNil(result);
}
- (void)test_whenUpdatesAreClean_thatResultMatches {
IGListBatchUpdateData *result = [[IGListBatchUpdateData alloc] initWithInsertSections:indexSet(@[@0, @1])
deleteSections:indexSet(@[@5])
moveSections:[NSSet setWithArray:@[newMove(3, 4)]]
insertIndexPaths:[NSSet setWithArray:@[newPath(0, 0)]]
deleteIndexPaths:[NSSet setWithArray:@[newPath(1, 0)]]
moveIndexPaths:[NSSet setWithArray:@[newMovePath(6, 0, 6, 1)]]];
XCTAssertEqualObjects(result.insertSections, indexSet(@[@0, @1]));
XCTAssertEqualObjects(result.deleteSections, indexSet(@[@5]));
XCTAssertEqualObjects(result.moveSections, [NSSet setWithArray:@[newMove(3, 4)]]);
XCTAssertEqualObjects(result.insertIndexPaths, [NSSet setWithArray:@[newPath(0, 0)]]);
XCTAssertEqualObjects(result.deleteIndexPaths, [NSSet setWithArray:@[newPath(1, 0)]]);
XCTAssertEqual(result.moveIndexPaths.count, 1);
XCTAssertEqualObjects(result.moveIndexPaths.anyObject, [[IGListMoveIndexPath alloc] initWithFrom:newPath(6, 0) to:newPath(6, 1)]);
}
- (void)test_whenMovingSections_withItemDeletes_thatResultConvertsConflicts_toDeletesAndInserts {
IGListBatchUpdateData *result = [[IGListBatchUpdateData alloc] initWithInsertSections:indexSet(@[])
deleteSections:indexSet(@[])
moveSections:[NSSet setWithArray:@[newMove(2, 4)]]
insertIndexPaths:[NSSet new]
deleteIndexPaths:[NSSet setWithArray:@[newPath(2, 0), newPath(3, 4)]]
moveIndexPaths:[NSSet new]];
XCTAssertEqualObjects(result.insertSections, indexSet(@[@4]));
XCTAssertEqualObjects(result.deleteSections, indexSet(@[@2]));
XCTAssertEqualObjects(result.deleteIndexPaths, [NSSet setWithArray:@[newPath(3, 4)]]);
XCTAssertEqual(result.moveSections.count, 0);
}
- (void)test_whenMovingSections_withItemInserts_thatResultConvertsConflicts_toDeletesAndInserts {
IGListBatchUpdateData *result = [[IGListBatchUpdateData alloc] initWithInsertSections:indexSet(@[])
deleteSections:indexSet(@[])
moveSections:[NSSet setWithArray:@[newMove(2, 4)]]
insertIndexPaths:[NSSet setWithArray:@[newPath(4, 0), newPath(3, 4)]]
deleteIndexPaths:[NSSet new]
moveIndexPaths:[NSSet new]];
XCTAssertEqualObjects(result.insertSections, indexSet(@[@4]));
XCTAssertEqualObjects(result.deleteSections, indexSet(@[@2]));
XCTAssertEqualObjects(result.insertIndexPaths, [NSSet setWithArray:@[newPath(3, 4)]]);
XCTAssertEqual(result.moveSections.count, 0);
}
- (void)test_whenMovingIndexPaths_withSectionDeleted_thatResultDropsTheMove {
IGListBatchUpdateData *result = [[IGListBatchUpdateData alloc] initWithInsertSections:indexSet(@[])
deleteSections:indexSet(@[@0])
moveSections:[NSSet new]
insertIndexPaths:[NSSet new]
deleteIndexPaths:[NSSet new]
moveIndexPaths:[NSSet setWithArray:@[newMovePath(0, 0, 0, 1)]]];
XCTAssertEqual(result.moveIndexPaths.count, 0);
XCTAssertEqualObjects(result.deleteSections, indexSet(@[@0]));
}
- (void)test_whenMovingIndexPaths_withSectionMoved_thatResultConvertsToDeletesAndInserts {
IGListBatchUpdateData *result = [[IGListBatchUpdateData alloc] initWithInsertSections:indexSet(@[])
deleteSections:indexSet(@[])
moveSections:[NSSet setWithArray:@[newMove(0, 1)]]
insertIndexPaths:[NSSet new]
deleteIndexPaths:[NSSet new]
moveIndexPaths:[NSSet setWithArray:@[newMovePath(0, 0, 0, 1)]]];
XCTAssertEqual(result.moveIndexPaths.count, 0);
XCTAssertEqual(result.moveSections.count, 0);
XCTAssertEqualObjects(result.deleteSections, indexSet(@[@0]));
XCTAssertEqualObjects(result.insertSections, indexSet(@[@1]));
}
- (void)test_whenMovingSections_withMoveFromConflictWithDelete_thatResultDropsTheMove {
IGListBatchUpdateData *result = [[IGListBatchUpdateData alloc] initWithInsertSections:indexSet(@[])
deleteSections:indexSet(@[@2])
moveSections:[NSSet setWithArray:@[newMove(2, 6), newMove(0, 2)]]
insertIndexPaths:[NSSet new]
deleteIndexPaths:[NSSet new]
moveIndexPaths:[NSSet new]];
XCTAssertEqual(result.deleteSections.count, 1);
XCTAssertEqual(result.moveSections.count, 1);
XCTAssertEqual(result.insertSections.count, 0);
XCTAssertEqualObjects(result.deleteSections, indexSet(@[@2]));
XCTAssertEqualObjects(result.moveSections.anyObject, newMove(0, 2));
}
@end