mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-19 07:18:26 +00:00
40625f8ff9
Summary: This adds `NS_SWIFT_NAME` annotations to all public API's to provide cleaner integration into Swift: - Removes the need to prefix classes in Swift code, instead rely on Swift module name spacing - Adds more argument labels to C function API's like `IGListDiff([], [], .equality)` => `ListDiff(oldArray: [], newArray: [], option: .equality)` While this is a large API change it should be as easy as: - Find and replace `(IGList)([^K])` to `List$2` in Xcode with a scope set to Swift - Build and follow compiler's auto fix corrections for C API's or any missed renames I have not updated the documentation to reflect this yet, I am totally willing to do so but before I sink that amount of time into it I wanted to see if the Instagram team is even open to this change! - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [ ] I have updated the documentation Closes https://github.com/Instagram/IGListKit/pull/593 Reviewed By: jessesquires Differential Revision: D5028039 Pulled By: rnystrom fbshipit-source-id: b473d874a1f9574e56b2ebaabd5b73d1b57d4bab
35 lines
1.1 KiB
Objective-C
35 lines
1.1 KiB
Objective-C
/**
|
|
* Copyright (c) 2016-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import <Foundation/Foundation.h>
|
|
|
|
@class IGListBindingSectionController;
|
|
|
|
NS_ASSUME_NONNULL_BEGIN
|
|
|
|
/**
|
|
A protocol that handles cell selection events in an `IGListBindingSectionController`.
|
|
*/
|
|
NS_SWIFT_NAME(ListBindingSectionControllerSelectionDelegate)
|
|
@protocol IGListBindingSectionControllerSelectionDelegate <NSObject>
|
|
|
|
/**
|
|
Tells the delegate that a cell at a given index was selected.
|
|
|
|
@param sectionController The section controller the selection occured in.
|
|
@param index The index of the selected cell.
|
|
@param viewModel The view model that was bound to the cell.
|
|
*/
|
|
- (void)sectionController:(IGListBindingSectionController *)sectionController
|
|
didSelectItemAtIndex:(NSInteger)index
|
|
viewModel:(id)viewModel;
|
|
|
|
@end
|
|
|
|
NS_ASSUME_NONNULL_END
|