mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-06 06:58:26 +00:00
08bf69cc2f
Summary: ## Changes in this pull request Issue fixed: https://github.com/Instagram/IGListKit/issues/1275 This PR is straintforward solution as mentioned in https://github.com/Instagram/IGListKit/issues/1275. When I finished it, I realized that it is not a problem in `IGListCollectionViewLayout Partial Optimization` and `IGListBindingSectionController` deserved it. Maybe `IGListCollectionViewLayout` is rarely used because of great builtin UICollectionViewFlowLayout or cells in section rarely need changing their sizes in practices. Despite it is not `IGListCollectionViewLayout`'s fault, I think it can be more optimized against `invalidateLayoutWithContext`. I would like to make an another PR to optimize it. Due to this PR just giving a proposed solution, it lacks of adding tests and changing log. When this solution is accepted, I would like to complete these todos. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1285 Reviewed By: candance Differential Revision: D15592807 Pulled By: lorixx fbshipit-source-id: ae06abce896341509de4f3dfb73b3a7bc0a68c51
39 lines
1.3 KiB
Objective-C
39 lines
1.3 KiB
Objective-C
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import "IGTestInvalidateLayoutSectionController.h"
|
|
|
|
#import "IGTestInvalidateLayoutObject.h"
|
|
#import "IGTestCell.h"
|
|
#import "IGTestObject.h"
|
|
#import "IGLayoutTestItem.h"
|
|
|
|
@implementation IGTestInvalidateLayoutSectionController
|
|
|
|
- (instancetype)init {
|
|
if (self = [super init]) {
|
|
self.dataSource = self;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
#pragma mark - IGListBindingSectionControllerDataSource
|
|
|
|
- (NSArray<id<IGListDiffable>> *)sectionController:(IGListBindingSectionController *)sectionController viewModelsForObject:(id)object {
|
|
return [(IGTestInvalidateLayoutObject *)object objects];
|
|
}
|
|
|
|
- (UICollectionViewCell<IGListBindable> *)sectionController:(IGListBindingSectionController *)sectionController cellForViewModel:(id)viewModel atIndex:(NSInteger)index {
|
|
IGTestCell *cell = [self.collectionContext dequeueReusableCellOfClass:[IGTestCell class] forSectionController:self atIndex:index];
|
|
return cell;
|
|
}
|
|
|
|
- (CGSize)sectionController:(IGListBindingSectionController *)sectionController sizeForViewModel:(id)viewModel atIndex:(NSInteger)index {
|
|
return [(IGLayoutTestItem *)[(IGTestObject *)viewModel value] size];
|
|
}
|
|
|
|
@end
|