A data-driven UICollectionView framework for building fast and flexible lists.
Find a file
Maxime Ollivier 032e1b0b83 goodbye allowsBackgroundReloading
Summary:
Originally, `allowsBackgroundReloading` was added to improve performance, but ironically, it's causing lots of performance issues among other issues.
* Performance: Looking back, it's not too surprising that it causes perf issues. We're falling back to a full `-reloadData` if the view is not in the window, which can happen pretty often. For example, if a view-controller is within a `UINavigationController` stack but not on top, or within a `UITabBarController`. Because a full `-reloadData` will re-query the cells and re-create the entire layout, it's going to be more expensive than an incremental update via `-performUpdatesAnimated`. The proof is in the data and we have a few examples where this flag was the cause of significant UI stalls.
* Bugs: Because we might reload cells often, it can create strange animation artifacts. Specifically, it was breaking the `UIView` snapshots just before a transition, like the new zoom animator.

Overall, we ended disabling this feature and I think most apps will be in the same boat.

But what if this flag does improve my app's performance?
* File an issue and lets chat! I'd be curious to understand why that's the case. If a full `-reloadData` is more performant than an incremental `-performUpdatesAnimated`, than something odd is happening and I don't think this flag is the right solution.

Reviewed By: joetam

Differential Revision: D25884777

fbshipit-source-id: c4626a52082ef4c7b7300b21077529f26c551e70
2021-01-21 19:58:48 -08:00
.github Update issue template to ask for example project 2018-12-07 15:12:26 -08:00
docs Fix the build_doc.sh and regenerate all the docs! (#1393) 2019-11-20 16:23:15 -08:00
Examples ship the new updater 2021-01-21 19:58:47 -08:00
Guides Update the version to be 4.0 2019-11-20 16:23:15 -08:00
IGListKit.xcodeproj udpate xcodeproj and example projects 2020-09-08 09:11:12 -07:00
IGListKit.xcworkspace Fix "new file header template" whitespace #trivial (#1324) 2019-05-20 16:39:14 -07:00
Pods Run ./script/setup.sh to generate project files (#1431) 2020-02-26 12:26:58 -08:00
remodel-plugin Update remodel iglistdiffable plugin to the latest 2019-08-14 12:23:59 -07:00
Resources Create binding and modeling guide/tutorial 2017-08-21 14:46:53 -07:00
scripts Run lint on IGListKit 2019-12-19 09:34:42 -08:00
Source goodbye allowsBackgroundReloading 2021-01-21 19:58:48 -08:00
Tests goodbye allowsBackgroundReloading 2021-01-21 19:58:48 -08:00
.gitignore Nitpicky comment fixes 2017-03-31 13:01:40 -07:00
.slather.yml Ignore Xcode dir in coverage reports 2016-11-20 07:58:58 -08:00
.travis.yml Fix the podlint error (#1428) 2020-02-25 23:20:25 -08:00
CHANGELOG.md goodbye allowsBackgroundReloading 2021-01-21 19:58:48 -08:00
CODE_OF_CONDUCT.md Adopt Contributor Covenant 2019-08-29 23:20:54 -07:00
Dangerfile Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial 2018-02-02 13:16:46 -08:00
Gemfile Update Cocoapods 2019-11-13 05:30:27 -08:00
Gemfile.lock Bump json from 2.2.0 to 2.3.1 (#1448) 2020-07-28 11:17:17 -07:00
IGListDiffKit.podspec Run lint on IGListKit 2019-12-19 09:34:42 -08:00
IGListKit.podspec Run lint on IGListKit 2019-12-19 09:34:42 -08:00
IGListSwiftKit.podspec Run lint on IGListKit 2019-12-19 09:34:42 -08:00
LICENSE.md Update MIT license language (#1272) 2018-11-01 10:58:46 -07:00
Package.swift Add support for Swift PM (#1323) 2019-05-21 14:50:56 -07:00
Podfile use cocoapods cdn (#1386) 2019-11-20 09:24:48 -08:00
Podfile.lock use cocoapods cdn (#1386) 2019-11-20 09:24:48 -08:00
README.md CCAutoTag : Chinese README translate (#1228) 2020-09-29 10:39:01 -07:00
README.zh.md Better chinese readme (#1480) 2020-12-15 10:46:25 -08:00

Build Status Coverage Status Pods Version Platforms Carthage Compatible


A data-driven UICollectionView framework for building fast and flexible lists.

Main Features
🙅 Never call performBatchUpdates(_:, completion:) or reloadData() again
🏠 Better architecture with reusable cells and components
🔠 Create collections with multiple data types
🔑 Decoupled diffing algorithm
Fully unit tested
🔍 Customize your diffing behavior for your models
📱 Simply UICollectionView at its core
🚀 Extendable API
🐦 Written in Objective-C with full Swift interop support

IGListKit is built and maintained with ❤️ by Instagram engineering. We use the open source version master branch in the Instagram app.

Multilingual translation

Chinese README

Requirements

  • Xcode 9.0+
  • iOS 9.0+
  • tvOS 9.0+
  • macOS 10.11+ (diffing algorithm components only)
  • Interoperability with Swift 3.0+

Installation

CocoaPods

The preferred installation method is with CocoaPods. Add the following to your Podfile:

pod 'IGListKit', '~> 4.0.0'

Carthage

For Carthage, add the following to your Cartfile:

github "Instagram/IGListKit" ~> 4.0.0

For advanced usage, see our Installation Guide.

Getting Started

$ git clone https://github.com/Instagram/IGListKit.git
$ cd IGListKit/
$ ./scripts/setup.sh

Documentation

You can find the docs here. Documentation is generated with jazzy and hosted on GitHub-Pages.

To regenerate docs, run ./scripts/build_docs.sh from the root directory in the repo.

Vision

For the long-term goals and "vision" of IGListKit, please read our Vision doc.

Contributing

Please see the CONTRIBUTING file for how to help. At Instagram, we sync the open source version of IGListKit daily, so we're always testing the latest changes. But that requires all changes be thoroughly tested and follow our style guide.

We have a set of starter tasks that are great for beginners to jump in on and start contributing.

License

IGListKit is MIT-licensed.

The files in the /Examples/ directory are licensed under a separate license as specified in each file. Documentation is licensed CC-BY-4.0.