mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-24 09:48:21 +00:00
Summary: ## Changes in this pull request It's been a few years since I did an audit of our test suite. The majority of changes to IGListKit since then were adding additional error checking and hardening, so this was relatively straightforward. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/instagram/IGListKit/pull/1654 Reviewed By: jurmarcus Differential Revision: D91551666 Pulled By: TimOliver fbshipit-source-id: c89c7a45abebb44dbf50b252bfadc9a7c2928683
181 lines
9 KiB
Objective-C
181 lines
9 KiB
Objective-C
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <XCTest/XCTest.h>
|
|
|
|
#import "IGTestDiffingObject.h"
|
|
#import "IGListSectionMap.h"
|
|
#import "IGListTestSection.h"
|
|
#import "IGTestObject.h"
|
|
|
|
@interface IGListSectionMapTests : XCTestCase
|
|
|
|
@end
|
|
|
|
@implementation IGListSectionMapTests
|
|
|
|
- (void)test_whenUpdatingItems_thatArraysAreEqual {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertEqualObjects(objects, map.objects);
|
|
}
|
|
|
|
- (void)test_whenUpdatingItems_thatSectionControllersAreMappedForSection {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertEqualObjects([map sectionControllerForSection:1], sectionControllers[1]);
|
|
}
|
|
|
|
- (void)test_whenUpdatingItems_thatSectionControllersAreMappedForItem {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertEqual([map sectionControllerForObject:objects[1]], sectionControllers[1]);
|
|
}
|
|
|
|
- (void)test_whenUpdatingItems_thatSectionsAreMappedForSectionController {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertEqual([map sectionForSectionController:sectionControllers[1]], 1);
|
|
}
|
|
|
|
- (void)test_whenUpdatingItems_withUnknownItem_thatSectionControllerIsNil {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertNil([map sectionControllerForObject:@4]);
|
|
}
|
|
|
|
- (void)test_whenUpdatingItems_withSectionController_thatSectionIsNotFound {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertEqual([map sectionForSectionController:[IGListTestSection new]], NSNotFound);
|
|
}
|
|
|
|
- (void)test_whenEnumeratingMap_withStopFlagSet_thatEnumerationEndsEarly {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
__block NSInteger counter = 0;
|
|
[map enumerateUsingBlock:^(id item, IGListSectionController * sectionController, NSInteger section, BOOL *stop) {
|
|
counter++;
|
|
*stop = section == 1;
|
|
}];
|
|
XCTAssertEqual(counter, 2);
|
|
}
|
|
|
|
- (void)test_whenAccessingOOBSection_thatNilIsReturned {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertNil([map objectForSection:4]);
|
|
}
|
|
|
|
- (void)test_whenUpdatingItems_thatSectionControllerIndexesAreUpdated {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
|
|
IGListTestSection *one = [IGListTestSection new];
|
|
XCTAssertEqual(one.section, NSNotFound);
|
|
|
|
NSArray *sectionControllers = @[[IGListTestSection new], one, [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
|
|
XCTAssertEqual(one.section, 1);
|
|
XCTAssertFalse(one.isFirstSection);
|
|
}
|
|
|
|
- (void)test_whenQueryingItems_thatNilReturnsNotFound {
|
|
IGTestDiffingObject *object = [IGTestDiffingObject new];
|
|
object = nil;
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
XCTAssertEqual([map sectionForObject:object], NSNotFound);
|
|
}
|
|
|
|
- (void)test_whenAccessingNegativeSection_thatNilIsReturned {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
XCTAssertNil([map objectForSection:-1]);
|
|
}
|
|
|
|
- (void)test_whenUpdatingWithDifferentObjectCounts_thatValidationHandlesMismatch {
|
|
// First update with 3 objects
|
|
NSArray *objects1 = @[@0, @1, @2];
|
|
NSArray *sectionControllers1 = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects1 sectionControllers:sectionControllers1];
|
|
|
|
// Update with different count - this exercises the count mismatch path in validation
|
|
NSArray *objects2 = @[@3, @4];
|
|
NSArray *sectionControllers2 = @[[IGListTestSection new], [IGListTestSection new]];
|
|
[map updateWithObjects:objects2 sectionControllers:sectionControllers2];
|
|
|
|
XCTAssertEqual(map.objects.count, 2);
|
|
}
|
|
|
|
- (void)test_whenCopyingMap_thatCopyIsIndependent {
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
|
|
IGListSectionMap *copy = [map copy];
|
|
|
|
XCTAssertEqualObjects(map.objects, copy.objects);
|
|
XCTAssertNotEqual(map, copy);
|
|
}
|
|
|
|
- (void)test_whenValidatingWithMismatchedSnapshotCount_thatValidationReturnsEarly {
|
|
// Set up the map with objects
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
|
|
// Use KVC to set a mismatched snapshot (different count) to trigger line 183
|
|
// mObjects has 3 items, snapshot has 2 - validation should return early
|
|
// Must use NSMutableArray since _updateAllDiffIdentifiers calls removeAllObjects
|
|
[map setValue:[@[@"id1", @"id2"] mutableCopy] forKey:@"diffIdentifiersSnapshot"];
|
|
|
|
// Trigger validation by updating - the validation should handle the count mismatch gracefully
|
|
NSArray *newObjects = @[@3, @4, @5];
|
|
NSArray *newSectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
[map updateWithObjects:newObjects sectionControllers:newSectionControllers];
|
|
|
|
XCTAssertEqual(map.objects.count, 3);
|
|
}
|
|
|
|
- (void)test_whenUpdatingObjectNotInMap_thatValidationHandlesInvalidSection {
|
|
// Set up the map with objects
|
|
NSArray *objects = @[@0, @1, @2];
|
|
NSArray *sectionControllers = @[[IGListTestSection new], [IGListTestSection new], [IGListTestSection new]];
|
|
IGListSectionMap *map = [[IGListSectionMap alloc] initWithMapTable:[NSMapTable strongToStrongObjectsMapTable]];
|
|
[map updateWithObjects:objects sectionControllers:sectionControllers];
|
|
|
|
// Calling updateObject: with an object not in the map will:
|
|
// 1. Get section = NSNotFound from sectionForObject:
|
|
// 2. Call _validateDiffIdentifierAtSection: which hits line 187 (section >= mObjects.count)
|
|
// 3. Then crash when trying to access mObjects[NSNotFound]
|
|
// The validation at line 187 handles the invalid section gracefully before the crash
|
|
XCTAssertThrows([map updateObject:@99]);
|
|
}
|
|
|
|
@end
|