Commit graph

7 commits

Author SHA1 Message Date
Valeriy Van
e3ea1903f7 Minor changes in WorkingRangeSectionController.swift
Summary:
Uses trailing block syntax calling URLSession.shared.dataTask,
uses guard statement inside that block.

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)

…uard statement inside that block.
Closes https://github.com/Instagram/IGListKit/pull/124

Differential Revision: D4088983

Pulled By: rnystrom

fbshipit-source-id: 8c88b486728d2b40e1ed3b1f4819cfc7c584cbc9
2016-10-27 09:44:10 -07:00
Bofei Zhu
8855b5156a Add storyboard support #39
Summary:
This PR is for #39

- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/92

Differential Revision: D4066721

Pulled By: rnystrom

fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 15:29:13 -07:00
Sherlock
8ccdc838db Fixed tail loading example (#105)
Summary:
- Fixes #105
- ~~Added a 'SpinnerSectionController' allowing us to trigger the activity spinner each time~~
- Changed the words array to be numbers instead (I found it personally difficult to realise if more cells were actually added as the text didn't seem to change, by using numbers you can quite clearly see it increment by 5 each time you load more)
- No changes/new tests as it is a fix to an example

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/109

Differential Revision: D4066700

Pulled By: rnystrom

fbshipit-source-id: 7779a8ba39361cfa2e782db9460e693e90f1a478
2016-10-23 17:44:10 -07:00
Ryan Nystrom
f6e088acd8 Working Range example
Summary:
Adding a working range example to the example app. This example:

- Displays a list of images downloaded from unsplash.it
- Create 20 uniquely-random sized objects
- When section controllers enter the range, create a data task to download the image
  - When finished, store image in `downloadedImage`
  - Set in cell if cell is visible
  - Don't create task if already downloaded or task created
- Cancel task when section controller is destroyed
- Show a spinner cell while downloading the image

Fixes #84

- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/89

Differential Revision: D4050210

Pulled By: rnystrom

fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-19 23:29:12 -07:00
Ryan Nystrom
8e9c08fff7 Fix search sample project scroll delegate
Summary:
The scroll delegate got lost in migrating scroll events to their own delegates and broke the sample app. It looks like there's an actual UIKit bug in iOS 10 though. Fixes #87

- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/88

Differential Revision: D4050213

Pulled By: rnystrom

fbshipit-source-id: 61b29489f28002ad61193df237889b0bb8d34a29
2016-10-19 23:29:12 -07:00
Valeriy Van
221c2fbd20 Makes objects function more swifty.
Summary:
- [x ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/70

Reviewed By: nlutsenko

Differential Revision: D4025610

Pulled By: rnystrom

fbshipit-source-id: 927e93cec5719466dc152f82a235d5a70e53109d
2016-10-14 17:44:19 -07:00
FBShipIt
cdc796746a Initial commit
fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-10-11 10:12:17 -04:00