Commit graph

9 commits

Author SHA1 Message Date
Valeriy Van
90d2805115 Changes 'if let _ = object as?' for 'if object is'
Summary:
Changes 'if let _ = object as?' for 'if object is'

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/83

Differential Revision: D4034281

Pulled By: jessesquires

fbshipit-source-id: f63e853b080ee63595ae5a808f4a2177c4615798
2016-10-18 02:44:21 -07:00
Valeriy Van
96a9555ecb Makes objects function more swifty.
Summary:
Makes objects function more swifty.

- [x ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/74

Reviewed By: dshahidehpour

Differential Revision: D4030906

Pulled By: jessesquires

fbshipit-source-id: 9a986fd4b470da0a33fadfd71f41f86b324df5be
2016-10-17 14:59:07 -07:00
Valeriy Van
799517d6ae Using switch with is cases instead of if with multiple as?.
Summary:
Using switch with is cases instead of if with multiple as?.

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/82

Reviewed By: dshahidehpour

Differential Revision: D4030890

Pulled By: jessesquires

fbshipit-source-id: fc17795620509572ed1d9fa6ef405357acab9a9b
2016-10-17 14:44:28 -07:00
Valeriy Van
1e73bc69b0 Fixes compilation errors in example app.
Summary:
Fixes compilation errors in example app.

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/71

Differential Revision: D4027054

Pulled By: rnystrom

fbshipit-source-id: 50020d309e8cf69dabaa1958d9f1eed37dc6ee63
2016-10-15 12:29:15 -07:00
Sven Bacia
ce4b851da3 Support cells created from nibs
Summary:
I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind.

- [x]  I'm currently thinking about the best way to test these changes.
- [x] I was not able to update the documentation (issue #55).

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/56

Reviewed By: dshahidehpour

Differential Revision: D4023746

Pulled By: rnystrom

fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-14 18:59:18 -07:00
Valeriy Van
221c2fbd20 Makes objects function more swifty.
Summary:
- [x ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/70

Reviewed By: nlutsenko

Differential Revision: D4025610

Pulled By: rnystrom

fbshipit-source-id: 927e93cec5719466dc152f82a235d5a70e53109d
2016-10-14 17:44:19 -07:00
Bas Broek
58e5888dea Jessie > Jesse
Summary:
Corrected Jesse's name.

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/60

Reviewed By: ocrickard

Differential Revision: D4009130

Pulled By: jessesquires

fbshipit-source-id: 5786282f0690829374096bed1528138dccf0a703
2016-10-12 11:14:16 -07:00
Patrick Balestra
bd72c71cd6 Fix Twitter handles in Example project
Summary:
I was exploring the example project when I noticed that two Twitter handles were wrong.
This will probably be the most useless PR ever in `IGListKit`, but it's good that you guys get the correct acknowledgment for your hard work! 🤓

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/54

Reviewed By: ryanolsonk

Differential Revision: D4008615

Pulled By: rnystrom

fbshipit-source-id: 904892d40fed73045e724cc87dddf641af02e27d
2016-10-12 09:14:10 -07:00
FBShipIt
cdc796746a Initial commit
fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-10-11 10:12:17 -04:00