Christian Tietze
8f3a89412c
fix cell height in macOS sample projects ( #1445 )
...
Summary:
## Changes in this pull request
The macOS sample project used to cut off descenders of the letters "y" and "g". I adjusted the programmatic cell height to match the Nib, and recenter the components vertically.
| Before | After |
| ---- | ---- |
|  |  |
### Checklist
- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- This doesn't sound newsworthy :)
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md )
Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1445
Reviewed By: joetam
Differential Revision: D22950519
Pulled By: bdotdub
fbshipit-source-id: 506df3ab158dae52d7d86695d602cca47bc420c3
2020-08-06 10:14:53 -07:00
Nate Stedman
1a44045dce
Run lint on IGListKit
...
Differential Revision: D19141253
fbshipit-source-id: 9ed4c278a91bb48a1f6d33cafa9ce8f21861573d
2019-12-19 09:34:42 -08:00
Ryan Nystrom
8d8a632b67
Update MIT license language ( #1272 )
...
Summary:
Updating license language to meet FB open source standards.
Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1272
Differential Revision: D12844366
Pulled By: rnystrom
fbshipit-source-id: 27ae49ae00d963c5c012c79c5738365c232a5773
2018-11-01 10:58:46 -07:00
Jesse Squires
ae7f36f5c2
Update gems, fix warnings, pod install
...
Summary:
- Update CocoaPods + Gems
- Update SwiftLint version
- Fix lint errors
- Fix `pod_setup.sh` script, move to `scripts/` (should now be run from root dir)
- Run `pod_setup.sh`
Closes https://github.com/Instagram/IGListKit/pull/1038
Differential Revision: D6602297
Pulled By: rnystrom
fbshipit-source-id: 1bf69611e041903cf982fe7d9a95197729e44d94
2017-12-19 09:31:37 -08:00
Weyert de Boer
bb983cf918
Refactors/macos example
...
Summary:
Issue fixed : #381
- [X] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [X] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md )
Closes https://github.com/Instagram/IGListKit/pull/915
Differential Revision: D5758006
Pulled By: rnystrom
fbshipit-source-id: cbc3f19b6bb9604d8a6c8c15a16414e558e3b70c
2017-09-01 14:00:52 -07:00
