Summary:
The scroll delegate got lost in migrating scroll events to their own delegates and broke the sample app. It looks like there's an actual UIKit bug in iOS 10 though. Fixes#87
- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/88
Differential Revision: D4050213
Pulled By: rnystrom
fbshipit-source-id: 61b29489f28002ad61193df237889b0bb8d34a29
Summary:
Using array initialisation instead of for loop.
- [X] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/81
Differential Revision: D4030872
Pulled By: jessesquires
fbshipit-source-id: f61114d60bacfcb7a3722a6727aa0060a68ae35d
Summary:
Changes 'if let _ = object as?' for 'if object is'
- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/83
Differential Revision: D4034281
Pulled By: jessesquires
fbshipit-source-id: f63e853b080ee63595ae5a808f4a2177c4615798
Summary:
Makes objects function more swifty.
- [x ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/74
Reviewed By: dshahidehpour
Differential Revision: D4030906
Pulled By: jessesquires
fbshipit-source-id: 9a986fd4b470da0a33fadfd71f41f86b324df5be
Summary:
Using switch with is cases instead of if with multiple as?.
- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/82
Reviewed By: dshahidehpour
Differential Revision: D4030890
Pulled By: jessesquires
fbshipit-source-id: fc17795620509572ed1d9fa6ef405357acab9a9b
Summary:
Fixes compilation errors in example app.
- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/71
Differential Revision: D4027054
Pulled By: rnystrom
fbshipit-source-id: 50020d309e8cf69dabaa1958d9f1eed37dc6ee63
Summary:
I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind.
- [x] I'm currently thinking about the best way to test these changes.
- [x] I was not able to update the documentation (issue #55).
- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/56
Reviewed By: dshahidehpour
Differential Revision: D4023746
Pulled By: rnystrom
fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
Summary:
I was exploring the example project when I noticed that two Twitter handles were wrong.
This will probably be the most useless PR ever in `IGListKit`, but it's good that you guys get the correct acknowledgment for your hard work! 🤓
- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/54
Reviewed By: ryanolsonk
Differential Revision: D4008615
Pulled By: rnystrom
fbshipit-source-id: 904892d40fed73045e724cc87dddf641af02e27d
