IGListKit

434 commits 16 branches 13 tags 23 MiB

Author	SHA1	Message	Date
Nikolai Johan Heum	a7855d15ac	consistent use of finall class Summary: You are already using `final class` as the default swift declaration as I guess most people agree this is best practice for classes you are not planning to inherit from :) So I just made the example code more consistent. I will not add much more reasoning to why, other than open source projects like this is a _big_ inspirations and starting ground to play with swift for new develoeprs joining the iOS community. Nuding them to ask the right questions (composition vs inheritance) early could only be a good thing (?) - [X] All tests pass. Demo project builds and runs. - [X] No new tests. No new classes. - [X] No breaking changes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/539 Differential Revision: D4696591 Pulled By: rnystrom fbshipit-source-id: 73539b907452ec0cb7a8e842a95cb4fd27138f2f	2017-03-12 13:17:54 -07:00
Jesse Squires	879260b417	internal diff for PR #209 Summary: https://github.com/Instagram/IGListKit/pull/209 Reviewed By: rnystrom Differential Revision: D4190633 fbshipit-source-id: 9d382b9ba3f3d20c8b9c48d900650ec354bc9728	2016-11-16 12:44:19 -08:00

Author

SHA1

Message

Date

Nikolai Johan Heum

a7855d15ac

consistent use of finall class

Summary:
You are already using `final class` as the default swift declaration as I guess most people agree this is best practice for classes you are not planning to inherit from :) So I just made the example code more consistent.

I will not add much more reasoning to why, other than open source projects like this is a _big_ inspirations and starting ground to play with swift for new develoeprs joining the iOS community. Nuding them to ask the right questions (composition vs inheritance) early could only be a good thing (?)

- [X] All tests pass. Demo project builds and runs.
- [X] No new tests. No new classes.
- [X] No breaking changes.
- [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/539

Differential Revision: D4696591

Pulled By: rnystrom

fbshipit-source-id: 73539b907452ec0cb7a8e842a95cb4fd27138f2f

2017-03-12 13:17:54 -07:00

Jesse Squires

879260b417

internal diff for PR #209

Summary: https://github.com/Instagram/IGListKit/pull/209

Reviewed By: rnystrom

Differential Revision: D4190633

fbshipit-source-id: 9d382b9ba3f3d20c8b9c48d900650ec354bc9728

2016-11-16 12:44:19 -08:00

Renamed from Example/IGListKitExamples/Views/SearchCell.swift (Browse further)

2 commits