Commit graph

6 commits

Author SHA1 Message Date
Jesse Squires
879260b417 internal diff for PR #209
Summary: https://github.com/Instagram/IGListKit/pull/209

Reviewed By: rnystrom

Differential Revision: D4190633

fbshipit-source-id: 9d382b9ba3f3d20c8b9c48d900650ec354bc9728
2016-11-16 12:44:19 -08:00
Ryan Nystrom
ab890fc607 Change equality API to avoid NSObject override
Summary:
Changing the API to avoid overiding `-[NSObject isEqual:]` because of the side effects it brings (e.g. `-hash`). Not to mention the problems with Swift 2.3.

Fixes #65.

Reviewed By: jessesquires

Differential Revision: D4138570

fbshipit-source-id: 804af6c468c4c273adb73377e9bfda22515121d1
2016-11-10 16:59:02 -08:00
Valeriy Van
b5bc6802ed Minor dubious changes to swift example app:
Summary:
Changes if to guard;
Uses forEach instead of for loop.

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)

Changes if to guard;
Uses forEach instead of for loop.
Closes https://github.com/Instagram/IGListKit/pull/178

Differential Revision: D4153631

Pulled By: rnystrom

fbshipit-source-id: 077a64f7c92a8d8acdb3626047b602b12a9ebe17
2016-11-09 09:31:15 -08:00
Bofei Zhu
59242c5b7e Add final to each class in Example
Summary: Closes https://github.com/Instagram/IGListKit/pull/173

Differential Revision: D4143811

Pulled By: rnystrom

fbshipit-source-id: 879ba9fa858648677fd2e3750bcf1815ac37ef18
2016-11-07 15:59:04 -08:00
Valeriy Van
d34a8aa9a5 Implements isEqual func with guard statement
Summary:
Implements isEqual func with guard statement

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/151

Differential Revision: D4120016

Pulled By: rnystrom

fbshipit-source-id: a769071f788b1acc1f2fade5606859a5d91f1bfd
2016-11-02 14:14:01 -07:00
Ryan Nystrom
cf7cfb89df Add diffing example
Summary: Adding an example of how to use diffing by itself w/ `UITableView` batch updates.

Reviewed By: jessesquires

Differential Revision: D4077768

fbshipit-source-id: 313193cdcadd337e08f74e90713fa127a5365112
2016-10-26 11:59:13 -07:00