Commit graph

7 commits

Author SHA1 Message Date
Ryan Nystrom
ab890fc607 Change equality API to avoid NSObject override
Summary:
Changing the API to avoid overiding `-[NSObject isEqual:]` because of the side effects it brings (e.g. `-hash`). Not to mention the problems with Swift 2.3.

Fixes #65.

Reviewed By: jessesquires

Differential Revision: D4138570

fbshipit-source-id: 804af6c468c4c273adb73377e9bfda22515121d1
2016-11-10 16:59:02 -08:00
Ryan Nystrom
1950abad4f Example using self sizing cells
Summary:
Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards.

![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png)

Fixes #149

- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/176

Differential Revision: D4156409

Pulled By: rnystrom

fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 15:29:19 -08:00
Valeriy Van
b5bc6802ed Minor dubious changes to swift example app:
Summary:
Changes if to guard;
Uses forEach instead of for loop.

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)

Changes if to guard;
Uses forEach instead of for loop.
Closes https://github.com/Instagram/IGListKit/pull/178

Differential Revision: D4153631

Pulled By: rnystrom

fbshipit-source-id: 077a64f7c92a8d8acdb3626047b602b12a9ebe17
2016-11-09 09:31:15 -08:00
Bofei Zhu
59242c5b7e Add final to each class in Example
Summary: Closes https://github.com/Instagram/IGListKit/pull/173

Differential Revision: D4143811

Pulled By: rnystrom

fbshipit-source-id: 879ba9fa858648677fd2e3750bcf1815ac37ef18
2016-11-07 15:59:04 -08:00
Ryan Nystrom
8fa4001d15 Add supplementary source example
Summary:
Got around to adding a supplementary view source example.

Fixes #153 #163

![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG)

- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/169

Differential Revision: D4139910

Pulled By: rnystrom

fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 06:44:29 -08:00
Valeriy Van
d34a8aa9a5 Implements isEqual func with guard statement
Summary:
Implements isEqual func with guard statement

- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/151

Differential Revision: D4120016

Pulled By: rnystrom

fbshipit-source-id: a769071f788b1acc1f2fade5606859a5d91f1bfd
2016-11-02 14:14:01 -07:00
FBShipIt
cdc796746a Initial commit
fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-10-11 10:12:17 -04:00