Commit graph

3 commits

Author SHA1 Message Date
Tim Oliver
2644442595 Add symlink for new IGListArrayUtilsInternal.m (#1591)
Summary:
## Changes in this pull request

I moved the functions from ` IGListArrayUtilsInternal.h` to `IGListArrayUtilsInternal.m` to ensure the code was properly captured for code coverage, but I forgot to re-run the SPM script to generate a new symlink for it. This should fix the failing sample app build tests.

### Checklist

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md)

Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1591

Test Plan: Confirmed this lets the sample apps run again.

Reviewed By: fabiomassimo

Differential Revision: D50013194

Pulled By: TimOliver

fbshipit-source-id: ff4bebae781ebb460915458848cb340a89401a83
2023-10-11 21:26:45 -07:00
Tim Oliver
bc83026985 Update IGListKit symlinks for SPM support
Summary: I ran the script needed to update the symlinks needed for SPM support. This removed the symlinks for the files we deleted and added the ones for `IGListBindingSingleSectionController`.

Reviewed By: candance

Differential Revision: D45147897

fbshipit-source-id: e3d351fcefd1f0e193aafc6f6c2af91fefb8c5cb
2023-04-20 14:26:11 -07:00
3a4oT
a1036e06e3 SPM number10 (#1487)
Summary:
## Changes in this pull request

 A better version of https://github.com/Instagram/IGListKit/issues/1465 =)

- SPM support with script-based generations.

- added macOS Catalyst support

 ### Generate SPM layout

1. From **project's root** run:

   `bash scripts/generate_spm_sources_layout.sh`

  2. Commit Changes

 Repeat those steps each time you delete/add the project's files. **Make sure** to have this CI step which will check that `generate_spm_sources_layout.sh` is not broken.

Issue fixed: https://github.com/Instagram/IGListKit/issues/1368 #1406

### Checklist

- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)

Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1487

Reviewed By: DimaVartanian, candance

Differential Revision: D30428297

Pulled By: lorixx

fbshipit-source-id: 655291ff03445dec9b0b8cd97916f0c88207e9a7
2021-08-31 19:28:37 -07:00