Nate Stedman
1a44045dce
Run lint on IGListKit
...
Differential Revision: D19141253
fbshipit-source-id: 9ed4c278a91bb48a1f6d33cafa9ce8f21861573d
2019-12-19 09:34:42 -08:00
Ryan Nystrom
8d8a632b67
Update MIT license language ( #1272 )
...
Summary:
Updating license language to meet FB open source standards.
Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1272
Differential Revision: D12844366
Pulled By: rnystrom
fbshipit-source-id: 27ae49ae00d963c5c012c79c5738365c232a5773
2018-11-01 10:58:46 -07:00
Bas Broek
ea5a4cc00f
Init without working range size
...
Summary:
Issue fixed : #414
- [x] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md )
What should we do with testing? I changed all the occurrences of the old initializer with the new one, so I think this is good to go?
Closes https://github.com/Instagram/IGListKit/pull/686
Differential Revision: D4931986
Pulled By: jessesquires
fbshipit-source-id: d6f0ac6578c11f8ef37ec0e385bc110e3abd7c91
2017-04-21 14:30:46 -07:00
Ryan Nystrom
3102852ce2
Remove IGListSectionType
...
Summary:
Removing the `IGListSectionType` protocol and adding default implementations into `IGListSectionController`.
- `numberOfItems` returns 1
- `cellForItemAtIndex:` asserts (have to return a cell)
- `didUpdateToObject:` no-ops
- `didSelectItemAtIndex:` no-ops
Fixes #168
Reviewed By: jessesquires
Differential Revision: D4909585
fbshipit-source-id: 8816702504e3fc0683868914ff4dd20e4af7c166
2017-04-19 08:26:30 -07:00
Ryan Nystrom
ba65b56a9b
Improve the ObjC demo to reflect best-practices
...
Summary:
Couple best practices I want to make sure our examples reflect:
- Multiple cells in a section controller
- Unique models returned in `objectsForListAdapter:` (no dupes!)
- Dynamic item count (`comments` array)
Issue fixed : #595
- [x] All tests pass. Demo project builds and runs.
Closes https://github.com/Instagram/IGListKit/pull/615
Differential Revision: D4852192
Pulled By: jessesquires
fbshipit-source-id: f4a89800f90e6b5ea4b6dd7c0d9a78ca5d65082c
2017-04-07 11:33:43 -07:00
Jesse Squires
2284ce3897
kill IGListCollectionView. GH issue #409 (redo of D4640425)
...
Summary:
Take 2. Remove `IGListCollectionView` per #409 . Use plain old `UICollectionView`.
(This re-applies D4640425 and updates as needed.)
Also:
- run `pod update` everywhere
- update changelog
Reviewed By: paulvanderspek
Differential Revision: D4812207
fbshipit-source-id: 1ddbae06cdeddb43d8af175d3e8a045a36ff150e
2017-03-31 14:54:09 -07:00
Leyla Hujer
68a264d29c
Revert D4640425: [IGListKit] kill IGListCollectionView. GH issue #409
...
Summary: This reverts commit 871b75eaeb1c9f2a40fe8f3fd81b209661704587
Differential Revision: D4640425
fbshipit-source-id: 4b0e8a9820891062cf7f8d13de13d678adb5df4a
2017-03-06 16:15:31 -08:00
Jesse Squires
3fb2ac0d60
kill IGListCollectionView. GH issue #409
...
Summary: Remove `IGListCollectionView` per #409 . Use plain old `UICollectionView`.
Reviewed By: rnystrom
Differential Revision: D4640425
fbshipit-source-id: 871b75eaeb1c9f2a40fe8f3fd81b209661704587
2017-03-06 15:01:01 -08:00
charles
1f33a77412
Add Example-iOS in ObjC
...
Summary:
Related issue: [#425 ](https://github.com/Instagram/IGListKit/issues/425 )
- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md )
Closes https://github.com/Instagram/IGListKit/pull/446
Differential Revision: D4589989
Pulled By: rnystrom
fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-20 16:18:21 -08:00
