Commit graph

6 commits

Author SHA1 Message Date
Markus Emrich
3deecff55a Update remodel iglistdiffable plugin to the latest
Summary:
Remodel changed quite a bit, this updates the plugin to work correctly with the latest state.
It also includes other recent Remodel changes like e.g. autoformatting of the codebase.

Resolves #1353

Reviewed By: natestedman

Differential Revision: D16794236

fbshipit-source-id: f543d0e3e5656f540accd5e359bbaf0acc8071fc
2019-08-14 12:23:59 -07:00
Jeremy Lawrence
c7caa4f166 Add copyright statement to remodel feature file
Summary: Add copyright statement to the `iglistdiffable.feature` file.

Reviewed By: calimarkus

Differential Revision: D15768452

fbshipit-source-id: 67bd21b7fbd9e13712b00f529ae4ce9ea118b341
2019-06-12 08:49:58 -07:00
Chris McGrath
0efb259e86 Optimize IGListDiffable for common diffIdentifier types
Summary: Let's use simple NSNumber wrapping to make diffable objects for most primitive types. This should be faster than building strings.

Reviewed By: calimarkus

Differential Revision: D10416548

fbshipit-source-id: af5b0a5afc6cd2c45c7e0bf2aa872864c12cbd98
2018-10-23 16:49:02 -07:00
Chris McGrath
c907d22acd Update acceptance test for the IGListKit internal version of the iglistdiffable plugin
Summary: Fix acceptance test for IGListDiffable remodel plugin to match recent remodel changes.

Reviewed By: calimarkus

Differential Revision: D10408993

fbshipit-source-id: 224808b47d17d83e86a42073a4dbf031b0e1ffed
2018-10-22 18:39:16 -07:00
Markus Emrich
6fa9be5d9f Update remodel plugin to latest openSource changes
Summary: This ensures we stay compatible with the current open source state of remodel.

Reviewed By: ColinCampbell

Differential Revision: D7082447

fbshipit-source-id: 3fa23b903760d36029141b5adc441ae57ea5caab
2018-02-26 23:09:03 -08:00
Markus Emrich
e02dd0e7ed Add IGListDiffable remodel plugin source + documentation (a new guide)
Summary:
Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`.

- [x] All tests pass. Demo project builds and runs. (source untouched, purely additive)
- [x] I added remodel plugin tests + and a new guide explaining the installation + usage
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/1083

Reviewed By: rnystrom

Differential Revision: D6937925

Pulled By: calimarkus

fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 10:18:18 -08:00