Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-23 09:18:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(385): Fixed a typo previuossectionMap -> previousSectionMap

Browse source 
Summary:
I have fixed the typo in the code `previuossectionMap` -> `previousSectionMap`. I don't think this change requires to be tested as it appears to be an internal class. Because of this it's not a breaking change so I don't think it needs to be reflected in CHANGELOG.md either.

Closes #385

- [X] All tests pass. Demo project builds and runs.
- [X] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/386

Differential Revision: D4390915

Pulled By: rnystrom

fbshipit-source-id: 1b745daaa913361ad211318ea1e216a03fe6f741
This commit is contained in:
Weyert de Boer 2017-01-07 09:34:07 -08:00 committed by Facebook Github Bot
parent 1b55215e60
commit fb4e823870
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Source/IGListAdapter.m
View file

@ -266,12 +266,12 @@
objectTransitionBlock:^(NSArray *toObjects) {
// temporarily capture the item map that we are transitioning from in case
// there are any item deletes at the same
weakSelf.previoussectionMap = [weakSelf.sectionMap copy];
weakSelf.previousSectionMap = [weakSelf.sectionMap copy];
[weakSelf updateObjects:toObjects dataSource:dataSource];
} completion:^(BOOL finished) {
// release the previous items
weakSelf.previoussectionMap = nil;
weakSelf.previousSectionMap = nil;
if (completion) {
completion(finished);
@ -521,8 +521,8 @@
- (IGListSectionMap *)sectionMapAdjustForUpdateBlock:(BOOL)adjustForUpdateBlock {
// if we are inside an update block, we may have to use the /previous/ item map for some operations
if (adjustForUpdateBlock && self.isInUpdateBlock && self.previoussectionMap != nil) {
return self.previoussectionMap;
if (adjustForUpdateBlock && self.isInUpdateBlock && self.previousSectionMap != nil) {
return self.previousSectionMap;
} else {
return self.sectionMap;
}

2
Source/Internal/IGListAdapterInternal.h
View file

@ -52,7 +52,7 @@ IGListCollectionContext
objects or section controllers.
*/
@property (nonatomic, assign) BOOL isInUpdateBlock;
@property (nonatomic, strong, nullable) IGListSectionMap *previoussectionMap;
@property (nonatomic, strong, nullable) IGListSectionMap *previousSectionMap;
@property (nonatomic, strong) NSMutableSet<Class> *registeredCellClasses;
@property (nonatomic, strong) NSMutableSet<NSString *> *registeredNibNames;