Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-22 16:58:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove layout experiment

Browse source 
Summary: Experiment results were neutral. Removing.

Reviewed By: jessesquires

Differential Revision: D4127172

fbshipit-source-id: 1110ea1e0c08ad74f63840465f12be5b6b059c15
This commit is contained in:
Ryan Nystrom 2016-11-03 16:27:18 -07:00 committed by Facebook Github Bot
parent 3e80402296
commit f682dfd45c
2 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Source/IGListAdapterUpdater.m
View file

@ -208,17 +208,6 @@ static NSArray *objectsWithDuplicateIdentifiersRemoved(NSArray<id<IGListDiffable
@try {
[delegate listAdapterUpdater:self willPerformBatchUpdatesWithCollectionView:collectionView];
if (IGListExperimentEnabled(self.experiments, IGListExperimentLayoutBeforeUpdate)) {
/**
There are traces where UICollectionView throws "Invalid update: invalid number of items in section i..." where
logs show that the problem section has a different "before" item count than the assert claims. Our hunch is
that there is some state corruption from too many unanimated updates happening rapidly and layout state
becoming out of sync.
*/
[collectionView layoutIfNeeded];
}
if (animated) {
[collectionView performBatchUpdates:updateBlock completion:completionBlock];
} else {

1
Source/IGListExperiments.h
View file

@ -15,7 +15,6 @@
Bitmask-able options used for prerelease feature testing.
*/
typedef NS_OPTIONS (NSUInteger, IGListExperiment) {
IGListExperimentLayoutBeforeUpdate = 1 << 0,
IGListExperimentUICVReloadedInSetter = 1 << 1,
};