From f55b6d289573b043ff4ffa865bbccd52816e54c6 Mon Sep 17 00:00:00 2001 From: Vasilenko Igor Vladimirovich Date: Wed, 31 Jan 2018 10:50:35 -0800 Subject: [PATCH] Made IGListTransitionDelegate inherited from NSObject Summary: Issue fixed: #1072 Changes don't need new tests. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1075 Differential Revision: D6858886 Pulled By: rnystrom fbshipit-source-id: ec3816cc66aa2f10c21ccc7dea6078adc034e74e --- CHANGELOG.md | 4 +++- Source/IGListTransitionDelegate.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d7212b5f..766c7071 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag - Updated project settings for iOS 11. [Ryan Nystrom](https://github.com/rnystrom) [(#942)](https://github.com/Instagram/IGListKit/pull/942) -- Added support UICollectionElementKindSectionFooter for IGListCollectionViewLayout [(#1017)](https://github.com/Instagram/IGListKit/pull/1017) +- Added support UICollectionElementKindSectionFooter for IGListCollectionViewLayout. [Igor Vasilenko](https://github.com/vasilenkoigor) [(#1017)](https://github.com/Instagram/IGListKit/pull/1017) - Added experiment to make `-[IGListAdapter visibleSectionControllers:]` a bit faster. [Maxime Ollivier](https://github.com/maxoll) [(82a2a2e)](https://github.com/Instagram/IGListKit/commit/82a2a2ee18bb6272744fd14c64c8ff2da3a620a6) @@ -25,6 +25,8 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag - Reordered position of intercepted selector in `IGListAdapterProxy`'s `isInterceptedSelector` method to reduce overall consumption of compare. [zhongwuzw](https://github.com/zhongwu) [(#1055)](https://github.com/Instagram/IGListKit/pull/1055) +- Made IGListTransitionDelegate inherited from NSObject. [Igor Vasilenko](https://github.com/vasilenkoigor) [(#1075)](https://github.com/Instagram/IGListKit/pull/1075) + ### Fixes - Duplicate objects for initial data source setup filtered out. [Mikhail Vashlyaev](https://github.com/yemodin) [(#993](https://github.com/Instagram/IGListKit/pull/993) diff --git a/Source/IGListTransitionDelegate.h b/Source/IGListTransitionDelegate.h index 34394f1d..80dc6f6e 100644 --- a/Source/IGListTransitionDelegate.h +++ b/Source/IGListTransitionDelegate.h @@ -10,7 +10,7 @@ /** Conform to `IGListTransitionDelegate` to provide customized layout information for a collection view. */ -@protocol IGListTransitionDelegate +@protocol IGListTransitionDelegate /** Asks the delegate to customize and return the starting layout information for an item being inserted into the collection view.