From df18195d18f60f4e3b46ed120991a83e9a58dcc7 Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Wed, 21 Mar 2018 19:37:35 -0700 Subject: [PATCH] Add deselect selector to proxy Summary: Issue fixed: #1105 - [x] All tests pass. Demo project builds and runs. - [ ] ~~I added tests, an experiment, or detailed why my change isn't tested.~~ - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Unable to add tests w/out hacking `UITouch` events on a collection view. Open to suggestions. Closes https://github.com/Instagram/IGListKit/pull/1108 Differential Revision: D7362200 Pulled By: rnystrom fbshipit-source-id: fed640c2c017f0ade0cefff0b0d2118564dda3b0 --- CHANGELOG.md | 2 ++ Source/Internal/IGListAdapterProxy.m | 1 + 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 47fcfed9..51b0b083 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag - Fixed footer is sticky when `stickyHeader` is `true` [aelam](https://github.com/aelam) [(#1094)](https://github.com/Instagram/IGListKit/pull/1094) +- `-[IGListSectionController didSelectItemAtIndex:]` is now called when a `scrollViewDelegate` or `collectionViewDelegate` is set. [Ryan Nystrom](https://github.com/rnystrom) [(#1108)](https://github.com/Instagram/IGListKit/pull/1108) + 3.2.0 ----- diff --git a/Source/Internal/IGListAdapterProxy.m b/Source/Internal/IGListAdapterProxy.m index 9fa6abc4..511f1a95 100644 --- a/Source/Internal/IGListAdapterProxy.m +++ b/Source/Internal/IGListAdapterProxy.m @@ -27,6 +27,7 @@ static BOOL isInterceptedSelector(SEL sel) { sel == @selector(collectionView:willDisplayCell:forItemAtIndexPath:) || sel == @selector(collectionView:didEndDisplayingCell:forItemAtIndexPath:) || sel == @selector(collectionView:didSelectItemAtIndexPath:) || + sel == @selector(collectionView:didDeselectItemAtIndexPath:) || sel == @selector(collectionView:didHighlightItemAtIndexPath:) || sel == @selector(collectionView:didUnhighlightItemAtIndexPath:) || // UICollectionViewDelegateFlowLayout