From d7e8ad445944ce12a83e89f1103ec3c4cde73abb Mon Sep 17 00:00:00 2001 From: Jordan Morgan Date: Wed, 30 May 2018 12:32:36 -0700 Subject: [PATCH] Add missing preprocessors value Summary: If you add the IGListDiffable plugin as is and run `./bin/build` on your Remodel install, it'll err out. It's missing the `preprocessor` values so I've added those in for both the required methods. - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1170 Differential Revision: D8204511 Pulled By: rnystrom fbshipit-source-id: 7b03964900c63e1762088e8e47a2a931c9945092 --- remodel-plugin/src/plugins/iglistdiffable.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/remodel-plugin/src/plugins/iglistdiffable.ts b/remodel-plugin/src/plugins/iglistdiffable.ts index 4529f04a..bded4614 100644 --- a/remodel-plugin/src/plugins/iglistdiffable.ts +++ b/remodel-plugin/src/plugins/iglistdiffable.ts @@ -20,6 +20,7 @@ import ObjectSpecCodeUtils = require('../object-spec-code-utils'); function isEqualToDiffableObjectMethod():ObjC.Method { return { + preprocessors:[], belongsToProtocol:Maybe.Just('IGListDiffable'), code: ['return [self isEqual:object];'], comments:[], @@ -147,6 +148,7 @@ function diffIdentifierMethodImplementation(objectType:ObjectSpec.Type):string[] function diffIdentifierMethod(objectType:ObjectSpec.Type):ObjC.Method { return { + preprocessors:[], belongsToProtocol:Maybe.Just('IGListDiffable'), code: diffIdentifierMethodImplementation(objectType), comments:[],