Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-23 09:18:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused experimental feature

Browse source 
Summary: Causes more crashes, removing since this isn't a useful feature.

Reviewed By: maxoll

Differential Revision: D8543859

fbshipit-source-id: 681aeaa23143e119405eefa2c2775180c51a5657
This commit is contained in:
Ryan Nystrom 2018-07-26 09:11:14 -07:00 committed by Facebook Github Bot
parent 985bf48ce0
commit c471d4f7bd
3 changed files with 0 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/Common/IGListExperiments.h
View file

@ -20,8 +20,6 @@ typedef NS_OPTIONS (NSInteger, IGListExperiment) {
IGListExperimentBackgroundDiffing = 1 << 2,
/// Test fallback to reloadData when "too many" update operations.
IGListExperimentReloadDataFallback = 1 << 3,
/// Test deduping item-level updates.
IGListExperimentDedupeItemUpdates = 1 << 5,
/// Test deferring object creation until just before diffing.
IGListExperimentDeferredToObjectCreation = 1 << 6,
/// Test getting collection view at update time.

5
Source/IGListAdapterUpdater.m
View file

@ -334,11 +334,6 @@ void convertReloadToDeleteInsert(NSMutableIndexSet *reloads,
[itemDeletes addObjectsFromArray:[reloadDeletePaths allObjects]];
[itemInserts addObjectsFromArray:[reloadInsertPaths allObjects]];
if (IGListExperimentEnabled(self.experiments, IGListExperimentDedupeItemUpdates)) {
itemDeletes = [[[NSSet setWithArray:itemDeletes] allObjects] mutableCopy];
itemInserts = [[[NSSet setWithArray:itemInserts] allObjects] mutableCopy];
}
IGListBatchUpdateData *updateData = [[IGListBatchUpdateData alloc] initWithInsertSections:inserts
deleteSections:deletes
moveSections:moves

19
Tests/IGListAdapterE2ETests.m
View file

@ -1785,25 +1785,6 @@
[self waitForExpectationsWithTimeout:30 handler:nil];
}
- (void)test_whenInsertingItemTwice_withDedupeExperiment_thatSecondInsertGetsDropped {
((IGListAdapterUpdater*)self.updater).experiments = IGListExperimentDedupeItemUpdates;
IGTestObject *object = genTestObject(@1, @1);
[self setupWithObjects:@[object]];
IGTestDelegateController *controller = [self.adapter sectionControllerForObject:self.dataSource.objects.firstObject];
XCTestExpectation *expectation = genExpectation;
[controller.collectionContext performBatchAnimated:YES updates:^(id<IGListBatchContext> _Nonnull batchContext) {
object.value = @2;
[batchContext insertInSectionController:controller atIndexes:[NSIndexSet indexSetWithIndex:0]];
[batchContext insertInSectionController:controller atIndexes:[NSIndexSet indexSetWithIndex:0]];
} completion:^(BOOL finished) {
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:30 handler:nil];
}
- (void)test_whenModifyingInitialAndFinalAttribute_thatLayoutIsCorrect {
// set up the custom layout
IGListCollectionViewLayout *layout = [[IGListCollectionViewLayout alloc] initWithStickyHeaders:NO topContentInset:0 stretchToEdge:YES];