From bee2178443ffcaff1d9135c4e094f74240433a62 Mon Sep 17 00:00:00 2001
From: Adam Stern <adamstern@fb.com>
Date: Tue, 10 Jul 2018 06:59:42 -0700
Subject: [PATCH] log instead of assert for duplicate object identifiers

Summary: The `IGFailAssert` for duplicate object identifiers causes unit tests to fail in CI / IGListKit because assertions aren't silenced. Changing this to a log for now.

Reviewed By: rnystrom

Differential Revision: D8773452

fbshipit-source-id: 369415fda4ba3eef8fe8684dc792b0a9905a4759
---
 CHANGELOG.md                                      | 2 ++
 Source/Common/Internal/IGListArrayUtilsInternal.h | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fb2e994f..f1f52e96 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,6 +21,8 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag
 
 - Ensuring view models with duplicate diff identifiers are removed when view models are first requested by `IGListBindingSectionController` [Adam Stern](https://github.com/adamastern) (tbd)
 
+- Log instead of assert for duplicate diff identifiers to make code testable. [Adam Stern](https://github.com/adamastern) (tbd)
+
 3.4.0
 -----
 
diff --git a/Source/Common/Internal/IGListArrayUtilsInternal.h b/Source/Common/Internal/IGListArrayUtilsInternal.h
index d6249fc6..2a18fa9c 100644
--- a/Source/Common/Internal/IGListArrayUtilsInternal.h
+++ b/Source/Common/Internal/IGListArrayUtilsInternal.h
@@ -25,7 +25,7 @@ static NSArray *objectsWithDuplicateIdentifiersRemoved(NSArray<id<IGListDiffable
             [identifierMap setObject:object forKey:diffIdentifier];
             [uniqueObjects addObject:object];
         } else {
-            IGFailAssert(@"Duplicate identifier %@ for object %@ with object %@", diffIdentifier, object, previousObject);
+            IGLKLog(@"Duplicate identifier %@ for object %@ with object %@", diffIdentifier, object, previousObject);
         }
     }
     return uniqueObjects;