Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-24 09:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove assert from working range handler (#1418)

Browse source 
Summary:
Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1418

This assert causes crashes on debug builds. While it's known that this algorithm is slow with a large number of items to work through, it doesn't seem to have been an issue for most when working with IGListKit. Removing this assertion to avoid crashes for others.

Reviewed By: bdotdub

Differential Revision: D19251924

fbshipit-source-id: c0e78d3963544b949bed823bdac9b39529ca5f9f
This commit is contained in:
Jeremy Lawrence 2020-01-21 12:49:39 -08:00 committed by Facebook Github Bot
parent fcd452e366
commit a9ecf5d476
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/IGListKit/Internal/IGListWorkingRangeHandler.mm
View file

@ -124,8 +124,6 @@ typedef std::unordered_set<_IGListWorkingRangeHandlerIndexPath, _IGListWorkingRa
workingRangeSectionControllers.insert({sectionController});
}
IGAssert(workingRangeSectionControllers.size() < 1000, @"This algorithm is way too slow with so many objects:%lu", workingRangeSectionControllers.size());
// Tell any new section controllers that they have entered the working range
for (const _IGListWorkingRangeHandlerSectionControllerWrapper &wrapper : workingRangeSectionControllers) {
// Check if the item exists in the old working range item array.