Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-22 16:58:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make IGListGenericSectionController's -didUpdateToObject: properly generic

Browse source 
Summary:
This is currently just `id`, so when you override it, you can't use the local without casting. We should declare it as `ObjectType` so that it gets the specialized type instead.

The implementation just assigns to the generic `_object` property-backing ivar, so no difference in type-safety.

Differential Revision: D23589584

fbshipit-source-id: 3784929f89580fd603fffcf940c7a5b502501bc5
This commit is contained in:
Nate Stedman 2020-09-09 06:06:25 -07:00 committed by Facebook GitHub Bot
parent 8c839d28c7
commit a64f9b809d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/IGListKit/IGListGenericSectionController.h
View file

@ -33,7 +33,7 @@ NS_SWIFT_NAME(ListGenericSectionController)
@note This `IGListSectionController` subclass sets its object in this method, so any overrides **must call super**.
*/
- (void)didUpdateToObject:(id)object NS_REQUIRES_SUPER;
- (void)didUpdateToObject:(ObjectType)object NS_REQUIRES_SUPER;
@end