Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-23 01:08:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add experiment to perform IGListAdapterUpdater background updates on a serial queue.

Browse source 
Summary: This diff adds a new `IGListExperimentBackgroundDiffingSerial` experiment that behaves similarly to `IGListExperimentBackgroundDiffing` but executes changes in a per-`IGListAdapterUpdater` serial queue instead of a global queue. Global queues are concurrent, and concurrent queues by nature don't ensure the execution order of the blocks that are enqueued into them, so there's a chance that the former `IGListExperimentBackgroundDiffing` experiment would lead to changes being applied out of order.

Reviewed By: calimarkus

Differential Revision: D13567403

fbshipit-source-id: a2aebb20e5e7dc22601fad3c2dfc80112747c81b
This commit is contained in:
Tim Johnsen 2019-01-03 09:24:23 -08:00 committed by Facebook Github Bot
parent 4387a488e8
commit a09242e279
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/Common/IGListExperiments.h
View file

@ -26,6 +26,8 @@ typedef NS_OPTIONS (NSInteger, IGListExperiment) {
IGListExperimentGetCollectionViewAtUpdate = 1 << 7,
/// Test skipping layout when UICollectionView isn't visible
IGListExperimentSkipLayout = 1 << 8,
/// Test updater diffing performed on a serial background queue.
IGListExperimentBackgroundDiffingSerial = 1 << 9,
};
/**

12
Source/IGListAdapterUpdater.m
View file

@ -267,9 +267,17 @@ willPerformBatchUpdatesWithCollectionView:collectionView
}
};
// temporary test to try out background diffing
dispatch_queue_t asyncQueue = nil;
if (IGListExperimentEnabled(experiments, IGListExperimentBackgroundDiffing)) {
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
asyncQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
} else if (IGListExperimentEnabled(experiments, IGListExperimentBackgroundDiffingSerial)) {
if (_backgroundUpdateQueue == nil) {
_backgroundUpdateQueue = dispatch_queue_create("io.github.instagram.IGListKit.backgroundupdatequeue", DISPATCH_QUEUE_SERIAL);
}
asyncQueue = _backgroundUpdateQueue;
}
if (asyncQueue) {
dispatch_async(asyncQueue, ^{
IGListIndexSetResult *result = performDiff();
dispatch_async(dispatch_get_main_queue(), ^{
performUpdate(result);

2
Source/Internal/IGListAdapterUpdaterInternal.h
View file

@ -41,6 +41,8 @@ FOUNDATION_EXTERN void convertReloadToDeleteInsert(NSMutableIndexSet *reloads,
@property (nonatomic, assign) IGListBatchUpdateState state;
@property (nonatomic, strong, nullable) IGListBatchUpdateData *applyingUpdateData;
@property (nonatomic, strong) dispatch_queue_t backgroundUpdateQueue;
- (void)performReloadDataWithCollectionViewBlock:(IGListCollectionViewBlock)collectionViewBlock;
- (void)performBatchUpdatesWithCollectionViewBlock:(IGListCollectionViewBlock)collectionViewBlock;
- (void)cleanStateBeforeUpdates;