Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-23 17:28:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove the unnecessary assert which would affect IGListKit perf

Browse source 
Summary:
This assert was hoping to find if there are any duplicates from the `fromObjects`. However, from the finding, we did not see any assertion or trace that this is the case.

The `objectsWithDuplicateIdentifiersRemoved` is actually doing extra work during updates.

We should remove this for the sake of better scroll perf and faster UI update.

Reviewed By: calimarkus

Differential Revision: D14339124

fbshipit-source-id: ff40fd23a05640058673d46f63a9e4bf516dd3f6
This commit is contained in:
Zhisheng Huang 2019-03-06 13:02:01 -08:00 committed by Facebook Github Bot
parent 3f5047dd9a
commit 9e59bdea11
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/IGListAdapterUpdater.m
View file

@ -131,8 +131,6 @@
executeCompletionBlocks(NO);
return;
}
IGAssert(objectsWithDuplicateIdentifiersRemoved(fromObjects).count == fromObjects.count, @"The fromObjects has duplicate identifiers (it should already be dedupepd at this point).");
NSArray *toObjects = nil;
if (toObjectsBlock != nil) {