Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-24 09:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix IGListSectionController shouldSelectItemAtIndex:

Browse source 
Summary:
While attempting to use `-[IGListSectionController shouldSelectItemAtIndex:`, I found that any implementations of those methods never actually get called.

It turned out that although the methods were added to the section controller (e.g. https://fb.workplace.com/groups/iglistkit/posts/1641463486199290/) and collection view delegate (https://www.internalfb.com/code/fbsource/[766baa5c9ffca558c9a7c5d1fdecc61ce8601e1d]/fbobjc/VendorLib/IGListKit/src/Source/IGListKit/Internal/IGListAdapter%2BUICollectionView.m?lines=125), the selectors weren't actually getting intercepted by the proxy.

Docs: https://instagram.github.io/IGListKit/Classes/IGListSectionController.html#/c:objc(cs)IGListSectionController(im)shouldSelectItemAtIndex:

Reviewed By: candance

Differential Revision: D39910477

fbshipit-source-id: a2b0c56d0e6954baad26e87c2502c7e1dd79e96e
This commit is contained in:
Jonathan Kim 2022-09-29 11:56:11 -07:00 committed by Facebook GitHub Bot
parent cf7f78e28a
commit 82f59a8760
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/IGListKit/Internal/IGListAdapterProxy.m
View file

@ -29,7 +29,9 @@ static BOOL isInterceptedSelector(SEL sel) {
// UICollectionViewDelegate
sel == @selector(collectionView:willDisplayCell:forItemAtIndexPath:) ||
sel == @selector(collectionView:didEndDisplayingCell:forItemAtIndexPath:) ||
sel == @selector(collectionView:shouldSelectItemAtIndexPath:) ||
sel == @selector(collectionView:didSelectItemAtIndexPath:) ||
sel == @selector(collectionView:shouldDeselectItemAtIndexPath:) ||
sel == @selector(collectionView:didDeselectItemAtIndexPath:) ||
sel == @selector(collectionView:didHighlightItemAtIndexPath:) ||
sel == @selector(collectionView:didUnhighlightItemAtIndexPath:) ||