From 595c09e5ec9af00a2fbbb8d33762d3b9725c9ebe Mon Sep 17 00:00:00 2001 From: Kim de Vo Date: Thu, 21 Sep 2017 07:13:11 -0700 Subject: [PATCH] Removed empty methods Summary: Issue fixed: # - [x] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/945 Differential Revision: D5881110 Pulled By: rnystrom fbshipit-source-id: 7f20fcaac04f64576a52ca68af87d3db64f199b9 --- .../SectionControllers/MonthSectionController.swift | 2 -- .../SectionControllers/CarouselSectionController.swift | 2 -- .../SectionControllers/HorizontalSectionController.swift | 2 -- .../SectionControllers/LabelSectionController.swift | 2 -- 4 files changed, 8 deletions(-) diff --git a/Examples/Examples-iOS/IGListKitExamples/SectionControllers/MonthSectionController.swift b/Examples/Examples-iOS/IGListKitExamples/SectionControllers/MonthSectionController.swift index 54fb05fa..e1db4a61 100644 --- a/Examples/Examples-iOS/IGListKitExamples/SectionControllers/MonthSectionController.swift +++ b/Examples/Examples-iOS/IGListKitExamples/SectionControllers/MonthSectionController.swift @@ -95,6 +95,4 @@ final class MonthSectionController: ListBindingSectionController, update(animated: true) } - func sectionController(_ sectionController: ListBindingSectionController, didDeselectItemAt index: Int, viewModel: Any) {} - } diff --git a/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/CarouselSectionController.swift b/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/CarouselSectionController.swift index c6c1f336..b77c7913 100644 --- a/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/CarouselSectionController.swift +++ b/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/CarouselSectionController.swift @@ -52,6 +52,4 @@ final class CarouselSectionController: ListSectionController { number = object as? Int } - override func didSelectItem(at index: Int) {} - } diff --git a/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/HorizontalSectionController.swift b/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/HorizontalSectionController.swift index 18a52ade..40166922 100644 --- a/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/HorizontalSectionController.swift +++ b/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/HorizontalSectionController.swift @@ -53,8 +53,6 @@ final class HorizontalSectionController: ListSectionController, ListAdapterDataS number = object as? Int } - override func didSelectItem(at index: Int) {} - // MARK: ListAdapterDataSource func objects(for listAdapter: ListAdapter) -> [ListDiffable] { diff --git a/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/LabelSectionController.swift b/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/LabelSectionController.swift index cd54a288..5893930c 100644 --- a/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/LabelSectionController.swift +++ b/Examples/Examples-tvOS/IGListKitExamples/SectionControllers/LabelSectionController.swift @@ -39,6 +39,4 @@ final class LabelSectionController: ListSectionController { self.object = String(describing: object) } - override func didSelectItem(at index: Int) {} - }