Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-23 09:18:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

clean up IGListExperimentBackgroundDiffingSerial

Browse source 
Summary: * Cleaning up experiment

Reviewed By: lorixx

Differential Revision: D15134137

fbshipit-source-id: a3f5a6d7b4a5f3897608c4e32ad4c4e6e4e720e5
This commit is contained in:
Maxime Ollivier 2019-04-30 10:44:00 -07:00 committed by Facebook Github Bot
parent 4662454c4a
commit 4f9c61a37f
3 changed files with 1 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/Common/IGListExperiments.h
View file

@ -26,8 +26,6 @@ typedef NS_OPTIONS (NSInteger, IGListExperiment) {
IGListExperimentGetCollectionViewAtUpdate = 1 << 7,
/// Test skipping layout when UICollectionView isn't visible
IGListExperimentSkipLayout = 1 << 8,
/// Test updater diffing performed on a serial background queue.
IGListExperimentBackgroundDiffingSerial = 1 << 9,
};
/**

11
Source/IGListAdapterUpdater.m
View file

@ -265,17 +265,8 @@ willPerformBatchUpdatesWithCollectionView:collectionView
}
};
dispatch_queue_t asyncQueue = nil;
if (IGListExperimentEnabled(experiments, IGListExperimentBackgroundDiffing)) {
asyncQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
} else if (IGListExperimentEnabled(experiments, IGListExperimentBackgroundDiffingSerial)) {
if (_backgroundUpdateQueue == nil) {
_backgroundUpdateQueue = dispatch_queue_create("io.github.instagram.IGListKit.backgroundupdatequeue", DISPATCH_QUEUE_SERIAL);
}
asyncQueue = _backgroundUpdateQueue;
}
if (asyncQueue) {
dispatch_async(asyncQueue, ^{
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
IGListIndexSetResult *result = performDiff();
dispatch_async(dispatch_get_main_queue(), ^{
performUpdate(result);

2
Source/Internal/IGListAdapterUpdaterInternal.h
View file

@ -41,8 +41,6 @@ FOUNDATION_EXTERN void convertReloadToDeleteInsert(NSMutableIndexSet *reloads,
@property (nonatomic, assign) IGListBatchUpdateState state;
@property (nonatomic, strong, nullable) IGListBatchUpdateData *applyingUpdateData;
@property (nonatomic, strong) dispatch_queue_t backgroundUpdateQueue;
- (void)performReloadDataWithCollectionViewBlock:(IGListCollectionViewBlock)collectionViewBlock;
- (void)performBatchUpdatesWithCollectionViewBlock:(IGListCollectionViewBlock)collectionViewBlock;
- (void)cleanStateBeforeUpdates;