From 49f1d3e653c0dfe6377f2832bbd5f198c2429c56 Mon Sep 17 00:00:00 2001 From: Daniel Alamo Date: Thu, 25 May 2017 08:05:26 -0700 Subject: [PATCH] Remove ", which will be super fast" from FAQ.md Summary: Issue fixed: #763 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/794 Differential Revision: D5129406 Pulled By: rnystrom fbshipit-source-id: dcca533130e99d5960781c5c3336a6fdbd399505 --- Guides/Best Practices and FAQ.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Guides/Best Practices and FAQ.md b/Guides/Best Practices and FAQ.md index 015c0d79..1ec81b81 100644 --- a/Guides/Best Practices and FAQ.md +++ b/Guides/Best Practices and FAQ.md @@ -72,7 +72,7 @@ See discussion at [#184](https://github.com/Instagram/IGListKit/issues/184). #### I have a *huge* data set and [`-performUpdatesAnimated: completion:`](https://instagram.github.io/IGListKit/Classes/IGListAdapter.html#/c:objc(cs)IGListAdapter(im)performUpdatesAnimated:completion:) is *super* slow. What do I do? -If you have multiple thousands of items and you cannot batch them in, you'll see performance issues with `-performUpdatesAnimated: completion:`. The real bottle neck behind the scenes here is `UICollectionView` attempting to insert so many cells at once. Instead, call [`-reloadDataWithCompletion:`](https://instagram.github.io/IGListKit/Classes/IGListAdapter.html#/c:objc(cs)IGListAdapter(im)reloadDataWithCompletion:) when you first load data, which will be super fast. Behind the scenes, this method *does not* do any diffing and simply calls `-reloadData` on `UICollectionView`. For subsequent updates, you can then use `-performUpdatesAnimated: completion:`. +If you have multiple thousands of items and you cannot batch them in, you'll see performance issues with `-performUpdatesAnimated: completion:`. The real bottle neck behind the scenes here is `UICollectionView` attempting to insert so many cells at once. Instead, call [`-reloadDataWithCompletion:`](https://instagram.github.io/IGListKit/Classes/IGListAdapter.html#/c:objc(cs)IGListAdapter(im)reloadDataWithCompletion:) when you first load data. Behind the scenes, this method *does not* do any diffing and simply calls `-reloadData` on `UICollectionView`. For subsequent updates, you can then use `-performUpdatesAnimated: completion:`. #### How do I use IGListKit and estimated cell sizes with Auto Layout?