From 2d5eed24777a7c1ecf31133ccd98d56a7dedf81a Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Tue, 21 Nov 2017 13:06:13 -0800 Subject: [PATCH] Add docs warning about reloadData being expensive Summary: Followup from performance findings. Reviewed By: maxoll Differential Revision: D6388330 fbshipit-source-id: 057d5f49b5b8fd7216b795fef3977beba9368b3a --- Source/IGListAdapter.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Source/IGListAdapter.h b/Source/IGListAdapter.h index d99c5e96..bcd80b4c 100644 --- a/Source/IGListAdapter.h +++ b/Source/IGListAdapter.h @@ -131,6 +131,9 @@ NS_SWIFT_NAME(ListAdapter) Perform an immediate reload of the data in the data source, discarding the old objects. @param completion The block to execute when the reload completes. + + @warning Do not use this method to update without animations as it can be very expensive to teardown and rebuild all + section controllers. Use `-[IGListAdapter performUpdatesAnimated:completion]` instead. */ - (void)reloadDataWithCompletion:(nullable IGListUpdaterCompletion)completion;