Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-04 05:58:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
IGListKit/Examples/Examples-iOS/IGListKitExamples.xcodeproj/project.pbxproj

1411 lines
89 KiB
Text
Raw Normal View History

Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
// !$*UTF8*$!
{
archiveVersion = 1;
classes = {
};
Update SwiftLint and make it an optional dependency Summary: Fixes one final friction point for the IGListKit sample apps: SwiftLint. At the moment, building the sample apps will hard fail if SwiftLint isn't presently installed. This is generally a good thing when adding new code to the sample apps, but for developers who might want to simply run the sample apps to try out IGListKit, this potentially adds additional unneeded friction. Since SwiftLint also runs on each incoming PR on GitHub Actions now, even if a third party contributor submits code that they didn't lint themselves, it will still be verified by the CI. This diff: * Updates `lint.sh` to check for the latest version of SwiftLint. * Makes the message that appears if SwiftLint isn't present a warning, instead of an error. * Adds the linting script to building the `IGListSwiftKit` framework targets as well. Differential Revision: D43864872 fbshipit-source-id: f5cc18f3612795ad1cc15cc4b7c0dfd7102639c6
2023-03-13 07:49:15 +00:00
objectVersion = 54;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
objects = {
/* Begin PBXBuildFile section */
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01681F9D9CBD0092A320 /* ReorderableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 13DF01671F9D9CBD0092A320 /* ReorderableSectionController.swift */; };
13DF016A1F9D9F600092A320 /* ReorderableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 13DF01691F9D9F600092A320 /* ReorderableViewController.swift */; };
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8E1DAE9D3F0073E116 /* SingleSectionViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 26271C8D1DAE9D3F0073E116 /* SingleSectionViewController.swift */; };
26271C921DAE9EFC0073E116 /* NibCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 26271C911DAE9EFC0073E116 /* NibCell.xib */; };
26271C941DAE9F050073E116 /* NibCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 26271C931DAE9F050073E116 /* NibCell.swift */; };
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658571E749EDC0041B56D /* CalendarViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 292658561E749EDC0041B56D /* CalendarViewController.swift */; };
292658591E749F820041B56D /* Month.swift in Sources */ = {isa = PBXBuildFile; fileRef = 292658581E749F820041B56D /* Month.swift */; };
292658601E74A19F0041B56D /* DayViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2926585F1E74A19F0041B56D /* DayViewModel.swift */; };
292658641E74A2550041B56D /* MonthSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 292658631E74A2550041B56D /* MonthSectionController.swift */; };
292658661E74A49D0041B56D /* CalendarDayCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 292658651E74A49D0041B56D /* CalendarDayCell.swift */; };
292658681E74AE8A0041B56D /* MonthTitleViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 292658671E74AE8A0041B56D /* MonthTitleViewModel.swift */; };
2926586A1E74AEFE0041B56D /* MonthTitleCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 292658691E74AEFE0041B56D /* MonthTitleCell.swift */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF8C1D9F39E00015D24B /* DemoSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF831D9F39E00015D24B /* DemoSectionController.swift */; };
2942FF8D1D9F39E00015D24B /* EmbeddedSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF841D9F39E00015D24B /* EmbeddedSectionController.swift */; };
2942FF8E1D9F39E00015D24B /* ExpandableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF851D9F39E00015D24B /* ExpandableSectionController.swift */; };
2942FF8F1D9F39E00015D24B /* GridSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF861D9F39E00015D24B /* GridSectionController.swift */; };
2942FF901D9F39E00015D24B /* HorizontalSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF871D9F39E00015D24B /* HorizontalSectionController.swift */; };
2942FF911D9F39E00015D24B /* LabelSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF881D9F39E00015D24B /* LabelSectionController.swift */; };
2942FF921D9F39E00015D24B /* RemoveSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF891D9F39E00015D24B /* RemoveSectionController.swift */; };
2942FF931D9F39E00015D24B /* SearchSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF8A1D9F39E00015D24B /* SearchSectionController.swift */; };
2942FF941D9F39E00015D24B /* UserSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF8B1D9F39E00015D24B /* UserSectionController.swift */; };
Add diffing example Summary: Adding an example of how to use diffing by itself w/ `UITableView` batch updates. Reviewed By: jessesquires Differential Revision: D4077768 fbshipit-source-id: 313193cdcadd337e08f74e90713fa127a5365112
2016-10-26 18:47:10 +00:00
29459C001DBE48E200F05375 /* DiffTableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29459BFF1DBE48E200F05375 /* DiffTableViewController.swift */; };
Improve the ObjC demo to reflect best-practices Summary: Couple best practices I want to make sure our examples reflect: - Multiple cells in a section controller - Unique models returned in `objectsForListAdapter:` (no dupes!) - Dynamic item count (`comments` array) Issue fixed: #595 - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/615 Differential Revision: D4852192 Pulled By: jessesquires fbshipit-source-id: f4a89800f90e6b5ea4b6dd7c0d9a78ca5d65082c
2017-04-07 18:20:37 +00:00
295D8A9A1E92EC96001F7C06 /* PostSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 295D8A991E92EC96001F7C06 /* PostSectionController.m */; };
295D8A9D1E92ECDE001F7C06 /* Post.m in Sources */ = {isa = PBXBuildFile; fileRef = 295D8A9C1E92ECDE001F7C06 /* Post.m */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B38E1D68B031001C9451 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B38D1D68B031001C9451 /* AppDelegate.swift */; };
2961B3951D68B031001C9451 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 2961B3941D68B031001C9451 /* Assets.xcassets */; };
2961B3981D68B031001C9451 /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 2961B3961D68B031001C9451 /* LaunchScreen.storyboard */; };
2961B3AB1D68B0B5001C9451 /* DemosViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B3A41D68B0B5001C9451 /* DemosViewController.swift */; };
2961B3AC1D68B0B5001C9451 /* LoadMoreViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B3A51D68B0B5001C9451 /* LoadMoreViewController.swift */; };
2961B3AD1D68B0B5001C9451 /* LabelCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B3A71D68B0B5001C9451 /* LabelCell.swift */; };
2961B3AE1D68B0B5001C9451 /* SpinnerCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B3A81D68B0B5001C9451 /* SpinnerCell.swift */; };
2961B3B01D68B28E001C9451 /* SearchCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B3AF1D68B28E001C9451 /* SearchCell.swift */; };
29628F141D91905A0026B15A /* DetailLabelCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29628F131D91905A0026B15A /* DetailLabelCell.swift */; };
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7531DD2147500206780 /* SelfSizingCellsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 296DD7521DD2147500206780 /* SelfSizingCellsViewController.swift */; };
296DD7551DD2150600206780 /* SelfSizingSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 296DD7541DD2150600206780 /* SelfSizingSectionController.swift */; };
296DD7571DD2163800206780 /* ManuallySelfSizingCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 296DD7561DD2163800206780 /* ManuallySelfSizingCell.swift */; };
296DD7591DD2174200206780 /* NibSelfSizingCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 296DD7581DD2174200206780 /* NibSelfSizingCell.swift */; };
296DD75B1DD217C000206780 /* NibSelfSizingCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 296DD75A1DD217C000206780 /* NibSelfSizingCell.xib */; };
296DD75D1DD21ADA00206780 /* SelectionModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 296DD75C1DD21ADA00206780 /* SelectionModel.swift */; };
297546FA1DD25384002A6F89 /* FullWidthSelfSizingCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 297546F91DD25384002A6F89 /* FullWidthSelfSizingCell.swift */; };
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
2981BA351DB868A500A987F9 /* ImageCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2981BA341DB868A500A987F9 /* ImageCell.swift */; };
2981BA371DB869FF00A987F9 /* WorkingRangeSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2981BA361DB869FF00A987F9 /* WorkingRangeSectionController.swift */; };
2981BA391DB874BB00A987F9 /* WorkingRangeViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2981BA381DB874BB00A987F9 /* WorkingRangeViewController.swift */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
299068281D75BFEC00A62888 /* MixedDataViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 299068271D75BFEC00A62888 /* MixedDataViewController.swift */; };
2991F9191D7BADC900B0C58F /* CenterLabelCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2991F9181D7BADC900B0C58F /* CenterLabelCell.swift */; };
2991F91E1D7BB30C00B0C58F /* User.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2991F91D1D7BB30C00B0C58F /* User.swift */; };
2991F9241D7BB89F00B0C58F /* NestedAdapterViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2991F9231D7BB89F00B0C58F /* NestedAdapterViewController.swift */; };
2991F9281D7BB9EC00B0C58F /* EmbeddedCollectionViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2991F9271D7BB9EC00B0C58F /* EmbeddedCollectionViewCell.swift */; };
2991F92C1D7BBE5400B0C58F /* RemoveCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2991F92B1D7BBE5400B0C58F /* RemoveCell.swift */; };
2991F9301D7BC0E400B0C58F /* EmptyViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2991F92F1D7BC0E400B0C58F /* EmptyViewController.swift */; };
299B54001D6BD6630074A202 /* SearchViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 299B53FF1D6BD6630074A202 /* SearchViewController.swift */; };
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297B1DCFD857004A5BB1 /* SupplementaryViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29C6297A1DCFD857004A5BB1 /* SupplementaryViewController.swift */; };
29C6297D1DCFD8E5004A5BB1 /* FeedItem.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29C6297C1DCFD8E5004A5BB1 /* FeedItem.swift */; };
29C6297F1DCFD9E9004A5BB1 /* FeedItemSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29C6297E1DCFD9E9004A5BB1 /* FeedItemSectionController.swift */; };
29C629811DCFDAF3004A5BB1 /* UserHeaderView.xib in Resources */ = {isa = PBXBuildFile; fileRef = 29C629801DCFDAF3004A5BB1 /* UserHeaderView.xib */; };
29C629831DCFDB57004A5BB1 /* UserHeaderView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29C629821DCFDB57004A5BB1 /* UserHeaderView.swift */; };
Add display delegate example Summary: Adds a new example. Fixes #159 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/194 Differential Revision: D4172780 Pulled By: rnystrom fbshipit-source-id: 34e1eaef03bb6564445f30dc2fe2b015bb276b6a
2016-11-12 17:18:29 +00:00
29D2E4AD1DD69B6000CD255D /* DisplaySectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29D2E4AC1DD69B6000CD255D /* DisplaySectionController.swift */; };
29D2E4AF1DD69C0E00CD255D /* DisplayViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29D2E4AE1DD69C0E00CD255D /* DisplayViewController.swift */; };
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2AA1E9283FF00197586 /* AnnouncingDepsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29F7E2A91E9283FF00197586 /* AnnouncingDepsViewController.swift */; };
29F7E2AD1E92843A00197586 /* IncrementAnnouncer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29F7E2AC1E92843A00197586 /* IncrementAnnouncer.swift */; };
29F7E2AF1E92858500197586 /* ListeningSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 29F7E2AE1E92858500197586 /* ListeningSectionController.swift */; };
Example using SwiftUI with compositional layout Summary: Introduces a compositional layout example that leverages section controller methods to determine layout. Differential Revision: D71402637 fbshipit-source-id: 1179abf13157fb5cb78c8a9086718d1216fb4276
2025-03-19 17:14:23 +00:00
4119B2AB2D89BB1E00D397BC /* ActivityItem.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4119B2AA2D89BB1200D397BC /* ActivityItem.swift */; };
4119B2AD2D89BBF000D397BC /* ActivityComposableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4119B2AC2D89BBE200D397BC /* ActivityComposableSectionController.swift */; };
41A162952D8A0C82002A5A8F /* SelectionComposableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 41A162942D8A0C7A002A5A8F /* SelectionComposableSectionController.swift */; };
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B691E49B2120026DB39 /* ObjcDemoViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 56C05B681E49B2120026DB39 /* ObjcDemoViewController.m */; };
56C05B6C1E49B2E80026DB39 /* UserInfoCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 56C05B6B1E49B2E80026DB39 /* UserInfoCell.m */; };
56C05B721E49B32A0026DB39 /* CommentCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 56C05B711E49B32A0026DB39 /* CommentCell.m */; };
56C05B751E49B33C0026DB39 /* InteractiveCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 56C05B741E49B33C0026DB39 /* InteractiveCell.m */; };
56C05B781E49B3A50026DB39 /* PhotoCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 56C05B771E49B3A50026DB39 /* PhotoCell.m */; };
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D20072B2CB50E0012C5B8 /* CompositionLayoutViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D20062B2CB50E0012C5B8 /* CompositionLayoutViewController.swift */; };
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D20092B2CB6C20012C5B8 /* SwipeActionComposabelSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D20082B2CB6C20012C5B8 /* SwipeActionComposabelSectionController.swift */; };
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200B2B2CC6DF0012C5B8 /* CompositionLayoutCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D200A2B2CC6DF0012C5B8 /* CompositionLayoutCell.swift */; };
576D200E2B2CE9EC0012C5B8 /* ExpandableComposableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D200D2B2CE9EC0012C5B8 /* ExpandableComposableSectionController.swift */; };
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D20102B2CEC4E0012C5B8 /* GridComposableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D200F2B2CEC4E0012C5B8 /* GridComposableSectionController.swift */; };
add user to UICollectionViewCompositionalLayout example Summary: Adding user cell Differential Revision: D52260532 fbshipit-source-id: ec3f4f5a70d02e0c6db713ade51938413cb5ee8a
2023-12-19 15:17:30 +00:00
576D20122B2CF04F0012C5B8 /* UserComposableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D20112B2CF04F0012C5B8 /* UserComposableSectionController.swift */; };
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D20142B2CF15C0012C5B8 /* GridItem.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D20132B2CF15C0012C5B8 /* GridItem.swift */; };
add horizontal row to UICollectionViewCompositionalLayout example Summary: Lets go even beyond the `MixedDataViewController` example by taking advantage of `orthogonalScrollingBehavior`. Really neat! Differential Revision: D52260531 fbshipit-source-id: aee8b38a38284104fa65ba8d33426a9e6216e503
2023-12-19 15:17:30 +00:00
576D20162B2CF1A50012C5B8 /* HorizontalCardsSection.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D20152B2CF1A50012C5B8 /* HorizontalCardsSection.swift */; };
576D20182B2CF24F0012C5B8 /* HorizontalComposableSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D20172B2CF24F0012C5B8 /* HorizontalComposableSectionController.swift */; };
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D201A2B2CF82C0012C5B8 /* SwipeActionSection.swift in Sources */ = {isa = PBXBuildFile; fileRef = 576D20192B2CF82C0012C5B8 /* SwipeActionSection.swift */; };
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4B61DB8B3DC00172ED0 /* StoryboardViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4B51DB8B3DC00172ED0 /* StoryboardViewController.swift */; };
821BC4B81DB8B48300172ED0 /* StoryboardCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4B71DB8B48300172ED0 /* StoryboardCell.swift */; };
821BC4BA1DB8B61200172ED0 /* StoryboardLabelSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4B91DB8B61200172ED0 /* StoryboardLabelSectionController.swift */; };
82D91B691DBA0EF300E62758 /* SingleSectionStoryboardViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 82D91B681DBA0EF300E62758 /* SingleSectionStoryboardViewController.swift */; };
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
9518E3C31DED03520008CC46 /* UITestCase.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9518E3C21DED03510008CC46 /* UITestCase.swift */; };
9518E3C51DED057E0008CC46 /* LoadMoreViewControllerUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9518E3C41DED057E0008CC46 /* LoadMoreViewControllerUITests.swift */; };
9518E3C71DED18370008CC46 /* SearchViewControllerUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9518E3C61DED18370008CC46 /* SearchViewControllerUITests.swift */; };
9518E3C91DED1BCB0008CC46 /* MixedDataViewControllerUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9518E3C81DED1BCB0008CC46 /* MixedDataViewControllerUITests.swift */; };
9518E3CB1DED27840008CC46 /* DemosViewControllerUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9518E3CA1DED27840008CC46 /* DemosViewControllerUITests.swift */; };
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7131DBBA60900A65C18 /* Messages.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 986FB7121DBBA60900A65C18 /* Messages.framework */; };
986FB7161DBBA60900A65C18 /* MessagesViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 986FB7151DBBA60900A65C18 /* MessagesViewController.swift */; };
986FB71B1DBBA60900A65C18 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 986FB71A1DBBA60900A65C18 /* Assets.xcassets */; };
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
986FB71F1DBBA60900A65C18 /* IGListKitMessageExample.appex in Embed Foundation Extensions */ = {isa = PBXBuildFile; fileRef = 986FB7111DBBA60900A65C18 /* IGListKitMessageExample.appex */; platformFilter = ios; settings = {ATTRIBUTES = (RemoveHeadersOnCopy, ); }; };
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7281DBBA9B200A65C18 /* LabelSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF881D9F39E00015D24B /* LabelSectionController.swift */; };
986FB7291DBBA9C900A65C18 /* LabelCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B3A71D68B0B5001C9451 /* LabelCell.swift */; };
986FB7311DBBAD8600A65C18 /* NotificationCenter.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 986FB7301DBBAD8600A65C18 /* NotificationCenter.framework */; };
986FB7341DBBAD8600A65C18 /* TodayViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 986FB7331DBBAD8600A65C18 /* TodayViewController.swift */; };
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
986FB73B1DBBAD8600A65C18 /* IGListKitTodayExample.appex in Embed Foundation Extensions */ = {isa = PBXBuildFile; fileRef = 986FB72F1DBBAD8600A65C18 /* IGListKitTodayExample.appex */; platformFilter = ios; settings = {ATTRIBUTES = (RemoveHeadersOnCopy, ); }; };
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7401DBBAEA600A65C18 /* LabelSectionController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2942FF881D9F39E00015D24B /* LabelSectionController.swift */; };
986FB7411DBBAEA900A65C18 /* LabelCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2961B3A71D68B0B5001C9451 /* LabelCell.swift */; };
98B4DBF41DC2937A002BA58A /* Demo.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 98B4DBF31DC2937A002BA58A /* Demo.storyboard */; };
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DB684E1251B10C2002023DD /* UIColor+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9DB684E0251B10C2002023DD /* UIColor+Extension.swift */; };
9DFF4CFB251F089E0048474A /* UIColor+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9DB684E0251B10C2002023DD /* UIColor+Extension.swift */; };
9DFF4D00251F089F0048474A /* UIColor+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9DB684E0251B10C2002023DD /* UIColor+Extension.swift */; };
9DFF4D06251F08F50048474A /* UIActivityIndicatorView+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9DFF4D05251F08F50048474A /* UIActivityIndicatorView+Extension.swift */; };
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB336E42760ECC1007B4098 /* IGListDiffKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336E32760ECC1007B4098 /* IGListDiffKit */; };
BAB336E62760ECC1007B4098 /* IGListKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336E52760ECC1007B4098 /* IGListKit */; };
BAB336E82760ECC1007B4098 /* IGListSwiftKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336E72760ECC1007B4098 /* IGListSwiftKit */; };
BAB336EA2760ECE5007B4098 /* IGListKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336E92760ECE5007B4098 /* IGListKit */; };
BAB336EC2760ECFE007B4098 /* IGListKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336EB2760ECFE007B4098 /* IGListKit */; };
BAB336EE2760ED0C007B4098 /* IGListSwiftKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336ED2760ED0C007B4098 /* IGListSwiftKit */; };
BAB336F02760ED28007B4098 /* IGListDiffKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336EF2760ED28007B4098 /* IGListDiffKit */; };
BAB336F22760ED55007B4098 /* IGListDiffKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336F12760ED55007B4098 /* IGListDiffKit */; };
BAB336F42760EDCB007B4098 /* IGListSwiftKit in Frameworks */ = {isa = PBXBuildFile; productRef = BAB336F32760EDCB007B4098 /* IGListSwiftKit */; };
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289A2202A11E0007E17D5 /* PersonModel.m in Sources */ = {isa = PBXBuildFile; fileRef = EB02899F202A11DF007E17D5 /* PersonModel.m */; };
EB0289A3202A11E0007E17D5 /* PersonModel.value in Resources */ = {isa = PBXBuildFile; fileRef = EB0289A0202A11DF007E17D5 /* PersonModel.value */; };
EB0289A6202A14E1007E17D5 /* ObjcGeneratedModelDemoViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = EB0289A5202A14E1007E17D5 /* ObjcGeneratedModelDemoViewController.m */; };
EB0289A9202A1507007E17D5 /* PersonSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = EB0289A8202A1507007E17D5 /* PersonSectionController.m */; };
EB0289AC202A1705007E17D5 /* PersonCell.m in Sources */ = {isa = PBXBuildFile; fileRef = EB0289AA202A1705007E17D5 /* PersonCell.m */; };
Fix travis & upgrade cocoapods (#1317) Summary: This is a bigger PR than I'd like but there is a bunch of stuff in here that feels like we should land all at once to fix the Travis setup. Currently, there is a few things wrong. Briefly: 1. Travis is failing to even build the library (see: [build 2298](https://travis-ci.org/Instagram/IGListKit/jobs/506564900)) 2. There are legitimately failing tests 3. Travis seems to be flakey running UI tests This PR deals with the first two. The Xcode projects were not building because some recently added files weren't added to the xcodeproj (ie. 46a124ddfe9bd043f3121b69ab4afb35cb8b796c and 4662454c4aedbc5d3bed0cb386f2ef93de40ba51). Also added `Foundation.h` import for `bool` definition for `IGSystemVersion` (also a new file) The main `Podfile.lock` was already being generated via `1.5.3` (0c0b31ad7c40471c4115fb90a59c357a910a4a75) but the `Gemfile` had the wrong version and none of the example project `Podfile.lock`s were re-generated with it. Once I got the projects correctly building and tests running, I discovered there were a bunch of tests that were legitimately failing. It's unclear when these started failing and what caused it. I thought it made sense to disable these tests for now and then create Github issues to fix them as starter tasks instead of making this diff even larger.. I can create those if that sounds good. Somewhat related, it seems like the UI tests on Travis may be a bit flakey. They pass locally, but breaks on Travis [[example](https://travis-ci.com/bdotdub/IGListKit/jobs/195758250)] with error messages like `Failure requesting automation session for com.instagram.IGListKitExamples:85190` ---- - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [X] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1317 Reviewed By: rnystrom Differential Revision: D15157375 Pulled By: rnystrom fbshipit-source-id: b29131f59b74398b6d2b3a73453248cb3325a955
2019-05-01 22:10:31 +00:00
FF73FF9C1FBA4B4400F2AB06 /* UserFooterView.swift in Sources */ = {isa = PBXBuildFile; fileRef = FF73FF9B1FBA4B4400F2AB06 /* UserFooterView.swift */; };
FF73FF9E1FBA4B5500F2AB06 /* UserFooterView.xib in Resources */ = {isa = PBXBuildFile; fileRef = FF73FF9D1FBA4B5500F2AB06 /* UserFooterView.xib */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXBuildFile section */
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
/* Begin PBXContainerItemProxy section */
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9161DE5006C00A64FEE /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 2961B3821D68B031001C9451 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 2961B3891D68B031001C9451;
remoteInfo = IGListKitExamples;
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB71D1DBBA60900A65C18 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 2961B3821D68B031001C9451 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 986FB7101DBBA60900A65C18;
remoteInfo = MessageExtension;
};
986FB7391DBBAD8600A65C18 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 2961B3821D68B031001C9451 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 986FB72E1DBBAD8600A65C18;
remoteInfo = IGListKitTodayExample;
};
/* End PBXContainerItemProxy section */
/* Begin PBXCopyFilesBuildPhase section */
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
986FB7231DBBA60900A65C18 /* Embed Foundation Extensions */ = {
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
dstPath = "";
dstSubfolderSpec = 13;
files = (
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
986FB73B1DBBAD8600A65C18 /* IGListKitTodayExample.appex in Embed Foundation Extensions */,
986FB71F1DBBA60900A65C18 /* IGListKitMessageExample.appex in Embed Foundation Extensions */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
name = "Embed Foundation Extensions";
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXCopyFilesBuildPhase section */
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* Begin PBXFileReference section */
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01671F9D9CBD0092A320 /* ReorderableSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReorderableSectionController.swift; sourceTree = "<group>"; };
13DF01691F9D9F600092A320 /* ReorderableViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReorderableViewController.swift; sourceTree = "<group>"; };
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8D1DAE9D3F0073E116 /* SingleSectionViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SingleSectionViewController.swift; sourceTree = "<group>"; };
26271C911DAE9EFC0073E116 /* NibCell.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = NibCell.xib; sourceTree = "<group>"; };
26271C931DAE9F050073E116 /* NibCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = NibCell.swift; sourceTree = "<group>"; };
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658561E749EDC0041B56D /* CalendarViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CalendarViewController.swift; sourceTree = "<group>"; };
292658581E749F820041B56D /* Month.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Month.swift; sourceTree = "<group>"; };
2926585F1E74A19F0041B56D /* DayViewModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DayViewModel.swift; sourceTree = "<group>"; };
292658631E74A2550041B56D /* MonthSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MonthSectionController.swift; sourceTree = "<group>"; };
292658651E74A49D0041B56D /* CalendarDayCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CalendarDayCell.swift; sourceTree = "<group>"; };
292658671E74AE8A0041B56D /* MonthTitleViewModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MonthTitleViewModel.swift; sourceTree = "<group>"; };
292658691E74AEFE0041B56D /* MonthTitleCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MonthTitleCell.swift; sourceTree = "<group>"; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF831D9F39E00015D24B /* DemoSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DemoSectionController.swift; sourceTree = "<group>"; };
2942FF841D9F39E00015D24B /* EmbeddedSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EmbeddedSectionController.swift; sourceTree = "<group>"; };
2942FF851D9F39E00015D24B /* ExpandableSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ExpandableSectionController.swift; sourceTree = "<group>"; };
2942FF861D9F39E00015D24B /* GridSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = GridSectionController.swift; sourceTree = "<group>"; };
2942FF871D9F39E00015D24B /* HorizontalSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = HorizontalSectionController.swift; sourceTree = "<group>"; };
2942FF881D9F39E00015D24B /* LabelSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LabelSectionController.swift; sourceTree = "<group>"; };
2942FF891D9F39E00015D24B /* RemoveSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = RemoveSectionController.swift; sourceTree = "<group>"; };
2942FF8A1D9F39E00015D24B /* SearchSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchSectionController.swift; sourceTree = "<group>"; };
2942FF8B1D9F39E00015D24B /* UserSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UserSectionController.swift; sourceTree = "<group>"; };
Add diffing example Summary: Adding an example of how to use diffing by itself w/ `UITableView` batch updates. Reviewed By: jessesquires Differential Revision: D4077768 fbshipit-source-id: 313193cdcadd337e08f74e90713fa127a5365112
2016-10-26 18:47:10 +00:00
29459BFF1DBE48E200F05375 /* DiffTableViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DiffTableViewController.swift; sourceTree = "<group>"; };
Improve the ObjC demo to reflect best-practices Summary: Couple best practices I want to make sure our examples reflect: - Multiple cells in a section controller - Unique models returned in `objectsForListAdapter:` (no dupes!) - Dynamic item count (`comments` array) Issue fixed: #595 - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/615 Differential Revision: D4852192 Pulled By: jessesquires fbshipit-source-id: f4a89800f90e6b5ea4b6dd7c0d9a78ca5d65082c
2017-04-07 18:20:37 +00:00
295D8A981E92EC96001F7C06 /* PostSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PostSectionController.h; sourceTree = "<group>"; };
295D8A991E92EC96001F7C06 /* PostSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PostSectionController.m; sourceTree = "<group>"; };
295D8A9B1E92ECDE001F7C06 /* Post.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Post.h; sourceTree = "<group>"; };
295D8A9C1E92ECDE001F7C06 /* Post.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = Post.m; sourceTree = "<group>"; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B38A1D68B031001C9451 /* IGListKitExamples.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = IGListKitExamples.app; sourceTree = BUILT_PRODUCTS_DIR; };
2961B38D1D68B031001C9451 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
2961B3941D68B031001C9451 /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
2961B3971D68B031001C9451 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; };
2961B3991D68B031001C9451 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
2961B3A41D68B0B5001C9451 /* DemosViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DemosViewController.swift; sourceTree = "<group>"; };
2961B3A51D68B0B5001C9451 /* LoadMoreViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoadMoreViewController.swift; sourceTree = "<group>"; };
2961B3A71D68B0B5001C9451 /* LabelCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LabelCell.swift; sourceTree = "<group>"; };
2961B3A81D68B0B5001C9451 /* SpinnerCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SpinnerCell.swift; sourceTree = "<group>"; };
2961B3AF1D68B28E001C9451 /* SearchCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchCell.swift; sourceTree = "<group>"; };
29628F131D91905A0026B15A /* DetailLabelCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DetailLabelCell.swift; sourceTree = "<group>"; };
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7521DD2147500206780 /* SelfSizingCellsViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SelfSizingCellsViewController.swift; sourceTree = "<group>"; };
296DD7541DD2150600206780 /* SelfSizingSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SelfSizingSectionController.swift; sourceTree = "<group>"; };
296DD7561DD2163800206780 /* ManuallySelfSizingCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ManuallySelfSizingCell.swift; sourceTree = "<group>"; };
296DD7581DD2174200206780 /* NibSelfSizingCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = NibSelfSizingCell.swift; sourceTree = "<group>"; };
296DD75A1DD217C000206780 /* NibSelfSizingCell.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = NibSelfSizingCell.xib; sourceTree = "<group>"; };
296DD75C1DD21ADA00206780 /* SelectionModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SelectionModel.swift; sourceTree = "<group>"; };
297546F91DD25384002A6F89 /* FullWidthSelfSizingCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FullWidthSelfSizingCell.swift; sourceTree = "<group>"; };
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
2981BA341DB868A500A987F9 /* ImageCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ImageCell.swift; sourceTree = "<group>"; };
2981BA361DB869FF00A987F9 /* WorkingRangeSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = WorkingRangeSectionController.swift; sourceTree = "<group>"; };
2981BA381DB874BB00A987F9 /* WorkingRangeViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = WorkingRangeViewController.swift; sourceTree = "<group>"; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
299068271D75BFEC00A62888 /* MixedDataViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MixedDataViewController.swift; sourceTree = "<group>"; };
2991F9181D7BADC900B0C58F /* CenterLabelCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CenterLabelCell.swift; sourceTree = "<group>"; };
2991F91D1D7BB30C00B0C58F /* User.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = User.swift; sourceTree = "<group>"; };
2991F9231D7BB89F00B0C58F /* NestedAdapterViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = NestedAdapterViewController.swift; sourceTree = "<group>"; };
2991F9271D7BB9EC00B0C58F /* EmbeddedCollectionViewCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EmbeddedCollectionViewCell.swift; sourceTree = "<group>"; };
2991F92B1D7BBE5400B0C58F /* RemoveCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = RemoveCell.swift; sourceTree = "<group>"; };
2991F92F1D7BC0E400B0C58F /* EmptyViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EmptyViewController.swift; sourceTree = "<group>"; };
299B53FF1D6BD6630074A202 /* SearchViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchViewController.swift; sourceTree = "<group>"; };
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297A1DCFD857004A5BB1 /* SupplementaryViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SupplementaryViewController.swift; sourceTree = "<group>"; };
29C6297C1DCFD8E5004A5BB1 /* FeedItem.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeedItem.swift; sourceTree = "<group>"; };
29C6297E1DCFD9E9004A5BB1 /* FeedItemSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FeedItemSectionController.swift; sourceTree = "<group>"; };
29C629801DCFDAF3004A5BB1 /* UserHeaderView.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = UserHeaderView.xib; sourceTree = "<group>"; };
29C629821DCFDB57004A5BB1 /* UserHeaderView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UserHeaderView.swift; sourceTree = "<group>"; };
Add display delegate example Summary: Adds a new example. Fixes #159 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/194 Differential Revision: D4172780 Pulled By: rnystrom fbshipit-source-id: 34e1eaef03bb6564445f30dc2fe2b015bb276b6a
2016-11-12 17:18:29 +00:00
29D2E4AC1DD69B6000CD255D /* DisplaySectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DisplaySectionController.swift; sourceTree = "<group>"; };
29D2E4AE1DD69C0E00CD255D /* DisplayViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DisplayViewController.swift; sourceTree = "<group>"; };
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2A91E9283FF00197586 /* AnnouncingDepsViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AnnouncingDepsViewController.swift; sourceTree = "<group>"; };
29F7E2AC1E92843A00197586 /* IncrementAnnouncer.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = IncrementAnnouncer.swift; sourceTree = "<group>"; };
29F7E2AE1E92858500197586 /* ListeningSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ListeningSectionController.swift; sourceTree = "<group>"; };
Example using SwiftUI with compositional layout Summary: Introduces a compositional layout example that leverages section controller methods to determine layout. Differential Revision: D71402637 fbshipit-source-id: 1179abf13157fb5cb78c8a9086718d1216fb4276
2025-03-19 17:14:23 +00:00
4119B2AA2D89BB1200D397BC /* ActivityItem.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ActivityItem.swift; sourceTree = "<group>"; };
4119B2AC2D89BBE200D397BC /* ActivityComposableSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ActivityComposableSectionController.swift; sourceTree = "<group>"; };
41A162942D8A0C7A002A5A8F /* SelectionComposableSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SelectionComposableSectionController.swift; sourceTree = "<group>"; };
Disable iOS 9.3 tests Summary: These tests are timing out all the time. ☠️ Issue fixed: #683 Closes https://github.com/Instagram/IGListKit/pull/688 Differential Revision: D4965525 Pulled By: rnystrom fbshipit-source-id: ea122e66379646c557d1b8f1c7325894620b88fb
2017-04-27 21:32:32 +00:00
49DEF56A3C9C414B461D113F /* Pods_IGListKitTodayExample.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_IGListKitTodayExample.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B661E49B2110026DB39 /* IGListKitExamples-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "IGListKitExamples-Bridging-Header.h"; sourceTree = "<group>"; };
56C05B671E49B2120026DB39 /* ObjcDemoViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ObjcDemoViewController.h; sourceTree = "<group>"; };
56C05B681E49B2120026DB39 /* ObjcDemoViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ObjcDemoViewController.m; sourceTree = "<group>"; };
56C05B6A1E49B2E80026DB39 /* UserInfoCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UserInfoCell.h; sourceTree = "<group>"; };
56C05B6B1E49B2E80026DB39 /* UserInfoCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = UserInfoCell.m; sourceTree = "<group>"; };
56C05B701E49B32A0026DB39 /* CommentCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CommentCell.h; sourceTree = "<group>"; };
56C05B711E49B32A0026DB39 /* CommentCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CommentCell.m; sourceTree = "<group>"; };
56C05B731E49B33C0026DB39 /* InteractiveCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InteractiveCell.h; sourceTree = "<group>"; };
56C05B741E49B33C0026DB39 /* InteractiveCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = InteractiveCell.m; sourceTree = "<group>"; };
56C05B761E49B3A50026DB39 /* PhotoCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PhotoCell.h; sourceTree = "<group>"; };
56C05B771E49B3A50026DB39 /* PhotoCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PhotoCell.m; sourceTree = "<group>"; };
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D20062B2CB50E0012C5B8 /* CompositionLayoutViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CompositionLayoutViewController.swift; sourceTree = "<group>"; };
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D20082B2CB6C20012C5B8 /* SwipeActionComposabelSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwipeActionComposabelSectionController.swift; sourceTree = "<group>"; };
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200A2B2CC6DF0012C5B8 /* CompositionLayoutCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CompositionLayoutCell.swift; sourceTree = "<group>"; };
576D200D2B2CE9EC0012C5B8 /* ExpandableComposableSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ExpandableComposableSectionController.swift; sourceTree = "<group>"; };
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D200F2B2CEC4E0012C5B8 /* GridComposableSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GridComposableSectionController.swift; sourceTree = "<group>"; };
add user to UICollectionViewCompositionalLayout example Summary: Adding user cell Differential Revision: D52260532 fbshipit-source-id: ec3f4f5a70d02e0c6db713ade51938413cb5ee8a
2023-12-19 15:17:30 +00:00
576D20112B2CF04F0012C5B8 /* UserComposableSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserComposableSectionController.swift; sourceTree = "<group>"; };
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D20132B2CF15C0012C5B8 /* GridItem.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GridItem.swift; sourceTree = "<group>"; };
add horizontal row to UICollectionViewCompositionalLayout example Summary: Lets go even beyond the `MixedDataViewController` example by taking advantage of `orthogonalScrollingBehavior`. Really neat! Differential Revision: D52260531 fbshipit-source-id: aee8b38a38284104fa65ba8d33426a9e6216e503
2023-12-19 15:17:30 +00:00
576D20152B2CF1A50012C5B8 /* HorizontalCardsSection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HorizontalCardsSection.swift; sourceTree = "<group>"; };
576D20172B2CF24F0012C5B8 /* HorizontalComposableSectionController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HorizontalComposableSectionController.swift; sourceTree = "<group>"; };
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D20192B2CF82C0012C5B8 /* SwipeActionSection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwipeActionSection.swift; sourceTree = "<group>"; };
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4B51DB8B3DC00172ED0 /* StoryboardViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StoryboardViewController.swift; sourceTree = "<group>"; };
821BC4B71DB8B48300172ED0 /* StoryboardCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StoryboardCell.swift; sourceTree = "<group>"; };
821BC4B91DB8B61200172ED0 /* StoryboardLabelSectionController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StoryboardLabelSectionController.swift; sourceTree = "<group>"; };
82D91B681DBA0EF300E62758 /* SingleSectionStoryboardViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SingleSectionStoryboardViewController.swift; sourceTree = "<group>"; };
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
9518E3C21DED03510008CC46 /* UITestCase.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UITestCase.swift; sourceTree = "<group>"; };
9518E3C41DED057E0008CC46 /* LoadMoreViewControllerUITests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoadMoreViewControllerUITests.swift; sourceTree = "<group>"; };
9518E3C61DED18370008CC46 /* SearchViewControllerUITests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchViewControllerUITests.swift; sourceTree = "<group>"; };
9518E3C81DED1BCB0008CC46 /* MixedDataViewControllerUITests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = MixedDataViewControllerUITests.swift; sourceTree = "<group>"; };
9518E3CA1DED27840008CC46 /* DemosViewControllerUITests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DemosViewControllerUITests.swift; sourceTree = "<group>"; };
95F7F9111DE5006B00A64FEE /* IGListKitExamples-UITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "IGListKitExamples-UITests.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
95F7F9151DE5006C00A64FEE /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7111DBBA60900A65C18 /* IGListKitMessageExample.appex */ = {isa = PBXFileReference; explicitFileType = "wrapper.app-extension"; includeInIndex = 0; path = IGListKitMessageExample.appex; sourceTree = BUILT_PRODUCTS_DIR; };
986FB7121DBBA60900A65C18 /* Messages.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Messages.framework; path = System/Library/Frameworks/Messages.framework; sourceTree = SDKROOT; };
986FB7151DBBA60900A65C18 /* MessagesViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MessagesViewController.swift; sourceTree = "<group>"; };
986FB71A1DBBA60900A65C18 /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
986FB71C1DBBA60900A65C18 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
986FB72F1DBBAD8600A65C18 /* IGListKitTodayExample.appex */ = {isa = PBXFileReference; explicitFileType = "wrapper.app-extension"; includeInIndex = 0; path = IGListKitTodayExample.appex; sourceTree = BUILT_PRODUCTS_DIR; };
986FB7301DBBAD8600A65C18 /* NotificationCenter.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = NotificationCenter.framework; path = System/Library/Frameworks/NotificationCenter.framework; sourceTree = SDKROOT; };
986FB7331DBBAD8600A65C18 /* TodayViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TodayViewController.swift; sourceTree = "<group>"; };
986FB7381DBBAD8600A65C18 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
98B4DBF31DC2937A002BA58A /* Demo.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = Demo.storyboard; path = IGListKitExamples/Storyboard/Demo.storyboard; sourceTree = "<group>"; };
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DB684E0251B10C2002023DD /* UIColor+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIColor+Extension.swift"; sourceTree = "<group>"; };
9DFF4D05251F08F50048474A /* UIActivityIndicatorView+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIActivityIndicatorView+Extension.swift"; sourceTree = "<group>"; };
Disable iOS 9.3 tests Summary: These tests are timing out all the time. ☠️ Issue fixed: #683 Closes https://github.com/Instagram/IGListKit/pull/688 Differential Revision: D4965525 Pulled By: rnystrom fbshipit-source-id: ea122e66379646c557d1b8f1c7325894620b88fb
2017-04-27 21:32:32 +00:00
B7B1FA2EFFA5E994FEE587DE /* Pods_IGListKitMessageExample.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_IGListKitMessageExample.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB336E22760EC95007B4098 /* IGListKit */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = IGListKit; path = ../..; sourceTree = "<group>"; };
BAB337022760F50D007B4098 /* IGListKitExamples.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = IGListKitExamples.entitlements; sourceTree = "<group>"; };
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB02899F202A11DF007E17D5 /* PersonModel.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PersonModel.m; sourceTree = "<group>"; };
EB0289A0202A11DF007E17D5 /* PersonModel.value */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = PersonModel.value; sourceTree = "<group>"; };
EB0289A1202A11DF007E17D5 /* PersonModel.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PersonModel.h; sourceTree = "<group>"; };
EB0289A4202A14E1007E17D5 /* ObjcGeneratedModelDemoViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ObjcGeneratedModelDemoViewController.h; sourceTree = "<group>"; };
EB0289A5202A14E1007E17D5 /* ObjcGeneratedModelDemoViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ObjcGeneratedModelDemoViewController.m; sourceTree = "<group>"; };
EB0289A7202A1507007E17D5 /* PersonSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PersonSectionController.h; sourceTree = "<group>"; };
EB0289A8202A1507007E17D5 /* PersonSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PersonSectionController.m; sourceTree = "<group>"; };
EB0289AA202A1705007E17D5 /* PersonCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PersonCell.m; sourceTree = "<group>"; };
EB0289AB202A1705007E17D5 /* PersonCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PersonCell.h; sourceTree = "<group>"; };
Disable iOS 9.3 tests Summary: These tests are timing out all the time. ☠️ Issue fixed: #683 Closes https://github.com/Instagram/IGListKit/pull/688 Differential Revision: D4965525 Pulled By: rnystrom fbshipit-source-id: ea122e66379646c557d1b8f1c7325894620b88fb
2017-04-27 21:32:32 +00:00
FE7316EF8201F89655D39E53 /* Pods_IGListKitExamples.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_IGListKitExamples.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Added support UICollectionElementKindSectionFooter for IGListCollectionViewLayout Summary: **Changes occurred only for the IGListCollectionViewLayout.** **Specifically:** 1. Harnessed the hardcore to the fact that it is possible to use only headers. 2. Assertions removed 3. Caching for layout of attributes of footers 4. Implemented the location of the footers in any orientation scroll Issue fixed: #898 I need this enhancement ASAP 🙏 **Example:** Footers with user comments count ![simulator screen shot - iphone 6 - 2017-11-14 at 13 35 22](https://user-images.githubusercontent.com/7735730/32775551-c69868cc-c940-11e7-8307-ae2e353519ff.png) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] I updated example project with implemented feature Closes https://github.com/Instagram/IGListKit/pull/1017 Reviewed By: jeremycohen Differential Revision: D6385893 Pulled By: rnystrom fbshipit-source-id: 5f1bad5655d2df321f8c71496aa797ac8e3d226a
2017-11-21 20:39:09 +00:00
FF73FF9B1FBA4B4400F2AB06 /* UserFooterView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserFooterView.swift; sourceTree = "<group>"; };
FF73FF9D1FBA4B5500F2AB06 /* UserFooterView.xib */ = {isa = PBXFileReference; lastKnownFileType = file.xib; path = UserFooterView.xib; sourceTree = "<group>"; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXFileReference section */
/* Begin PBXFrameworksBuildPhase section */
2961B3871D68B031001C9451 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB336E42760ECC1007B4098 /* IGListDiffKit in Frameworks */,
BAB336E62760ECC1007B4098 /* IGListKit in Frameworks */,
BAB336E82760ECC1007B4098 /* IGListSwiftKit in Frameworks */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F90E1DE5006B00A64FEE /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB70E1DBBA60900A65C18 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
986FB7131DBBA60900A65C18 /* Messages.framework in Frameworks */,
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB336F22760ED55007B4098 /* IGListDiffKit in Frameworks */,
BAB336EC2760ECFE007B4098 /* IGListKit in Frameworks */,
BAB336F42760EDCB007B4098 /* IGListSwiftKit in Frameworks */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
986FB72C1DBBAD8600A65C18 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
986FB7311DBBAD8600A65C18 /* NotificationCenter.framework in Frameworks */,
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB336EA2760ECE5007B4098 /* IGListKit in Frameworks */,
BAB336F02760ED28007B4098 /* IGListDiffKit in Frameworks */,
BAB336EE2760ED0C007B4098 /* IGListSwiftKit in Frameworks */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXFrameworksBuildPhase section */
/* Begin PBXGroup section */
0853E82EF5C5E4BD4E0760E3 /* Frameworks */ = {
isa = PBXGroup;
children = (
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7121DBBA60900A65C18 /* Messages.framework */,
986FB7301DBBAD8600A65C18 /* NotificationCenter.framework */,
Disable iOS 9.3 tests Summary: These tests are timing out all the time. ☠️ Issue fixed: #683 Closes https://github.com/Instagram/IGListKit/pull/688 Differential Revision: D4965525 Pulled By: rnystrom fbshipit-source-id: ea122e66379646c557d1b8f1c7325894620b88fb
2017-04-27 21:32:32 +00:00
FE7316EF8201F89655D39E53 /* Pods_IGListKitExamples.framework */,
B7B1FA2EFFA5E994FEE587DE /* Pods_IGListKitMessageExample.framework */,
49DEF56A3C9C414B461D113F /* Pods_IGListKitTodayExample.framework */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
name = Frameworks;
sourceTree = "<group>";
};
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926585C1E74A0360041B56D /* ViewModels */ = {
isa = PBXGroup;
children = (
2926585F1E74A19F0041B56D /* DayViewModel.swift */,
292658671E74AE8A0041B56D /* MonthTitleViewModel.swift */,
);
path = ViewModels;
sourceTree = "<group>";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF821D9F39E00015D24B /* SectionControllers */ = {
isa = PBXGroup;
children = (
2942FF831D9F39E00015D24B /* DemoSectionController.swift */,
Add display delegate example Summary: Adds a new example. Fixes #159 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/194 Differential Revision: D4172780 Pulled By: rnystrom fbshipit-source-id: 34e1eaef03bb6564445f30dc2fe2b015bb276b6a
2016-11-12 17:18:29 +00:00
29D2E4AC1DD69B6000CD255D /* DisplaySectionController.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF841D9F39E00015D24B /* EmbeddedSectionController.swift */,
2942FF851D9F39E00015D24B /* ExpandableSectionController.swift */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297E1DCFD9E9004A5BB1 /* FeedItemSectionController.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF861D9F39E00015D24B /* GridSectionController.swift */,
2942FF871D9F39E00015D24B /* HorizontalSectionController.swift */,
2942FF881D9F39E00015D24B /* LabelSectionController.swift */,
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2AE1E92858500197586 /* ListeningSectionController.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658631E74A2550041B56D /* MonthSectionController.swift */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289A7202A1507007E17D5 /* PersonSectionController.h */,
EB0289A8202A1507007E17D5 /* PersonSectionController.m */,
Improve the ObjC demo to reflect best-practices Summary: Couple best practices I want to make sure our examples reflect: - Multiple cells in a section controller - Unique models returned in `objectsForListAdapter:` (no dupes!) - Dynamic item count (`comments` array) Issue fixed: #595 - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/615 Differential Revision: D4852192 Pulled By: jessesquires fbshipit-source-id: f4a89800f90e6b5ea4b6dd7c0d9a78ca5d65082c
2017-04-07 18:20:37 +00:00
295D8A981E92EC96001F7C06 /* PostSectionController.h */,
295D8A991E92EC96001F7C06 /* PostSectionController.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF891D9F39E00015D24B /* RemoveSectionController.swift */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01671F9D9CBD0092A320 /* ReorderableSectionController.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF8A1D9F39E00015D24B /* SearchSectionController.swift */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7541DD2150600206780 /* SelfSizingSectionController.swift */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4B91DB8B61200172ED0 /* StoryboardLabelSectionController.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2942FF8B1D9F39E00015D24B /* UserSectionController.swift */,
2981BA361DB869FF00A987F9 /* WorkingRangeSectionController.swift */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200C2B2CE9C60012C5B8 /* With Composable Layout */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
path = SectionControllers;
sourceTree = "<group>";
};
2961B3811D68B031001C9451 = {
isa = PBXGroup;
children = (
2961B38C1D68B031001C9451 /* IGListKitExamples */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7141DBBA60900A65C18 /* IGListKitMessageExample */,
986FB7321DBBAD8600A65C18 /* IGListKitTodayExample */,
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9121DE5006C00A64FEE /* IGListKitExamples-UITests */,
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB336E12760EC95007B4098 /* Packages */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B38B1D68B031001C9451 /* Products */,
0853E82EF5C5E4BD4E0760E3 /* Frameworks */,
);
sourceTree = "<group>";
};
2961B38B1D68B031001C9451 /* Products */ = {
isa = PBXGroup;
children = (
2961B38A1D68B031001C9451 /* IGListKitExamples.app */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7111DBBA60900A65C18 /* IGListKitMessageExample.appex */,
986FB72F1DBBAD8600A65C18 /* IGListKitTodayExample.appex */,
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9111DE5006B00A64FEE /* IGListKitExamples-UITests.xctest */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
name = Products;
sourceTree = "<group>";
};
2961B38C1D68B031001C9451 /* IGListKitExamples */ = {
isa = PBXGroup;
children = (
2961B38D1D68B031001C9451 /* AppDelegate.swift */,
2961B3941D68B031001C9451 /* Assets.xcassets */,
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DB684DF251B1093002023DD /* Extensions */,
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB337022760F50D007B4098 /* IGListKitExamples.entitlements */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3991D68B031001C9451 /* Info.plist */,
2961B3961D68B031001C9451 /* LaunchScreen.storyboard */,
2991F91C1D7BB30300B0C58F /* Models */,
2942FF821D9F39E00015D24B /* SectionControllers */,
project organization, 'sort by name' Summary: Closes https://github.com/Instagram/IGListKit/pull/271 Differential Revision: D4259848 Pulled By: jessesquires fbshipit-source-id: 4a7a1159bbb335b88243e4fbc7bf62c54ce7b6dc
2016-12-01 19:56:11 +00:00
822B29F21DB8AA4700010000 /* Storyboard */,
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2AB1E92842D00197586 /* Systems */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3A31D68B0B5001C9451 /* ViewControllers */,
2961B3A61D68B0B5001C9451 /* Views */,
);
path = IGListKitExamples;
sourceTree = "<group>";
};
2961B3A31D68B0B5001C9451 /* ViewControllers */ = {
isa = PBXGroup;
children = (
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2A91E9283FF00197586 /* AnnouncingDepsViewController.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658561E749EDC0041B56D /* CalendarViewController.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3A41D68B0B5001C9451 /* DemosViewController.swift */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29459BFF1DBE48E200F05375 /* DiffTableViewController.swift */,
Add display delegate example Summary: Adds a new example. Fixes #159 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/194 Differential Revision: D4172780 Pulled By: rnystrom fbshipit-source-id: 34e1eaef03bb6564445f30dc2fe2b015bb276b6a
2016-11-12 17:18:29 +00:00
29D2E4AE1DD69C0E00CD255D /* DisplayViewController.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F92F1D7BC0E400B0C58F /* EmptyViewController.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
56C05B661E49B2110026DB39 /* IGListKitExamples-Bridging-Header.h */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3A51D68B0B5001C9451 /* LoadMoreViewController.swift */,
299068271D75BFEC00A62888 /* MixedDataViewController.swift */,
2991F9231D7BB89F00B0C58F /* NestedAdapterViewController.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
56C05B671E49B2120026DB39 /* ObjcDemoViewController.h */,
56C05B681E49B2120026DB39 /* ObjcDemoViewController.m */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289A4202A14E1007E17D5 /* ObjcGeneratedModelDemoViewController.h */,
EB0289A5202A14E1007E17D5 /* ObjcGeneratedModelDemoViewController.m */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01691F9D9F600092A320 /* ReorderableViewController.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
299B53FF1D6BD6630074A202 /* SearchViewController.swift */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7521DD2147500206780 /* SelfSizingCellsViewController.swift */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
82D91B681DBA0EF300E62758 /* SingleSectionStoryboardViewController.swift */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8D1DAE9D3F0073E116 /* SingleSectionViewController.swift */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4B51DB8B3DC00172ED0 /* StoryboardViewController.swift */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297A1DCFD857004A5BB1 /* SupplementaryViewController.swift */,
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
2981BA381DB874BB00A987F9 /* WorkingRangeViewController.swift */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D20062B2CB50E0012C5B8 /* CompositionLayoutViewController.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
path = ViewControllers;
sourceTree = "<group>";
};
2961B3A61D68B0B5001C9451 /* Views */ = {
isa = PBXGroup;
children = (
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658651E74A49D0041B56D /* CalendarDayCell.swift */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F9181D7BADC900B0C58F /* CenterLabelCell.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
56C05B701E49B32A0026DB39 /* CommentCell.h */,
56C05B711E49B32A0026DB39 /* CommentCell.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
29628F131D91905A0026B15A /* DetailLabelCell.swift */,
2991F9271D7BB9EC00B0C58F /* EmbeddedCollectionViewCell.swift */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
297546F91DD25384002A6F89 /* FullWidthSelfSizingCell.swift */,
2981BA341DB868A500A987F9 /* ImageCell.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
56C05B731E49B33C0026DB39 /* InteractiveCell.h */,
56C05B741E49B33C0026DB39 /* InteractiveCell.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3A71D68B0B5001C9451 /* LabelCell.swift */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7561DD2163800206780 /* ManuallySelfSizingCell.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658691E74AEFE0041B56D /* MonthTitleCell.swift */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
26271C931DAE9F050073E116 /* NibCell.swift */,
26271C911DAE9EFC0073E116 /* NibCell.xib */,
296DD7581DD2174200206780 /* NibSelfSizingCell.swift */,
296DD75A1DD217C000206780 /* NibSelfSizingCell.xib */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289AB202A1705007E17D5 /* PersonCell.h */,
EB0289AA202A1705007E17D5 /* PersonCell.m */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
56C05B761E49B3A50026DB39 /* PhotoCell.h */,
56C05B771E49B3A50026DB39 /* PhotoCell.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F92B1D7BBE5400B0C58F /* RemoveCell.swift */,
2961B3AF1D68B28E001C9451 /* SearchCell.swift */,
2961B3A81D68B0B5001C9451 /* SpinnerCell.swift */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4B71DB8B48300172ED0 /* StoryboardCell.swift */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C629821DCFDB57004A5BB1 /* UserHeaderView.swift */,
Added support UICollectionElementKindSectionFooter for IGListCollectionViewLayout Summary: **Changes occurred only for the IGListCollectionViewLayout.** **Specifically:** 1. Harnessed the hardcore to the fact that it is possible to use only headers. 2. Assertions removed 3. Caching for layout of attributes of footers 4. Implemented the location of the footers in any orientation scroll Issue fixed: #898 I need this enhancement ASAP 🙏 **Example:** Footers with user comments count ![simulator screen shot - iphone 6 - 2017-11-14 at 13 35 22](https://user-images.githubusercontent.com/7735730/32775551-c69868cc-c940-11e7-8307-ae2e353519ff.png) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] I updated example project with implemented feature Closes https://github.com/Instagram/IGListKit/pull/1017 Reviewed By: jeremycohen Differential Revision: D6385893 Pulled By: rnystrom fbshipit-source-id: 5f1bad5655d2df321f8c71496aa797ac8e3d226a
2017-11-21 20:39:09 +00:00
FF73FF9B1FBA4B4400F2AB06 /* UserFooterView.swift */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200A2B2CC6DF0012C5B8 /* CompositionLayoutCell.swift */,
Added support UICollectionElementKindSectionFooter for IGListCollectionViewLayout Summary: **Changes occurred only for the IGListCollectionViewLayout.** **Specifically:** 1. Harnessed the hardcore to the fact that it is possible to use only headers. 2. Assertions removed 3. Caching for layout of attributes of footers 4. Implemented the location of the footers in any orientation scroll Issue fixed: #898 I need this enhancement ASAP 🙏 **Example:** Footers with user comments count ![simulator screen shot - iphone 6 - 2017-11-14 at 13 35 22](https://user-images.githubusercontent.com/7735730/32775551-c69868cc-c940-11e7-8307-ae2e353519ff.png) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] I updated example project with implemented feature Closes https://github.com/Instagram/IGListKit/pull/1017 Reviewed By: jeremycohen Differential Revision: D6385893 Pulled By: rnystrom fbshipit-source-id: 5f1bad5655d2df321f8c71496aa797ac8e3d226a
2017-11-21 20:39:09 +00:00
FF73FF9D1FBA4B5500F2AB06 /* UserFooterView.xib */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
29C629801DCFDAF3004A5BB1 /* UserHeaderView.xib */,
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B6A1E49B2E80026DB39 /* UserInfoCell.h */,
56C05B6B1E49B2E80026DB39 /* UserInfoCell.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
path = Views;
sourceTree = "<group>";
};
2991F91C1D7BB30300B0C58F /* Models */ = {
isa = PBXGroup;
children = (
Example using SwiftUI with compositional layout Summary: Introduces a compositional layout example that leverages section controller methods to determine layout. Differential Revision: D71402637 fbshipit-source-id: 1179abf13157fb5cb78c8a9086718d1216fb4276
2025-03-19 17:14:23 +00:00
4119B2AA2D89BB1200D397BC /* ActivityItem.swift */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297C1DCFD8E5004A5BB1 /* FeedItem.swift */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658581E749F820041B56D /* Month.swift */,
Improve the ObjC demo to reflect best-practices Summary: Couple best practices I want to make sure our examples reflect: - Multiple cells in a section controller - Unique models returned in `objectsForListAdapter:` (no dupes!) - Dynamic item count (`comments` array) Issue fixed: #595 - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/615 Differential Revision: D4852192 Pulled By: jessesquires fbshipit-source-id: f4a89800f90e6b5ea4b6dd7c0d9a78ca5d65082c
2017-04-07 18:20:37 +00:00
295D8A9B1E92ECDE001F7C06 /* Post.h */,
295D8A9C1E92ECDE001F7C06 /* Post.m */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD75C1DD21ADA00206780 /* SelectionModel.swift */,
2991F91D1D7BB30C00B0C58F /* User.swift */,
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D20132B2CF15C0012C5B8 /* GridItem.swift */,
add horizontal row to UICollectionViewCompositionalLayout example Summary: Lets go even beyond the `MixedDataViewController` example by taking advantage of `orthogonalScrollingBehavior`. Really neat! Differential Revision: D52260531 fbshipit-source-id: aee8b38a38284104fa65ba8d33426a9e6216e503
2023-12-19 15:17:30 +00:00
576D20152B2CF1A50012C5B8 /* HorizontalCardsSection.swift */,
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D20192B2CF82C0012C5B8 /* SwipeActionSection.swift */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB02899E202A11DF007E17D5 /* RemodelGeneratedModels */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926585C1E74A0360041B56D /* ViewModels */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
path = Models;
sourceTree = "<group>";
};
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2AB1E92842D00197586 /* Systems */ = {
isa = PBXGroup;
children = (
29F7E2AC1E92843A00197586 /* IncrementAnnouncer.swift */,
);
path = Systems;
sourceTree = "<group>";
};
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200C2B2CE9C60012C5B8 /* With Composable Layout */ = {
isa = PBXGroup;
children = (
Example using SwiftUI with compositional layout Summary: Introduces a compositional layout example that leverages section controller methods to determine layout. Differential Revision: D71402637 fbshipit-source-id: 1179abf13157fb5cb78c8a9086718d1216fb4276
2025-03-19 17:14:23 +00:00
41A162942D8A0C7A002A5A8F /* SelectionComposableSectionController.swift */,
4119B2AC2D89BBE200D397BC /* ActivityComposableSectionController.swift */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200D2B2CE9EC0012C5B8 /* ExpandableComposableSectionController.swift */,
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D200F2B2CEC4E0012C5B8 /* GridComposableSectionController.swift */,
add user to UICollectionViewCompositionalLayout example Summary: Adding user cell Differential Revision: D52260532 fbshipit-source-id: ec3f4f5a70d02e0c6db713ade51938413cb5ee8a
2023-12-19 15:17:30 +00:00
576D20112B2CF04F0012C5B8 /* UserComposableSectionController.swift */,
add horizontal row to UICollectionViewCompositionalLayout example Summary: Lets go even beyond the `MixedDataViewController` example by taking advantage of `orthogonalScrollingBehavior`. Really neat! Differential Revision: D52260531 fbshipit-source-id: aee8b38a38284104fa65ba8d33426a9e6216e503
2023-12-19 15:17:30 +00:00
576D20172B2CF24F0012C5B8 /* HorizontalComposableSectionController.swift */,
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D20082B2CB6C20012C5B8 /* SwipeActionComposabelSectionController.swift */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
);
path = "With Composable Layout";
sourceTree = "<group>";
};
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
822B29F21DB8AA4700010000 /* Storyboard */ = {
isa = PBXGroup;
children = (
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
98B4DBF31DC2937A002BA58A /* Demo.storyboard */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
);
name = Storyboard;
path = ..;
sourceTree = "<group>";
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9121DE5006C00A64FEE /* IGListKitExamples-UITests */ = {
isa = PBXGroup;
children = (
project organization, 'sort by name' Summary: Closes https://github.com/Instagram/IGListKit/pull/271 Differential Revision: D4259848 Pulled By: jessesquires fbshipit-source-id: 4a7a1159bbb335b88243e4fbc7bf62c54ce7b6dc
2016-12-01 19:56:11 +00:00
9518E3CA1DED27840008CC46 /* DemosViewControllerUITests.swift */,
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9151DE5006C00A64FEE /* Info.plist */,
9518E3C41DED057E0008CC46 /* LoadMoreViewControllerUITests.swift */,
9518E3C81DED1BCB0008CC46 /* MixedDataViewControllerUITests.swift */,
project organization, 'sort by name' Summary: Closes https://github.com/Instagram/IGListKit/pull/271 Differential Revision: D4259848 Pulled By: jessesquires fbshipit-source-id: 4a7a1159bbb335b88243e4fbc7bf62c54ce7b6dc
2016-12-01 19:56:11 +00:00
9518E3C61DED18370008CC46 /* SearchViewControllerUITests.swift */,
9518E3C21DED03510008CC46 /* UITestCase.swift */,
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
);
path = "IGListKitExamples-UITests";
sourceTree = "<group>";
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7141DBBA60900A65C18 /* IGListKitMessageExample */ = {
isa = PBXGroup;
children = (
986FB71A1DBBA60900A65C18 /* Assets.xcassets */,
986FB71C1DBBA60900A65C18 /* Info.plist */,
986FB72A1DBBAC8500A65C18 /* ViewControllers */,
);
path = IGListKitMessageExample;
sourceTree = "<group>";
};
986FB72A1DBBAC8500A65C18 /* ViewControllers */ = {
isa = PBXGroup;
children = (
986FB7151DBBA60900A65C18 /* MessagesViewController.swift */,
);
name = ViewControllers;
sourceTree = "<group>";
};
986FB7321DBBAD8600A65C18 /* IGListKitTodayExample */ = {
isa = PBXGroup;
children = (
986FB7381DBBAD8600A65C18 /* Info.plist */,
986FB73F1DBBADE400A65C18 /* ViewControllers */,
);
path = IGListKitTodayExample;
sourceTree = "<group>";
};
986FB73F1DBBADE400A65C18 /* ViewControllers */ = {
isa = PBXGroup;
children = (
986FB7331DBBAD8600A65C18 /* TodayViewController.swift */,
);
name = ViewControllers;
sourceTree = "<group>";
};
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DB684DF251B1093002023DD /* Extensions */ = {
isa = PBXGroup;
children = (
9DB684E0251B10C2002023DD /* UIColor+Extension.swift */,
9DFF4D05251F08F50048474A /* UIActivityIndicatorView+Extension.swift */,
);
path = Extensions;
sourceTree = "<group>";
};
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
BAB336E12760EC95007B4098 /* Packages */ = {
isa = PBXGroup;
children = (
BAB336E22760EC95007B4098 /* IGListKit */,
);
name = Packages;
sourceTree = "<group>";
};
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB02899E202A11DF007E17D5 /* RemodelGeneratedModels */ = {
isa = PBXGroup;
children = (
EB0289A0202A11DF007E17D5 /* PersonModel.value */,
EB0289A1202A11DF007E17D5 /* PersonModel.h */,
EB02899F202A11DF007E17D5 /* PersonModel.m */,
);
path = RemodelGeneratedModels;
sourceTree = "<group>";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXGroup section */
/* Begin PBXNativeTarget section */
2961B3891D68B031001C9451 /* IGListKitExamples */ = {
isa = PBXNativeTarget;
buildConfigurationList = 2961B39C1D68B031001C9451 /* Build configuration list for PBXNativeTarget "IGListKitExamples" */;
buildPhases = (
2961B3861D68B031001C9451 /* Sources */,
2961B3871D68B031001C9451 /* Frameworks */,
2961B3881D68B031001C9451 /* Resources */,
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
986FB7231DBBA60900A65C18 /* Embed Foundation Extensions */,
Implemented SwiftLint, new PR Summary: Replaces #642, #681 Issue ref: #394 Changes from last PR: - Deleted the shared SwiftLint folder, incl. all files (On the plus side, did this in the quest to get this PR in https://github.com/realm/SwiftLint/pull/1513) - Changed the build script such that it runs the user's `HomeBrew` installation of SwiftLint instead of the local copy Integrates SwiftLint into DangerBot. You may want to append a ?w=1 to the end of the files-changed url to exclude whitespace-only changes. - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/741 Differential Revision: D5068134 Pulled By: jessesquires fbshipit-source-id: 68d6a57e0072672e38eeb94908d00f26bbd68fbc
2017-05-16 14:30:08 +00:00
DC1296C41EC38A0B0043990F /* SwiftLint */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
buildRules = (
);
dependencies = (
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB71E1DBBA60900A65C18 /* PBXTargetDependency */,
986FB73A1DBBAD8600A65C18 /* PBXTargetDependency */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
name = IGListKitExamples;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
packageProductDependencies = (
BAB336E32760ECC1007B4098 /* IGListDiffKit */,
BAB336E52760ECC1007B4098 /* IGListKit */,
BAB336E72760ECC1007B4098 /* IGListSwiftKit */,
);
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
productName = IGListKitExamples;
productReference = 2961B38A1D68B031001C9451 /* IGListKitExamples.app */;
productType = "com.apple.product-type.application";
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9101DE5006B00A64FEE /* IGListKitExamples-UITests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 95F7F91A1DE5006C00A64FEE /* Build configuration list for PBXNativeTarget "IGListKitExamples-UITests" */;
buildPhases = (
95F7F90D1DE5006B00A64FEE /* Sources */,
95F7F90E1DE5006B00A64FEE /* Frameworks */,
95F7F90F1DE5006B00A64FEE /* Resources */,
);
buildRules = (
);
dependencies = (
95F7F9171DE5006C00A64FEE /* PBXTargetDependency */,
);
name = "IGListKitExamples-UITests";
productName = "IGListKitExamples-UITests";
productReference = 95F7F9111DE5006B00A64FEE /* IGListKitExamples-UITests.xctest */;
productType = "com.apple.product-type.bundle.ui-testing";
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7101DBBA60900A65C18 /* IGListKitMessageExample */ = {
isa = PBXNativeTarget;
buildConfigurationList = 986FB7221DBBA60900A65C18 /* Build configuration list for PBXNativeTarget "IGListKitMessageExample" */;
buildPhases = (
986FB70D1DBBA60900A65C18 /* Sources */,
986FB70E1DBBA60900A65C18 /* Frameworks */,
986FB70F1DBBA60900A65C18 /* Resources */,
);
buildRules = (
);
dependencies = (
);
name = IGListKitMessageExample;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
packageProductDependencies = (
BAB336EB2760ECFE007B4098 /* IGListKit */,
BAB336F12760ED55007B4098 /* IGListDiffKit */,
BAB336F32760EDCB007B4098 /* IGListSwiftKit */,
);
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
productName = MessageExtension;
productReference = 986FB7111DBBA60900A65C18 /* IGListKitMessageExample.appex */;
productType = "com.apple.product-type.app-extension.messages";
};
986FB72E1DBBAD8600A65C18 /* IGListKitTodayExample */ = {
isa = PBXNativeTarget;
buildConfigurationList = 986FB73C1DBBAD8600A65C18 /* Build configuration list for PBXNativeTarget "IGListKitTodayExample" */;
buildPhases = (
986FB72B1DBBAD8600A65C18 /* Sources */,
986FB72C1DBBAD8600A65C18 /* Frameworks */,
986FB72D1DBBAD8600A65C18 /* Resources */,
);
buildRules = (
);
dependencies = (
);
name = IGListKitTodayExample;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
packageProductDependencies = (
BAB336E92760ECE5007B4098 /* IGListKit */,
BAB336ED2760ED0C007B4098 /* IGListSwiftKit */,
BAB336EF2760ED28007B4098 /* IGListDiffKit */,
);
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
productName = IGListKitTodayExample;
productReference = 986FB72F1DBBAD8600A65C18 /* IGListKitTodayExample.appex */;
productType = "com.apple.product-type.app-extension";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXNativeTarget section */
/* Begin PBXProject section */
2961B3821D68B031001C9451 /* Project object */ = {
isa = PBXProject;
attributes = {
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
BuildIndependentTargetsInParallel = YES;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
LastSwiftUpdateCheck = 0810;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
LastUpgradeCheck = 1500;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
ORGANIZATIONNAME = Instagram;
TargetAttributes = {
2961B3891D68B031001C9451 = {
CreatedOnToolsVersion = 7.3.1;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
LastSwiftMigration = 1120;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9101DE5006B00A64FEE = {
CreatedOnToolsVersion = 8.1;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
LastSwiftMigration = 1120;
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
TestTargetID = 2961B3891D68B031001C9451;
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7101DBBA60900A65C18 = {
CreatedOnToolsVersion = 8.1;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
LastSwiftMigration = 1120;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
};
986FB72E1DBBAD8600A65C18 = {
CreatedOnToolsVersion = 8.1;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
LastSwiftMigration = 1120;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
};
buildConfigurationList = 2961B3851D68B031001C9451 /* Build configuration list for PBXProject "IGListKitExamples" */;
compatibilityVersion = "Xcode 3.2";
Update deployment targets to silence Xcode 14 warnings (#1573) Summary: ## Changes in this pull request Xcode 14 changed the minimum deployment target to iOS/tvOS 11.0 and macOS 10.13. This PR moves up the deployment targets so that a warning isn't shown on every build. I also silenced the development region and base localization warnings. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1573 Differential Revision: D45223095 Pulled By: TimOliver fbshipit-source-id: 57fbd284809c09f86a9731d0676332de35fbe0df
2023-05-02 05:48:23 +00:00
developmentRegion = en;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
hasScannedForEncodings = 0;
knownRegions = (
en,
Base,
);
mainGroup = 2961B3811D68B031001C9451;
productRefGroup = 2961B38B1D68B031001C9451 /* Products */;
projectDirPath = "";
projectRoot = "";
targets = (
2961B3891D68B031001C9451 /* IGListKitExamples */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7101DBBA60900A65C18 /* IGListKitMessageExample */,
986FB72E1DBBAD8600A65C18 /* IGListKitTodayExample */,
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9101DE5006B00A64FEE /* IGListKitExamples-UITests */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
};
/* End PBXProject section */
/* Begin PBXResourcesBuildPhase section */
2961B3881D68B031001C9451 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C629811DCFDAF3004A5BB1 /* UserHeaderView.xib in Resources */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD75B1DD217C000206780 /* NibSelfSizingCell.xib in Resources */,
Added support UICollectionElementKindSectionFooter for IGListCollectionViewLayout Summary: **Changes occurred only for the IGListCollectionViewLayout.** **Specifically:** 1. Harnessed the hardcore to the fact that it is possible to use only headers. 2. Assertions removed 3. Caching for layout of attributes of footers 4. Implemented the location of the footers in any orientation scroll Issue fixed: #898 I need this enhancement ASAP 🙏 **Example:** Footers with user comments count ![simulator screen shot - iphone 6 - 2017-11-14 at 13 35 22](https://user-images.githubusercontent.com/7735730/32775551-c69868cc-c940-11e7-8307-ae2e353519ff.png) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] I updated example project with implemented feature Closes https://github.com/Instagram/IGListKit/pull/1017 Reviewed By: jeremycohen Differential Revision: D6385893 Pulled By: rnystrom fbshipit-source-id: 5f1bad5655d2df321f8c71496aa797ac8e3d226a
2017-11-21 20:39:09 +00:00
FF73FF9E1FBA4B5500F2AB06 /* UserFooterView.xib in Resources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3981D68B031001C9451 /* LaunchScreen.storyboard in Resources */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C921DAE9EFC0073E116 /* NibCell.xib in Resources */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289A3202A11E0007E17D5 /* PersonModel.value in Resources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3951D68B031001C9451 /* Assets.xcassets in Resources */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
98B4DBF41DC2937A002BA58A /* Demo.storyboard in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F90F1DE5006B00A64FEE /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB70F1DBBA60900A65C18 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
986FB71B1DBBA60900A65C18 /* Assets.xcassets in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
986FB72D1DBBAD8600A65C18 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXResourcesBuildPhase section */
/* Begin PBXShellScriptBuildPhase section */
Implemented SwiftLint, new PR Summary: Replaces #642, #681 Issue ref: #394 Changes from last PR: - Deleted the shared SwiftLint folder, incl. all files (On the plus side, did this in the quest to get this PR in https://github.com/realm/SwiftLint/pull/1513) - Changed the build script such that it runs the user's `HomeBrew` installation of SwiftLint instead of the local copy Integrates SwiftLint into DangerBot. You may want to append a ?w=1 to the end of the files-changed url to exclude whitespace-only changes. - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/741 Differential Revision: D5068134 Pulled By: jessesquires fbshipit-source-id: 68d6a57e0072672e38eeb94908d00f26bbd68fbc
2017-05-16 14:30:08 +00:00
DC1296C41EC38A0B0043990F /* SwiftLint */ = {
isa = PBXShellScriptBuildPhase;
Update SwiftLint and make it an optional dependency Summary: Fixes one final friction point for the IGListKit sample apps: SwiftLint. At the moment, building the sample apps will hard fail if SwiftLint isn't presently installed. This is generally a good thing when adding new code to the sample apps, but for developers who might want to simply run the sample apps to try out IGListKit, this potentially adds additional unneeded friction. Since SwiftLint also runs on each incoming PR on GitHub Actions now, even if a third party contributor submits code that they didn't lint themselves, it will still be verified by the CI. This diff: * Updates `lint.sh` to check for the latest version of SwiftLint. * Makes the message that appears if SwiftLint isn't present a warning, instead of an error. * Adds the linting script to building the `IGListSwiftKit` framework targets as well. Differential Revision: D43864872 fbshipit-source-id: f5cc18f3612795ad1cc15cc4b7c0dfd7102639c6
2023-03-13 07:49:15 +00:00
alwaysOutOfDate = 1;
Implemented SwiftLint, new PR Summary: Replaces #642, #681 Issue ref: #394 Changes from last PR: - Deleted the shared SwiftLint folder, incl. all files (On the plus side, did this in the quest to get this PR in https://github.com/realm/SwiftLint/pull/1513) - Changed the build script such that it runs the user's `HomeBrew` installation of SwiftLint instead of the local copy Integrates SwiftLint into DangerBot. You may want to append a ?w=1 to the end of the files-changed url to exclude whitespace-only changes. - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/741 Differential Revision: D5068134 Pulled By: jessesquires fbshipit-source-id: 68d6a57e0072672e38eeb94908d00f26bbd68fbc
2017-05-16 14:30:08 +00:00
buildActionMask = 2147483647;
files = (
);
inputPaths = (
);
name = SwiftLint;
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Update swiftlint + script, add newrules, autocorrect Summary: - Updates to SwiftLint 0.24.2 - Improve `scripts/lint.sh` - pull version out to a var for easier maintenance - better error message - make script fail xcode build if not installed (so we don't commit lint errors) - Adds a few new SwiftLint rules - Correct all new lint errors (most can be done by running `swiftlint autocorrect`) - Cleans up `.swiftlint.yml` - Fix up example projects Closes https://github.com/Instagram/IGListKit/pull/1058 Differential Revision: D6776177 Pulled By: rnystrom fbshipit-source-id: 345172237b97aaed0d62312c8f366f46145f8cd9
2018-01-22 20:01:53 +00:00
shellScript = "../../scripts/lint.sh\n";
Implemented SwiftLint, new PR Summary: Replaces #642, #681 Issue ref: #394 Changes from last PR: - Deleted the shared SwiftLint folder, incl. all files (On the plus side, did this in the quest to get this PR in https://github.com/realm/SwiftLint/pull/1513) - Changed the build script such that it runs the user's `HomeBrew` installation of SwiftLint instead of the local copy Integrates SwiftLint into DangerBot. You may want to append a ?w=1 to the end of the files-changed url to exclude whitespace-only changes. - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/741 Differential Revision: D5068134 Pulled By: jessesquires fbshipit-source-id: 68d6a57e0072672e38eeb94908d00f26bbd68fbc
2017-05-16 14:30:08 +00:00
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXShellScriptBuildPhase section */
/* Begin PBXSourcesBuildPhase section */
2961B3861D68B031001C9451 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
299068281D75BFEC00A62888 /* MixedDataViewController.swift in Sources */,
299B54001D6BD6630074A202 /* SearchViewController.swift in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658661E74A49D0041B56D /* CalendarDayCell.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3AE1D68B0B5001C9451 /* SpinnerCell.swift in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658591E749F820041B56D /* Month.swift in Sources */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7591DD2174200206780 /* NibSelfSizingCell.swift in Sources */,
296DD7531DD2147500206780 /* SelfSizingCellsViewController.swift in Sources */,
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B691E49B2120026DB39 /* ObjcDemoViewController.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3B01D68B28E001C9451 /* SearchCell.swift in Sources */,
2942FF8C1D9F39E00015D24B /* DemoSectionController.swift in Sources */,
add horizontal row to UICollectionViewCompositionalLayout example Summary: Lets go even beyond the `MixedDataViewController` example by taking advantage of `orthogonalScrollingBehavior`. Really neat! Differential Revision: D52260531 fbshipit-source-id: aee8b38a38284104fa65ba8d33426a9e6216e503
2023-12-19 15:17:30 +00:00
576D20162B2CF1A50012C5B8 /* HorizontalCardsSection.swift in Sources */,
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
2981BA351DB868A500A987F9 /* ImageCell.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF931D9F39E00015D24B /* SearchSectionController.swift in Sources */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
297546FA1DD25384002A6F89 /* FullWidthSelfSizingCell.swift in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658681E74AE8A0041B56D /* MonthTitleViewModel.swift in Sources */,
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D20102B2CEC4E0012C5B8 /* GridComposableSectionController.swift in Sources */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289AC202A1705007E17D5 /* PersonCell.m in Sources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
82D91B691DBA0EF300E62758 /* SingleSectionStoryboardViewController.swift in Sources */,
Add display delegate example Summary: Adds a new example. Fixes #159 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/194 Differential Revision: D4172780 Pulled By: rnystrom fbshipit-source-id: 34e1eaef03bb6564445f30dc2fe2b015bb276b6a
2016-11-12 17:18:29 +00:00
29D2E4AF1DD69C0E00CD255D /* DisplayViewController.swift in Sources */,
Example using SwiftUI with compositional layout Summary: Introduces a compositional layout example that leverages section controller methods to determine layout. Differential Revision: D71402637 fbshipit-source-id: 1179abf13157fb5cb78c8a9086718d1216fb4276
2025-03-19 17:14:23 +00:00
4119B2AD2D89BBF000D397BC /* ActivityComposableSectionController.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF911D9F39E00015D24B /* LabelSectionController.swift in Sources */,
Fix iOS Example xcodeproj file Summary: Issue fixed: #630 - [x] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/631 Differential Revision: D4860116 Pulled By: jessesquires fbshipit-source-id: 8138b50106ae06e06c643ba74451c511f38b0b98
2017-04-10 16:19:48 +00:00
295D8A9D1E92ECDE001F7C06 /* Post.m in Sources */,
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2AD1E92843A00197586 /* IncrementAnnouncer.swift in Sources */,
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
2981BA391DB874BB00A987F9 /* WorkingRangeViewController.swift in Sources */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D20072B2CB50E0012C5B8 /* CompositionLayoutViewController.swift in Sources */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C629831DCFDB57004A5BB1 /* UserHeaderView.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3AC1D68B0B5001C9451 /* LoadMoreViewController.swift in Sources */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C941DAE9F050073E116 /* NibCell.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F9191D7BADC900B0C58F /* CenterLabelCell.swift in Sources */,
Improve the ObjC demo to reflect best-practices Summary: Couple best practices I want to make sure our examples reflect: - Multiple cells in a section controller - Unique models returned in `objectsForListAdapter:` (no dupes!) - Dynamic item count (`comments` array) Issue fixed: #595 - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/615 Differential Revision: D4852192 Pulled By: jessesquires fbshipit-source-id: f4a89800f90e6b5ea4b6dd7c0d9a78ca5d65082c
2017-04-07 18:20:37 +00:00
295D8A9A1E92EC96001F7C06 /* PostSectionController.m in Sources */,
Example using SwiftUI with compositional layout Summary: Introduces a compositional layout example that leverages section controller methods to determine layout. Differential Revision: D71402637 fbshipit-source-id: 1179abf13157fb5cb78c8a9086718d1216fb4276
2025-03-19 17:14:23 +00:00
4119B2AB2D89BB1E00D397BC /* ActivityItem.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
29628F141D91905A0026B15A /* DetailLabelCell.swift in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01681F9D9CBD0092A320 /* ReorderableSectionController.swift in Sources */,
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B751E49B33C0026DB39 /* InteractiveCell.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F9301D7BC0E400B0C58F /* EmptyViewController.swift in Sources */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289A9202A1507007E17D5 /* PersonSectionController.m in Sources */,
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2AF1E92858500197586 /* ListeningSectionController.swift in Sources */,
Added support UICollectionElementKindSectionFooter for IGListCollectionViewLayout Summary: **Changes occurred only for the IGListCollectionViewLayout.** **Specifically:** 1. Harnessed the hardcore to the fact that it is possible to use only headers. 2. Assertions removed 3. Caching for layout of attributes of footers 4. Implemented the location of the footers in any orientation scroll Issue fixed: #898 I need this enhancement ASAP 🙏 **Example:** Footers with user comments count ![simulator screen shot - iphone 6 - 2017-11-14 at 13 35 22](https://user-images.githubusercontent.com/7735730/32775551-c69868cc-c940-11e7-8307-ae2e353519ff.png) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] I updated example project with implemented feature Closes https://github.com/Instagram/IGListKit/pull/1017 Reviewed By: jeremycohen Differential Revision: D6385893 Pulled By: rnystrom fbshipit-source-id: 5f1bad5655d2df321f8c71496aa797ac8e3d226a
2017-11-21 20:39:09 +00:00
FF73FF9C1FBA4B4400F2AB06 /* UserFooterView.swift in Sources */,
Add display delegate example Summary: Adds a new example. Fixes #159 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/194 Differential Revision: D4172780 Pulled By: rnystrom fbshipit-source-id: 34e1eaef03bb6564445f30dc2fe2b015bb276b6a
2016-11-12 17:18:29 +00:00
29D2E4AD1DD69B6000CD255D /* DisplaySectionController.swift in Sources */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289A6202A14E1007E17D5 /* ObjcGeneratedModelDemoViewController.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F91E1D7BB30C00B0C58F /* User.swift in Sources */,
2991F9241D7BB89F00B0C58F /* NestedAdapterViewController.swift in Sources */,
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DFF4D06251F08F50048474A /* UIActivityIndicatorView+Extension.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B38E1D68B031001C9451 /* AppDelegate.swift in Sources */,
2942FF941D9F39E00015D24B /* UserSectionController.swift in Sources */,
Add diffing example Summary: Adding an example of how to use diffing by itself w/ `UITableView` batch updates. Reviewed By: jessesquires Differential Revision: D4077768 fbshipit-source-id: 313193cdcadd337e08f74e90713fa127a5365112
2016-10-26 18:47:10 +00:00
29459C001DBE48E200F05375 /* DiffTableViewController.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F92C1D7BBE5400B0C58F /* RemoveCell.swift in Sources */,
2942FF8D1D9F39E00015D24B /* EmbeddedSectionController.swift in Sources */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297B1DCFD857004A5BB1 /* SupplementaryViewController.swift in Sources */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7551DD2150600206780 /* SelfSizingSectionController.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2991F9281D7BB9EC00B0C58F /* EmbeddedCollectionViewCell.swift in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF016A1F9D9F600092A320 /* ReorderableViewController.swift in Sources */,
add grid to UICollectionViewCompositionalLayout example Summary: Adding a grid Differential Revision: D52260530 fbshipit-source-id: 82e0ef4c1b0cad4a95e0c802d783d7c3f44c5f3b
2023-12-19 15:17:30 +00:00
576D20142B2CF15C0012C5B8 /* GridItem.swift in Sources */,
add horizontal row to UICollectionViewCompositionalLayout example Summary: Lets go even beyond the `MixedDataViewController` example by taking advantage of `orthogonalScrollingBehavior`. Really neat! Differential Revision: D52260531 fbshipit-source-id: aee8b38a38284104fa65ba8d33426a9e6216e503
2023-12-19 15:17:30 +00:00
576D20182B2CF24F0012C5B8 /* HorizontalComposableSectionController.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF8F1D9F39E00015D24B /* GridSectionController.swift in Sources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4B81DB8B48300172ED0 /* StoryboardCell.swift in Sources */,
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B781E49B3A50026DB39 /* PhotoCell.m in Sources */,
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D201A2B2CF82C0012C5B8 /* SwipeActionSection.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF921D9F39E00015D24B /* RemoveSectionController.swift in Sources */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8E1DAE9D3F0073E116 /* SingleSectionViewController.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3AD1D68B0B5001C9451 /* LabelCell.swift in Sources */,
2942FF901D9F39E00015D24B /* HorizontalSectionController.swift in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658641E74A2550041B56D /* MonthSectionController.swift in Sources */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200E2B2CE9EC0012C5B8 /* ExpandableComposableSectionController.swift in Sources */,
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
2981BA371DB869FF00A987F9 /* WorkingRangeSectionController.swift in Sources */,
Add IGListDiffable remodel plugin source + documentation (a new guide) Summary: Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`. - [x] All tests pass. Demo project builds and runs. (source untouched, purely additive) - [x] I added remodel plugin tests + and a new guide explaining the installation + usage - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1083 Reviewed By: rnystrom Differential Revision: D6937925 Pulled By: calimarkus fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
2018-02-09 17:50:18 +00:00
EB0289A2202A11E0007E17D5 /* PersonModel.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658601E74A19F0041B56D /* DayViewModel.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2961B3AB1D68B0B5001C9451 /* DemosViewController.swift in Sources */,
add user to UICollectionViewCompositionalLayout example Summary: Adding user cell Differential Revision: D52260532 fbshipit-source-id: ec3f4f5a70d02e0c6db713ade51938413cb5ee8a
2023-12-19 15:17:30 +00:00
576D20122B2CF04F0012C5B8 /* UserComposableSectionController.swift in Sources */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD75D1DD21ADA00206780 /* SelectionModel.swift in Sources */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297D1DCFD8E5004A5BB1 /* FeedItem.swift in Sources */,
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B6C1E49B2E80026DB39 /* UserInfoCell.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926586A1E74AEFE0041B56D /* MonthTitleCell.swift in Sources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4B61DB8B3DC00172ED0 /* StoryboardViewController.swift in Sources */,
Example using self sizing cells Summary: Adding an example using self sizing cells (`estimatedSize` API of `UICollectionViewFlowLayout`) both in code and from cells in nibs. I assume cells in storyboards would follow the same AL design patterns as nibs, so I left out storyboards. ![simulator screen shot nov 8 2016 11 55 04 am](https://cloud.githubusercontent.com/assets/739696/20108568/7b37ba8c-a5aa-11e6-8323-4ee218e023f3.png) Fixes #149 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/176 Differential Revision: D4156409 Pulled By: rnystrom fbshipit-source-id: b0b6d0cc8f4a575ff9963d66bc0df605843d47fe
2016-11-09 23:16:19 +00:00
296DD7571DD2163800206780 /* ManuallySelfSizingCell.swift in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658571E749EDC0041B56D /* CalendarViewController.swift in Sources */,
Add supplementary source example Summary: Got around to adding a supplementary view source example. Fixes #153 #163 ![img_0197](https://cloud.githubusercontent.com/assets/739696/20042159/03d2489e-a443-11e6-8d60-895256b56273.PNG) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/169 Differential Revision: D4139910 Pulled By: rnystrom fbshipit-source-id: 846c61c4d097392f18778d46044d4989e6bdf183
2016-11-07 14:37:37 +00:00
29C6297F1DCFD9E9004A5BB1 /* FeedItemSectionController.swift in Sources */,
add swipe action to UICollectionViewCompositionalLayout example Summary: Lets add swipe to delete. Differential Revision: D52262785 fbshipit-source-id: b95cdee116374c561967dd585d02110a4d877e16
2023-12-19 15:17:30 +00:00
576D20092B2CB6C20012C5B8 /* SwipeActionComposabelSectionController.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
2942FF8E1D9F39E00015D24B /* ExpandableSectionController.swift in Sources */,
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
29F7E2AA1E9283FF00197586 /* AnnouncingDepsViewController.swift in Sources */,
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DB684E1251B10C2002023DD /* UIColor+Extension.swift in Sources */,
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
56C05B721E49B32A0026DB39 /* CommentCell.m in Sources */,
create UICollectionViewCompositionalLayout example Summary: Lets try using `UICollectionViewCompositionalLayout` with IGListKit! It does require some data plumbing, but maybe we can make that simpler in the future. For now, lets keep things simple and see how it feels. This diff replicates the `MixedDataViewController` example starting with the expandable text. Differential Revision: D52260529 fbshipit-source-id: 5579b8d6fe5d1f95ed282f821e6555a6a56b1c1c
2023-12-19 15:17:30 +00:00
576D200B2B2CC6DF0012C5B8 /* CompositionLayoutCell.swift in Sources */,
Example using SwiftUI with compositional layout Summary: Introduces a compositional layout example that leverages section controller methods to determine layout. Differential Revision: D71402637 fbshipit-source-id: 1179abf13157fb5cb78c8a9086718d1216fb4276
2025-03-19 17:14:23 +00:00
41A162952D8A0C82002A5A8F /* SelectionComposableSectionController.swift in Sources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4BA1DB8B61200172ED0 /* StoryboardLabelSectionController.swift in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F90D1DE5006B00A64FEE /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
9518E3C51DED057E0008CC46 /* LoadMoreViewControllerUITests.swift in Sources */,
9518E3CB1DED27840008CC46 /* DemosViewControllerUITests.swift in Sources */,
9518E3C91DED1BCB0008CC46 /* MixedDataViewControllerUITests.swift in Sources */,
9518E3C71DED18370008CC46 /* SearchViewControllerUITests.swift in Sources */,
9518E3C31DED03520008CC46 /* UITestCase.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB70D1DBBA60900A65C18 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
986FB7281DBBA9B200A65C18 /* LabelSectionController.swift in Sources */,
986FB7291DBBA9C900A65C18 /* LabelCell.swift in Sources */,
986FB7161DBBA60900A65C18 /* MessagesViewController.swift in Sources */,
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DFF4CFB251F089E0048474A /* UIColor+Extension.swift in Sources */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
986FB72B1DBBAD8600A65C18 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
986FB7401DBBAEA600A65C18 /* LabelSectionController.swift in Sources */,
986FB7411DBBAEA900A65C18 /* LabelCell.swift in Sources */,
986FB7341DBBAD8600A65C18 /* TodayViewController.swift in Sources */,
Adapts to dark mode for iOS example project. (#1453) Summary: ## Changes in this pull request ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1453 Reviewed By: lorixx Differential Revision: D23836038 Pulled By: joetam fbshipit-source-id: 8245415992a5b1ed49f67ebfcf9f85a2745a8042
2020-10-03 08:37:52 +00:00
9DFF4D00251F089F0048474A /* UIColor+Extension.swift in Sources */,
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXSourcesBuildPhase section */
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
/* Begin PBXTargetDependency section */
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9171DE5006C00A64FEE /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 2961B3891D68B031001C9451 /* IGListKitExamples */;
targetProxy = 95F7F9161DE5006C00A64FEE /* PBXContainerItemProxy */;
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB71E1DBBA60900A65C18 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
platformFilter = ios;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
target = 986FB7101DBBA60900A65C18 /* IGListKitMessageExample */;
targetProxy = 986FB71D1DBBA60900A65C18 /* PBXContainerItemProxy */;
};
986FB73A1DBBAD8600A65C18 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
platformFilter = ios;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
target = 986FB72E1DBBAD8600A65C18 /* IGListKitTodayExample */;
targetProxy = 986FB7391DBBAD8600A65C18 /* PBXContainerItemProxy */;
};
/* End PBXTargetDependency section */
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* Begin PBXVariantGroup section */
2961B3961D68B031001C9451 /* LaunchScreen.storyboard */ = {
isa = PBXVariantGroup;
children = (
2961B3971D68B031001C9451 /* Base */,
);
name = LaunchScreen.storyboard;
sourceTree = "<group>";
};
/* End PBXVariantGroup section */
/* Begin XCBuildConfiguration section */
2961B39A1D68B031001C9451 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_NONNULL = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_BOOL_CONVERSION = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_COMMA = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_CONSTANT_CONVERSION = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
COPY_PHASE_STRIP = NO;
DEBUG_INFORMATION_FORMAT = dwarf;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
ENABLE_USER_SCRIPT_SANDBOXING = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_DYNAMIC_NO_PIC = NO;
GCC_NO_COMMON_BLOCKS = YES;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PREPROCESSOR_DEFINITIONS = (
"DEBUG=1",
"$(inherited)",
);
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
};
name = Debug;
};
2961B39B1D68B031001C9451 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_NONNULL = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_BOOL_CONVERSION = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_COMMA = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_CONSTANT_CONVERSION = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
COPY_PHASE_STRIP = NO;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
ENABLE_USER_SCRIPT_SANDBOXING = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_NO_COMMON_BLOCKS = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
VALIDATE_PRODUCT = YES;
};
name = Release;
};
2961B39D1D68B031001C9451 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
Fixed issue with Podfile in Example project Summary: Fixed issue with Podfile in Example project #152 Closes https://github.com/Instagram/IGListKit/pull/155 Differential Revision: D4124632 Pulled By: rnystrom fbshipit-source-id: 9f825c500e776fe3a4cb8aad2ef6106bc3d76729
2016-11-03 15:38:42 +00:00
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = "$(inherited)";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
CLANG_ENABLE_MODULES = YES;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
CODE_SIGN_ENTITLEMENTS = IGListKitExamples/IGListKitExamples.entitlements;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_STYLE = Automatic;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
DEVELOPMENT_TEAM = "";
INFOPLIST_FILE = IGListKitExamples/Info.plist;
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 16.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitExamples;
PRODUCT_NAME = "$(TARGET_NAME)";
Update swiftlint + script, add newrules, autocorrect Summary: - Updates to SwiftLint 0.24.2 - Improve `scripts/lint.sh` - pull version out to a var for easier maintenance - better error message - make script fail xcode build if not installed (so we don't commit lint errors) - Adds a few new SwiftLint rules - Correct all new lint errors (most can be done by running `swiftlint autocorrect`) - Cleans up `.swiftlint.yml` - Fix up example projects Closes https://github.com/Instagram/IGListKit/pull/1058 Differential Revision: D6776177 Pulled By: rnystrom fbshipit-source-id: 345172237b97aaed0d62312c8f366f46145f8cd9
2018-01-22 20:01:53 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
SUPPORTS_MACCATALYST = YES;
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
SWIFT_OBJC_BRIDGING_HEADER = "IGListKitExamples/ViewControllers/IGListKitExamples-Bridging-Header.h";
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
TARGETED_DEVICE_FAMILY = "1,2";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
name = Debug;
};
2961B39E1D68B031001C9451 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
Fixed issue with Podfile in Example project Summary: Fixed issue with Podfile in Example project #152 Closes https://github.com/Instagram/IGListKit/pull/155 Differential Revision: D4124632 Pulled By: rnystrom fbshipit-source-id: 9f825c500e776fe3a4cb8aad2ef6106bc3d76729
2016-11-03 15:38:42 +00:00
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = "$(inherited)";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
Working Range example Summary: Adding a working range example to the example app. This example: - Displays a list of images downloaded from unsplash.it - Create 20 uniquely-random sized objects - When section controllers enter the range, create a data task to download the image - When finished, store image in `downloadedImage` - Set in cell if cell is visible - Don't create task if already downloaded or task created - Cancel task when section controller is destroyed - Show a spinner cell while downloading the image Fixes #84 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/89 Differential Revision: D4050210 Pulled By: rnystrom fbshipit-source-id: 628a777fa819dccd9d9f4f58646cdf72fb4bc65c
2016-10-20 06:26:07 +00:00
CLANG_ENABLE_MODULES = YES;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
CODE_SIGN_ENTITLEMENTS = IGListKitExamples/IGListKitExamples.entitlements;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_STYLE = Automatic;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
DEVELOPMENT_TEAM = "";
INFOPLIST_FILE = IGListKitExamples/Info.plist;
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 16.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitExamples;
PRODUCT_NAME = "$(TARGET_NAME)";
Update swiftlint + script, add newrules, autocorrect Summary: - Updates to SwiftLint 0.24.2 - Improve `scripts/lint.sh` - pull version out to a var for easier maintenance - better error message - make script fail xcode build if not installed (so we don't commit lint errors) - Adds a few new SwiftLint rules - Correct all new lint errors (most can be done by running `swiftlint autocorrect`) - Cleans up `.swiftlint.yml` - Fix up example projects Closes https://github.com/Instagram/IGListKit/pull/1058 Differential Revision: D6776177 Pulled By: rnystrom fbshipit-source-id: 345172237b97aaed0d62312c8f366f46145f8cd9
2018-01-22 20:01:53 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
SUPPORTS_MACCATALYST = YES;
Add Example-iOS in ObjC Summary: Related issue: [#425](https://github.com/Instagram/IGListKit/issues/425) - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/446 Differential Revision: D4589989 Pulled By: rnystrom fbshipit-source-id: df91f10e0896dfe2f39a643f68e7ebd91e8461cb
2017-02-21 00:11:56 +00:00
SWIFT_OBJC_BRIDGING_HEADER = "IGListKitExamples/ViewControllers/IGListKitExamples-Bridging-Header.h";
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
TARGETED_DEVICE_FAMILY = "1,2";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
name = Release;
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F9181DE5006C00A64FEE /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_STYLE = Automatic;
project organization, 'sort by name' Summary: Closes https://github.com/Instagram/IGListKit/pull/271 Differential Revision: D4259848 Pulled By: jessesquires fbshipit-source-id: 4a7a1159bbb335b88243e4fbc7bf62c54ce7b6dc
2016-12-01 19:56:11 +00:00
DEVELOPMENT_TEAM = "";
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
INFOPLIST_FILE = "IGListKitExamples-UITests/Info.plist";
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
PRODUCT_BUNDLE_IDENTIFIER = "com.instagram.IGListKitExamples-UITests";
PRODUCT_NAME = "$(TARGET_NAME)";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
TEST_TARGET_NAME = IGListKitExamples;
};
name = Debug;
};
95F7F9191DE5006C00A64FEE /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_STYLE = Automatic;
project organization, 'sort by name' Summary: Closes https://github.com/Instagram/IGListKit/pull/271 Differential Revision: D4259848 Pulled By: jessesquires fbshipit-source-id: 4a7a1159bbb335b88243e4fbc7bf62c54ce7b6dc
2016-12-01 19:56:11 +00:00
DEVELOPMENT_TEAM = "";
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
INFOPLIST_FILE = "IGListKitExamples-UITests/Info.plist";
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
PRODUCT_BUNDLE_IDENTIFIER = "com.instagram.IGListKitExamples-UITests";
PRODUCT_NAME = "$(TARGET_NAME)";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
TEST_TARGET_NAME = IGListKitExamples;
};
name = Release;
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7201DBBA60900A65C18 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = "iMessage App Icon";
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
DEVELOPMENT_TEAM = "";
INFOPLIST_FILE = "$(SRCROOT)/IGListKitMessageExample/Info.plist";
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitExamples.IGListKitMessageExample;
PRODUCT_NAME = "$(TARGET_NAME)";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
SKIP_INSTALL = YES;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
SUPPORTS_MACCATALYST = NO;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
};
name = Debug;
};
986FB7211DBBA60900A65C18 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = "iMessage App Icon";
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
DEVELOPMENT_TEAM = "";
INFOPLIST_FILE = "$(SRCROOT)/IGListKitMessageExample/Info.plist";
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitExamples.IGListKitMessageExample;
PRODUCT_NAME = "$(TARGET_NAME)";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
SKIP_INSTALL = YES;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
SUPPORTS_MACCATALYST = NO;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
};
name = Release;
};
986FB73D1DBBAD8600A65C18 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
DEVELOPMENT_TEAM = "";
INFOPLIST_FILE = IGListKitTodayExample/Info.plist;
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitExamples.IGListKitTodayExample;
PRODUCT_NAME = "$(TARGET_NAME)";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
SKIP_INSTALL = YES;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
SUPPORTS_MACCATALYST = NO;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
};
name = Debug;
};
986FB73E1DBBAD8600A65C18 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
DEVELOPMENT_TEAM = "";
INFOPLIST_FILE = IGListKitTodayExample/Info.plist;
Polish Demos view controller Summary: Adds additional polish and refinement to the initial Demos view controller. * Adds SF Symbols to each section. * Correctly selects and deselects cells when in and out split view mode. * Fixes demo table view cell to adapt to safe area insets correctly. Reviewed By: fabiomassimo Differential Revision: D45686668 fbshipit-source-id: 5e24120a0aab5cb3fb9c33b0b0d7c087a56d6304
2023-07-20 05:08:21 +00:00
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
"@executable_path/../../Frameworks",
);
Update all example apps and related schemes for Xcode 15 Summary: Updates the iOS, macOS and tvOS example apps Xcode projects to be based off Xcode 15 with all appropriate new build configurations. Reviewed By: fethica Differential Revision: D50294914 fbshipit-source-id: b6b292ec53e4ab9f336c23e81af3fc6815881398
2023-10-14 05:50:38 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.13;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitExamples.IGListKitTodayExample;
PRODUCT_NAME = "$(TARGET_NAME)";
Add split mode to iPad Summary: Updates the sample iOS app with `UISplitViewController` to enable split view functionality on iPad, and larger screen iPhones. Reviewed By: fabiomassimo Differential Revision: D45687142 fbshipit-source-id: 171cf7f3306b64db92216dded5c129fa15fd97b3
2023-07-20 05:08:21 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
SKIP_INSTALL = YES;
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
SUPPORTS_MACCATALYST = NO;
Update example project files, convert to Swift 4, and fix errors Summary: Used migration tool with Swift 4, fixed build errors, and killed all warnings. Only non-trivial change was in the macOS example. Will flag that one. No changelog needed for this, right? - [x] All tests pass. Demo project builds and runs. Closes https://github.com/Instagram/IGListKit/pull/941 Differential Revision: D5890505 Pulled By: rnystrom fbshipit-source-id: 7e0d3510ff0e5856a0ffd59f1a97548a72266c20
2017-09-22 13:34:52 +00:00
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
Update examples and tests to Swift 5 Summary: Swift 5 came out a while ago, we should definitely be targeting it. Reviewed By: lorixx Differential Revision: D19141252 fbshipit-source-id: d6f8fc5209e721a8b28e569855b5e3cc8b8c3431
2019-12-19 05:50:02 +00:00
SWIFT_VERSION = 5.0;
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
};
name = Release;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End XCBuildConfiguration section */
/* Begin XCConfigurationList section */
2961B3851D68B031001C9451 /* Build configuration list for PBXProject "IGListKitExamples" */ = {
isa = XCConfigurationList;
buildConfigurations = (
2961B39A1D68B031001C9451 /* Debug */,
2961B39B1D68B031001C9451 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
2961B39C1D68B031001C9451 /* Build configuration list for PBXNativeTarget "IGListKitExamples" */ = {
isa = XCConfigurationList;
buildConfigurations = (
2961B39D1D68B031001C9451 /* Debug */,
2961B39E1D68B031001C9451 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
95F7F91A1DE5006C00A64FEE /* Build configuration list for PBXNativeTarget "IGListKitExamples-UITests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
95F7F9181DE5006C00A64FEE /* Debug */,
95F7F9191DE5006C00A64FEE /* Release */,
);
defaultConfigurationIsVisible = 0;
project organization, 'sort by name' Summary: Closes https://github.com/Instagram/IGListKit/pull/271 Differential Revision: D4259848 Pulled By: jessesquires fbshipit-source-id: 4a7a1159bbb335b88243e4fbc7bf62c54ce7b6dc
2016-12-01 19:56:11 +00:00
defaultConfigurationName = Release;
Add UI Testing to Examples-iOS app Summary: Add basic UI Testing to Examples-iOS app. It doesn't cover all the examples yet, but Xcode is reporting ~82% of coverage. Updated travis.yml to run the UI Tests for only one of the matrix jobs - "OS=10.0,name=iPhone 6s", to try to keep the build times acceptable. Last job took ~3 min for the UI Testing section (being the whole build usually around 40 min). Was feeling like playing a bit with UI Testing and took the chance to use it here, since rnystrom [showed interest in having it](https://github.com/Instagram/IGListKit/pull/251#issuecomment-262375087). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/268 Differential Revision: D4259177 Pulled By: jessesquires fbshipit-source-id: 77fdaf8588e090e4b13836a127d9f6d838248163
2016-12-01 18:28:57 +00:00
};
Added example schemes for Today/iMessage extensions Summary: Offering this open to a bit of a discussion based on the comments at #77. - Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension. - Updated the Podfile to ensure they have IGListKit as a dependency - Added a super simple example reusing the `LabelSectionController` from the main app Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary! - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/112 Differential Revision: D4066698 Pulled By: rnystrom fbshipit-source-id: 64c5cc6f34cc9107f4f6e52ebc57596101eb695c
2016-11-01 14:48:28 +00:00
986FB7221DBBA60900A65C18 /* Build configuration list for PBXNativeTarget "IGListKitMessageExample" */ = {
isa = XCConfigurationList;
buildConfigurations = (
986FB7201DBBA60900A65C18 /* Debug */,
986FB7211DBBA60900A65C18 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
986FB73C1DBBAD8600A65C18 /* Build configuration list for PBXNativeTarget "IGListKitTodayExample" */ = {
isa = XCConfigurationList;
buildConfigurations = (
986FB73D1DBBAD8600A65C18 /* Debug */,
986FB73E1DBBAD8600A65C18 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End XCConfigurationList section */
Improve SwiftPM support (#1546) Summary: This diff imports and refines the PR made by cntrump on GitHub. The PR introduces the following: * Sample apps now use SPM instead of CocoaPods to import IGListKit. * Adds Mac Catalyst as an example target. * Adds C++ flags to the CocoaPods specs. * Fixes a script issue that was discovered when regenerating the symlinks. The PR originally aimed to remove the need for symlinked references to the IGListKit and IGListDiffKit source files, but in testing, I couldn't get it working. It's possible SPM being too strict [on where the headers can be placed to be discovered](https://forums.swift.org/t/how-do-i-specify-the-headers-directory-for-a-objc-target-in-swift-package-managers-package-swift/58531/3). Additionally, another issue was that the original PR changed all of the `#import` statements to the the modular `import` statements, which is fine for the sample apps, but ended up breaking compatibility for any apps that had modules disabled. ## Changes in this pull request Improve SwiftPM support: Build module `IGListDiffKit` and `IGListKit` as Objective-C++. module `IGListDiffKit`: - Source/IGListDiffKit - module defined in `Source/IGListDiffKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListKit`: - depend on `IGListDiffKit`, use `import IGListDiffKit;` - Source/IGListKit - module defined in `Source/IGListKit/modulemap/module.modulemap` - requires `-fmodules` and `-fcxx-modules` module `IGListSwiftKit`: - depend on `IGListKit`, use `import IGListKit` - Source/IGListSwiftKit Deleted `spm/` and `scripts/generate_spm_sources_layout.sh`, it is unnecessary. Updated `.podspec`, add `'OTHER_CFLAGS' => '-fmodules'` and `'OTHER_CPLUSPLUSFLAGS' => '-fcxx-modules'`. Add missing swift files for `IGListSwiftKit` in `IGListKit.xcodeproj` ### How to use Replace `#import <IGListDiffKit/IGListDiffKit.h>` with `import IGListDiffKit;`, because `IGListDiffKit.h` isn't exist in `modulemap/`, Or create a symbol link by `ln -sf ../IGListDiffKit.h` for support it ? ### Examples Use SwiftPM for building examples. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1546 Test Plan: Test PR showing running tests: https://github.com/TimOliver/IGListKit/actions/runs/4339956050/jobs/7578047058 Reviewed By: lorixx Differential Revision: D33592395 Pulled By: TimOliver fbshipit-source-id: 8f7b1873f2b1c6a80908bb55b123e31bea13bb0c
2023-03-07 07:29:41 +00:00
/* Begin XCSwiftPackageProductDependency section */
BAB336E32760ECC1007B4098 /* IGListDiffKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListDiffKit;
};
BAB336E52760ECC1007B4098 /* IGListKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListKit;
};
BAB336E72760ECC1007B4098 /* IGListSwiftKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListSwiftKit;
};
BAB336E92760ECE5007B4098 /* IGListKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListKit;
};
BAB336EB2760ECFE007B4098 /* IGListKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListKit;
};
BAB336ED2760ED0C007B4098 /* IGListSwiftKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListSwiftKit;
};
BAB336EF2760ED28007B4098 /* IGListDiffKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListDiffKit;
};
BAB336F12760ED55007B4098 /* IGListDiffKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListDiffKit;
};
BAB336F32760EDCB007B4098 /* IGListSwiftKit */ = {
isa = XCSwiftPackageProductDependency;
productName = IGListSwiftKit;
};
/* End XCSwiftPackageProductDependency section */
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
rootObject = 2961B3821D68B031001C9451 /* Project object */;
}
Reference in a new issue Copy permalink