Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-22 16:58:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
IGListKit/IGListKit.xcodeproj/project.pbxproj

2449 lines
194 KiB
Text
Raw Normal View History

Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
// !$*UTF8*$!
{
archiveVersion = 1;
classes = {
};
objectVersion = 46;
objects = {
/* Begin PBXBuildFile section */
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92DA1E08D7F5008390ED /* IGListKit.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B928B1E08D7F5008390ED /* IGListKit.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92DB1E08D7F5008390ED /* IGListKit.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B928B1E08D7F5008390ED /* IGListKit.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92F61E08D7F5008390ED /* IGListAdapter.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929A1E08D7F5008390ED /* IGListAdapter.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92F71E08D7F5008390ED /* IGListAdapter.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929A1E08D7F5008390ED /* IGListAdapter.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92F81E08D7F5008390ED /* IGListAdapter.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B929B1E08D7F5008390ED /* IGListAdapter.m */; };
0B3B92F91E08D7F5008390ED /* IGListAdapter.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B929B1E08D7F5008390ED /* IGListAdapter.m */; };
0B3B92FA1E08D7F5008390ED /* IGListAdapterDataSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929C1E08D7F5008390ED /* IGListAdapterDataSource.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92FB1E08D7F5008390ED /* IGListAdapterDataSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929C1E08D7F5008390ED /* IGListAdapterDataSource.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92FC1E08D7F5008390ED /* IGListAdapterDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929D1E08D7F5008390ED /* IGListAdapterDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92FD1E08D7F5008390ED /* IGListAdapterDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929D1E08D7F5008390ED /* IGListAdapterDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92FE1E08D7F5008390ED /* IGListAdapterUpdater.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929E1E08D7F5008390ED /* IGListAdapterUpdater.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B92FF1E08D7F5008390ED /* IGListAdapterUpdater.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B929E1E08D7F5008390ED /* IGListAdapterUpdater.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93001E08D7F5008390ED /* IGListAdapterUpdater.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B929F1E08D7F5008390ED /* IGListAdapterUpdater.m */; };
0B3B93011E08D7F5008390ED /* IGListAdapterUpdater.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B929F1E08D7F5008390ED /* IGListAdapterUpdater.m */; };
0B3B93021E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A01E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93031E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A01E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93041E08D7F5008390ED /* IGListCollectionContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A11E08D7F5008390ED /* IGListCollectionContext.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93051E08D7F5008390ED /* IGListCollectionContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A11E08D7F5008390ED /* IGListCollectionContext.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B930A1E08D7F5008390ED /* IGListDisplayDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A41E08D7F5008390ED /* IGListDisplayDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B930B1E08D7F5008390ED /* IGListDisplayDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A41E08D7F5008390ED /* IGListDisplayDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93101E08D7F5008390ED /* IGListReloadDataUpdater.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A71E08D7F5008390ED /* IGListReloadDataUpdater.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93111E08D7F5008390ED /* IGListReloadDataUpdater.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A71E08D7F5008390ED /* IGListReloadDataUpdater.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93121E08D7F5008390ED /* IGListReloadDataUpdater.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92A81E08D7F5008390ED /* IGListReloadDataUpdater.m */; };
0B3B93131E08D7F5008390ED /* IGListReloadDataUpdater.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92A81E08D7F5008390ED /* IGListReloadDataUpdater.m */; };
0B3B93141E08D7F5008390ED /* IGListScrollDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A91E08D7F5008390ED /* IGListScrollDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93151E08D7F5008390ED /* IGListScrollDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92A91E08D7F5008390ED /* IGListScrollDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93161E08D7F5008390ED /* IGListSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92AA1E08D7F5008390ED /* IGListSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93171E08D7F5008390ED /* IGListSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92AA1E08D7F5008390ED /* IGListSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93181E08D7F5008390ED /* IGListSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92AB1E08D7F5008390ED /* IGListSectionController.m */; };
0B3B93191E08D7F5008390ED /* IGListSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92AB1E08D7F5008390ED /* IGListSectionController.m */; };
0B3B931C1E08D7F5008390ED /* IGListSingleSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92AD1E08D7F5008390ED /* IGListSingleSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B931D1E08D7F5008390ED /* IGListSingleSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92AD1E08D7F5008390ED /* IGListSingleSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B931E1E08D7F5008390ED /* IGListSingleSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92AE1E08D7F5008390ED /* IGListSingleSectionController.m */; };
0B3B931F1E08D7F5008390ED /* IGListSingleSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92AE1E08D7F5008390ED /* IGListSingleSectionController.m */; };
0B3B93201E08D7F5008390ED /* IGListStackedSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92AF1E08D7F5008390ED /* IGListStackedSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93211E08D7F5008390ED /* IGListStackedSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92AF1E08D7F5008390ED /* IGListStackedSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93221E08D7F5008390ED /* IGListStackedSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92B01E08D7F5008390ED /* IGListStackedSectionController.m */; };
0B3B93231E08D7F5008390ED /* IGListStackedSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92B01E08D7F5008390ED /* IGListStackedSectionController.m */; };
0B3B93241E08D7F5008390ED /* IGListSupplementaryViewSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B11E08D7F5008390ED /* IGListSupplementaryViewSource.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93251E08D7F5008390ED /* IGListSupplementaryViewSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B11E08D7F5008390ED /* IGListSupplementaryViewSource.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93261E08D7F5008390ED /* IGListUpdatingDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B21E08D7F5008390ED /* IGListUpdatingDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93271E08D7F5008390ED /* IGListUpdatingDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B21E08D7F5008390ED /* IGListUpdatingDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93281E08D7F5008390ED /* IGListWorkingRangeDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B31E08D7F5008390ED /* IGListWorkingRangeDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B93291E08D7F5008390ED /* IGListWorkingRangeDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B31E08D7F5008390ED /* IGListWorkingRangeDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
0B3B932C1E08D7F5008390ED /* IGListAdapterInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B61E08D7F5008390ED /* IGListAdapterInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B932D1E08D7F5008390ED /* IGListAdapterInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B61E08D7F5008390ED /* IGListAdapterInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B932E1E08D7F5008390ED /* IGListAdapterProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B71E08D7F5008390ED /* IGListAdapterProxy.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B932F1E08D7F5008390ED /* IGListAdapterProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B71E08D7F5008390ED /* IGListAdapterProxy.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93301E08D7F5008390ED /* IGListAdapterProxy.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92B81E08D7F5008390ED /* IGListAdapterProxy.m */; };
0B3B93311E08D7F5008390ED /* IGListAdapterProxy.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92B81E08D7F5008390ED /* IGListAdapterProxy.m */; };
0B3B93321E08D7F5008390ED /* IGListAdapterUpdaterInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B91E08D7F5008390ED /* IGListAdapterUpdaterInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93331E08D7F5008390ED /* IGListAdapterUpdaterInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92B91E08D7F5008390ED /* IGListAdapterUpdaterInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93341E08D7F5008390ED /* IGListDisplayHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BA1E08D7F5008390ED /* IGListDisplayHandler.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93351E08D7F5008390ED /* IGListDisplayHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BA1E08D7F5008390ED /* IGListDisplayHandler.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93361E08D7F5008390ED /* IGListDisplayHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92BB1E08D7F5008390ED /* IGListDisplayHandler.m */; };
0B3B93371E08D7F5008390ED /* IGListDisplayHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92BB1E08D7F5008390ED /* IGListDisplayHandler.m */; };
0B3B93381E08D7F5008390ED /* IGListSectionControllerInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BC1E08D7F5008390ED /* IGListSectionControllerInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93391E08D7F5008390ED /* IGListSectionControllerInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BC1E08D7F5008390ED /* IGListSectionControllerInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B933A1E08D7F5008390ED /* IGListSectionMap.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BD1E08D7F5008390ED /* IGListSectionMap.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B933B1E08D7F5008390ED /* IGListSectionMap.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BD1E08D7F5008390ED /* IGListSectionMap.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B933C1E08D7F5008390ED /* IGListSectionMap.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92BE1E08D7F5008390ED /* IGListSectionMap.m */; };
0B3B933D1E08D7F5008390ED /* IGListSectionMap.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92BE1E08D7F5008390ED /* IGListSectionMap.m */; };
0B3B933E1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BF1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B933F1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92BF1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93401E08D7F5008390ED /* IGListWorkingRangeHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92C01E08D7F5008390ED /* IGListWorkingRangeHandler.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93411E08D7F5008390ED /* IGListWorkingRangeHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92C01E08D7F5008390ED /* IGListWorkingRangeHandler.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93421E08D7F5008390ED /* IGListWorkingRangeHandler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92C11E08D7F5008390ED /* IGListWorkingRangeHandler.mm */; };
0B3B93431E08D7F5008390ED /* IGListWorkingRangeHandler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92C11E08D7F5008390ED /* IGListWorkingRangeHandler.mm */; };
0B3B93441E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92C21E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93451E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B92C21E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h */; settings = {ATTRIBUTES = (Private, ); }; };
0B3B93461E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92C31E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m */; };
0B3B93471E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m in Sources */ = {isa = PBXBuildFile; fileRef = 0B3B92C31E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m */; };
0B3B93611E08E38C008390ED /* IGListBatchUpdateDataTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE51D870EDC007C7F66 /* IGListBatchUpdateDataTests.m */; };
run pod install everywhere, gen docs. Summary: - Project fixes for macOS support, #270 - Podspec fixes for macOS, #270 - Project test target fixes - Pod install all examples - Re-gen docs Differential Revision: D4327169 fbshipit-source-id: bbe7896f8f50aaf3b8da03d0c21a0fb6f775c7cd
2016-12-14 22:39:01 +00:00
0B40C5F31E01CB8200378109 /* IGReloadDataUpdaterTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 2997D4961DF5FC0B005A5DD2 /* IGReloadDataUpdaterTests.m */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
0D52F0AD1F1ADA1600460F79 /* IGListAdapter+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 0D52F0AB1F1ADA1600460F79 /* IGListAdapter+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0AE1F1ADA1600460F79 /* IGListAdapter+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 0D52F0AC1F1ADA1600460F79 /* IGListAdapter+DebugDescription.m */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
0D52F0B41F1AE81800460F79 /* IGListBindingSectionController+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 0D52F0B31F1AE81800460F79 /* IGListBindingSectionController+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0B61F1AE8BD00460F79 /* IGListBindingSectionController+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 0D52F0B51F1AE8BD00460F79 /* IGListBindingSectionController+DebugDescription.m */; };
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01731FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 13DF01721FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m */; };
13DF01741FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 13DF01721FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m */; };
13DF01771FA1000E0092A320 /* IGTestReorderableSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 13DF01761FA1000E0092A320 /* IGTestReorderableSection.m */; };
13DF01781FA1000E0092A320 /* IGTestReorderableSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 13DF01761FA1000E0092A320 /* IGTestReorderableSection.m */; };
13E1028C1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 13E1028B1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m */; };
13E1028D1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 13E1028B1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m */; };
13E102941FA414C400123403 /* IGListReorderableStackSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 13E102921FA414C400123403 /* IGListReorderableStackSectionControllerTests.m */; };
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
1F2984CA1E8039EC005FA211 /* IGListCollectionViewLayoutInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 917E89871E800EE70015F934 /* IGListCollectionViewLayoutInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
262373C2015556E71A70FA30 /* Pods_IGListKit_tvOSTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E980179F5E885E417EB20D55 /* Pods_IGListKit_tvOSTests.framework */; };
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8A1DAE94E40073E116 /* IGTestSingleNibItemDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 26271C891DAE94E40073E116 /* IGTestSingleNibItemDataSource.m */; };
26271C8C1DAE96740073E116 /* IGListSingleNibItemControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 26271C8B1DAE96740073E116 /* IGListSingleNibItemControllerTests.m */; };
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3541E930C89009FE456 /* IGListDebugger.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3521E930C89009FE456 /* IGListDebugger.h */; settings = {ATTRIBUTES = (Private, ); }; };
290DF3551E930C89009FE456 /* IGListDebugger.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3531E930C89009FE456 /* IGListDebugger.m */; };
290DF3581E930CE2009FE456 /* UICollectionView+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3561E930CE2009FE456 /* UICollectionView+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
290DF3591E930CE2009FE456 /* UICollectionView+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3571E930CE2009FE456 /* UICollectionView+DebugDescription.m */; };
290DF3601E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF35E1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
290DF3611E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF35F1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.m */; };
290DF3641E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3621E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
290DF3651E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3631E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.m */; };
290DF3701E931457009FE456 /* IGListSectionMap+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF36E1E931457009FE456 /* IGListSectionMap+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
290DF3711E931457009FE456 /* IGListSectionMap+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF36F1E931457009FE456 /* IGListSectionMap+DebugDescription.m */; };
290DF3741E931B57009FE456 /* IGListDebuggingUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3721E931B57009FE456 /* IGListDebuggingUtilities.h */; settings = {ATTRIBUTES = (Private, ); }; };
290DF3751E931B57009FE456 /* IGListDebuggingUtilities.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3731E931B57009FE456 /* IGListDebuggingUtilities.m */; };
290DF3771E9323E6009FE456 /* IGListDebuggerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3761E9323E6009FE456 /* IGListDebuggerTests.m */; };
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
2914BEE91DCD15F400C96401 /* IGTestNibSupplementaryView.xib in Resources */ = {isa = PBXBuildFile; fileRef = 2904861C1DCD02140007F41D /* IGTestNibSupplementaryView.xib */; };
2914BEEA1DCD15F400C96401 /* IGTestNibSupplementaryView.xib in Resources */ = {isa = PBXBuildFile; fileRef = 2904861C1DCD02140007F41D /* IGTestNibSupplementaryView.xib */; };
Fix examples Summary: Broke in #525 b/c didn't run `pod_install.sh` after adding new files. Issue fixed: #537 Closes https://github.com/Instagram/IGListKit/pull/538 Differential Revision: D4695675 Pulled By: rnystrom fbshipit-source-id: 3edc6e25f545efdc5475035036e25bb0e1b304d3
2017-03-11 21:28:34 +00:00
292658551E7498220041B56D /* IGListKit.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B3B928B1E08D7F5008390ED /* IGListKit.h */; settings = {ATTRIBUTES = (Public, ); }; };
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926586C1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 2926586B1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h */; settings = {ATTRIBUTES = (Public, ); }; };
2926586D1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 2926586B1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h */; settings = {ATTRIBUTES = (Public, ); }; };
2926586F1E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 2926586E1E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
292658701E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 2926586E1E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
292658711E75E2440041B56D /* IGListBatchUpdateState.h in Headers */ = {isa = PBXBuildFile; fileRef = 297278C31E6B59D50099D8EA /* IGListBatchUpdateState.h */; settings = {ATTRIBUTES = (Private, ); }; };
Move section controller mutation API to object provided in update block Summary: We constantly have random bugs pop up when mutations are made outside of a batch update. This change restricts the mutation API to a batch context object (which is just an `IGListAdapter`) so they can only be done **inside an update block**. - Fixed open source project - Confirmed open source examples build - Updated all of Instagram.app to use this API - Changelog breaking changes entry Fixes #392 Reviewed By: jessesquires Differential Revision: D4754129 fbshipit-source-id: 11d32a0fac3e50c9edbb01e92a8a0c7b8a43cf2d
2017-03-22 19:40:51 +00:00
292807391E82CE240077A81C /* IGListBatchContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 292807381E82CE240077A81C /* IGListBatchContext.h */; settings = {ATTRIBUTES = (Public, ); }; };
2928073A1E82CE2E0077A81C /* IGListBatchContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 292807381E82CE240077A81C /* IGListBatchContext.h */; settings = {ATTRIBUTES = (Public, ); }; };
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841AE202B4F5C00484901 /* IGListAdapterMoveDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 293841AD202B4F5C00484901 /* IGListAdapterMoveDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
293841B1202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.h in Headers */ = {isa = PBXBuildFile; fileRef = 293841AF202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.h */; settings = {ATTRIBUTES = (Private, ); }; };
293841B2202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.m in Sources */ = {isa = PBXBuildFile; fileRef = 293841B0202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.m */; };
293841B3202B4F7F00484901 /* IGListAdapterMoveDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 293841AD202B4F5C00484901 /* IGListAdapterMoveDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
293841B4202B4F8C00484901 /* UICollectionViewLayout+InteractiveReordering.m in Sources */ = {isa = PBXBuildFile; fileRef = 293841B0202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.m */; };
293841B5202B4F9000484901 /* UICollectionViewLayout+InteractiveReordering.h in Headers */ = {isa = PBXBuildFile; fileRef = 293841AF202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.h */; settings = {ATTRIBUTES = (Private, ); }; };
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B01EA927440063BDD9 /* IGListAdapterUpdater+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3631E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.m */; };
294652B11EA927440063BDD9 /* IGListBatchUpdateData+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF35F1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.m */; };
294652B21EA927440063BDD9 /* IGListDebugger.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3531E930C89009FE456 /* IGListDebugger.m */; };
294652B31EA927440063BDD9 /* IGListSectionMap+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF36F1E931457009FE456 /* IGListSectionMap+DebugDescription.m */; };
294652B41EA927440063BDD9 /* UICollectionView+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3571E930CE2009FE456 /* UICollectionView+DebugDescription.m */; };
294652B51EA9275A0063BDD9 /* IGListDebuggingUtilities.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3731E931B57009FE456 /* IGListDebuggingUtilities.m */; };
294652B71EA927750063BDD9 /* IGListAdapterUpdater+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3621E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
294652B81EA927750063BDD9 /* IGListBatchUpdateData+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF35E1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
294652B91EA927750063BDD9 /* IGListDebugger.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3521E930C89009FE456 /* IGListDebugger.h */; settings = {ATTRIBUTES = (Private, ); }; };
294652BA1EA927750063BDD9 /* IGListDebuggingUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3721E931B57009FE456 /* IGListDebuggingUtilities.h */; settings = {ATTRIBUTES = (Private, ); }; };
294652BB1EA927750063BDD9 /* IGListSectionMap+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF36E1E931457009FE456 /* IGListSectionMap+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
294652BC1EA927750063BDD9 /* UICollectionView+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 290DF3561E930CE2009FE456 /* UICollectionView+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
Unit test moves in containers Summary: Unit testing moves in sets so their `hash` and `isEqual` functions provide uniqueness. Fixes #187, #188 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/217 Differential Revision: D4201042 Pulled By: jessesquires fbshipit-source-id: 9c4803ca11e04bb86a7745d6ebc63d173e8ac814
2016-11-18 02:48:07 +00:00
294AC6321DDE4C19002FCE5D /* IGListDiffResultTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 294AC6311DDE4C19002FCE5D /* IGListDiffResultTests.m */; };
Add update finished announcer API Summary: Adding a new API to support adding 1:many listeners to observe when an `IGListAdapter` finishes performing an update event. It supports: - `performUpdates:` - `reloadData...` - Even handling update triggered from //inside// a section controller Differential Revision: D6108096 fbshipit-source-id: d0b43d83f1963fdbf6ef388685cbd8f6890177fa
2017-10-20 15:41:01 +00:00
294CDE5F1F98E3A7002CF6E4 /* IGListAdapterUpdateListener.h in Headers */ = {isa = PBXBuildFile; fileRef = 294CDE5E1F98E3A6002CF6E4 /* IGListAdapterUpdateListener.h */; settings = {ATTRIBUTES = (Public, ); }; };
294CDE601F995488002CF6E4 /* IGListAdapterUpdateListener.h in Headers */ = {isa = PBXBuildFile; fileRef = 294CDE5E1F98E3A6002CF6E4 /* IGListAdapterUpdateListener.h */; settings = {ATTRIBUTES = (Public, ); }; };
Prevent duplicate item deletes and drop reload collisions Summary: a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in `UICollectionView` where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4) Closes https://github.com/Instagram/IGListKit/pull/657 Reviewed By: jessesquires Differential Revision: D4913790 Pulled By: rnystrom fbshipit-source-id: 8f6fcdd2e2438da309fc64ca0ac111b9a0980149
2017-04-20 00:01:12 +00:00
296AC95C1EA518D3005137E2 /* IGListReloadIndexPath.h in Headers */ = {isa = PBXBuildFile; fileRef = 296AC95A1EA518D3005137E2 /* IGListReloadIndexPath.h */; settings = {ATTRIBUTES = (Private, ); }; };
296AC95D1EA518D3005137E2 /* IGListReloadIndexPath.h in Headers */ = {isa = PBXBuildFile; fileRef = 296AC95A1EA518D3005137E2 /* IGListReloadIndexPath.h */; settings = {ATTRIBUTES = (Private, ); }; };
296AC95F1EA518D3005137E2 /* IGListReloadIndexPath.m in Sources */ = {isa = PBXBuildFile; fileRef = 296AC95B1EA518D3005137E2 /* IGListReloadIndexPath.m */; };
296AC9601EA518D3005137E2 /* IGListReloadIndexPath.m in Sources */ = {isa = PBXBuildFile; fileRef = 296AC95B1EA518D3005137E2 /* IGListReloadIndexPath.m */; };
Fix examples Summary: Broke in #525 b/c didn't run `pod_install.sh` after adding new files. Issue fixed: #537 Closes https://github.com/Instagram/IGListKit/pull/538 Differential Revision: D4695675 Pulled By: rnystrom fbshipit-source-id: 3edc6e25f545efdc5475035036e25bb0e1b304d3
2017-03-11 21:28:34 +00:00
297278BD1E6B58560099D8EA /* IGListBatchUpdates.h in Headers */ = {isa = PBXBuildFile; fileRef = 297278BB1E6B58560099D8EA /* IGListBatchUpdates.h */; settings = {ATTRIBUTES = (Private, ); }; };
297278BE1E6B58560099D8EA /* IGListBatchUpdates.h in Headers */ = {isa = PBXBuildFile; fileRef = 297278BB1E6B58560099D8EA /* IGListBatchUpdates.h */; settings = {ATTRIBUTES = (Private, ); }; };
Track batch updates in object and explicit state Summary: Batch updates are complicated b/c its unknown when the update block will actually execute. When executing the block, we want to collect inserts/deletes/reloads/moves (item and section). Allow mutations to happen synchronously outside of the update block. Tracking state will also help with the auto-diff where we need to allow re-entrant updates. Peeling off a chunk from #494 Issue fixed: #288 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/525 Reviewed By: jessesquires Differential Revision: D4656463 Pulled By: rnystrom fbshipit-source-id: 8f4d3dc21b03d595e02ee9ee9664277e8ead0531
2017-03-07 17:22:22 +00:00
297278BF1E6B58560099D8EA /* IGListBatchUpdates.m in Sources */ = {isa = PBXBuildFile; fileRef = 297278BC1E6B58560099D8EA /* IGListBatchUpdates.m */; };
297278C11E6B58560099D8EA /* IGListBatchUpdates.m in Sources */ = {isa = PBXBuildFile; fileRef = 297278BC1E6B58560099D8EA /* IGListBatchUpdates.m */; };
Fix examples Summary: Broke in #525 b/c didn't run `pod_install.sh` after adding new files. Issue fixed: #537 Closes https://github.com/Instagram/IGListKit/pull/538 Differential Revision: D4695675 Pulled By: rnystrom fbshipit-source-id: 3edc6e25f545efdc5475035036e25bb0e1b304d3
2017-03-11 21:28:34 +00:00
297278C41E6B59D50099D8EA /* IGListBatchUpdateState.h in Headers */ = {isa = PBXBuildFile; fileRef = 297278C31E6B59D50099D8EA /* IGListBatchUpdateState.h */; settings = {ATTRIBUTES = (Private, ); }; };
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
29822E541FE3473A008532D2 /* IGListCollectionView.h in Headers */ = {isa = PBXBuildFile; fileRef = 29822E521FE3473A008532D2 /* IGListCollectionView.h */; settings = {ATTRIBUTES = (Public, ); }; };
29822E551FE3473A008532D2 /* IGListCollectionView.m in Sources */ = {isa = PBXBuildFile; fileRef = 29822E531FE3473A008532D2 /* IGListCollectionView.m */; };
29822E561FE34773008532D2 /* IGListCollectionView.m in Sources */ = {isa = PBXBuildFile; fileRef = 29822E531FE3473A008532D2 /* IGListCollectionView.m */; };
29822E571FE3477C008532D2 /* IGListCollectionView.h in Headers */ = {isa = PBXBuildFile; fileRef = 29822E521FE3473A008532D2 /* IGListCollectionView.h */; settings = {ATTRIBUTES = (Public, ); }; };
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9C21E3ACF4800F76F50 /* IGListBindable.h in Headers */ = {isa = PBXBuildFile; fileRef = 298DD9C11E3ACF4800F76F50 /* IGListBindable.h */; settings = {ATTRIBUTES = (Public, ); }; };
298DD9C31E3ACF8600F76F50 /* IGListBindable.h in Headers */ = {isa = PBXBuildFile; fileRef = 298DD9C11E3ACF4800F76F50 /* IGListBindable.h */; settings = {ATTRIBUTES = (Public, ); }; };
298DD9C71E3ACFE300F76F50 /* IGListBindingSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 298DD9C51E3ACFE300F76F50 /* IGListBindingSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
298DD9C81E3ACFE300F76F50 /* IGListBindingSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 298DD9C51E3ACFE300F76F50 /* IGListBindingSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
298DD9CA1E3ACFE300F76F50 /* IGListBindingSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9C61E3ACFE300F76F50 /* IGListBindingSectionController.m */; };
298DD9CB1E3ACFE300F76F50 /* IGListBindingSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9C61E3ACFE300F76F50 /* IGListBindingSectionController.m */; };
298DD9CE1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9CD1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m */; };
298DD9CF1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9CD1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m */; };
298DDA001E3AE28000F76F50 /* IGTestDiffingObject.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9F91E3AE1AA00F76F50 /* IGTestDiffingObject.m */; };
298DDA011E3AE28000F76F50 /* IGTestDiffingObject.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9F91E3AE1AA00F76F50 /* IGTestDiffingObject.m */; };
298DDA051E3AE2B000F76F50 /* IGTestStringBindableCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9D91E3ADE3300F76F50 /* IGTestStringBindableCell.m */; };
298DDA061E3AE2B000F76F50 /* IGTestNumberBindableCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9E11E3ADE4300F76F50 /* IGTestNumberBindableCell.m */; };
298DDA071E3AE2B100F76F50 /* IGTestStringBindableCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9D91E3ADE3300F76F50 /* IGTestStringBindableCell.m */; };
298DDA081E3AE2B100F76F50 /* IGTestNumberBindableCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9E11E3ADE4300F76F50 /* IGTestNumberBindableCell.m */; };
298DDA091E3AE31D00F76F50 /* IGTestDiffingSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9D11E3ADDB400F76F50 /* IGTestDiffingSectionController.m */; };
298DDA0A1E3AE31E00F76F50 /* IGTestDiffingSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DD9D11E3ADDB400F76F50 /* IGTestDiffingSectionController.m */; };
298DDA131E3AE3F100F76F50 /* IGTestDiffingDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA0C1E3AE3ED00F76F50 /* IGTestDiffingDataSource.m */; };
298DDA141E3AE3F300F76F50 /* IGTestDiffingDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA0C1E3AE3ED00F76F50 /* IGTestDiffingDataSource.m */; };
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA1F1E3B0DC800F76F50 /* IGListCollectionViewLayout.h in Headers */ = {isa = PBXBuildFile; fileRef = 298DDA1D1E3B0DC800F76F50 /* IGListCollectionViewLayout.h */; settings = {ATTRIBUTES = (Public, ); }; };
298DDA201E3B0DC800F76F50 /* IGListCollectionViewLayout.h in Headers */ = {isa = PBXBuildFile; fileRef = 298DDA1D1E3B0DC800F76F50 /* IGListCollectionViewLayout.h */; settings = {ATTRIBUTES = (Public, ); }; };
298DDA211E3B0DC800F76F50 /* IGListCollectionViewLayout.mm in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA1E1E3B0DC800F76F50 /* IGListCollectionViewLayout.mm */; };
298DDA221E3B0DC800F76F50 /* IGListCollectionViewLayout.mm in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA1E1E3B0DC800F76F50 /* IGListCollectionViewLayout.mm */; };
298DDA241E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA231E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m */; };
298DDA251E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA231E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m */; };
298DDA381E3B168E00F76F50 /* IGLayoutTestItem.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA291E3B166100F76F50 /* IGLayoutTestItem.m */; };
298DDA391E3B168F00F76F50 /* IGLayoutTestItem.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA291E3B166100F76F50 /* IGLayoutTestItem.m */; };
298DDA3A1E3B16F600F76F50 /* IGLayoutTestDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA271E3B166100F76F50 /* IGLayoutTestDataSource.m */; };
298DDA3B1E3B16F800F76F50 /* IGLayoutTestDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA271E3B166100F76F50 /* IGLayoutTestDataSource.m */; };
298DDA3C1E3B170300F76F50 /* IGLayoutTestSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA2B1E3B166100F76F50 /* IGLayoutTestSection.m */; };
298DDA3D1E3B170400F76F50 /* IGLayoutTestSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 298DDA2B1E3B166100F76F50 /* IGLayoutTestSection.m */; };
Fix binding SC deselection crash and publish 3.1.1 Summary: - Fixed #918 by checking `respondsToSelector:` (boo optionals) - Cut 3.1.1 for immediate publish - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/921 Differential Revision: D5748009 Pulled By: rnystrom fbshipit-source-id: b387b3988abc785f312bc47ac003851283972d7a
2017-08-31 19:35:22 +00:00
2995409E1F588C9400F647CF /* IGTestBindingWithoutDeselectionDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 2995409B1F588C8D00F647CF /* IGTestBindingWithoutDeselectionDelegate.m */; };
2995409F1F588C9500F647CF /* IGTestBindingWithoutDeselectionDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 2995409B1F588C8D00F647CF /* IGTestBindingWithoutDeselectionDelegate.m */; };
Add unit tests to reloadData updater Summary: Adding a few more missing unit tests. Closes #185 Closes https://github.com/Instagram/IGListKit/pull/289 Differential Revision: D4284610 Pulled By: rnystrom fbshipit-source-id: a592fb9c12a3995a62b608f44cdcc693a0f79bec
2016-12-06 13:54:48 +00:00
2997D4971DF5FC0B005A5DD2 /* IGReloadDataUpdaterTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 2997D4961DF5FC0B005A5DD2 /* IGReloadDataUpdaterTests.m */; };
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C4748C1DDF45F400AE68CE /* IGListAdapterProxyTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 29C4748A1DDF45E700AE68CE /* IGListAdapterProxyTests.m */; };
29C4748D1DDF45F900AE68CE /* IGListAdapterProxyTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 29C4748A1DDF45E700AE68CE /* IGListAdapterProxyTests.m */; };
29C4748E1DDF460500AE68CE /* IGListAdapterStoryboardTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F11DC284C300B3AAE7 /* IGListAdapterStoryboardTests.m */; };
29C4748F1DDF460500AE68CE /* IGListDiffResultTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 294AC6311DDE4C19002FCE5D /* IGListDiffResultTests.m */; };
29C474901DDF460500AE68CE /* IGListSectionMapTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 829D7BA81DD1816400549816 /* IGListSectionMapTests.m */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48145202413B00093D4BC /* IGListExperiments.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77E201FBD870029277A /* IGListExperiments.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48146202413B00093D4BC /* IGListIndexPathResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA775201FBD870029277A /* IGListIndexPathResult.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48148202413B00093D4BC /* IGListMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA781201FBD870029277A /* IGListMacros.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48149202413B00093D4BC /* IGListMoveIndex.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA782201FBD870029277A /* IGListMoveIndex.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C4814B202413B00093D4BC /* NSNumber+IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA786201FBD870029277A /* NSNumber+IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C4814D202413B20093D4BC /* IGListAssert.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA787201FBD870029277A /* IGListAssert.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C4814E202413B20093D4BC /* IGListBatchUpdateData.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA788201FBD870029277A /* IGListBatchUpdateData.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C4814F202413B20093D4BC /* IGListCompatibility.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77D201FBD870029277A /* IGListCompatibility.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48150202413B20093D4BC /* IGListDiff.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA78A201FBD870029277A /* IGListDiff.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48152202413B20093D4BC /* IGListExperiments.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77E201FBD870029277A /* IGListExperiments.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48153202413B20093D4BC /* IGListIndexPathResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA775201FBD870029277A /* IGListIndexPathResult.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48154202413B20093D4BC /* IGListIndexSetResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA770201FBD870029277A /* IGListIndexSetResult.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48156202413B20093D4BC /* IGListMoveIndex.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA782201FBD870029277A /* IGListMoveIndex.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48157202413B20093D4BC /* IGListMoveIndexPath.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA780201FBD870029277A /* IGListMoveIndexPath.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48158202413B20093D4BC /* NSNumber+IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA786201FBD870029277A /* NSNumber+IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48159202413B20093D4BC /* NSString+IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA773201FBD870029277A /* NSString+IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C4815B202413BD0093D4BC /* IGListIndexPathResultInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA779201FBD870029277A /* IGListIndexPathResultInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C4815E202413BD0093D4BC /* IGListMoveIndexPathInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77C201FBD870029277A /* IGListMoveIndexPathInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C4815F202413BE0093D4BC /* IGListIndexSetResultInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA778201FBD870029277A /* IGListIndexSetResultInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C48160202413BE0093D4BC /* IGListIndexPathResultInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA779201FBD870029277A /* IGListIndexPathResultInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C48161202413BE0093D4BC /* IGListArrayUtilsInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77A201FBD870029277A /* IGListArrayUtilsInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C48163202413BE0093D4BC /* IGListMoveIndexPathInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77C201FBD870029277A /* IGListMoveIndexPathInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C48164202414780093D4BC /* IGListBatchUpdateData.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA774201FBD870029277A /* IGListBatchUpdateData.mm */; };
29C48166202414780093D4BC /* IGListIndexPathResult.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA789201FBD870029277A /* IGListIndexPathResult.m */; };
29C48167202414780093D4BC /* IGListIndexSetResult.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA77F201FBD870029277A /* IGListIndexSetResult.m */; };
29C48169202414780093D4BC /* IGListMoveIndexPath.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA771201FBD870029277A /* IGListMoveIndexPath.m */; };
29C4816A202414780093D4BC /* NSNumber+IGListDiffable.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA776201FBD870029277A /* NSNumber+IGListDiffable.m */; };
29C4816B202414780093D4BC /* NSString+IGListDiffable.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA783201FBD870029277A /* NSString+IGListDiffable.m */; };
29C481742024167B0093D4BC /* IGListCollectionViewDelegateLayout.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA7A7201FBD9B0029277A /* IGListCollectionViewDelegateLayout.h */; settings = {ATTRIBUTES = (Public, ); }; };
29C48178202417380093D4BC /* IGListAdapter+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 0D52F0AC1F1ADA1600460F79 /* IGListAdapter+DebugDescription.m */; };
29C48179202417380093D4BC /* IGListBindingSectionController+DebugDescription.m in Sources */ = {isa = PBXBuildFile; fileRef = 0D52F0B51F1AE8BD00460F79 /* IGListBindingSectionController+DebugDescription.m */; };
29C4817A202417380093D4BC /* UIScrollView+IGListKit.m in Sources */ = {isa = PBXBuildFile; fileRef = E8B5C73A1FC431D400C26914 /* UIScrollView+IGListKit.m */; };
29C4817B2024174F0093D4BC /* IGListAdapter+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 0D52F0AB1F1ADA1600460F79 /* IGListAdapter+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C4817C2024174F0093D4BC /* IGListBindingSectionController+DebugDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 0D52F0B31F1AE81800460F79 /* IGListBindingSectionController+DebugDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
29C4817D2024174F0093D4BC /* UIScrollView+IGListKit.h in Headers */ = {isa = PBXBuildFile; fileRef = E8B5C7391FC431D400C26914 /* UIScrollView+IGListKit.h */; settings = {ATTRIBUTES = (Private, ); }; };
Fix TV tests Summary: Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho. Maybe fix #227 If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/228 Differential Revision: D4210696 Pulled By: rnystrom fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
2016-11-20 00:01:35 +00:00
29C5792E1DE0DA89003A149B /* IGTestNibSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 2904861F1DCD02750007F41D /* IGTestNibSupplementaryView.m */; };
29C5792F1DE0DA8A003A149B /* IGListTestAdapterStoryboardDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7FA1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m */; };
29C579301DE0DA8A003A149B /* IGListTestStoryboardSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F71DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.m */; };
29C579311DE0DA8A003A149B /* IGTestNibSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 2904861F1DCD02750007F41D /* IGTestNibSupplementaryView.m */; };
29C579321DE0DA8A003A149B /* IGTestStoryboardSupplementarySource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F41DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.m */; };
29C579331DE0DA8A003A149B /* IGTestStoryboardSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7EF1DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.m */; };
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5CA01EA7C70400113926 /* IGListGenericSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DA5C9E1EA7C70400113926 /* IGListGenericSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DA5CA11EA7C70400113926 /* IGListGenericSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DA5C9F1EA7C70400113926 /* IGListGenericSectionController.m */; };
29DA5CA31EA7C72400113926 /* IGListGenericSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DA5CA21EA7C72400113926 /* IGListGenericSectionControllerTests.m */; };
29DA5CA41EA7C75500113926 /* IGListGenericSectionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DA5C9E1EA7C70400113926 /* IGListGenericSectionController.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DA5CA51EA7C75500113926 /* IGListGenericSectionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DA5C9F1EA7C70400113926 /* IGListGenericSectionController.m */; };
Add base test case class for simpler unit testing Summary: Making it simpler to setup tests w/ default config and objects. Less LoC in tests, lower setup cost when creating new test suites. Should I changelog? Issue fixed: #183 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/678 Differential Revision: D4921633 Pulled By: rnystrom fbshipit-source-id: fb4d08acb6ed0ba885cf56ce147f70b304301ff1
2017-04-20 21:35:26 +00:00
29DA5CA71EA7D37000113926 /* IGListTestCase.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DA5CA61EA7D37000113926 /* IGListTestCase.m */; };
29DA5CA81EA7D37000113926 /* IGListTestCase.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DA5CA61EA7D37000113926 /* IGListTestCase.m */; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA78B201FBD880029277A /* IGListMoveIndex.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA76F201FBD870029277A /* IGListMoveIndex.m */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA78C201FBD880029277A /* IGListIndexSetResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA770201FBD870029277A /* IGListIndexSetResult.h */; settings = {ATTRIBUTES = (Public, ); }; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA78D201FBD880029277A /* IGListMoveIndexPath.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA771201FBD870029277A /* IGListMoveIndexPath.m */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA78E201FBD880029277A /* IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA772201FBD870029277A /* IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DAA78F201FBD880029277A /* NSString+IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA773201FBD870029277A /* NSString+IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA790201FBD880029277A /* IGListBatchUpdateData.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA774201FBD870029277A /* IGListBatchUpdateData.mm */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA791201FBD880029277A /* IGListIndexPathResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA775201FBD870029277A /* IGListIndexPathResult.h */; settings = {ATTRIBUTES = (Public, ); }; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA792201FBD880029277A /* NSNumber+IGListDiffable.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA776201FBD870029277A /* NSNumber+IGListDiffable.m */; };
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
29DAA793201FBD880029277A /* IGListIndexSetResultInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA778201FBD870029277A /* IGListIndexSetResultInternal.h */; };
29DAA794201FBD880029277A /* IGListIndexPathResultInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA779201FBD870029277A /* IGListIndexPathResultInternal.h */; };
29DAA795201FBD880029277A /* IGListArrayUtilsInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77A201FBD870029277A /* IGListArrayUtilsInternal.h */; };
29DAA796201FBD880029277A /* IGListMoveIndexInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77B201FBD870029277A /* IGListMoveIndexInternal.h */; };
29DAA797201FBD880029277A /* IGListMoveIndexPathInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77C201FBD870029277A /* IGListMoveIndexPathInternal.h */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA798201FBD880029277A /* IGListCompatibility.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77D201FBD870029277A /* IGListCompatibility.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DAA799201FBD880029277A /* IGListExperiments.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77E201FBD870029277A /* IGListExperiments.h */; settings = {ATTRIBUTES = (Public, ); }; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA79A201FBD880029277A /* IGListIndexSetResult.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA77F201FBD870029277A /* IGListIndexSetResult.m */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA79B201FBD880029277A /* IGListMoveIndexPath.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA780201FBD870029277A /* IGListMoveIndexPath.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DAA79C201FBD880029277A /* IGListMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA781201FBD870029277A /* IGListMacros.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DAA79D201FBD880029277A /* IGListMoveIndex.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA782201FBD870029277A /* IGListMoveIndex.h */; settings = {ATTRIBUTES = (Public, ); }; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA79E201FBD880029277A /* NSString+IGListDiffable.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA783201FBD870029277A /* NSString+IGListDiffable.m */; };
29DAA79F201FBD880029277A /* IGListDiff.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA784201FBD870029277A /* IGListDiff.mm */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA7A1201FBD880029277A /* NSNumber+IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA786201FBD870029277A /* NSNumber+IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DAA7A2201FBD880029277A /* IGListAssert.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA787201FBD870029277A /* IGListAssert.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DAA7A3201FBD880029277A /* IGListBatchUpdateData.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA788201FBD870029277A /* IGListBatchUpdateData.h */; settings = {ATTRIBUTES = (Public, ); }; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A4201FBD880029277A /* IGListIndexPathResult.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA789201FBD870029277A /* IGListIndexPathResult.m */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA7A8201FBD9B0029277A /* IGListTransitionDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA7A6201FBD9B0029277A /* IGListTransitionDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
29DAA7A9201FBD9B0029277A /* IGListCollectionViewDelegateLayout.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA7A7201FBD9B0029277A /* IGListCollectionViewDelegateLayout.h */; settings = {ATTRIBUTES = (Public, ); }; };
Swap test nib to test bundle Summary: IGTestNibCell.xib was in the wrong bundle after imported internally (moved it to `Assets` dir) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/78 Reviewed By: ryanolsonk Differential Revision: D4028444 Pulled By: rnystrom fbshipit-source-id: cb7ed0f8024ca9fd116827f3935f075c1d9193be
2016-10-16 23:30:18 +00:00
29EA6C491DB43A8000957A88 /* IGTestNibCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 294369B01DB1B7AE0025F6E7 /* IGTestNibCell.xib */; };
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
6A9EB3611F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 6A9EB3601F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m */; };
6A9EB3621F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = 6A9EB3601F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m */; };
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4C01DB8C9D500172ED0 /* IGListSingleStoryboardItemControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4BE1DB8C95300172ED0 /* IGListSingleStoryboardItemControllerTests.m */; };
821BC4C41DB8CEF800172ED0 /* IGTestStoryboard.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 821BC4C21DB8CAE900172ED0 /* IGTestStoryboard.storyboard */; };
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
821BC4CB1DB8D60100172ED0 /* IGTestStoryboardViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4C81DB8D5B200172ED0 /* IGTestStoryboardViewController.m */; };
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4D01DB8D90900172ED0 /* IGTestStoryboardCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4CD1DB8D8C500172ED0 /* IGTestStoryboardCell.m */; };
821BC4D31DB981AB00172ED0 /* IGTestSingleStoryboardItemDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4D21DB981AB00172ED0 /* IGTestSingleStoryboardItemDataSource.m */; };
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F01DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7EF1DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.m */; };
8240C7F21DC284C300B3AAE7 /* IGListAdapterStoryboardTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F11DC284C300B3AAE7 /* IGListAdapterStoryboardTests.m */; };
8240C7F51DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F41DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.m */; };
8240C7F81DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F71DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.m */; };
8240C7FB1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7FA1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m */; };
Unit tests for -scrollToObject horizontal end position Summary: Fixes #238 Try to finish what I started 😂 Closes https://github.com/Instagram/IGListKit/pull/247 Differential Revision: D4220011 Pulled By: rnystrom fbshipit-source-id: 9f4e1bd4f112f69f601c83d6604dc18bc27f0c68
2016-11-22 14:38:27 +00:00
8285404C1DE40C6E00118B94 /* IGListTestHorizontalSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 8285404B1DE40C6E00118B94 /* IGListTestHorizontalSection.m */; };
8285404D1DE40C6E00118B94 /* IGListTestHorizontalSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 8285404B1DE40C6E00118B94 /* IGListTestHorizontalSection.m */; };
828540501DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8285404F1DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m */; };
828540511DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8285404F1DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m */; };
Container Inset Size For Section Controller Summary: Add API for #315. Not sure if this is what you want rnystrom though 🤔. Will add tests after you confirm. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/456 Reviewed By: jessesquires Differential Revision: D4697190 Pulled By: rnystrom fbshipit-source-id: f8513cf2fa33441eb40f486954136553d19dda0c
2017-03-15 16:25:03 +00:00
82914C5B1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 82914C5A1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m */; };
82914C5C1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 82914C5A1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m */; };
Commit 1a92c15 breaks pbxproj Summary: Update project.pbxproj Closes https://github.com/Instagram/IGListKit/pull/174 Differential Revision: D4147048 Pulled By: rnystrom fbshipit-source-id: 03713030f5604839af3c64f64f3a700e08b3fa94
2016-11-08 14:18:29 +00:00
829D7BAA1DD1819000549816 /* IGListSectionMapTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 829D7BA81DD1816400549816 /* IGListSectionMapTests.m */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F071D870EDC007C7F66 /* IGListAdapterE2ETests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE21D870EDC007C7F66 /* IGListAdapterE2ETests.m */; };
88144F081D870EDC007C7F66 /* IGListAdapterTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE31D870EDC007C7F66 /* IGListAdapterTests.m */; };
88144F091D870EDC007C7F66 /* IGListAdapterUpdaterTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE41D870EDC007C7F66 /* IGListAdapterUpdaterTests.m */; };
88144F0A1D870EDC007C7F66 /* IGListBatchUpdateDataTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE51D870EDC007C7F66 /* IGListBatchUpdateDataTests.m */; };
88144F0B1D870EDC007C7F66 /* IGListDiffSwiftTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE61D870EDC007C7F66 /* IGListDiffSwiftTests.swift */; };
88144F0C1D870EDC007C7F66 /* IGListDiffTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE81D870EDC007C7F66 /* IGListDiffTests.m */; };
88144F0D1D870EDC007C7F66 /* IGListDisplayHandlerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE91D870EDC007C7F66 /* IGListDisplayHandlerTests.m */; };
Rename *ItemController unit tests to *SectionController Summary: Rename *ItemController unit tests to *SectionController, addressing issue #126 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/129 Differential Revision: D4095496 Pulled By: rnystrom fbshipit-source-id: 277be38ed2789f14199cee9d711a838552921f10
2016-10-28 14:31:37 +00:00
88144F101D870EDC007C7F66 /* IGListSingleSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EED1D870EDC007C7F66 /* IGListSingleSectionControllerTests.m */; };
88144F111D870EDC007C7F66 /* IGListStackSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EEE1D870EDC007C7F66 /* IGListStackSectionControllerTests.m */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F121D870EDC007C7F66 /* IGListWorkingRangeHandlerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EEF1D870EDC007C7F66 /* IGListWorkingRangeHandlerTests.m */; };
88144F131D870EDC007C7F66 /* IGListTestAdapterDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF21D870EDC007C7F66 /* IGListTestAdapterDataSource.m */; };
88144F141D870EDC007C7F66 /* IGListTestOffsettingLayout.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF41D870EDC007C7F66 /* IGListTestOffsettingLayout.m */; };
88144F151D870EDC007C7F66 /* IGListTestSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF61D870EDC007C7F66 /* IGListTestSection.m */; };
88144F161D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF81D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.m */; };
88144F171D870EDC007C7F66 /* IGTestCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EFA1D870EDC007C7F66 /* IGTestCell.m */; };
88144F181D870EDC007C7F66 /* IGTestDelegateController.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EFC1D870EDC007C7F66 /* IGTestDelegateController.m */; };
88144F191D870EDC007C7F66 /* IGTestDelegateDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EFE1D870EDC007C7F66 /* IGTestDelegateDataSource.m */; };
88144F1A1D870EDC007C7F66 /* IGTestObject.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F001D870EDC007C7F66 /* IGTestObject.m */; };
88144F1B1D870EDC007C7F66 /* IGTestSingleItemDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F021D870EDC007C7F66 /* IGTestSingleItemDataSource.m */; };
88144F1C1D870EDC007C7F66 /* IGTestStackedDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F041D870EDC007C7F66 /* IGTestStackedDataSource.m */; };
88144F1D1D870EDC007C7F66 /* IGTestSupplementarySource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F061D870EDC007C7F66 /* IGTestSupplementarySource.m */; };
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
882BC1321E0118CB0083B311 /* IGTestObject.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F001D870EDC007C7F66 /* IGTestObject.m */; };
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883796EA2022301F00B94676 /* IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA772201FBD870029277A /* IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
883796F72022304D00B94676 /* IGListAssert.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA787201FBD870029277A /* IGListAssert.h */; settings = {ATTRIBUTES = (Public, ); }; };
883796F82022304D00B94676 /* IGListBatchUpdateData.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA788201FBD870029277A /* IGListBatchUpdateData.h */; settings = {ATTRIBUTES = (Public, ); }; };
883796F92022304D00B94676 /* IGListCompatibility.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77D201FBD870029277A /* IGListCompatibility.h */; settings = {ATTRIBUTES = (Public, ); }; };
883796FB2022304D00B94676 /* IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA772201FBD870029277A /* IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
883796FF2022304D00B94676 /* IGListIndexSetResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA770201FBD870029277A /* IGListIndexSetResult.h */; settings = {ATTRIBUTES = (Public, ); }; };
883797022022304D00B94676 /* IGListMoveIndexPath.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA780201FBD870029277A /* IGListMoveIndexPath.h */; settings = {ATTRIBUTES = (Public, ); }; };
883797042022304D00B94676 /* NSString+IGListDiffable.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA773201FBD870029277A /* NSString+IGListDiffable.h */; settings = {ATTRIBUTES = (Public, ); }; };
883797082022304E00B94676 /* (null) in Headers */ = {isa = PBXBuildFile; };
8837970C2022304E00B94676 /* IGListMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA781201FBD870029277A /* IGListMacros.h */; settings = {ATTRIBUTES = (Public, ); }; };
883797112022308200B94676 /* IGListTransitionDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA7A6201FBD9B0029277A /* IGListTransitionDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
88379712202230DE00B94676 /* IGListDiff.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA78A201FBD870029277A /* IGListDiff.h */; settings = {ATTRIBUTES = (Public, ); }; };
88379713202230DF00B94676 /* IGListDiff.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA78A201FBD870029277A /* IGListDiff.h */; settings = {ATTRIBUTES = (Public, ); }; };
883797142022319300B94676 /* IGListMoveIndexInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77B201FBD870029277A /* IGListMoveIndexInternal.h */; };
883797152022319400B94676 /* IGListMoveIndexInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA77B201FBD870029277A /* IGListMoveIndexInternal.h */; };
88379717202231E400B94676 /* IGListIndexSetResultInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 29DAA778201FBD870029277A /* IGListIndexSetResultInternal.h */; };
8837971D202235F200B94676 /* IGListMoveIndexPath.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA771201FBD870029277A /* IGListMoveIndexPath.m */; };
8837971F2022360700B94676 /* IGListBatchUpdateData.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA774201FBD870029277A /* IGListBatchUpdateData.mm */; };
883797202022361F00B94676 /* IGListDiff.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA784201FBD870029277A /* IGListDiff.mm */; };
883797212022361F00B94676 /* IGListDiff.mm in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA784201FBD870029277A /* IGListDiff.mm */; };
883797232022364900B94676 /* IGListIndexPathResult.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA789201FBD870029277A /* IGListIndexPathResult.m */; };
883797252022365700B94676 /* IGListIndexSetResult.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA77F201FBD870029277A /* IGListIndexSetResult.m */; };
883797262022366000B94676 /* IGListMoveIndex.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA76F201FBD870029277A /* IGListMoveIndex.m */; };
883797272022366000B94676 /* IGListMoveIndex.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA76F201FBD870029277A /* IGListMoveIndex.m */; };
88379728202236AB00B94676 /* IGListAdapterUpdateTester.m in Sources */ = {isa = PBXBuildFile; fileRef = 294CDE621F995DD7002CF6E4 /* IGListAdapterUpdateTester.m */; };
88379729202236AC00B94676 /* IGListAdapterUpdateTester.m in Sources */ = {isa = PBXBuildFile; fileRef = 294CDE621F995DD7002CF6E4 /* IGListAdapterUpdateTester.m */; };
8837972B202236FF00B94676 /* NSNumber+IGListDiffable.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA776201FBD870029277A /* NSNumber+IGListDiffable.m */; };
8837972D2022370600B94676 /* NSString+IGListDiffable.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DAA783201FBD870029277A /* NSString+IGListDiffable.m */; };
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1DD1DC51A0D009CE2B4 /* IGListKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 885FE1D41DC51A0D009CE2B4 /* IGListKit.framework */; };
885FE22B1DC51B76009CE2B4 /* IGListAdapterE2ETests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE21D870EDC007C7F66 /* IGListAdapterE2ETests.m */; };
885FE22C1DC51B76009CE2B4 /* IGListAdapterTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE31D870EDC007C7F66 /* IGListAdapterTests.m */; };
885FE22D1DC51B76009CE2B4 /* IGListAdapterUpdaterTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE41D870EDC007C7F66 /* IGListAdapterUpdaterTests.m */; };
885FE22E1DC51B76009CE2B4 /* IGListBatchUpdateDataTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE51D870EDC007C7F66 /* IGListBatchUpdateDataTests.m */; };
885FE22F1DC51B76009CE2B4 /* IGListDiffSwiftTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE61D870EDC007C7F66 /* IGListDiffSwiftTests.swift */; };
885FE2301DC51B76009CE2B4 /* IGListDiffTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE81D870EDC007C7F66 /* IGListDiffTests.m */; };
885FE2311DC51B76009CE2B4 /* IGListDisplayHandlerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE91D870EDC007C7F66 /* IGListDisplayHandlerTests.m */; };
885FE2331DC51B76009CE2B4 /* IGListSingleSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EED1D870EDC007C7F66 /* IGListSingleSectionControllerTests.m */; };
885FE2341DC51B76009CE2B4 /* IGListSingleNibItemControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 26271C8B1DAE96740073E116 /* IGListSingleNibItemControllerTests.m */; };
885FE2351DC51B76009CE2B4 /* IGListSingleStoryboardItemControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4BE1DB8C95300172ED0 /* IGListSingleStoryboardItemControllerTests.m */; };
885FE2361DC51B76009CE2B4 /* IGListStackSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EEE1D870EDC007C7F66 /* IGListStackSectionControllerTests.m */; };
885FE2371DC51B76009CE2B4 /* IGListWorkingRangeHandlerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EEF1D870EDC007C7F66 /* IGListWorkingRangeHandlerTests.m */; };
885FE2381DC51B86009CE2B4 /* IGListTestAdapterDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF21D870EDC007C7F66 /* IGListTestAdapterDataSource.m */; };
885FE2391DC51B86009CE2B4 /* IGListTestOffsettingLayout.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF41D870EDC007C7F66 /* IGListTestOffsettingLayout.m */; };
885FE23A1DC51B86009CE2B4 /* IGListTestSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF61D870EDC007C7F66 /* IGListTestSection.m */; };
885FE23B1DC51B86009CE2B4 /* IGListTestUICollectionViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EF81D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.m */; };
885FE23C1DC51B86009CE2B4 /* IGTestCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EFA1D870EDC007C7F66 /* IGTestCell.m */; };
885FE23D1DC51B86009CE2B4 /* IGTestDelegateController.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EFC1D870EDC007C7F66 /* IGTestDelegateController.m */; };
885FE23E1DC51B86009CE2B4 /* IGTestDelegateDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EFE1D870EDC007C7F66 /* IGTestDelegateDataSource.m */; };
885FE23F1DC51B86009CE2B4 /* IGTestObject.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F001D870EDC007C7F66 /* IGTestObject.m */; };
885FE2401DC51B86009CE2B4 /* IGTestSingleItemDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F021D870EDC007C7F66 /* IGTestSingleItemDataSource.m */; };
885FE2411DC51B86009CE2B4 /* IGTestSingleNibItemDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 26271C891DAE94E40073E116 /* IGTestSingleNibItemDataSource.m */; };
885FE2421DC51B86009CE2B4 /* IGTestSingleStoryboardItemDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4D21DB981AB00172ED0 /* IGTestSingleStoryboardItemDataSource.m */; };
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
885FE2431DC51B86009CE2B4 /* IGTestStoryboardViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4C81DB8D5B200172ED0 /* IGTestStoryboardViewController.m */; };
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2441DC51B86009CE2B4 /* IGTestStackedDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F041D870EDC007C7F66 /* IGTestStackedDataSource.m */; };
885FE2451DC51B86009CE2B4 /* IGTestStoryboardCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4CD1DB8D8C500172ED0 /* IGTestStoryboardCell.m */; };
885FE2461DC51B86009CE2B4 /* IGTestSupplementarySource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F061D870EDC007C7F66 /* IGTestSupplementarySource.m */; };
885FE2471DC51B90009CE2B4 /* IGTestNibCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 294369B01DB1B7AE0025F6E7 /* IGTestNibCell.xib */; };
885FE2481DC51B90009CE2B4 /* IGTestStoryboard.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 821BC4C21DB8CAE900172ED0 /* IGTestStoryboard.storyboard */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B401D870D7F009E01F7 /* IGListKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 887D0B361D870D7E009E01F7 /* IGListKit.framework */; };
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89811E010E6A00B1B9B4 /* IGListKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DD3152AC1DE227FA00AC9D2C /* IGListKit.framework */; };
88DF89881E010F5C00B1B9B4 /* IGListDiffResultTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 294AC6311DDE4C19002FCE5D /* IGListDiffResultTests.m */; };
88DF89891E010F6500B1B9B4 /* IGListDiffSwiftTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE61D870EDC007C7F66 /* IGListDiffSwiftTests.swift */; };
88DF898A1E010F7000B1B9B4 /* IGListDiffTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144EE81D870EDC007C7F66 /* IGListDiffTests.m */; };
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
917E89881E800EE70015F934 /* IGListCollectionViewLayoutInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 917E89871E800EE70015F934 /* IGListCollectionViewLayoutInternal.h */; settings = {ATTRIBUTES = (Private, ); }; };
Move UICollectionView(DataSource|Delegate) to category Summary: This reduces the quantity of the code within IGListAdapter.m and is a bit more in line with Swift style of putting protocol conformance into extensions. This does not change functionality just rearranges where code lives. - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [N/A] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [N/A] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/599 Reviewed By: jessesquires Differential Revision: D4861777 Pulled By: amonshiz fbshipit-source-id: eaa31aa9438f3892193aeb8b4ae580ba2960ee8b
2017-04-18 18:07:34 +00:00
DA5F484B1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.h in Headers */ = {isa = PBXBuildFile; fileRef = DA5F48491E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.h */; settings = {ATTRIBUTES = (Private, ); }; };
DA5F484C1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.m in Sources */ = {isa = PBXBuildFile; fileRef = DA5F484A1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.m */; };
DAA83ACF1E8ECE06000F6810 /* IGListAdapter+UICollectionView.m in Sources */ = {isa = PBXBuildFile; fileRef = DA5F484A1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.m */; };
DAD4A40D1E8E9E1E00DACC36 /* IGListAdapter+UICollectionView.h in Headers */ = {isa = PBXBuildFile; fileRef = DA5F48491E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.h */; settings = {ATTRIBUTES = (Private, ); }; };
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
DD468D380BBF350ACE7EA28B /* Pods_IGListKitTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 1AB7195278D0BBB5DA88D36F /* Pods_IGListKitTests.framework */; };
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
E8B5C73B1FC431D400C26914 /* UIScrollView+IGListKit.h in Headers */ = {isa = PBXBuildFile; fileRef = E8B5C7391FC431D400C26914 /* UIScrollView+IGListKit.h */; settings = {ATTRIBUTES = (Private, ); }; };
Add new iOS 11 api adjustedContentInset support Summary: adopt adjustedContentInset instead of contentInset on iOS 11 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1020 Reviewed By: manicakes Differential Revision: D6513703 Pulled By: rnystrom fbshipit-source-id: 5d718f2cb30361959ca5ba8238746427223cb5fd
2017-12-18 16:33:24 +00:00
E8B5C73C1FC431D400C26914 /* UIScrollView+IGListKit.m in Sources */ = {isa = PBXBuildFile; fileRef = E8B5C73A1FC431D400C26914 /* UIScrollView+IGListKit.m */; };
E8D312E01FC472A60009FA2F /* IGListContentInsetTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E8D312DF1FC472A60009FA2F /* IGListContentInsetTests.m */; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXBuildFile section */
/* Begin PBXContainerItemProxy section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1DE1DC51A0D009CE2B4 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 887D0B2D1D870D7E009E01F7 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 885FE1D31DC51A0D009CE2B4;
remoteInfo = "IGListKit-tvOS";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B411D870D7F009E01F7 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 887D0B2D1D870D7E009E01F7 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 887D0B351D870D7E009E01F7;
remoteInfo = IGListKit;
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89821E010E6A00B1B9B4 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 887D0B2D1D870D7E009E01F7 /* Project object */;
proxyType = 1;
remoteGlobalIDString = DD3152661DE227FA00AC9D2C;
remoteInfo = "IGListKit-macOS";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXContainerItemProxy section */
/* Begin PBXFileReference section */
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
08F0B0FD0690F4FC46DDF21B /* Pods-IGListKit-tvOSTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-IGListKit-tvOSTests.release.xcconfig"; path = "Pods/Target Support Files/Pods-IGListKit-tvOSTests/Pods-IGListKit-tvOSTests.release.xcconfig"; sourceTree = "<group>"; };
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B928B1E08D7F5008390ED /* IGListKit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListKit.h; sourceTree = "<group>"; };
0B3B929A1E08D7F5008390ED /* IGListAdapter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapter.h; sourceTree = "<group>"; };
0B3B929B1E08D7F5008390ED /* IGListAdapter.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapter.m; sourceTree = "<group>"; };
0B3B929C1E08D7F5008390ED /* IGListAdapterDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterDataSource.h; sourceTree = "<group>"; };
0B3B929D1E08D7F5008390ED /* IGListAdapterDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterDelegate.h; sourceTree = "<group>"; };
0B3B929E1E08D7F5008390ED /* IGListAdapterUpdater.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterUpdater.h; sourceTree = "<group>"; };
0B3B929F1E08D7F5008390ED /* IGListAdapterUpdater.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterUpdater.m; sourceTree = "<group>"; };
0B3B92A01E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterUpdaterDelegate.h; sourceTree = "<group>"; };
0B3B92A11E08D7F5008390ED /* IGListCollectionContext.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListCollectionContext.h; sourceTree = "<group>"; };
0B3B92A41E08D7F5008390ED /* IGListDisplayDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListDisplayDelegate.h; sourceTree = "<group>"; };
0B3B92A71E08D7F5008390ED /* IGListReloadDataUpdater.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListReloadDataUpdater.h; sourceTree = "<group>"; };
0B3B92A81E08D7F5008390ED /* IGListReloadDataUpdater.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListReloadDataUpdater.m; sourceTree = "<group>"; };
0B3B92A91E08D7F5008390ED /* IGListScrollDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListScrollDelegate.h; sourceTree = "<group>"; };
0B3B92AA1E08D7F5008390ED /* IGListSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListSectionController.h; sourceTree = "<group>"; };
0B3B92AB1E08D7F5008390ED /* IGListSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListSectionController.m; sourceTree = "<group>"; };
0B3B92AD1E08D7F5008390ED /* IGListSingleSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListSingleSectionController.h; sourceTree = "<group>"; };
0B3B92AE1E08D7F5008390ED /* IGListSingleSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListSingleSectionController.m; sourceTree = "<group>"; };
0B3B92AF1E08D7F5008390ED /* IGListStackedSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListStackedSectionController.h; sourceTree = "<group>"; };
0B3B92B01E08D7F5008390ED /* IGListStackedSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListStackedSectionController.m; sourceTree = "<group>"; };
0B3B92B11E08D7F5008390ED /* IGListSupplementaryViewSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListSupplementaryViewSource.h; sourceTree = "<group>"; };
0B3B92B21E08D7F5008390ED /* IGListUpdatingDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListUpdatingDelegate.h; sourceTree = "<group>"; };
0B3B92B31E08D7F5008390ED /* IGListWorkingRangeDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListWorkingRangeDelegate.h; sourceTree = "<group>"; };
0B3B92B41E08D7F5008390ED /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
0B3B92B61E08D7F5008390ED /* IGListAdapterInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterInternal.h; sourceTree = "<group>"; };
0B3B92B71E08D7F5008390ED /* IGListAdapterProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterProxy.h; sourceTree = "<group>"; };
0B3B92B81E08D7F5008390ED /* IGListAdapterProxy.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterProxy.m; sourceTree = "<group>"; };
0B3B92B91E08D7F5008390ED /* IGListAdapterUpdaterInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterUpdaterInternal.h; sourceTree = "<group>"; };
0B3B92BA1E08D7F5008390ED /* IGListDisplayHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListDisplayHandler.h; sourceTree = "<group>"; };
0B3B92BB1E08D7F5008390ED /* IGListDisplayHandler.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListDisplayHandler.m; sourceTree = "<group>"; };
0B3B92BC1E08D7F5008390ED /* IGListSectionControllerInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListSectionControllerInternal.h; sourceTree = "<group>"; };
0B3B92BD1E08D7F5008390ED /* IGListSectionMap.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListSectionMap.h; sourceTree = "<group>"; };
0B3B92BE1E08D7F5008390ED /* IGListSectionMap.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListSectionMap.m; sourceTree = "<group>"; };
0B3B92BF1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListStackedSectionControllerInternal.h; sourceTree = "<group>"; };
0B3B92C01E08D7F5008390ED /* IGListWorkingRangeHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListWorkingRangeHandler.h; sourceTree = "<group>"; };
0B3B92C11E08D7F5008390ED /* IGListWorkingRangeHandler.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = IGListWorkingRangeHandler.mm; sourceTree = "<group>"; };
0B3B92C21E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UICollectionView+IGListBatchUpdateData.h"; sourceTree = "<group>"; };
0B3B92C31E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UICollectionView+IGListBatchUpdateData.m"; sourceTree = "<group>"; };
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0AB1F1ADA1600460F79 /* IGListAdapter+DebugDescription.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "IGListAdapter+DebugDescription.h"; sourceTree = "<group>"; };
0D52F0AC1F1ADA1600460F79 /* IGListAdapter+DebugDescription.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "IGListAdapter+DebugDescription.m"; sourceTree = "<group>"; };
0D52F0B31F1AE81800460F79 /* IGListBindingSectionController+DebugDescription.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "IGListBindingSectionController+DebugDescription.h"; sourceTree = "<group>"; };
0D52F0B51F1AE8BD00460F79 /* IGListBindingSectionController+DebugDescription.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "IGListBindingSectionController+DebugDescription.m"; sourceTree = "<group>"; };
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01711FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IGListTestAdapterReorderingDataSource.h; sourceTree = "<group>"; };
13DF01721FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = IGListTestAdapterReorderingDataSource.m; sourceTree = "<group>"; };
13DF01751FA1000E0092A320 /* IGTestReorderableSection.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IGTestReorderableSection.h; sourceTree = "<group>"; };
13DF01761FA1000E0092A320 /* IGTestReorderableSection.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = IGTestReorderableSection.m; sourceTree = "<group>"; };
13E1028A1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IGListTestAdapterStackedReorderingDataSource.h; sourceTree = "<group>"; };
13E1028B1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = IGListTestAdapterStackedReorderingDataSource.m; sourceTree = "<group>"; };
13E102921FA414C400123403 /* IGListReorderableStackSectionControllerTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = IGListReorderableStackSectionControllerTests.m; sourceTree = "<group>"; };
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
1AB7195278D0BBB5DA88D36F /* Pods_IGListKitTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_IGListKitTests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
1D6BFC11D5380CB8311E1029 /* Pods-IGListKit-tvOSTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-IGListKit-tvOSTests.debug.xcconfig"; path = "Pods/Target Support Files/Pods-IGListKit-tvOSTests/Pods-IGListKit-tvOSTests.debug.xcconfig"; sourceTree = "<group>"; };
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C881DAE94E40073E116 /* IGTestSingleNibItemDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestSingleNibItemDataSource.h; sourceTree = "<group>"; };
26271C891DAE94E40073E116 /* IGTestSingleNibItemDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestSingleNibItemDataSource.m; sourceTree = "<group>"; };
26271C8B1DAE96740073E116 /* IGListSingleNibItemControllerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListSingleNibItemControllerTests.m; sourceTree = "<group>"; };
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
2904861C1DCD02140007F41D /* IGTestNibSupplementaryView.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = IGTestNibSupplementaryView.xib; sourceTree = "<group>"; };
2904861E1DCD02750007F41D /* IGTestNibSupplementaryView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestNibSupplementaryView.h; sourceTree = "<group>"; };
2904861F1DCD02750007F41D /* IGTestNibSupplementaryView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestNibSupplementaryView.m; sourceTree = "<group>"; };
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3521E930C89009FE456 /* IGListDebugger.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListDebugger.h; sourceTree = "<group>"; };
290DF3531E930C89009FE456 /* IGListDebugger.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListDebugger.m; sourceTree = "<group>"; };
290DF3561E930CE2009FE456 /* UICollectionView+DebugDescription.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UICollectionView+DebugDescription.h"; sourceTree = "<group>"; };
290DF3571E930CE2009FE456 /* UICollectionView+DebugDescription.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UICollectionView+DebugDescription.m"; sourceTree = "<group>"; };
290DF35E1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "IGListBatchUpdateData+DebugDescription.h"; sourceTree = "<group>"; };
290DF35F1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "IGListBatchUpdateData+DebugDescription.m"; sourceTree = "<group>"; };
290DF3621E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "IGListAdapterUpdater+DebugDescription.h"; sourceTree = "<group>"; };
290DF3631E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "IGListAdapterUpdater+DebugDescription.m"; sourceTree = "<group>"; };
290DF36E1E931457009FE456 /* IGListSectionMap+DebugDescription.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "IGListSectionMap+DebugDescription.h"; sourceTree = "<group>"; };
290DF36F1E931457009FE456 /* IGListSectionMap+DebugDescription.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "IGListSectionMap+DebugDescription.m"; sourceTree = "<group>"; };
290DF3721E931B57009FE456 /* IGListDebuggingUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListDebuggingUtilities.h; sourceTree = "<group>"; };
290DF3731E931B57009FE456 /* IGListDebuggingUtilities.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListDebuggingUtilities.m; sourceTree = "<group>"; };
290DF3761E9323E6009FE456 /* IGListDebuggerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListDebuggerTests.m; sourceTree = "<group>"; };
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926586B1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBindingSectionControllerDataSource.h; sourceTree = "<group>"; };
2926586E1E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBindingSectionControllerSelectionDelegate.h; sourceTree = "<group>"; };
Move section controller mutation API to object provided in update block Summary: We constantly have random bugs pop up when mutations are made outside of a batch update. This change restricts the mutation API to a batch context object (which is just an `IGListAdapter`) so they can only be done **inside an update block**. - Fixed open source project - Confirmed open source examples build - Updated all of Instagram.app to use this API - Changelog breaking changes entry Fixes #392 Reviewed By: jessesquires Differential Revision: D4754129 fbshipit-source-id: 11d32a0fac3e50c9edbb01e92a8a0c7b8a43cf2d
2017-03-22 19:40:51 +00:00
292807381E82CE240077A81C /* IGListBatchContext.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBatchContext.h; sourceTree = "<group>"; };
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841AD202B4F5C00484901 /* IGListAdapterMoveDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterMoveDelegate.h; sourceTree = "<group>"; };
293841AF202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UICollectionViewLayout+InteractiveReordering.h"; sourceTree = "<group>"; };
293841B0202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UICollectionViewLayout+InteractiveReordering.m"; sourceTree = "<group>"; };
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
294369B01DB1B7AE0025F6E7 /* IGTestNibCell.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = IGTestNibCell.xib; sourceTree = "<group>"; };
Unit test moves in containers Summary: Unit testing moves in sets so their `hash` and `isEqual` functions provide uniqueness. Fixes #187, #188 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/217 Differential Revision: D4201042 Pulled By: jessesquires fbshipit-source-id: 9c4803ca11e04bb86a7745d6ebc63d173e8ac814
2016-11-18 02:48:07 +00:00
294AC6311DDE4C19002FCE5D /* IGListDiffResultTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListDiffResultTests.m; sourceTree = "<group>"; };
Add update finished announcer API Summary: Adding a new API to support adding 1:many listeners to observe when an `IGListAdapter` finishes performing an update event. It supports: - `performUpdates:` - `reloadData...` - Even handling update triggered from //inside// a section controller Differential Revision: D6108096 fbshipit-source-id: d0b43d83f1963fdbf6ef388685cbd8f6890177fa
2017-10-20 15:41:01 +00:00
294CDE5E1F98E3A6002CF6E4 /* IGListAdapterUpdateListener.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAdapterUpdateListener.h; sourceTree = "<group>"; };
294CDE611F995DD7002CF6E4 /* IGListAdapterUpdateTester.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IGListAdapterUpdateTester.h; sourceTree = "<group>"; };
294CDE621F995DD7002CF6E4 /* IGListAdapterUpdateTester.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterUpdateTester.m; sourceTree = "<group>"; };
Prevent duplicate item deletes and drop reload collisions Summary: a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in `UICollectionView` where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4) Closes https://github.com/Instagram/IGListKit/pull/657 Reviewed By: jessesquires Differential Revision: D4913790 Pulled By: rnystrom fbshipit-source-id: 8f6fcdd2e2438da309fc64ca0ac111b9a0980149
2017-04-20 00:01:12 +00:00
296AC95A1EA518D3005137E2 /* IGListReloadIndexPath.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListReloadIndexPath.h; sourceTree = "<group>"; };
296AC95B1EA518D3005137E2 /* IGListReloadIndexPath.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListReloadIndexPath.m; sourceTree = "<group>"; };
Track batch updates in object and explicit state Summary: Batch updates are complicated b/c its unknown when the update block will actually execute. When executing the block, we want to collect inserts/deletes/reloads/moves (item and section). Allow mutations to happen synchronously outside of the update block. Tracking state will also help with the auto-diff where we need to allow re-entrant updates. Peeling off a chunk from #494 Issue fixed: #288 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/525 Reviewed By: jessesquires Differential Revision: D4656463 Pulled By: rnystrom fbshipit-source-id: 8f4d3dc21b03d595e02ee9ee9664277e8ead0531
2017-03-07 17:22:22 +00:00
297278BB1E6B58560099D8EA /* IGListBatchUpdates.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBatchUpdates.h; sourceTree = "<group>"; };
297278BC1E6B58560099D8EA /* IGListBatchUpdates.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListBatchUpdates.m; sourceTree = "<group>"; };
297278C31E6B59D50099D8EA /* IGListBatchUpdateState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBatchUpdateState.h; sourceTree = "<group>"; };
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
29822E521FE3473A008532D2 /* IGListCollectionView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListCollectionView.h; sourceTree = "<group>"; };
29822E531FE3473A008532D2 /* IGListCollectionView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListCollectionView.m; sourceTree = "<group>"; };
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9C11E3ACF4800F76F50 /* IGListBindable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBindable.h; sourceTree = "<group>"; };
298DD9C51E3ACFE300F76F50 /* IGListBindingSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBindingSectionController.h; sourceTree = "<group>"; };
298DD9C61E3ACFE300F76F50 /* IGListBindingSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListBindingSectionController.m; sourceTree = "<group>"; };
298DD9CD1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListBindingSectionControllerTests.m; sourceTree = "<group>"; };
298DD9D01E3ADDB400F76F50 /* IGTestDiffingSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestDiffingSectionController.h; sourceTree = "<group>"; };
298DD9D11E3ADDB400F76F50 /* IGTestDiffingSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestDiffingSectionController.m; sourceTree = "<group>"; };
298DD9D81E3ADE3300F76F50 /* IGTestStringBindableCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestStringBindableCell.h; sourceTree = "<group>"; };
298DD9D91E3ADE3300F76F50 /* IGTestStringBindableCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestStringBindableCell.m; sourceTree = "<group>"; };
298DD9E01E3ADE4300F76F50 /* IGTestNumberBindableCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestNumberBindableCell.h; sourceTree = "<group>"; };
298DD9E11E3ADE4300F76F50 /* IGTestNumberBindableCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestNumberBindableCell.m; sourceTree = "<group>"; };
298DD9F81E3AE1AA00F76F50 /* IGTestDiffingObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestDiffingObject.h; sourceTree = "<group>"; };
298DD9F91E3AE1AA00F76F50 /* IGTestDiffingObject.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestDiffingObject.m; sourceTree = "<group>"; };
298DDA0B1E3AE3ED00F76F50 /* IGTestDiffingDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestDiffingDataSource.h; sourceTree = "<group>"; };
298DDA0C1E3AE3ED00F76F50 /* IGTestDiffingDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestDiffingDataSource.m; sourceTree = "<group>"; };
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA1D1E3B0DC800F76F50 /* IGListCollectionViewLayout.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListCollectionViewLayout.h; sourceTree = "<group>"; };
298DDA1E1E3B0DC800F76F50 /* IGListCollectionViewLayout.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = IGListCollectionViewLayout.mm; sourceTree = "<group>"; };
298DDA231E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListCollectionViewLayoutTests.m; sourceTree = "<group>"; };
298DDA261E3B166100F76F50 /* IGLayoutTestDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGLayoutTestDataSource.h; sourceTree = "<group>"; };
298DDA271E3B166100F76F50 /* IGLayoutTestDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGLayoutTestDataSource.m; sourceTree = "<group>"; };
298DDA281E3B166100F76F50 /* IGLayoutTestItem.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGLayoutTestItem.h; sourceTree = "<group>"; };
298DDA291E3B166100F76F50 /* IGLayoutTestItem.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGLayoutTestItem.m; sourceTree = "<group>"; };
298DDA2A1E3B166100F76F50 /* IGLayoutTestSection.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGLayoutTestSection.h; sourceTree = "<group>"; };
298DDA2B1E3B166100F76F50 /* IGLayoutTestSection.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGLayoutTestSection.m; sourceTree = "<group>"; };
Fix binding SC deselection crash and publish 3.1.1 Summary: - Fixed #918 by checking `respondsToSelector:` (boo optionals) - Cut 3.1.1 for immediate publish - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/921 Differential Revision: D5748009 Pulled By: rnystrom fbshipit-source-id: b387b3988abc785f312bc47ac003851283972d7a
2017-08-31 19:35:22 +00:00
2995409A1F588C8D00F647CF /* IGTestBindingWithoutDeselectionDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestBindingWithoutDeselectionDelegate.h; sourceTree = "<group>"; };
2995409B1F588C8D00F647CF /* IGTestBindingWithoutDeselectionDelegate.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestBindingWithoutDeselectionDelegate.m; sourceTree = "<group>"; };
Add unit tests to reloadData updater Summary: Adding a few more missing unit tests. Closes #185 Closes https://github.com/Instagram/IGListKit/pull/289 Differential Revision: D4284610 Pulled By: rnystrom fbshipit-source-id: a592fb9c12a3995a62b608f44cdcc693a0f79bec
2016-12-06 13:54:48 +00:00
2997D4961DF5FC0B005A5DD2 /* IGReloadDataUpdaterTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGReloadDataUpdaterTests.m; sourceTree = "<group>"; };
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C4748A1DDF45E700AE68CE /* IGListAdapterProxyTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterProxyTests.m; sourceTree = "<group>"; };
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5C9E1EA7C70400113926 /* IGListGenericSectionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListGenericSectionController.h; sourceTree = "<group>"; };
29DA5C9F1EA7C70400113926 /* IGListGenericSectionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListGenericSectionController.m; sourceTree = "<group>"; };
29DA5CA21EA7C72400113926 /* IGListGenericSectionControllerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListGenericSectionControllerTests.m; sourceTree = "<group>"; };
Add base test case class for simpler unit testing Summary: Making it simpler to setup tests w/ default config and objects. Less LoC in tests, lower setup cost when creating new test suites. Should I changelog? Issue fixed: #183 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/678 Differential Revision: D4921633 Pulled By: rnystrom fbshipit-source-id: fb4d08acb6ed0ba885cf56ce147f70b304301ff1
2017-04-20 21:35:26 +00:00
29DA5CA61EA7D37000113926 /* IGListTestCase.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestCase.m; sourceTree = "<group>"; };
29DA5CA91EA7D39B00113926 /* IGListTestCase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestCase.h; sourceTree = "<group>"; };
29DA5CAA1EA7D3FF00113926 /* IGListTestHelpers.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestHelpers.h; sourceTree = "<group>"; };
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA76F201FBD870029277A /* IGListMoveIndex.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListMoveIndex.m; sourceTree = "<group>"; };
29DAA770201FBD870029277A /* IGListIndexSetResult.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListIndexSetResult.h; sourceTree = "<group>"; };
29DAA771201FBD870029277A /* IGListMoveIndexPath.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListMoveIndexPath.m; sourceTree = "<group>"; };
29DAA772201FBD870029277A /* IGListDiffable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListDiffable.h; sourceTree = "<group>"; };
29DAA773201FBD870029277A /* NSString+IGListDiffable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSString+IGListDiffable.h"; sourceTree = "<group>"; };
29DAA774201FBD870029277A /* IGListBatchUpdateData.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = IGListBatchUpdateData.mm; sourceTree = "<group>"; };
29DAA775201FBD870029277A /* IGListIndexPathResult.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListIndexPathResult.h; sourceTree = "<group>"; };
29DAA776201FBD870029277A /* NSNumber+IGListDiffable.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSNumber+IGListDiffable.m"; sourceTree = "<group>"; };
29DAA778201FBD870029277A /* IGListIndexSetResultInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListIndexSetResultInternal.h; sourceTree = "<group>"; };
29DAA779201FBD870029277A /* IGListIndexPathResultInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListIndexPathResultInternal.h; sourceTree = "<group>"; };
29DAA77A201FBD870029277A /* IGListArrayUtilsInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListArrayUtilsInternal.h; sourceTree = "<group>"; };
29DAA77B201FBD870029277A /* IGListMoveIndexInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListMoveIndexInternal.h; sourceTree = "<group>"; };
29DAA77C201FBD870029277A /* IGListMoveIndexPathInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListMoveIndexPathInternal.h; sourceTree = "<group>"; };
29DAA77D201FBD870029277A /* IGListCompatibility.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListCompatibility.h; sourceTree = "<group>"; };
29DAA77E201FBD870029277A /* IGListExperiments.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListExperiments.h; sourceTree = "<group>"; };
29DAA77F201FBD870029277A /* IGListIndexSetResult.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListIndexSetResult.m; sourceTree = "<group>"; };
29DAA780201FBD870029277A /* IGListMoveIndexPath.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListMoveIndexPath.h; sourceTree = "<group>"; };
29DAA781201FBD870029277A /* IGListMacros.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListMacros.h; sourceTree = "<group>"; };
29DAA782201FBD870029277A /* IGListMoveIndex.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListMoveIndex.h; sourceTree = "<group>"; };
29DAA783201FBD870029277A /* NSString+IGListDiffable.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSString+IGListDiffable.m"; sourceTree = "<group>"; };
29DAA784201FBD870029277A /* IGListDiff.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = IGListDiff.mm; sourceTree = "<group>"; };
29DAA786201FBD870029277A /* NSNumber+IGListDiffable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSNumber+IGListDiffable.h"; sourceTree = "<group>"; };
29DAA787201FBD870029277A /* IGListAssert.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListAssert.h; sourceTree = "<group>"; };
29DAA788201FBD870029277A /* IGListBatchUpdateData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListBatchUpdateData.h; sourceTree = "<group>"; };
29DAA789201FBD870029277A /* IGListIndexPathResult.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListIndexPathResult.m; sourceTree = "<group>"; };
29DAA78A201FBD870029277A /* IGListDiff.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListDiff.h; sourceTree = "<group>"; };
29DAA7A6201FBD9B0029277A /* IGListTransitionDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTransitionDelegate.h; sourceTree = "<group>"; };
29DAA7A7201FBD9B0029277A /* IGListCollectionViewDelegateLayout.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListCollectionViewDelegateLayout.h; sourceTree = "<group>"; };
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
6A9EB35F1F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IGTestSingleWithoutDeselectionDelegate.h; sourceTree = "<group>"; };
6A9EB3601F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = IGTestSingleWithoutDeselectionDelegate.m; sourceTree = "<group>"; };
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4BE1DB8C95300172ED0 /* IGListSingleStoryboardItemControllerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListSingleStoryboardItemControllerTests.m; sourceTree = "<group>"; };
821BC4C21DB8CAE900172ED0 /* IGTestStoryboard.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; path = IGTestStoryboard.storyboard; sourceTree = "<group>"; };
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
821BC4C71DB8D5B200172ED0 /* IGTestStoryboardViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestStoryboardViewController.h; sourceTree = "<group>"; };
821BC4C81DB8D5B200172ED0 /* IGTestStoryboardViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestStoryboardViewController.m; sourceTree = "<group>"; };
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4CC1DB8D8C500172ED0 /* IGTestStoryboardCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestStoryboardCell.h; sourceTree = "<group>"; };
821BC4CD1DB8D8C500172ED0 /* IGTestStoryboardCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestStoryboardCell.m; sourceTree = "<group>"; };
821BC4D11DB9816E00172ED0 /* IGTestSingleStoryboardItemDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestSingleStoryboardItemDataSource.h; sourceTree = "<group>"; };
821BC4D21DB981AB00172ED0 /* IGTestSingleStoryboardItemDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestSingleStoryboardItemDataSource.m; sourceTree = "<group>"; };
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7EE1DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestStoryboardSupplementaryView.h; sourceTree = "<group>"; };
8240C7EF1DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestStoryboardSupplementaryView.m; sourceTree = "<group>"; };
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
8240C7F11DC284C300B3AAE7 /* IGListAdapterStoryboardTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterStoryboardTests.m; sourceTree = "<group>"; };
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F31DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestStoryboardSupplementarySource.h; sourceTree = "<group>"; };
8240C7F41DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestStoryboardSupplementarySource.m; sourceTree = "<group>"; };
8240C7F61DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestStoryboardSection.h; sourceTree = "<group>"; };
8240C7F71DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestStoryboardSection.m; sourceTree = "<group>"; };
8240C7F91DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestAdapterStoryboardDataSource.h; sourceTree = "<group>"; };
8240C7FA1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestAdapterStoryboardDataSource.m; sourceTree = "<group>"; };
Unit tests for -scrollToObject horizontal end position Summary: Fixes #238 Try to finish what I started 😂 Closes https://github.com/Instagram/IGListKit/pull/247 Differential Revision: D4220011 Pulled By: rnystrom fbshipit-source-id: 9f4e1bd4f112f69f601c83d6604dc18bc27f0c68
2016-11-22 14:38:27 +00:00
8285404A1DE40C6E00118B94 /* IGListTestHorizontalSection.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestHorizontalSection.h; sourceTree = "<group>"; };
8285404B1DE40C6E00118B94 /* IGListTestHorizontalSection.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestHorizontalSection.m; sourceTree = "<group>"; };
8285404E1DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestAdapterHorizontalDataSource.h; sourceTree = "<group>"; };
8285404F1DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestAdapterHorizontalDataSource.m; sourceTree = "<group>"; };
Container Inset Size For Section Controller Summary: Add API for #315. Not sure if this is what you want rnystrom though 🤔. Will add tests after you confirm. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/456 Reviewed By: jessesquires Differential Revision: D4697190 Pulled By: rnystrom fbshipit-source-id: f8513cf2fa33441eb40f486954136553d19dda0c
2017-03-15 16:25:03 +00:00
82914C591E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestContainerSizeSection.h; sourceTree = "<group>"; };
82914C5A1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestContainerSizeSection.m; sourceTree = "<group>"; };
Commit 1a92c15 breaks pbxproj Summary: Update project.pbxproj Closes https://github.com/Instagram/IGListKit/pull/174 Differential Revision: D4147048 Pulled By: rnystrom fbshipit-source-id: 03713030f5604839af3c64f64f3a700e08b3fa94
2016-11-08 14:18:29 +00:00
829D7BA81DD1816400549816 /* IGListSectionMapTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListSectionMapTests.m; sourceTree = "<group>"; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EE21D870EDC007C7F66 /* IGListAdapterE2ETests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterE2ETests.m; sourceTree = "<group>"; };
88144EE31D870EDC007C7F66 /* IGListAdapterTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterTests.m; sourceTree = "<group>"; };
88144EE41D870EDC007C7F66 /* IGListAdapterUpdaterTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListAdapterUpdaterTests.m; sourceTree = "<group>"; };
88144EE51D870EDC007C7F66 /* IGListBatchUpdateDataTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListBatchUpdateDataTests.m; sourceTree = "<group>"; };
88144EE61D870EDC007C7F66 /* IGListDiffSwiftTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = IGListDiffSwiftTests.swift; sourceTree = "<group>"; };
88144EE81D870EDC007C7F66 /* IGListDiffTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListDiffTests.m; sourceTree = "<group>"; };
88144EE91D870EDC007C7F66 /* IGListDisplayHandlerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListDisplayHandlerTests.m; sourceTree = "<group>"; };
88144EEB1D870EDC007C7F66 /* IGListKitTests-Bridging-Header.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "IGListKitTests-Bridging-Header.h"; sourceTree = "<group>"; };
Rename *ItemController unit tests to *SectionController Summary: Rename *ItemController unit tests to *SectionController, addressing issue #126 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/129 Differential Revision: D4095496 Pulled By: rnystrom fbshipit-source-id: 277be38ed2789f14199cee9d711a838552921f10
2016-10-28 14:31:37 +00:00
88144EED1D870EDC007C7F66 /* IGListSingleSectionControllerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListSingleSectionControllerTests.m; sourceTree = "<group>"; };
88144EEE1D870EDC007C7F66 /* IGListStackSectionControllerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListStackSectionControllerTests.m; sourceTree = "<group>"; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EEF1D870EDC007C7F66 /* IGListWorkingRangeHandlerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListWorkingRangeHandlerTests.m; sourceTree = "<group>"; };
88144EF11D870EDC007C7F66 /* IGListTestAdapterDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestAdapterDataSource.h; sourceTree = "<group>"; };
88144EF21D870EDC007C7F66 /* IGListTestAdapterDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestAdapterDataSource.m; sourceTree = "<group>"; };
88144EF31D870EDC007C7F66 /* IGListTestOffsettingLayout.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestOffsettingLayout.h; sourceTree = "<group>"; };
88144EF41D870EDC007C7F66 /* IGListTestOffsettingLayout.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestOffsettingLayout.m; sourceTree = "<group>"; };
88144EF51D870EDC007C7F66 /* IGListTestSection.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestSection.h; sourceTree = "<group>"; };
88144EF61D870EDC007C7F66 /* IGListTestSection.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestSection.m; sourceTree = "<group>"; };
88144EF71D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListTestUICollectionViewDataSource.h; sourceTree = "<group>"; };
88144EF81D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGListTestUICollectionViewDataSource.m; sourceTree = "<group>"; };
88144EF91D870EDC007C7F66 /* IGTestCell.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestCell.h; sourceTree = "<group>"; };
88144EFA1D870EDC007C7F66 /* IGTestCell.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestCell.m; sourceTree = "<group>"; };
88144EFB1D870EDC007C7F66 /* IGTestDelegateController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestDelegateController.h; sourceTree = "<group>"; };
88144EFC1D870EDC007C7F66 /* IGTestDelegateController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestDelegateController.m; sourceTree = "<group>"; };
88144EFD1D870EDC007C7F66 /* IGTestDelegateDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestDelegateDataSource.h; sourceTree = "<group>"; };
88144EFE1D870EDC007C7F66 /* IGTestDelegateDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestDelegateDataSource.m; sourceTree = "<group>"; };
88144EFF1D870EDC007C7F66 /* IGTestObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestObject.h; sourceTree = "<group>"; };
88144F001D870EDC007C7F66 /* IGTestObject.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestObject.m; sourceTree = "<group>"; };
88144F011D870EDC007C7F66 /* IGTestSingleItemDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestSingleItemDataSource.h; sourceTree = "<group>"; };
88144F021D870EDC007C7F66 /* IGTestSingleItemDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestSingleItemDataSource.m; sourceTree = "<group>"; };
88144F031D870EDC007C7F66 /* IGTestStackedDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestStackedDataSource.h; sourceTree = "<group>"; };
88144F041D870EDC007C7F66 /* IGTestStackedDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestStackedDataSource.m; sourceTree = "<group>"; };
88144F051D870EDC007C7F66 /* IGTestSupplementarySource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGTestSupplementarySource.h; sourceTree = "<group>"; };
88144F061D870EDC007C7F66 /* IGTestSupplementarySource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = IGTestSupplementarySource.m; sourceTree = "<group>"; };
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D41DC51A0D009CE2B4 /* IGListKit.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = IGListKit.framework; sourceTree = BUILT_PRODUCTS_DIR; };
885FE1DC1DC51A0D009CE2B4 /* IGListKit-tvOSTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "IGListKit-tvOSTests.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B361D870D7E009E01F7 /* IGListKit.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = IGListKit.framework; sourceTree = BUILT_PRODUCTS_DIR; };
887D0B3F1D870D7F009E01F7 /* IGListKitTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = IGListKitTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
887D0B571D870E1E009E01F7 /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF897C1E010E6A00B1B9B4 /* IGListKit-macOSTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "IGListKit-macOSTests.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
fixed broken example project Summary: - The recent addition of `IGListCollectionViewLayoutInternal.h` in a80245a696d0fe96777f796eef92cef5942aed7c broke the example project. This PR fixes this. - Name sorted the internal files - [x] All tests pass. Demo project builds and runs. - [x] Why didnt Travis catch this? 🤔 - [X] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/569 Differential Revision: D4740682 Pulled By: rnystrom fbshipit-source-id: 2c57d03f9751d14edf35741eaa97d0ae8a2f167a
2017-03-20 21:42:55 +00:00
917E89871E800EE70015F934 /* IGListCollectionViewLayoutInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IGListCollectionViewLayoutInternal.h; sourceTree = "<group>"; };
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
9574C58371B7A46F62E9AC24 /* Pods-IGListKitTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-IGListKitTests.release.xcconfig"; path = "Pods/Target Support Files/Pods-IGListKitTests/Pods-IGListKitTests.release.xcconfig"; sourceTree = "<group>"; };
CA8726D7FF3608E20E9F7EC6 /* Pods-IGListKitTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-IGListKitTests.debug.xcconfig"; path = "Pods/Target Support Files/Pods-IGListKitTests/Pods-IGListKitTests.debug.xcconfig"; sourceTree = "<group>"; };
Move UICollectionView(DataSource|Delegate) to category Summary: This reduces the quantity of the code within IGListAdapter.m and is a bit more in line with Swift style of putting protocol conformance into extensions. This does not change functionality just rearranges where code lives. - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [N/A] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [N/A] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/599 Reviewed By: jessesquires Differential Revision: D4861777 Pulled By: amonshiz fbshipit-source-id: eaa31aa9438f3892193aeb8b4ae580ba2960ee8b
2017-04-18 18:07:34 +00:00
DA5F48491E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "IGListAdapter+UICollectionView.h"; sourceTree = "<group>"; };
DA5F484A1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "IGListAdapter+UICollectionView.m"; sourceTree = "<group>"; };
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152AC1DE227FA00AC9D2C /* IGListKit.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = IGListKit.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Add new iOS 11 api adjustedContentInset support Summary: adopt adjustedContentInset instead of contentInset on iOS 11 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1020 Reviewed By: manicakes Differential Revision: D6513703 Pulled By: rnystrom fbshipit-source-id: 5d718f2cb30361959ca5ba8238746427223cb5fd
2017-12-18 16:33:24 +00:00
E8B5C7391FC431D400C26914 /* UIScrollView+IGListKit.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIScrollView+IGListKit.h"; sourceTree = "<group>"; };
E8B5C73A1FC431D400C26914 /* UIScrollView+IGListKit.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UIScrollView+IGListKit.m"; sourceTree = "<group>"; };
E8D312DF1FC472A60009FA2F /* IGListContentInsetTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = IGListContentInsetTests.m; sourceTree = "<group>"; };
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
E980179F5E885E417EB20D55 /* Pods_IGListKit_tvOSTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_IGListKit_tvOSTests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXFileReference section */
/* Begin PBXFrameworksBuildPhase section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D01DC51A0D009CE2B4 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
885FE1D91DC51A0D009CE2B4 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
885FE1DD1DC51A0D009CE2B4 /* IGListKit.framework in Frameworks */,
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
262373C2015556E71A70FA30 /* Pods_IGListKit_tvOSTests.framework in Frameworks */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B321D870D7E009E01F7 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
887D0B3C1D870D7F009E01F7 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
887D0B401D870D7F009E01F7 /* IGListKit.framework in Frameworks */,
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
DD468D380BBF350ACE7EA28B /* Pods_IGListKitTests.framework in Frameworks */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89791E010E6A00B1B9B4 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
88DF89811E010E6A00B1B9B4 /* IGListKit.framework in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD31527B1DE227FA00AC9D2C /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXFrameworksBuildPhase section */
/* Begin PBXGroup section */
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B927E1E08D7F5008390ED /* Source */ = {
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
isa = PBXGroup;
children = (
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA76E201FBD870029277A /* Common */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B929A1E08D7F5008390ED /* IGListAdapter.h */,
Header/.m/.mm order clean up #416 Summary: Moved .m and .mm files directly below header file for easier project navigation. Closes https://github.com/Instagram/IGListKit/pull/417 Differential Revision: D4430737 Pulled By: rnystrom fbshipit-source-id: 6e67566c38c1804ce995ba48148734587cb93c74
2017-01-18 21:10:55 +00:00
0B3B929B1E08D7F5008390ED /* IGListAdapter.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B929C1E08D7F5008390ED /* IGListAdapterDataSource.h */,
0B3B929D1E08D7F5008390ED /* IGListAdapterDelegate.h */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841AD202B4F5C00484901 /* IGListAdapterMoveDelegate.h */,
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
294CDE5E1F98E3A6002CF6E4 /* IGListAdapterUpdateListener.h */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B929E1E08D7F5008390ED /* IGListAdapterUpdater.h */,
Header/.m/.mm order clean up #416 Summary: Moved .m and .mm files directly below header file for easier project navigation. Closes https://github.com/Instagram/IGListKit/pull/417 Differential Revision: D4430737 Pulled By: rnystrom fbshipit-source-id: 6e67566c38c1804ce995ba48148734587cb93c74
2017-01-18 21:10:55 +00:00
0B3B929F1E08D7F5008390ED /* IGListAdapterUpdater.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92A01E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h */,
Move section controller mutation API to object provided in update block Summary: We constantly have random bugs pop up when mutations are made outside of a batch update. This change restricts the mutation API to a batch context object (which is just an `IGListAdapter`) so they can only be done **inside an update block**. - Fixed open source project - Confirmed open source examples build - Updated all of Instagram.app to use this API - Changelog breaking changes entry Fixes #392 Reviewed By: jessesquires Differential Revision: D4754129 fbshipit-source-id: 11d32a0fac3e50c9edbb01e92a8a0c7b8a43cf2d
2017-03-22 19:40:51 +00:00
292807381E82CE240077A81C /* IGListBatchContext.h */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9C11E3ACF4800F76F50 /* IGListBindable.h */,
298DD9C51E3ACFE300F76F50 /* IGListBindingSectionController.h */,
298DD9C61E3ACFE300F76F50 /* IGListBindingSectionController.m */,
2926586B1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h */,
2926586E1E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92A11E08D7F5008390ED /* IGListCollectionContext.h */,
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
29822E521FE3473A008532D2 /* IGListCollectionView.h */,
29822E531FE3473A008532D2 /* IGListCollectionView.m */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A7201FBD9B0029277A /* IGListCollectionViewDelegateLayout.h */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA1D1E3B0DC800F76F50 /* IGListCollectionViewLayout.h */,
298DDA1E1E3B0DC800F76F50 /* IGListCollectionViewLayout.mm */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92A41E08D7F5008390ED /* IGListDisplayDelegate.h */,
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5C9E1EA7C70400113926 /* IGListGenericSectionController.h */,
29DA5C9F1EA7C70400113926 /* IGListGenericSectionController.m */,
Added Subspec for Diffing Summary: So the main Podspec file now has two Subspecs, `Diffing` and for lack of better name `Default`. `Diffing` is purely the files within the common directories (used for Diffing, if in the future we support MacOS NSCollectionView then this may need changing). `Default` depends on `Diffing` but also adds all the non-common files. To use it via CocoaPods, nothing changes. You `import IGListKit` and you will only have access to the files in the pod you use. (So if you use `IGListKit/Diffing` in your Podfile, then you will only get access to the diffing files). If you do a manual installation, or I assume via Carthage, then you will need to import the correct header file (either `IGListDiffKit.h` or `IGListKit.h` depending on what you want). Turns out CocoaPods creates it's own umbrella header (unless you tell it otherwise) meaning our ones are unused by it. Just to confirm `IGListKit` in your Podfile will give you everything, only if you add `/Diffing` will you "opt-out" o Closes https://github.com/Instagram/IGListKit/pull/368 Differential Revision: D4367438 Pulled By: jessesquires fbshipit-source-id: 272318ca551e7e8c4177ca3ca501fde23bd9705a
2016-12-27 20:37:57 +00:00
0B3B928B1E08D7F5008390ED /* IGListKit.h */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92A71E08D7F5008390ED /* IGListReloadDataUpdater.h */,
Header/.m/.mm order clean up #416 Summary: Moved .m and .mm files directly below header file for easier project navigation. Closes https://github.com/Instagram/IGListKit/pull/417 Differential Revision: D4430737 Pulled By: rnystrom fbshipit-source-id: 6e67566c38c1804ce995ba48148734587cb93c74
2017-01-18 21:10:55 +00:00
0B3B92A81E08D7F5008390ED /* IGListReloadDataUpdater.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92A91E08D7F5008390ED /* IGListScrollDelegate.h */,
0B3B92AA1E08D7F5008390ED /* IGListSectionController.h */,
Header/.m/.mm order clean up #416 Summary: Moved .m and .mm files directly below header file for easier project navigation. Closes https://github.com/Instagram/IGListKit/pull/417 Differential Revision: D4430737 Pulled By: rnystrom fbshipit-source-id: 6e67566c38c1804ce995ba48148734587cb93c74
2017-01-18 21:10:55 +00:00
0B3B92AB1E08D7F5008390ED /* IGListSectionController.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92AD1E08D7F5008390ED /* IGListSingleSectionController.h */,
Header/.m/.mm order clean up #416 Summary: Moved .m and .mm files directly below header file for easier project navigation. Closes https://github.com/Instagram/IGListKit/pull/417 Differential Revision: D4430737 Pulled By: rnystrom fbshipit-source-id: 6e67566c38c1804ce995ba48148734587cb93c74
2017-01-18 21:10:55 +00:00
0B3B92AE1E08D7F5008390ED /* IGListSingleSectionController.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92AF1E08D7F5008390ED /* IGListStackedSectionController.h */,
Header/.m/.mm order clean up #416 Summary: Moved .m and .mm files directly below header file for easier project navigation. Closes https://github.com/Instagram/IGListKit/pull/417 Differential Revision: D4430737 Pulled By: rnystrom fbshipit-source-id: 6e67566c38c1804ce995ba48148734587cb93c74
2017-01-18 21:10:55 +00:00
0B3B92B01E08D7F5008390ED /* IGListStackedSectionController.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92B11E08D7F5008390ED /* IGListSupplementaryViewSource.h */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A6201FBD9B0029277A /* IGListTransitionDelegate.h */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92B21E08D7F5008390ED /* IGListUpdatingDelegate.h */,
0B3B92B31E08D7F5008390ED /* IGListWorkingRangeDelegate.h */,
0B3B92B41E08D7F5008390ED /* Info.plist */,
0B3B92B51E08D7F5008390ED /* Internal */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
);
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
path = Source;
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
sourceTree = "<group>";
};
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92B51E08D7F5008390ED /* Internal */ = {
isa = PBXGroup;
children = (
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0AB1F1ADA1600460F79 /* IGListAdapter+DebugDescription.h */,
0D52F0AC1F1ADA1600460F79 /* IGListAdapter+DebugDescription.m */,
Move UICollectionView(DataSource|Delegate) to category Summary: This reduces the quantity of the code within IGListAdapter.m and is a bit more in line with Swift style of putting protocol conformance into extensions. This does not change functionality just rearranges where code lives. - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [N/A] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [N/A] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/599 Reviewed By: jessesquires Differential Revision: D4861777 Pulled By: amonshiz fbshipit-source-id: eaa31aa9438f3892193aeb8b4ae580ba2960ee8b
2017-04-18 18:07:34 +00:00
DA5F48491E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.h */,
DA5F484A1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92B61E08D7F5008390ED /* IGListAdapterInternal.h */,
0B3B92B71E08D7F5008390ED /* IGListAdapterProxy.h */,
0B3B92B81E08D7F5008390ED /* IGListAdapterProxy.m */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3621E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.h */,
290DF3631E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92B91E08D7F5008390ED /* IGListAdapterUpdaterInternal.h */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF35E1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.h */,
290DF35F1E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.m */,
Track batch updates in object and explicit state Summary: Batch updates are complicated b/c its unknown when the update block will actually execute. When executing the block, we want to collect inserts/deletes/reloads/moves (item and section). Allow mutations to happen synchronously outside of the update block. Tracking state will also help with the auto-diff where we need to allow re-entrant updates. Peeling off a chunk from #494 Issue fixed: #288 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/525 Reviewed By: jessesquires Differential Revision: D4656463 Pulled By: rnystrom fbshipit-source-id: 8f4d3dc21b03d595e02ee9ee9664277e8ead0531
2017-03-07 17:22:22 +00:00
297278BB1E6B58560099D8EA /* IGListBatchUpdates.h */,
297278BC1E6B58560099D8EA /* IGListBatchUpdates.m */,
fixed broken example project Summary: - The recent addition of `IGListCollectionViewLayoutInternal.h` in a80245a696d0fe96777f796eef92cef5942aed7c broke the example project. This PR fixes this. - Name sorted the internal files - [x] All tests pass. Demo project builds and runs. - [x] Why didnt Travis catch this? 🤔 - [X] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/569 Differential Revision: D4740682 Pulled By: rnystrom fbshipit-source-id: 2c57d03f9751d14edf35741eaa97d0ae8a2f167a
2017-03-20 21:42:55 +00:00
297278C31E6B59D50099D8EA /* IGListBatchUpdateState.h */,
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
0D52F0B31F1AE81800460F79 /* IGListBindingSectionController+DebugDescription.h */,
0D52F0B51F1AE8BD00460F79 /* IGListBindingSectionController+DebugDescription.m */,
fixed broken example project Summary: - The recent addition of `IGListCollectionViewLayoutInternal.h` in a80245a696d0fe96777f796eef92cef5942aed7c broke the example project. This PR fixes this. - Name sorted the internal files - [x] All tests pass. Demo project builds and runs. - [x] Why didnt Travis catch this? 🤔 - [X] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/569 Differential Revision: D4740682 Pulled By: rnystrom fbshipit-source-id: 2c57d03f9751d14edf35741eaa97d0ae8a2f167a
2017-03-20 21:42:55 +00:00
917E89871E800EE70015F934 /* IGListCollectionViewLayoutInternal.h */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3521E930C89009FE456 /* IGListDebugger.h */,
290DF3531E930C89009FE456 /* IGListDebugger.m */,
290DF3721E931B57009FE456 /* IGListDebuggingUtilities.h */,
290DF3731E931B57009FE456 /* IGListDebuggingUtilities.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92BA1E08D7F5008390ED /* IGListDisplayHandler.h */,
0B3B92BB1E08D7F5008390ED /* IGListDisplayHandler.m */,
Prevent duplicate item deletes and drop reload collisions Summary: a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in `UICollectionView` where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4) Closes https://github.com/Instagram/IGListKit/pull/657 Reviewed By: jessesquires Differential Revision: D4913790 Pulled By: rnystrom fbshipit-source-id: 8f6fcdd2e2438da309fc64ca0ac111b9a0980149
2017-04-20 00:01:12 +00:00
296AC95A1EA518D3005137E2 /* IGListReloadIndexPath.h */,
296AC95B1EA518D3005137E2 /* IGListReloadIndexPath.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92BC1E08D7F5008390ED /* IGListSectionControllerInternal.h */,
0B3B92BD1E08D7F5008390ED /* IGListSectionMap.h */,
0B3B92BE1E08D7F5008390ED /* IGListSectionMap.m */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF36E1E931457009FE456 /* IGListSectionMap+DebugDescription.h */,
290DF36F1E931457009FE456 /* IGListSectionMap+DebugDescription.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92BF1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h */,
0B3B92C01E08D7F5008390ED /* IGListWorkingRangeHandler.h */,
0B3B92C11E08D7F5008390ED /* IGListWorkingRangeHandler.mm */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3561E930CE2009FE456 /* UICollectionView+DebugDescription.h */,
290DF3571E930CE2009FE456 /* UICollectionView+DebugDescription.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92C21E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h */,
0B3B92C31E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841AF202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.h */,
293841B0202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.m */,
Add new iOS 11 api adjustedContentInset support Summary: adopt adjustedContentInset instead of contentInset on iOS 11 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1020 Reviewed By: manicakes Differential Revision: D6513703 Pulled By: rnystrom fbshipit-source-id: 5d718f2cb30361959ca5ba8238746427223cb5fd
2017-12-18 16:33:24 +00:00
E8B5C7391FC431D400C26914 /* UIScrollView+IGListKit.h */,
E8B5C73A1FC431D400C26914 /* UIScrollView+IGListKit.m */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
);
path = Internal;
sourceTree = "<group>";
};
294369AF1DB1B7AE0025F6E7 /* Assets */ = {
isa = PBXGroup;
children = (
294369B01DB1B7AE0025F6E7 /* IGTestNibCell.xib */,
2904861C1DCD02140007F41D /* IGTestNibSupplementaryView.xib */,
821BC4C21DB8CAE900172ED0 /* IGTestStoryboard.storyboard */,
);
path = Assets;
sourceTree = "<group>";
};
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA76E201FBD870029277A /* Common */ = {
isa = PBXGroup;
children = (
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA787201FBD870029277A /* IGListAssert.h */,
29DAA788201FBD870029277A /* IGListBatchUpdateData.h */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA774201FBD870029277A /* IGListBatchUpdateData.mm */,
29DAA77D201FBD870029277A /* IGListCompatibility.h */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA78A201FBD870029277A /* IGListDiff.h */,
29DAA784201FBD870029277A /* IGListDiff.mm */,
29DAA772201FBD870029277A /* IGListDiffable.h */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA77E201FBD870029277A /* IGListExperiments.h */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA775201FBD870029277A /* IGListIndexPathResult.h */,
29DAA789201FBD870029277A /* IGListIndexPathResult.m */,
29DAA770201FBD870029277A /* IGListIndexSetResult.h */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA77F201FBD870029277A /* IGListIndexSetResult.m */,
29DAA781201FBD870029277A /* IGListMacros.h */,
29DAA782201FBD870029277A /* IGListMoveIndex.h */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA76F201FBD870029277A /* IGListMoveIndex.m */,
29DAA780201FBD870029277A /* IGListMoveIndexPath.h */,
29DAA771201FBD870029277A /* IGListMoveIndexPath.m */,
29DAA777201FBD870029277A /* Internal */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA786201FBD870029277A /* NSNumber+IGListDiffable.h */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29DAA776201FBD870029277A /* NSNumber+IGListDiffable.m */,
29DAA773201FBD870029277A /* NSString+IGListDiffable.h */,
29DAA783201FBD870029277A /* NSString+IGListDiffable.m */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
);
path = Common;
sourceTree = "<group>";
};
29DAA777201FBD870029277A /* Internal */ = {
isa = PBXGroup;
children = (
29DAA77A201FBD870029277A /* IGListArrayUtilsInternal.h */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
29DAA779201FBD870029277A /* IGListIndexPathResultInternal.h */,
29DAA778201FBD870029277A /* IGListIndexSetResultInternal.h */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA77B201FBD870029277A /* IGListMoveIndexInternal.h */,
29DAA77C201FBD870029277A /* IGListMoveIndexPathInternal.h */,
);
path = Internal;
sourceTree = "<group>";
};
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
30B5A6475AE0ACFF15B23D2B /* Pods */ = {
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
isa = PBXGroup;
children = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
1D6BFC11D5380CB8311E1029 /* Pods-IGListKit-tvOSTests.debug.xcconfig */,
08F0B0FD0690F4FC46DDF21B /* Pods-IGListKit-tvOSTests.release.xcconfig */,
CA8726D7FF3608E20E9F7EC6 /* Pods-IGListKitTests.debug.xcconfig */,
9574C58371B7A46F62E9AC24 /* Pods-IGListKitTests.release.xcconfig */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
name = Pods;
sourceTree = "<group>";
};
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
41882EBBC340173A8053E3AF /* Frameworks */ = {
isa = PBXGroup;
children = (
E980179F5E885E417EB20D55 /* Pods_IGListKit_tvOSTests.framework */,
1AB7195278D0BBB5DA88D36F /* Pods_IGListKitTests.framework */,
);
name = Frameworks;
sourceTree = "<group>";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EF01D870EDC007C7F66 /* Objects */ = {
isa = PBXGroup;
children = (
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA261E3B166100F76F50 /* IGLayoutTestDataSource.h */,
298DDA271E3B166100F76F50 /* IGLayoutTestDataSource.m */,
298DDA281E3B166100F76F50 /* IGLayoutTestItem.h */,
298DDA291E3B166100F76F50 /* IGLayoutTestItem.m */,
298DDA2A1E3B166100F76F50 /* IGLayoutTestSection.h */,
298DDA2B1E3B166100F76F50 /* IGLayoutTestSection.m */,
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
294CDE611F995DD7002CF6E4 /* IGListAdapterUpdateTester.h */,
294CDE621F995DD7002CF6E4 /* IGListAdapterUpdateTester.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EF11D870EDC007C7F66 /* IGListTestAdapterDataSource.h */,
88144EF21D870EDC007C7F66 /* IGListTestAdapterDataSource.m */,
Unit tests for -scrollToObject horizontal end position Summary: Fixes #238 Try to finish what I started 😂 Closes https://github.com/Instagram/IGListKit/pull/247 Differential Revision: D4220011 Pulled By: rnystrom fbshipit-source-id: 9f4e1bd4f112f69f601c83d6604dc18bc27f0c68
2016-11-22 14:38:27 +00:00
8285404E1DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.h */,
8285404F1DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01711FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.h */,
13DF01721FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m */,
13E1028A1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.h */,
13E1028B1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F91DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.h */,
8240C7FA1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m */,
Add base test case class for simpler unit testing Summary: Making it simpler to setup tests w/ default config and objects. Less LoC in tests, lower setup cost when creating new test suites. Should I changelog? Issue fixed: #183 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/678 Differential Revision: D4921633 Pulled By: rnystrom fbshipit-source-id: fb4d08acb6ed0ba885cf56ce147f70b304301ff1
2017-04-20 21:35:26 +00:00
82914C591E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.h */,
82914C5A1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m */,
Add more unit tests to stack section controller Summary: Beefing up our test coverage. Made an improvement to supplementary view behavior along the way. Will update `CHANGELOG.md` once travis finishes w/ link to PR #. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/286 Differential Revision: D4281961 Pulled By: jessesquires fbshipit-source-id: 32b5877bd72250b9a99e600ceffc64d686fa5651
2016-12-06 01:38:56 +00:00
8285404A1DE40C6E00118B94 /* IGListTestHorizontalSection.h */,
8285404B1DE40C6E00118B94 /* IGListTestHorizontalSection.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EF31D870EDC007C7F66 /* IGListTestOffsettingLayout.h */,
88144EF41D870EDC007C7F66 /* IGListTestOffsettingLayout.m */,
88144EF51D870EDC007C7F66 /* IGListTestSection.h */,
88144EF61D870EDC007C7F66 /* IGListTestSection.m */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F61DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.h */,
8240C7F71DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EF71D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.h */,
88144EF81D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.m */,
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
2995409A1F588C8D00F647CF /* IGTestBindingWithoutDeselectionDelegate.h */,
2995409B1F588C8D00F647CF /* IGTestBindingWithoutDeselectionDelegate.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EF91D870EDC007C7F66 /* IGTestCell.h */,
88144EFA1D870EDC007C7F66 /* IGTestCell.m */,
88144EFB1D870EDC007C7F66 /* IGTestDelegateController.h */,
88144EFC1D870EDC007C7F66 /* IGTestDelegateController.m */,
88144EFD1D870EDC007C7F66 /* IGTestDelegateDataSource.h */,
88144EFE1D870EDC007C7F66 /* IGTestDelegateDataSource.m */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA0B1E3AE3ED00F76F50 /* IGTestDiffingDataSource.h */,
298DDA0C1E3AE3ED00F76F50 /* IGTestDiffingDataSource.m */,
298DD9F81E3AE1AA00F76F50 /* IGTestDiffingObject.h */,
298DD9F91E3AE1AA00F76F50 /* IGTestDiffingObject.m */,
298DD9D01E3ADDB400F76F50 /* IGTestDiffingSectionController.h */,
298DD9D11E3ADDB400F76F50 /* IGTestDiffingSectionController.m */,
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
2904861E1DCD02750007F41D /* IGTestNibSupplementaryView.h */,
2904861F1DCD02750007F41D /* IGTestNibSupplementaryView.m */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9E01E3ADE4300F76F50 /* IGTestNumberBindableCell.h */,
298DD9E11E3ADE4300F76F50 /* IGTestNumberBindableCell.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EFF1D870EDC007C7F66 /* IGTestObject.h */,
88144F001D870EDC007C7F66 /* IGTestObject.m */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01751FA1000E0092A320 /* IGTestReorderableSection.h */,
13DF01761FA1000E0092A320 /* IGTestReorderableSection.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F011D870EDC007C7F66 /* IGTestSingleItemDataSource.h */,
88144F021D870EDC007C7F66 /* IGTestSingleItemDataSource.m */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C881DAE94E40073E116 /* IGTestSingleNibItemDataSource.h */,
26271C891DAE94E40073E116 /* IGTestSingleNibItemDataSource.m */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4D11DB9816E00172ED0 /* IGTestSingleStoryboardItemDataSource.h */,
821BC4D21DB981AB00172ED0 /* IGTestSingleStoryboardItemDataSource.m */,
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
6A9EB35F1F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.h */,
6A9EB3601F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F031D870EDC007C7F66 /* IGTestStackedDataSource.h */,
88144F041D870EDC007C7F66 /* IGTestStackedDataSource.m */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
821BC4CC1DB8D8C500172ED0 /* IGTestStoryboardCell.h */,
821BC4CD1DB8D8C500172ED0 /* IGTestStoryboardCell.m */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F31DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.h */,
8240C7F41DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.m */,
8240C7EE1DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.h */,
8240C7EF1DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.m */,
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
821BC4C71DB8D5B200172ED0 /* IGTestStoryboardViewController.h */,
821BC4C81DB8D5B200172ED0 /* IGTestStoryboardViewController.m */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9D81E3ADE3300F76F50 /* IGTestStringBindableCell.h */,
298DD9D91E3ADE3300F76F50 /* IGTestStringBindableCell.m */,
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
88144F051D870EDC007C7F66 /* IGTestSupplementarySource.h */,
88144F061D870EDC007C7F66 /* IGTestSupplementarySource.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
path = Objects;
sourceTree = "<group>";
};
887D0B2C1D870D7E009E01F7 = {
isa = PBXGroup;
children = (
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
41882EBBC340173A8053E3AF /* Frameworks */,
30B5A6475AE0ACFF15B23D2B /* Pods */,
887D0B371D870D7E009E01F7 /* Products */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B927E1E08D7F5008390ED /* Source */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B551D870E1E009E01F7 /* Tests */,
);
sourceTree = "<group>";
Set Project Indentation to Use Spaces, Not Tabs Summary: Killer framework! Closes https://github.com/Instagram/IGListKit/pull/502 Differential Revision: D4591116 Pulled By: rnystrom fbshipit-source-id: 5f0ad7a6aa555cd75c5c5b306b321d70f7d98447
2017-02-21 15:04:47 +00:00
usesTabs = 0;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
887D0B371D870D7E009E01F7 /* Products */ = {
isa = PBXGroup;
children = (
887D0B361D870D7E009E01F7 /* IGListKit.framework */,
887D0B3F1D870D7F009E01F7 /* IGListKitTests.xctest */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D41DC51A0D009CE2B4 /* IGListKit.framework */,
885FE1DC1DC51A0D009CE2B4 /* IGListKit-tvOSTests.xctest */,
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152AC1DE227FA00AC9D2C /* IGListKit.framework */,
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF897C1E010E6A00B1B9B4 /* IGListKit-macOSTests.xctest */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
name = Products;
sourceTree = "<group>";
};
887D0B551D870E1E009E01F7 /* Tests */ = {
isa = PBXGroup;
children = (
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
294369AF1DB1B7AE0025F6E7 /* Assets */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EE21D870EDC007C7F66 /* IGListAdapterE2ETests.m */,
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C4748A1DDF45E700AE68CE /* IGListAdapterProxyTests.m */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F11DC284C300B3AAE7 /* IGListAdapterStoryboardTests.m */,
Unit test moves in containers Summary: Unit testing moves in sets so their `hash` and `isEqual` functions provide uniqueness. Fixes #187, #188 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/217 Differential Revision: D4201042 Pulled By: jessesquires fbshipit-source-id: 9c4803ca11e04bb86a7745d6ebc63d173e8ac814
2016-11-18 02:48:07 +00:00
88144EE31D870EDC007C7F66 /* IGListAdapterTests.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EE41D870EDC007C7F66 /* IGListAdapterUpdaterTests.m */,
88144EE51D870EDC007C7F66 /* IGListBatchUpdateDataTests.m */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9CD1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA231E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
E8D312DF1FC472A60009FA2F /* IGListContentInsetTests.m */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3761E9323E6009FE456 /* IGListDebuggerTests.m */,
Unit test moves in containers Summary: Unit testing moves in sets so their `hash` and `isEqual` functions provide uniqueness. Fixes #187, #188 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/217 Differential Revision: D4201042 Pulled By: jessesquires fbshipit-source-id: 9c4803ca11e04bb86a7745d6ebc63d173e8ac814
2016-11-18 02:48:07 +00:00
294AC6311DDE4C19002FCE5D /* IGListDiffResultTests.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EE61D870EDC007C7F66 /* IGListDiffSwiftTests.swift */,
88144EE81D870EDC007C7F66 /* IGListDiffTests.m */,
88144EE91D870EDC007C7F66 /* IGListDisplayHandlerTests.m */,
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5CA21EA7C72400113926 /* IGListGenericSectionControllerTests.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EEB1D870EDC007C7F66 /* IGListKitTests-Bridging-Header.h */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13E102921FA414C400123403 /* IGListReorderableStackSectionControllerTests.m */,
Unit test moves in containers Summary: Unit testing moves in sets so their `hash` and `isEqual` functions provide uniqueness. Fixes #187, #188 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/217 Differential Revision: D4201042 Pulled By: jessesquires fbshipit-source-id: 9c4803ca11e04bb86a7745d6ebc63d173e8ac814
2016-11-18 02:48:07 +00:00
829D7BA81DD1816400549816 /* IGListSectionMapTests.m */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8B1DAE96740073E116 /* IGListSingleNibItemControllerTests.m */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
88144EED1D870EDC007C7F66 /* IGListSingleSectionControllerTests.m */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4BE1DB8C95300172ED0 /* IGListSingleStoryboardItemControllerTests.m */,
Rename *ItemController unit tests to *SectionController Summary: Rename *ItemController unit tests to *SectionController, addressing issue #126 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/129 Differential Revision: D4095496 Pulled By: rnystrom fbshipit-source-id: 277be38ed2789f14199cee9d711a838552921f10
2016-10-28 14:31:37 +00:00
88144EEE1D870EDC007C7F66 /* IGListStackSectionControllerTests.m */,
Add base test case class for simpler unit testing Summary: Making it simpler to setup tests w/ default config and objects. Less LoC in tests, lower setup cost when creating new test suites. Should I changelog? Issue fixed: #183 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/678 Differential Revision: D4921633 Pulled By: rnystrom fbshipit-source-id: fb4d08acb6ed0ba885cf56ce147f70b304301ff1
2017-04-20 21:35:26 +00:00
29DA5CA91EA7D39B00113926 /* IGListTestCase.h */,
29DA5CA61EA7D37000113926 /* IGListTestCase.m */,
29DA5CAA1EA7D3FF00113926 /* IGListTestHelpers.h */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144EEF1D870EDC007C7F66 /* IGListWorkingRangeHandlerTests.m */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
2997D4961DF5FC0B005A5DD2 /* IGReloadDataUpdaterTests.m */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B571D870E1E009E01F7 /* Info.plist */,
88144EF01D870EDC007C7F66 /* Objects */,
);
path = Tests;
sourceTree = "<group>";
};
/* End PBXGroup section */
/* Begin PBXHeadersBuildPhase section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D11DC51A0D009CE2B4 /* Headers */ = {
isa = PBXHeadersBuildPhase;
buildActionMask = 2147483647;
files = (
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92FB1E08D7F5008390ED /* IGListAdapterDataSource.h in Headers */,
Add update finished announcer API Summary: Adding a new API to support adding 1:many listeners to observe when an `IGListAdapter` finishes performing an update event. It supports: - `performUpdates:` - `reloadData...` - Even handling update triggered from //inside// a section controller Differential Revision: D6108096 fbshipit-source-id: d0b43d83f1963fdbf6ef388685cbd8f6890177fa
2017-10-20 15:41:01 +00:00
294CDE601F995488002CF6E4 /* IGListAdapterUpdateListener.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
88379717202231E400B94676 /* IGListIndexSetResultInternal.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B930B1E08D7F5008390ED /* IGListDisplayDelegate.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883797042022304D00B94676 /* NSString+IGListDiffable.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B933F1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h in Headers */,
0B3B93171E08D7F5008390ED /* IGListSectionController.h in Headers */,
0B3B93451E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h in Headers */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841B3202B4F7F00484901 /* IGListAdapterMoveDelegate.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C481742024167B0093D4BC /* IGListCollectionViewDelegateLayout.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926586D1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C4817C2024174F0093D4BC /* IGListBindingSectionController+DebugDescription.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652BA1EA927750063BDD9 /* IGListDebuggingUtilities.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93351E08D7F5008390ED /* IGListDisplayHandler.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48148202413B00093D4BC /* IGListMacros.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93251E08D7F5008390ED /* IGListSupplementaryViewSource.h in Headers */,
0B3B932D1E08D7F5008390ED /* IGListAdapterInternal.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652BB1EA927750063BDD9 /* IGListSectionMap+DebugDescription.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48149202413B00093D4BC /* IGListMoveIndex.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652BC1EA927750063BDD9 /* UICollectionView+DebugDescription.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883796F82022304D00B94676 /* IGListBatchUpdateData.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93291E08D7F5008390ED /* IGListWorkingRangeDelegate.h in Headers */,
0B3B93051E08D7F5008390ED /* IGListCollectionContext.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658701E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883796FB2022304D00B94676 /* IGListDiffable.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B931D1E08D7F5008390ED /* IGListSingleSectionController.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C4814B202413B00093D4BC /* NSNumber+IGListDiffable.h in Headers */,
Prevent duplicate item deletes and drop reload collisions Summary: a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in `UICollectionView` where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4) Closes https://github.com/Instagram/IGListKit/pull/657 Reviewed By: jessesquires Differential Revision: D4913790 Pulled By: rnystrom fbshipit-source-id: 8f6fcdd2e2438da309fc64ca0ac111b9a0980149
2017-04-20 00:01:12 +00:00
296AC95D1EA518D3005137E2 /* IGListReloadIndexPath.h in Headers */,
Move UICollectionView(DataSource|Delegate) to category Summary: This reduces the quantity of the code within IGListAdapter.m and is a bit more in line with Swift style of putting protocol conformance into extensions. This does not change functionality just rearranges where code lives. - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [N/A] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [N/A] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/599 Reviewed By: jessesquires Differential Revision: D4861777 Pulled By: amonshiz fbshipit-source-id: eaa31aa9438f3892193aeb8b4ae580ba2960ee8b
2017-04-18 18:07:34 +00:00
DAD4A40D1E8E9E1E00DACC36 /* IGListAdapter+UICollectionView.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93331E08D7F5008390ED /* IGListAdapterUpdaterInternal.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883797022022304D00B94676 /* IGListMoveIndexPath.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93391E08D7F5008390ED /* IGListSectionControllerInternal.h in Headers */,
0B3B92DB1E08D7F5008390ED /* IGListKit.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C4817D2024174F0093D4BC /* UIScrollView+IGListKit.h in Headers */,
29C4817B2024174F0093D4BC /* IGListAdapter+DebugDescription.h in Headers */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841B5202B4F9000484901 /* UICollectionViewLayout+InteractiveReordering.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93031E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B91EA927750063BDD9 /* IGListDebugger.h in Headers */,
294652B71EA927750063BDD9 /* IGListAdapterUpdater+DebugDescription.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B933B1E08D7F5008390ED /* IGListSectionMap.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C4815E202413BD0093D4BC /* IGListMoveIndexPathInternal.h in Headers */,
29C48145202413B00093D4BC /* IGListExperiments.h in Headers */,
29C4815B202413BD0093D4BC /* IGListIndexPathResultInternal.h in Headers */,
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5CA41EA7C75500113926 /* IGListGenericSectionController.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93211E08D7F5008390ED /* IGListStackedSectionController.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883796F72022304D00B94676 /* IGListAssert.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9C81E3ACFE300F76F50 /* IGListBindingSectionController.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883796FF2022304D00B94676 /* IGListIndexSetResult.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93411E08D7F5008390ED /* IGListWorkingRangeHandler.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883797112022308200B94676 /* IGListTransitionDelegate.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B81EA927750063BDD9 /* IGListBatchUpdateData+DebugDescription.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883796F92022304D00B94676 /* IGListCompatibility.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B932F1E08D7F5008390ED /* IGListAdapterProxy.h in Headers */,
0B3B92FD1E08D7F5008390ED /* IGListAdapterDelegate.h in Headers */,
0B3B92F71E08D7F5008390ED /* IGListAdapter.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9C31E3ACF8600F76F50 /* IGListBindable.h in Headers */,
Move section controller mutation API to object provided in update block Summary: We constantly have random bugs pop up when mutations are made outside of a batch update. This change restricts the mutation API to a batch context object (which is just an `IGListAdapter`) so they can only be done **inside an update block**. - Fixed open source project - Confirmed open source examples build - Updated all of Instagram.app to use this API - Changelog breaking changes entry Fixes #392 Reviewed By: jessesquires Differential Revision: D4754129 fbshipit-source-id: 11d32a0fac3e50c9edbb01e92a8a0c7b8a43cf2d
2017-03-22 19:40:51 +00:00
2928073A1E82CE2E0077A81C /* IGListBatchContext.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
292658711E75E2440041B56D /* IGListBatchUpdateState.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
88379712202230DE00B94676 /* IGListDiff.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93111E08D7F5008390ED /* IGListReloadDataUpdater.h in Headers */,
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
1F2984CA1E8039EC005FA211 /* IGListCollectionViewLayoutInternal.h in Headers */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48146202413B00093D4BC /* IGListIndexPathResult.h in Headers */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA201E3B0DC800F76F50 /* IGListCollectionViewLayout.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883797142022319300B94676 /* IGListMoveIndexInternal.h in Headers */,
Fix examples Summary: Broke in #525 b/c didn't run `pod_install.sh` after adding new files. Issue fixed: #537 Closes https://github.com/Instagram/IGListKit/pull/538 Differential Revision: D4695675 Pulled By: rnystrom fbshipit-source-id: 3edc6e25f545efdc5475035036e25bb0e1b304d3
2017-03-11 21:28:34 +00:00
297278BE1E6B58560099D8EA /* IGListBatchUpdates.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92FF1E08D7F5008390ED /* IGListAdapterUpdater.h in Headers */,
0B3B93151E08D7F5008390ED /* IGListScrollDelegate.h in Headers */,
0B3B93271E08D7F5008390ED /* IGListUpdatingDelegate.h in Headers */,
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
29822E571FE3477C008532D2 /* IGListCollectionView.h in Headers */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B331D870D7E009E01F7 /* Headers */ = {
isa = PBXHeadersBuildPhase;
buildActionMask = 2147483647;
files = (
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA797201FBD880029277A /* IGListMoveIndexPathInternal.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3541E930C89009FE456 /* IGListDebugger.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92FA1E08D7F5008390ED /* IGListAdapterDataSource.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA791201FBD880029277A /* IGListIndexPathResult.h in Headers */,
29DAA78C201FBD880029277A /* IGListIndexSetResult.h in Headers */,
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0AD1F1ADA1600460F79 /* IGListAdapter+DebugDescription.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B930A1E08D7F5008390ED /* IGListDisplayDelegate.h in Headers */,
0B3B933E1E08D7F5008390ED /* IGListStackedSectionControllerInternal.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A9201FBD9B0029277A /* IGListCollectionViewDelegateLayout.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3641E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93161E08D7F5008390ED /* IGListSectionController.h in Headers */,
0B3B93441E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.h in Headers */,
Add update finished announcer API Summary: Adding a new API to support adding 1:many listeners to observe when an `IGListAdapter` finishes performing an update event. It supports: - `performUpdates:` - `reloadData...` - Even handling update triggered from //inside// a section controller Differential Revision: D6108096 fbshipit-source-id: d0b43d83f1963fdbf6ef388685cbd8f6890177fa
2017-10-20 15:41:01 +00:00
294CDE5F1F98E3A7002CF6E4 /* IGListAdapterUpdateListener.h in Headers */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841B1202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3741E931B57009FE456 /* IGListDebuggingUtilities.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A1201FBD880029277A /* NSNumber+IGListDiffable.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93341E08D7F5008390ED /* IGListDisplayHandler.h in Headers */,
Add new iOS 11 api adjustedContentInset support Summary: adopt adjustedContentInset instead of contentInset on iOS 11 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1020 Reviewed By: manicakes Differential Revision: D6513703 Pulled By: rnystrom fbshipit-source-id: 5d718f2cb30361959ca5ba8238746427223cb5fd
2017-12-18 16:33:24 +00:00
E8B5C73B1FC431D400C26914 /* UIScrollView+IGListKit.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926586C1E75E01A0041B56D /* IGListBindingSectionControllerDataSource.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93241E08D7F5008390ED /* IGListSupplementaryViewSource.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3701E931457009FE456 /* IGListSectionMap+DebugDescription.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA794201FBD880029277A /* IGListIndexPathResultInternal.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B932C1E08D7F5008390ED /* IGListAdapterInternal.h in Headers */,
0B3B93281E08D7F5008390ED /* IGListWorkingRangeDelegate.h in Headers */,
0B3B93041E08D7F5008390ED /* IGListCollectionContext.h in Headers */,
0B3B931C1E08D7F5008390ED /* IGListSingleSectionController.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA798201FBD880029277A /* IGListCompatibility.h in Headers */,
29DAA78F201FBD880029277A /* NSString+IGListDiffable.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
88379713202230DF00B94676 /* IGListDiff.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3601E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.h in Headers */,
Prevent duplicate item deletes and drop reload collisions Summary: a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in `UICollectionView` where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4) Closes https://github.com/Instagram/IGListKit/pull/657 Reviewed By: jessesquires Differential Revision: D4913790 Pulled By: rnystrom fbshipit-source-id: 8f6fcdd2e2438da309fc64ca0ac111b9a0980149
2017-04-20 00:01:12 +00:00
296AC95C1EA518D3005137E2 /* IGListReloadIndexPath.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA79D201FBD880029277A /* IGListMoveIndex.h in Headers */,
29DAA78E201FBD880029277A /* IGListDiffable.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93321E08D7F5008390ED /* IGListAdapterUpdaterInternal.h in Headers */,
Move UICollectionView(DataSource|Delegate) to category Summary: This reduces the quantity of the code within IGListAdapter.m and is a bit more in line with Swift style of putting protocol conformance into extensions. This does not change functionality just rearranges where code lives. - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [N/A] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [N/A] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/599 Reviewed By: jessesquires Differential Revision: D4861777 Pulled By: amonshiz fbshipit-source-id: eaa31aa9438f3892193aeb8b4ae580ba2960ee8b
2017-04-18 18:07:34 +00:00
DA5F484B1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93381E08D7F5008390ED /* IGListSectionControllerInternal.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
2926586F1E75E0830041B56D /* IGListBindingSectionControllerSelectionDelegate.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92DA1E08D7F5008390ED /* IGListKit.h in Headers */,
0B3B93021E08D7F5008390ED /* IGListAdapterUpdaterDelegate.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA795201FBD880029277A /* IGListArrayUtilsInternal.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B933A1E08D7F5008390ED /* IGListSectionMap.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A3201FBD880029277A /* IGListBatchUpdateData.h in Headers */,
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5CA01EA7C70400113926 /* IGListGenericSectionController.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA793201FBD880029277A /* IGListIndexSetResultInternal.h in Headers */,
29DAA796201FBD880029277A /* IGListMoveIndexInternal.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93201E08D7F5008390ED /* IGListStackedSectionController.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA799201FBD880029277A /* IGListExperiments.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9C71E3ACFE300F76F50 /* IGListBindingSectionController.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93401E08D7F5008390ED /* IGListWorkingRangeHandler.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA79B201FBD880029277A /* IGListMoveIndexPath.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B932E1E08D7F5008390ED /* IGListAdapterProxy.h in Headers */,
0B3B92FC1E08D7F5008390ED /* IGListAdapterDelegate.h in Headers */,
0B3B92F61E08D7F5008390ED /* IGListAdapter.h in Headers */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9C21E3ACF4800F76F50 /* IGListBindable.h in Headers */,
Move section controller mutation API to object provided in update block Summary: We constantly have random bugs pop up when mutations are made outside of a batch update. This change restricts the mutation API to a batch context object (which is just an `IGListAdapter`) so they can only be done **inside an update block**. - Fixed open source project - Confirmed open source examples build - Updated all of Instagram.app to use this API - Changelog breaking changes entry Fixes #392 Reviewed By: jessesquires Differential Revision: D4754129 fbshipit-source-id: 11d32a0fac3e50c9edbb01e92a8a0c7b8a43cf2d
2017-03-22 19:40:51 +00:00
292807391E82CE240077A81C /* IGListBatchContext.h in Headers */,
Fix examples Summary: Broke in #525 b/c didn't run `pod_install.sh` after adding new files. Issue fixed: #537 Closes https://github.com/Instagram/IGListKit/pull/538 Differential Revision: D4695675 Pulled By: rnystrom fbshipit-source-id: 3edc6e25f545efdc5475035036e25bb0e1b304d3
2017-03-11 21:28:34 +00:00
297278C41E6B59D50099D8EA /* IGListBatchUpdateState.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA79C201FBD880029277A /* IGListMacros.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93101E08D7F5008390ED /* IGListReloadDataUpdater.h in Headers */,
Demo for dependency injection and announcing changes Summary: Created a new demo that shows off how to: - Inject dependencies to section controllers - Objects shared between section controllers - Things that aren't the core "object" - Announce changes from the VC that make their way to the section controllers - Without calling updates Closes https://github.com/Instagram/IGListKit/pull/612 Differential Revision: D4827188 Pulled By: rnystrom fbshipit-source-id: 9575df0e105fd06f9a59db49432b19e8b824e0e3
2017-04-04 17:10:20 +00:00
917E89881E800EE70015F934 /* IGListCollectionViewLayoutInternal.h in Headers */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA1F1E3B0DC800F76F50 /* IGListCollectionViewLayout.h in Headers */,
Fix examples Summary: Broke in #525 b/c didn't run `pod_install.sh` after adding new files. Issue fixed: #537 Closes https://github.com/Instagram/IGListKit/pull/538 Differential Revision: D4695675 Pulled By: rnystrom fbshipit-source-id: 3edc6e25f545efdc5475035036e25bb0e1b304d3
2017-03-11 21:28:34 +00:00
297278BD1E6B58560099D8EA /* IGListBatchUpdates.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92FE1E08D7F5008390ED /* IGListAdapterUpdater.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A8201FBD9B0029277A /* IGListTransitionDelegate.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93141E08D7F5008390ED /* IGListScrollDelegate.h in Headers */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841AE202B4F5C00484901 /* IGListAdapterMoveDelegate.h in Headers */,
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0B41F1AE81800460F79 /* IGListBindingSectionController+DebugDescription.h in Headers */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3581E930CE2009FE456 /* UICollectionView+DebugDescription.h in Headers */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93261E08D7F5008390ED /* IGListUpdatingDelegate.h in Headers */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A2201FBD880029277A /* IGListAssert.h in Headers */,
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
29822E541FE3473A008532D2 /* IGListCollectionView.h in Headers */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD31527C1DE227FA00AC9D2C /* Headers */ = {
isa = PBXHeadersBuildPhase;
buildActionMask = 2147483647;
files = (
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48163202413BE0093D4BC /* IGListMoveIndexPathInternal.h in Headers */,
29C4814E202413B20093D4BC /* IGListBatchUpdateData.h in Headers */,
29C48159202413B20093D4BC /* NSString+IGListDiffable.h in Headers */,
29C48160202413BE0093D4BC /* IGListIndexPathResultInternal.h in Headers */,
29C48161202413BE0093D4BC /* IGListArrayUtilsInternal.h in Headers */,
29C4814F202413B20093D4BC /* IGListCompatibility.h in Headers */,
29C4815F202413BE0093D4BC /* IGListIndexSetResultInternal.h in Headers */,
29C48156202413B20093D4BC /* IGListMoveIndex.h in Headers */,
29C48150202413B20093D4BC /* IGListDiff.h in Headers */,
29C48158202413B20093D4BC /* NSNumber+IGListDiffable.h in Headers */,
29C48152202413B20093D4BC /* IGListExperiments.h in Headers */,
29C4814D202413B20093D4BC /* IGListAssert.h in Headers */,
29C48153202413B20093D4BC /* IGListIndexPathResult.h in Headers */,
29C48157202413B20093D4BC /* IGListMoveIndexPath.h in Headers */,
29C48154202413B20093D4BC /* IGListIndexSetResult.h in Headers */,
Fix examples Summary: Broke in #525 b/c didn't run `pod_install.sh` after adding new files. Issue fixed: #537 Closes https://github.com/Instagram/IGListKit/pull/538 Differential Revision: D4695675 Pulled By: rnystrom fbshipit-source-id: 3edc6e25f545efdc5475035036e25bb0e1b304d3
2017-03-11 21:28:34 +00:00
292658551E7498220041B56D /* IGListKit.h in Headers */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
8837970C2022304E00B94676 /* IGListMacros.h in Headers */,
883797152022319400B94676 /* IGListMoveIndexInternal.h in Headers */,
883796EA2022301F00B94676 /* IGListDiffable.h in Headers */,
883797082022304E00B94676 /* (null) in Headers */,
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXHeadersBuildPhase section */
/* Begin PBXNativeTarget section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D31DC51A0D009CE2B4 /* IGListKit-tvOS */ = {
isa = PBXNativeTarget;
buildConfigurationList = 885FE1E91DC51A0D009CE2B4 /* Build configuration list for PBXNativeTarget "IGListKit-tvOS" */;
buildPhases = (
885FE1CF1DC51A0D009CE2B4 /* Sources */,
885FE1D01DC51A0D009CE2B4 /* Frameworks */,
885FE1D11DC51A0D009CE2B4 /* Headers */,
885FE1D21DC51A0D009CE2B4 /* Resources */,
);
buildRules = (
);
dependencies = (
);
name = "IGListKit-tvOS";
productName = "IGListKit-tvOS";
productReference = 885FE1D41DC51A0D009CE2B4 /* IGListKit.framework */;
productType = "com.apple.product-type.framework";
};
885FE1DB1DC51A0D009CE2B4 /* IGListKit-tvOSTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 885FE1EA1DC51A0D009CE2B4 /* Build configuration list for PBXNativeTarget "IGListKit-tvOSTests" */;
buildPhases = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
9B12CED6C1A4A7B9137C8C52 /* [CP] Check Pods Manifest.lock */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D81DC51A0D009CE2B4 /* Sources */,
885FE1D91DC51A0D009CE2B4 /* Frameworks */,
885FE1DA1DC51A0D009CE2B4 /* Resources */,
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
1C5FA70E034CFACCF4FD0854 /* [CP] Embed Pods Frameworks */,
50676A19DB6B3CECF9C54BC9 /* [CP] Copy Pods Resources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
buildRules = (
);
dependencies = (
885FE1DF1DC51A0D009CE2B4 /* PBXTargetDependency */,
);
name = "IGListKit-tvOSTests";
productName = "IGListKit-tvOSTests";
productReference = 885FE1DC1DC51A0D009CE2B4 /* IGListKit-tvOSTests.xctest */;
productType = "com.apple.product-type.bundle.unit-test";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B351D870D7E009E01F7 /* IGListKit */ = {
isa = PBXNativeTarget;
buildConfigurationList = 887D0B4A1D870D7F009E01F7 /* Build configuration list for PBXNativeTarget "IGListKit" */;
buildPhases = (
887D0B311D870D7E009E01F7 /* Sources */,
887D0B321D870D7E009E01F7 /* Frameworks */,
887D0B331D870D7E009E01F7 /* Headers */,
887D0B341D870D7E009E01F7 /* Resources */,
);
buildRules = (
);
dependencies = (
);
name = IGListKit;
productName = IGListKit;
productReference = 887D0B361D870D7E009E01F7 /* IGListKit.framework */;
productType = "com.apple.product-type.framework";
};
887D0B3E1D870D7F009E01F7 /* IGListKitTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 887D0B4D1D870D7F009E01F7 /* Build configuration list for PBXNativeTarget "IGListKitTests" */;
buildPhases = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
9B9AB53579E3C2BBEEBC3548 /* [CP] Check Pods Manifest.lock */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B3B1D870D7F009E01F7 /* Sources */,
887D0B3C1D870D7F009E01F7 /* Frameworks */,
887D0B3D1D870D7F009E01F7 /* Resources */,
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
21587AA7E74BD876C049E30D /* [CP] Embed Pods Frameworks */,
AC15CB0B9881429871447055 /* [CP] Copy Pods Resources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
buildRules = (
);
dependencies = (
887D0B421D870D7F009E01F7 /* PBXTargetDependency */,
);
name = IGListKitTests;
productName = IGListKitTests;
productReference = 887D0B3F1D870D7F009E01F7 /* IGListKitTests.xctest */;
productType = "com.apple.product-type.bundle.unit-test";
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF897B1E010E6A00B1B9B4 /* IGListKit-macOSTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 88DF89861E010E6A00B1B9B4 /* Build configuration list for PBXNativeTarget "IGListKit-macOSTests" */;
buildPhases = (
88DF89781E010E6A00B1B9B4 /* Sources */,
88DF89791E010E6A00B1B9B4 /* Frameworks */,
88DF897A1E010E6A00B1B9B4 /* Resources */,
);
buildRules = (
);
dependencies = (
88DF89831E010E6A00B1B9B4 /* PBXTargetDependency */,
);
name = "IGListKit-macOSTests";
productName = "IGListKitTests-macOS";
productReference = 88DF897C1E010E6A00B1B9B4 /* IGListKit-macOSTests.xctest */;
productType = "com.apple.product-type.bundle.unit-test";
};
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152661DE227FA00AC9D2C /* IGListKit-macOS */ = {
isa = PBXNativeTarget;
buildConfigurationList = DD3152A91DE227FA00AC9D2C /* Build configuration list for PBXNativeTarget "IGListKit-macOS" */;
buildPhases = (
DD3152671DE227FA00AC9D2C /* Sources */,
DD31527B1DE227FA00AC9D2C /* Frameworks */,
DD31527C1DE227FA00AC9D2C /* Headers */,
DD3152A81DE227FA00AC9D2C /* Resources */,
);
buildRules = (
);
dependencies = (
);
name = "IGListKit-macOS";
productName = IGListKit;
productReference = DD3152AC1DE227FA00AC9D2C /* IGListKit.framework */;
productType = "com.apple.product-type.framework";
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXNativeTarget section */
/* Begin PBXProject section */
887D0B2D1D870D7E009E01F7 /* Project object */ = {
isa = PBXProject;
attributes = {
CLASSPREFIX = IG;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
LastUpgradeCheck = 0920;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
ORGANIZATIONNAME = Instagram;
TargetAttributes = {
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D31DC51A0D009CE2B4 = {
CreatedOnToolsVersion = 8.1;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
ProvisioningStyle = Manual;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
};
885FE1DB1DC51A0D009CE2B4 = {
CreatedOnToolsVersion = 8.1;
LastSwiftMigration = 0810;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
ProvisioningStyle = Manual;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B351D870D7E009E01F7 = {
CreatedOnToolsVersion = 8.0;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
LastSwiftMigration = 0800;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
ProvisioningStyle = Manual;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
887D0B3E1D870D7F009E01F7 = {
CreatedOnToolsVersion = 8.0;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
LastSwiftMigration = 0900;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
ProvisioningStyle = Manual;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF897B1E010E6A00B1B9B4 = {
CreatedOnToolsVersion = 8.2;
LastSwiftMigration = 0820;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
ProvisioningStyle = Manual;
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
};
buildConfigurationList = 887D0B301D870D7E009E01F7 /* Build configuration list for PBXProject "IGListKit" */;
compatibilityVersion = "Xcode 3.2";
developmentRegion = English;
hasScannedForEncodings = 0;
knownRegions = (
en,
);
mainGroup = 887D0B2C1D870D7E009E01F7;
productRefGroup = 887D0B371D870D7E009E01F7 /* Products */;
projectDirPath = "";
projectRoot = "";
targets = (
887D0B351D870D7E009E01F7 /* IGListKit */,
887D0B3E1D870D7F009E01F7 /* IGListKitTests */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D31DC51A0D009CE2B4 /* IGListKit-tvOS */,
885FE1DB1DC51A0D009CE2B4 /* IGListKit-tvOSTests */,
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152661DE227FA00AC9D2C /* IGListKit-macOS */,
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF897B1E010E6A00B1B9B4 /* IGListKit-macOSTests */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
};
/* End PBXProject section */
/* Begin PBXResourcesBuildPhase section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1D21DC51A0D009CE2B4 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
885FE1DA1DC51A0D009CE2B4 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
2914BEEA1DCD15F400C96401 /* IGTestNibSupplementaryView.xib in Resources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2471DC51B90009CE2B4 /* IGTestNibCell.xib in Resources */,
885FE2481DC51B90009CE2B4 /* IGTestStoryboard.storyboard in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B341D870D7E009E01F7 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
887D0B3D1D870D7F009E01F7 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
2914BEE91DCD15F400C96401 /* IGTestNibSupplementaryView.xib in Resources */,
Swap test nib to test bundle Summary: IGTestNibCell.xib was in the wrong bundle after imported internally (moved it to `Assets` dir) - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/78 Reviewed By: ryanolsonk Differential Revision: D4028444 Pulled By: rnystrom fbshipit-source-id: cb7ed0f8024ca9fd116827f3935f075c1d9193be
2016-10-16 23:30:18 +00:00
29EA6C491DB43A8000957A88 /* IGTestNibCell.xib in Resources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4C41DB8CEF800172ED0 /* IGTestStoryboard.storyboard in Resources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF897A1E010E6A00B1B9B4 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152A81DE227FA00AC9D2C /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXResourcesBuildPhase section */
/* Begin PBXShellScriptBuildPhase section */
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
1C5FA70E034CFACCF4FD0854 /* [CP] Embed Pods Frameworks */ = {
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"${SRCROOT}/Pods/Target Support Files/Pods-IGListKit-tvOSTests/Pods-IGListKit-tvOSTests-frameworks.sh",
"${BUILT_PRODUCTS_DIR}/OCMock-tvOS/OCMock.framework",
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
name = "[CP] Embed Pods Frameworks";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
outputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/OCMock.framework",
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-IGListKit-tvOSTests/Pods-IGListKit-tvOSTests-frameworks.sh\"\n";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
showEnvVarsInLog = 0;
};
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
21587AA7E74BD876C049E30D /* [CP] Embed Pods Frameworks */ = {
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"${SRCROOT}/Pods/Target Support Files/Pods-IGListKitTests/Pods-IGListKitTests-frameworks.sh",
"${BUILT_PRODUCTS_DIR}/OCMock-iOS/OCMock.framework",
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
name = "[CP] Embed Pods Frameworks";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
outputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/OCMock.framework",
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-IGListKitTests/Pods-IGListKitTests-frameworks.sh\"\n";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
showEnvVarsInLog = 0;
};
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
50676A19DB6B3CECF9C54BC9 /* [CP] Copy Pods Resources */ = {
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
);
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
name = "[CP] Copy Pods Resources";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-IGListKit-tvOSTests/Pods-IGListKit-tvOSTests-resources.sh\"\n";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
showEnvVarsInLog = 0;
};
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
9B12CED6C1A4A7B9137C8C52 /* [CP] Check Pods Manifest.lock */ = {
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"${PODS_PODFILE_DIR_PATH}/Podfile.lock",
"${PODS_ROOT}/Manifest.lock",
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
name = "[CP] Check Pods Manifest.lock";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
outputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"$(DERIVED_FILE_DIR)/Pods-IGListKit-tvOSTests-checkManifestLockResult.txt",
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n # print error to STDERR\n echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
showEnvVarsInLog = 0;
};
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
9B9AB53579E3C2BBEEBC3548 /* [CP] Check Pods Manifest.lock */ = {
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"${PODS_PODFILE_DIR_PATH}/Podfile.lock",
"${PODS_ROOT}/Manifest.lock",
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
name = "[CP] Check Pods Manifest.lock";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
outputPaths = (
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
"$(DERIVED_FILE_DIR)/Pods-IGListKitTests-checkManifestLockResult.txt",
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n # print error to STDERR\n echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
showEnvVarsInLog = 0;
};
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
AC15CB0B9881429871447055 /* [CP] Copy Pods Resources */ = {
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
);
Disable iOS 9.3 tests Summary: These tests are timing out all the time. ☠️ Issue fixed: #683 Closes https://github.com/Instagram/IGListKit/pull/688 Differential Revision: D4965525 Pulled By: rnystrom fbshipit-source-id: ea122e66379646c557d1b8f1c7325894620b88fb
2017-04-27 21:32:32 +00:00
name = "[CP] Copy Pods Resources";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
shellScript = "\"${SRCROOT}/Pods/Target Support Files/Pods-IGListKitTests/Pods-IGListKitTests-resources.sh\"\n";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
showEnvVarsInLog = 0;
};
/* End PBXShellScriptBuildPhase section */
/* Begin PBXSourcesBuildPhase section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1CF1DC51A0D009CE2B4 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93011E08D7F5008390ED /* IGListAdapterUpdater.m in Sources */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48166202414780093D4BC /* IGListIndexPathResult.m in Sources */,
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5CA51EA7C75500113926 /* IGListGenericSectionController.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B31EA927440063BDD9 /* IGListSectionMap+DebugDescription.m in Sources */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48169202414780093D4BC /* IGListMoveIndexPath.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93431E08D7F5008390ED /* IGListWorkingRangeHandler.mm in Sources */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48164202414780093D4BC /* IGListBatchUpdateData.mm in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA221E3B0DC800F76F50 /* IGListCollectionViewLayout.mm in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B51EA9275A0063BDD9 /* IGListDebuggingUtilities.m in Sources */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48178202417380093D4BC /* IGListAdapter+DebugDescription.m in Sources */,
29C4817A202417380093D4BC /* UIScrollView+IGListKit.m in Sources */,
29C48167202414780093D4BC /* IGListIndexSetResult.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93311E08D7F5008390ED /* IGListAdapterProxy.m in Sources */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C48179202417380093D4BC /* IGListBindingSectionController+DebugDescription.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B01EA927440063BDD9 /* IGListAdapterUpdater+DebugDescription.m in Sources */,
Track batch updates in object and explicit state Summary: Batch updates are complicated b/c its unknown when the update block will actually execute. When executing the block, we want to collect inserts/deletes/reloads/moves (item and section). Allow mutations to happen synchronously outside of the update block. Tracking state will also help with the auto-diff where we need to allow re-entrant updates. Peeling off a chunk from #494 Issue fixed: #288 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/525 Reviewed By: jessesquires Differential Revision: D4656463 Pulled By: rnystrom fbshipit-source-id: 8f4d3dc21b03d595e02ee9ee9664277e8ead0531
2017-03-07 17:22:22 +00:00
297278C11E6B58560099D8EA /* IGListBatchUpdates.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B931F1E08D7F5008390ED /* IGListSingleSectionController.m in Sources */,
Prevent duplicate item deletes and drop reload collisions Summary: a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in `UICollectionView` where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4) Closes https://github.com/Instagram/IGListKit/pull/657 Reviewed By: jessesquires Differential Revision: D4913790 Pulled By: rnystrom fbshipit-source-id: 8f6fcdd2e2438da309fc64ca0ac111b9a0980149
2017-04-20 00:01:12 +00:00
296AC9601EA518D3005137E2 /* IGListReloadIndexPath.m in Sources */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883797262022366000B94676 /* IGListMoveIndex.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B21EA927440063BDD9 /* IGListDebugger.m in Sources */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C4816B202414780093D4BC /* NSString+IGListDiffable.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93371E08D7F5008390ED /* IGListDisplayHandler.m in Sources */,
0B3B93471E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m in Sources */,
Move UICollectionView(DataSource|Delegate) to category Summary: This reduces the quantity of the code within IGListAdapter.m and is a bit more in line with Swift style of putting protocol conformance into extensions. This does not change functionality just rearranges where code lives. - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [N/A] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [N/A] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/599 Reviewed By: jessesquires Differential Revision: D4861777 Pulled By: amonshiz fbshipit-source-id: eaa31aa9438f3892193aeb8b4ae580ba2960ee8b
2017-04-18 18:07:34 +00:00
DAA83ACF1E8ECE06000F6810 /* IGListAdapter+UICollectionView.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B11EA927440063BDD9 /* IGListBatchUpdateData+DebugDescription.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B933D1E08D7F5008390ED /* IGListSectionMap.m in Sources */,
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
29822E561FE34773008532D2 /* IGListCollectionView.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B92F91E08D7F5008390ED /* IGListAdapter.m in Sources */,
Fixup project file corruption Summary: Continuing issues raised in #1068. Project file was totally busted for macOS and AppleTV. Closes https://github.com/Instagram/IGListKit/pull/1079 Differential Revision: D6883599 Pulled By: rnystrom fbshipit-source-id: 29b118c87ffd302b3e54a47f81305292bd38a8fe
2018-02-02 15:00:15 +00:00
29C4816A202414780093D4BC /* NSNumber+IGListDiffable.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93191E08D7F5008390ED /* IGListSectionController.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841B4202B4F8C00484901 /* UICollectionViewLayout+InteractiveReordering.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93131E08D7F5008390ED /* IGListReloadDataUpdater.m in Sources */,
0B3B93231E08D7F5008390ED /* IGListStackedSectionController.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
294652B41EA927440063BDD9 /* UICollectionView+DebugDescription.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9CB1E3ACFE300F76F50 /* IGListBindingSectionController.m in Sources */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
883797202022361F00B94676 /* IGListDiff.mm in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
885FE1D81DC51A0D009CE2B4 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA381E3B168E00F76F50 /* IGLayoutTestItem.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2361DC51B76009CE2B4 /* IGListStackSectionControllerTests.m in Sources */,
885FE2311DC51B76009CE2B4 /* IGListDisplayHandlerTests.m in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA3B1E3B16F800F76F50 /* IGLayoutTestDataSource.m in Sources */,
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C474901DDF460500AE68CE /* IGListSectionMapTests.m in Sources */,
Fix TV tests Summary: Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho. Maybe fix #227 If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/228 Differential Revision: D4210696 Pulled By: rnystrom fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
2016-11-20 00:01:35 +00:00
29C579321DE0DA8A003A149B /* IGTestStoryboardSupplementarySource.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13E102941FA414C400123403 /* IGListReorderableStackSectionControllerTests.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA131E3AE3F100F76F50 /* IGTestDiffingDataSource.m in Sources */,
Fix TV tests Summary: Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho. Maybe fix #227 If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/228 Differential Revision: D4210696 Pulled By: rnystrom fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
2016-11-20 00:01:35 +00:00
29C5792F1DE0DA8A003A149B /* IGListTestAdapterStoryboardDataSource.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE23B1DC51B86009CE2B4 /* IGListTestUICollectionViewDataSource.m in Sources */,
885FE23D1DC51B86009CE2B4 /* IGTestDelegateController.m in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA251E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE22B1DC51B76009CE2B4 /* IGListAdapterE2ETests.m in Sources */,
885FE2331DC51B76009CE2B4 /* IGListSingleSectionControllerTests.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01741FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m in Sources */,
Fix TV tests Summary: Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho. Maybe fix #227 If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/228 Differential Revision: D4210696 Pulled By: rnystrom fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
2016-11-20 00:01:35 +00:00
29C579311DE0DA8A003A149B /* IGTestNibSupplementaryView.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01781FA1000E0092A320 /* IGTestReorderableSection.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE23C1DC51B86009CE2B4 /* IGTestCell.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA001E3AE28000F76F50 /* IGTestDiffingObject.m in Sources */,
Fix TV tests Summary: Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho. Maybe fix #227 If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/228 Differential Revision: D4210696 Pulled By: rnystrom fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
2016-11-20 00:01:35 +00:00
29C579331DE0DA8A003A149B /* IGTestStoryboardSupplementaryView.m in Sources */,
Fix binding SC deselection crash and publish 3.1.1 Summary: - Fixed #918 by checking `respondsToSelector:` (boo optionals) - Cut 3.1.1 for immediate publish - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/921 Differential Revision: D5748009 Pulled By: rnystrom fbshipit-source-id: b387b3988abc785f312bc47ac003851283972d7a
2017-08-31 19:35:22 +00:00
2995409F1F588C9500F647CF /* IGTestBindingWithoutDeselectionDelegate.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2401DC51B86009CE2B4 /* IGTestSingleItemDataSource.m in Sources */,
885FE2451DC51B86009CE2B4 /* IGTestStoryboardCell.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9CF1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE22F1DC51B76009CE2B4 /* IGListDiffSwiftTests.swift in Sources */,
885FE23F1DC51B86009CE2B4 /* IGTestObject.m in Sources */,
Unit tests for -scrollToObject horizontal end position Summary: Fixes #238 Try to finish what I started 😂 Closes https://github.com/Instagram/IGListKit/pull/247 Differential Revision: D4220011 Pulled By: rnystrom fbshipit-source-id: 9f4e1bd4f112f69f601c83d6604dc18bc27f0c68
2016-11-22 14:38:27 +00:00
828540511DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2371DC51B76009CE2B4 /* IGListWorkingRangeHandlerTests.m in Sources */,
Unit tests for -scrollToObject horizontal end position Summary: Fixes #238 Try to finish what I started 😂 Closes https://github.com/Instagram/IGListKit/pull/247 Differential Revision: D4220011 Pulled By: rnystrom fbshipit-source-id: 9f4e1bd4f112f69f601c83d6604dc18bc27f0c68
2016-11-22 14:38:27 +00:00
8285404D1DE40C6E00118B94 /* IGListTestHorizontalSection.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA061E3AE2B000F76F50 /* IGTestNumberBindableCell.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2381DC51B86009CE2B4 /* IGListTestAdapterDataSource.m in Sources */,
885FE2341DC51B76009CE2B4 /* IGListSingleNibItemControllerTests.m in Sources */,
run pod install everywhere, gen docs. Summary: - Project fixes for macOS support, #270 - Podspec fixes for macOS, #270 - Project test target fixes - Pod install all examples - Re-gen docs Differential Revision: D4327169 fbshipit-source-id: bbe7896f8f50aaf3b8da03d0c21a0fb6f775c7cd
2016-12-14 22:39:01 +00:00
0B40C5F31E01CB8200378109 /* IGReloadDataUpdaterTests.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2391DC51B86009CE2B4 /* IGListTestOffsettingLayout.m in Sources */,
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C4748F1DDF460500AE68CE /* IGListDiffResultTests.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2421DC51B86009CE2B4 /* IGTestSingleStoryboardItemDataSource.m in Sources */,
885FE2301DC51B76009CE2B4 /* IGListDiffTests.m in Sources */,
885FE22E1DC51B76009CE2B4 /* IGListBatchUpdateDataTests.m in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA3C1E3B170300F76F50 /* IGLayoutTestSection.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA0A1E3AE31E00F76F50 /* IGTestDiffingSectionController.m in Sources */,
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C4748D1DDF45F900AE68CE /* IGListAdapterProxyTests.m in Sources */,
Container Inset Size For Section Controller Summary: Add API for #315. Not sure if this is what you want rnystrom though 🤔. Will add tests after you confirm. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/456 Reviewed By: jessesquires Differential Revision: D4697190 Pulled By: rnystrom fbshipit-source-id: f8513cf2fa33441eb40f486954136553d19dda0c
2017-03-15 16:25:03 +00:00
82914C5C1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m in Sources */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
88379729202236AC00B94676 /* IGListAdapterUpdateTester.m in Sources */,
Add base test case class for simpler unit testing Summary: Making it simpler to setup tests w/ default config and objects. Less LoC in tests, lower setup cost when creating new test suites. Should I changelog? Issue fixed: #183 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/678 Differential Revision: D4921633 Pulled By: rnystrom fbshipit-source-id: fb4d08acb6ed0ba885cf56ce147f70b304301ff1
2017-04-20 21:35:26 +00:00
29DA5CA81EA7D37000113926 /* IGListTestCase.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE22C1DC51B76009CE2B4 /* IGListAdapterTests.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA051E3AE2B000F76F50 /* IGTestStringBindableCell.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE22D1DC51B76009CE2B4 /* IGListAdapterUpdaterTests.m in Sources */,
885FE2351DC51B76009CE2B4 /* IGListSingleStoryboardItemControllerTests.m in Sources */,
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C4748E1DDF460500AE68CE /* IGListAdapterStoryboardTests.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2411DC51B86009CE2B4 /* IGTestSingleNibItemDataSource.m in Sources */,
885FE2441DC51B86009CE2B4 /* IGTestStackedDataSource.m in Sources */,
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
6A9EB3621F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE2461DC51B86009CE2B4 /* IGTestSupplementarySource.m in Sources */,
Support supplementaryViews created from nibs (continued) Summary: Continuing the work on #90. I don't believe I can push directly to that PR since the origin is `master` of a repo I don't have access to. https://help.github.com/articles/checking-out-pull-requests-locally/ I went ahead and added another supplementary view test copying the old one we had. cc jessesquires in case there's something else I can do here. I believe this will still give rawlinxx credit? Closes https://github.com/Instagram/IGListKit/pull/162 Differential Revision: D4137364 Pulled By: rnystrom fbshipit-source-id: d8418ac5728fd6d9570fa1d1568f4343f5c4112b
2016-11-05 23:27:32 +00:00
885FE2431DC51B86009CE2B4 /* IGTestStoryboardViewController.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13E1028D1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE23A1DC51B86009CE2B4 /* IGListTestSection.m in Sources */,
Fix TV tests Summary: Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho. Maybe fix #227 If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/228 Differential Revision: D4210696 Pulled By: rnystrom fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
2016-11-20 00:01:35 +00:00
29C579301DE0DA8A003A149B /* IGListTestStoryboardSection.m in Sources */,
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE23E1DC51B86009CE2B4 /* IGTestDelegateDataSource.m in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B311D870D7E009E01F7 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA78B201FBD880029277A /* IGListMoveIndex.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3591E930CE2009FE456 /* UICollectionView+DebugDescription.m in Sources */,
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0AE1F1ADA1600460F79 /* IGListAdapter+DebugDescription.m in Sources */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA79A201FBD880029277A /* IGListIndexSetResult.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93001E08D7F5008390ED /* IGListAdapterUpdater.m in Sources */,
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5CA11EA7C70400113926 /* IGListGenericSectionController.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3711E931457009FE456 /* IGListSectionMap+DebugDescription.m in Sources */,
Update pods and examples Summary: Update pod and examples so project builds when synced Depends on D6545334 Reviewed By: rnystrom Differential Revision: D6573821 fbshipit-source-id: b0d4246fa9c0d627ebcd34ac7abd5c8453964037
2017-12-15 17:19:29 +00:00
29822E551FE3473A008532D2 /* IGListCollectionView.m in Sources */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA7A4201FBD880029277A /* IGListIndexPathResult.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93421E08D7F5008390ED /* IGListWorkingRangeHandler.mm in Sources */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA78D201FBD880029277A /* IGListMoveIndexPath.m in Sources */,
29DAA79F201FBD880029277A /* IGListDiff.mm in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA211E3B0DC800F76F50 /* IGListCollectionViewLayout.mm in Sources */,
Add new iOS 11 api adjustedContentInset support Summary: adopt adjustedContentInset instead of contentInset on iOS 11 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1020 Reviewed By: manicakes Differential Revision: D6513703 Pulled By: rnystrom fbshipit-source-id: 5d718f2cb30361959ca5ba8238746427223cb5fd
2017-12-18 16:33:24 +00:00
E8B5C73C1FC431D400C26914 /* UIScrollView+IGListKit.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93301E08D7F5008390ED /* IGListAdapterProxy.m in Sources */,
Added debug dump support to IGListBindingSectionController Summary: Issue fixed: #698 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/856 Differential Revision: D5611625 Pulled By: rnystrom fbshipit-source-id: d9d54e2a10cf0cfae6cff121c20cc8d24d802716
2017-08-11 16:12:05 +00:00
0D52F0B61F1AE8BD00460F79 /* IGListBindingSectionController+DebugDescription.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3651E930D25009FE456 /* IGListAdapterUpdater+DebugDescription.m in Sources */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA792201FBD880029277A /* NSNumber+IGListDiffable.m in Sources */,
Track batch updates in object and explicit state Summary: Batch updates are complicated b/c its unknown when the update block will actually execute. When executing the block, we want to collect inserts/deletes/reloads/moves (item and section). Allow mutations to happen synchronously outside of the update block. Tracking state will also help with the auto-diff where we need to allow re-entrant updates. Peeling off a chunk from #494 Issue fixed: #288 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/525 Reviewed By: jessesquires Differential Revision: D4656463 Pulled By: rnystrom fbshipit-source-id: 8f4d3dc21b03d595e02ee9ee9664277e8ead0531
2017-03-07 17:22:22 +00:00
297278BF1E6B58560099D8EA /* IGListBatchUpdates.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3751E931B57009FE456 /* IGListDebuggingUtilities.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B931E1E08D7F5008390ED /* IGListSingleSectionController.m in Sources */,
Prevent duplicate item deletes and drop reload collisions Summary: a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in `UICollectionView` where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like ``` * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4) Closes https://github.com/Instagram/IGListKit/pull/657 Reviewed By: jessesquires Differential Revision: D4913790 Pulled By: rnystrom fbshipit-source-id: 8f6fcdd2e2438da309fc64ca0ac111b9a0980149
2017-04-20 00:01:12 +00:00
296AC95F1EA518D3005137E2 /* IGListReloadIndexPath.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93361E08D7F5008390ED /* IGListDisplayHandler.m in Sources */,
0B3B93461E08D7F5008390ED /* UICollectionView+IGListBatchUpdateData.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3551E930C89009FE456 /* IGListDebugger.m in Sources */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA79E201FBD880029277A /* NSString+IGListDiffable.m in Sources */,
Move UICollectionView(DataSource|Delegate) to category Summary: This reduces the quantity of the code within IGListAdapter.m and is a bit more in line with Swift style of putting protocol conformance into extensions. This does not change functionality just rearranges where code lives. - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [N/A] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [N/A] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/599 Reviewed By: jessesquires Differential Revision: D4861777 Pulled By: amonshiz fbshipit-source-id: eaa31aa9438f3892193aeb8b4ae580ba2960ee8b
2017-04-18 18:07:34 +00:00
DA5F484C1E8E9D7000DAE6DA /* IGListAdapter+UICollectionView.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B933C1E08D7F5008390ED /* IGListSectionMap.m in Sources */,
0B3B92F81E08D7F5008390ED /* IGListAdapter.m in Sources */,
0B3B93181E08D7F5008390ED /* IGListSectionController.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
293841B2202B4F7200484901 /* UICollectionViewLayout+InteractiveReordering.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3611E930D05009FE456 /* IGListBatchUpdateData+DebugDescription.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93121E08D7F5008390ED /* IGListReloadDataUpdater.m in Sources */,
Fix project, examples, and CHANGELOG from internal changes Summary: - Unbreak builds so PRs should work (requires rebase) - Add CHANGELOG entry Closes https://github.com/Instagram/IGListKit/pull/1069 Differential Revision: D6839909 Pulled By: rnystrom fbshipit-source-id: abe0c75b50069ec9aac55b6acb7872fd2c8f04fb
2018-01-29 23:49:01 +00:00
29DAA790201FBD880029277A /* IGListBatchUpdateData.mm in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93221E08D7F5008390ED /* IGListStackedSectionController.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9CA1E3ACFE300F76F50 /* IGListBindingSectionController.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
887D0B3B1D870D7F009E01F7 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA391E3B168F00F76F50 /* IGLayoutTestItem.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F1C1D870EDC007C7F66 /* IGTestStackedDataSource.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01731FA0FD400092A320 /* IGListTestAdapterReorderingDataSource.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F181D870EDC007C7F66 /* IGTestDelegateController.m in Sources */,
Add debug dump scripts Summary: Got a little time on the plane to mess around with this idea. Very much want comments on this! Some questions: - We should probably compile out parts of this using `#if DEBUG`. - Should I compile out all of the description methods? - Maybe I wrap the entire debug files w/ `#if DEBUG ... #endif` so none of it is loaded? - ryanolsonk I used [FLEX](https://github.com/Flipboard/FLEX/blob/master/Classes/Utility/FLEXHeapEnumerator.m) for searching the heap, lmk if you see any problems w/ this - Its lifted w/ only a few changes for my specific needs (including comments 😂) - Chalk us up for using [another bit](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListAdapterProxy.m#L77-L82) of your code - Added a basic test so that the basics of this work and coverage doesn't tank - Anything else I should test? - Is there more data we should be dumping? - I have to track batch update state on the updater in order to dump it. If this seems dan Closes https://github.com/Instagram/IGListKit/pull/617 Reviewed By: jessesquires Differential Revision: D4929426 Pulled By: rnystrom fbshipit-source-id: fcba0d6f0b7766485440f208cf70ad39dfc7a42e
2017-04-21 23:34:49 +00:00
290DF3771E9323E6009FE456 /* IGListDebuggerTests.m in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA3A1E3B16F600F76F50 /* IGLayoutTestDataSource.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F0D1D870EDC007C7F66 /* IGListDisplayHandlerTests.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA141E3AE3F300F76F50 /* IGTestDiffingDataSource.m in Sources */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F51DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F1B1D870EDC007C7F66 /* IGTestSingleItemDataSource.m in Sources */,
88144F171D870EDC007C7F66 /* IGTestCell.m in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA241E3B15EE00F76F50 /* IGListCollectionViewLayoutTests.m in Sources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4C01DB8C9D500172ED0 /* IGListSingleStoryboardItemControllerTests.m in Sources */,
Unit test moves in containers Summary: Unit testing moves in sets so their `hash` and `isEqual` functions provide uniqueness. Fixes #187, #188 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/217 Differential Revision: D4201042 Pulled By: jessesquires fbshipit-source-id: 9c4803ca11e04bb86a7745d6ebc63d173e8ac814
2016-11-18 02:48:07 +00:00
294AC6321DDE4C19002FCE5D /* IGListDiffResultTests.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F141D870EDC007C7F66 /* IGListTestOffsettingLayout.m in Sources */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7FB1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA011E3AE28000F76F50 /* IGTestDiffingObject.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F131D870EDC007C7F66 /* IGListTestAdapterDataSource.m in Sources */,
88144F071D870EDC007C7F66 /* IGListAdapterE2ETests.m in Sources */,
Rename *ItemController unit tests to *SectionController Summary: Rename *ItemController unit tests to *SectionController, addressing issue #126 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/129 Differential Revision: D4095496 Pulled By: rnystrom fbshipit-source-id: 277be38ed2789f14199cee9d711a838552921f10
2016-10-28 14:31:37 +00:00
88144F111D870EDC007C7F66 /* IGListStackSectionControllerTests.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F1A1D870EDC007C7F66 /* IGTestObject.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DD9CE1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F0B1D870EDC007C7F66 /* IGListDiffSwiftTests.swift in Sources */,
88144F191D870EDC007C7F66 /* IGTestDelegateDataSource.m in Sources */,
Unit tests for -scrollToObject horizontal end position Summary: Fixes #238 Try to finish what I started 😂 Closes https://github.com/Instagram/IGListKit/pull/247 Differential Revision: D4220011 Pulled By: rnystrom fbshipit-source-id: 9f4e1bd4f112f69f601c83d6604dc18bc27f0c68
2016-11-22 14:38:27 +00:00
828540501DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F0C1D870EDC007C7F66 /* IGListDiffTests.m in Sources */,
Unit tests for -scrollToObject horizontal end position Summary: Fixes #238 Try to finish what I started 😂 Closes https://github.com/Instagram/IGListKit/pull/247 Differential Revision: D4220011 Pulled By: rnystrom fbshipit-source-id: 9f4e1bd4f112f69f601c83d6604dc18bc27f0c68
2016-11-22 14:38:27 +00:00
8285404C1DE40C6E00118B94 /* IGListTestHorizontalSection.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA081E3AE2B100F76F50 /* IGTestNumberBindableCell.m in Sources */,
Fix binding SC deselection crash and publish 3.1.1 Summary: - Fixed #918 by checking `respondsToSelector:` (boo optionals) - Cut 3.1.1 for immediate publish - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/921 Differential Revision: D5748009 Pulled By: rnystrom fbshipit-source-id: b387b3988abc785f312bc47ac003851283972d7a
2017-08-31 19:35:22 +00:00
2995409E1F588C9400F647CF /* IGTestBindingWithoutDeselectionDelegate.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F0A1D870EDC007C7F66 /* IGListBatchUpdateDataTests.m in Sources */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8C1DAE96740073E116 /* IGListSingleNibItemControllerTests.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13E1028C1FA4019000123403 /* IGListTestAdapterStackedReorderingDataSource.m in Sources */,
Add generic type section controller Summary: Adding and implementing an example of a new section controller that can be configured with a type. This section controller automatically stores its object in `didUpdateToObject:`, and implementations can trust the type-safety of the object! Reviewed By: jessesquires Differential Revision: D4914179 fbshipit-source-id: 39e2dce8ca29a1c0c92dc78eb8c25a7ab0a21978
2017-04-19 19:42:31 +00:00
29DA5CA31EA7C72400113926 /* IGListGenericSectionControllerTests.m in Sources */,
Add unit tests to reloadData updater Summary: Adding a few more missing unit tests. Closes #185 Closes https://github.com/Instagram/IGListKit/pull/289 Differential Revision: D4284610 Pulled By: rnystrom fbshipit-source-id: a592fb9c12a3995a62b608f44cdcc693a0f79bec
2016-12-06 13:54:48 +00:00
2997D4971DF5FC0B005A5DD2 /* IGReloadDataUpdaterTests.m in Sources */,
Interactive Reordering Summary: I had a desire for interactive reordering in a personal project, so here's a first attempt at adding support in IGListKit. I figured I might as well get a WIP PR up for comments before I continue further as there are a few aspects to interactive reordering that don't interplay perfectly with IGListKit. As discussed in #291, I went after two prime use cases: 1. Moving items amongst a section 2. Rearranging whole sections I also "disabled" moving items between sections by having those moves revert, to mimic interactive reordering cancellation as closely as possible. You can see both in the Mixed Data example. Grid items can be moved within a section, while users can be moved to reorder whole sections. But trying to move a grid item out of a grid or a user item into a grid will auto-revert. The revert animation isn't as tight as it should be. It may be more desirable to disable the animation - though you lose the visual cue. There is a also a new example, `ReorderableViewController`, that demonstrates 2 in its pure form (likely the most desired use case), where all sections are reorderable single rows. Happy to take feedback -- this is my first experience working on IGListKit, so I would expect there to be gaps. (Ex. I haven't used `IGListStackedSectionController`, and its tests failed as I hadn't implemented reordering delegates for it. Those are simply stubbed out for now.) Issue fixed: #291 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) - [x] Proper support in `IGListStackedSectionController` Closes https://github.com/Instagram/IGListKit/pull/976 Differential Revision: D6674493 Pulled By: rnystrom fbshipit-source-id: cd53c5fdc6fb59636edc4747c4bbd0f81a4610e5
2018-02-12 17:09:26 +00:00
13DF01771FA1000E0092A320 /* IGTestReorderableSection.m in Sources */,
Commit 1a92c15 breaks pbxproj Summary: Update project.pbxproj Closes https://github.com/Instagram/IGListKit/pull/174 Differential Revision: D4147048 Pulled By: rnystrom fbshipit-source-id: 03713030f5604839af3c64f64f3a700e08b3fa94
2016-11-08 14:18:29 +00:00
829D7BAA1DD1819000549816 /* IGListSectionMapTests.m in Sources */,
Fix TV tests Summary: Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho. Maybe fix #227 If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/228 Differential Revision: D4210696 Pulled By: rnystrom fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
2016-11-20 00:01:35 +00:00
29C5792E1DE0DA89003A149B /* IGTestNibSupplementaryView.m in Sources */,
Rename *ItemController unit tests to *SectionController Summary: Rename *ItemController unit tests to *SectionController, addressing issue #126 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/129 Differential Revision: D4095496 Pulled By: rnystrom fbshipit-source-id: 277be38ed2789f14199cee9d711a838552921f10
2016-10-28 14:31:37 +00:00
88144F101D870EDC007C7F66 /* IGListSingleSectionControllerTests.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F121D870EDC007C7F66 /* IGListWorkingRangeHandlerTests.m in Sources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4D31DB981AB00172ED0 /* IGTestSingleStoryboardItemDataSource.m in Sources */,
Vertical UICollectionViewLayout supporting inline sections (take 2) Summary: Working on porting our collection view layout to IGListKit. I'm doing this because its a solid layout, and we just finished preparing it to work with inline sections. It is designed to work in tandem with IGListKit, so we're adding it. This is still a WIP as I add more tests, but I'd love as much feedback as possible. Aside from the glob of header documentation, this has the following features: - Infinite sections that each have infinite items. Sections and items can fall inline. When they break the width of their container they will fall on the next row. - Sections can have their own insets, line spacing, and interitem spacing. - Sticky header support! When you use headers, it will always newline the section. - Maximum width with a border decoration view - Use this to pinch in your content on larger devices Followup to #423 - [ ] ~~Move decoration view support to delegate~~ removed - [x] Unit test changing [top y sticky inset](https://coveralls.io/builds/9977284/source?filen Closes https://github.com/Instagram/IGListKit/pull/484 Differential Revision: D4547760 Pulled By: rnystrom fbshipit-source-id: 879e2da16eb78bb6a90967e77d9ad0bbf7c69594
2017-02-11 01:58:52 +00:00
298DDA3D1E3B170400F76F50 /* IGLayoutTestSection.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA091E3AE31D00F76F50 /* IGTestDiffingSectionController.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F151D870EDC007C7F66 /* IGListTestSection.m in Sources */,
Container Inset Size For Section Controller Summary: Add API for #315. Not sure if this is what you want rnystrom though 🤔. Will add tests after you confirm. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/456 Reviewed By: jessesquires Differential Revision: D4697190 Pulled By: rnystrom fbshipit-source-id: f8513cf2fa33441eb40f486954136553d19dda0c
2017-03-15 16:25:03 +00:00
82914C5B1E6E2DEC0066C2F8 /* IGListTestContainerSizeSection.m in Sources */,
Add base test case class for simpler unit testing Summary: Making it simpler to setup tests w/ default config and objects. Less LoC in tests, lower setup cost when creating new test suites. Should I changelog? Issue fixed: #183 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/678 Differential Revision: D4921633 Pulled By: rnystrom fbshipit-source-id: fb4d08acb6ed0ba885cf56ce147f70b304301ff1
2017-04-20 21:35:26 +00:00
29DA5CA71EA7D37000113926 /* IGListTestCase.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F1D1D870EDC007C7F66 /* IGTestSupplementarySource.m in Sources */,
Add new iOS 11 api adjustedContentInset support Summary: adopt adjustedContentInset instead of contentInset on iOS 11 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/1020 Reviewed By: manicakes Differential Revision: D6513703 Pulled By: rnystrom fbshipit-source-id: 5d718f2cb30361959ca5ba8238746427223cb5fd
2017-12-18 16:33:24 +00:00
E8D312E01FC472A60009FA2F /* IGListContentInsetTests.m in Sources */,
Auto diffing section controller Summary: Started work on the plane to get this moving since #418 is up and ready to land. We'll likely need to spend some time fleshing out the API of this, and I think I'll split it up into a couple different PRs once ready for review. Putting this up now to get early feedback. This adds an auto-diffing section controller as outlined in #38. There are several key parts: - Subclass a new section controller `IGListAutoSectionController` (naming wip) - Connect a data source - Implement the data source methods that do 3 things: - Given a top-level object, transform it into an array of **diffable** view models - Given a view model, return a cell - Given a view model, return a size for a cell - A new protocol for the cell `IGListBindable` so that we can control when the cell is updated w/ the view model. - The most important part of this is that it unlocks moving and reloading a cell, which you can't do w/ `UICollectionView` - [ ] Unit test `reloadObjects:` - [x] Add Closes https://github.com/Instagram/IGListKit/pull/494 Reviewed By: amonshiz Differential Revision: D4696966 Pulled By: rnystrom fbshipit-source-id: f21b8341b3ed4389f2a4a106d0d316f481ba6943
2017-03-15 14:44:52 +00:00
298DDA071E3AE2B100F76F50 /* IGTestStringBindableCell.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F081D870EDC007C7F66 /* IGListAdapterTests.m in Sources */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F21DC284C300B3AAE7 /* IGListAdapterStoryboardTests.m in Sources */,
8240C7F01DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.m in Sources */,
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
88379728202236AB00B94676 /* IGListAdapterUpdateTester.m in Sources */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
821BC4CB1DB8D60100172ED0 /* IGTestStoryboardViewController.m in Sources */,
Add storyboard support #39 Summary: This PR is for #39 - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/92 Differential Revision: D4066721 Pulled By: rnystrom fbshipit-source-id: 4fca278ae9a54aa46626932d47d4a4c001b437d6
2016-10-25 22:17:45 +00:00
821BC4D01DB8D90900172ED0 /* IGTestStoryboardCell.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
88144F161D870EDC007C7F66 /* IGListTestUICollectionViewDataSource.m in Sources */,
88144F091D870EDC007C7F66 /* IGListAdapterUpdaterTests.m in Sources */,
Test adapter proxy object Summary: Fixes #186 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/218 Differential Revision: D4201040 Pulled By: rnystrom fbshipit-source-id: ef94ea7d77af60abe19dc611f5390b9a8bf25f6a
2016-11-18 19:09:26 +00:00
29C4748C1DDF45F400AE68CE /* IGListAdapterProxyTests.m in Sources */,
Support supplementaryViews created from storyboard Summary: Miss this in the previous PR #92. Will add unit test soon. Closes https://github.com/Instagram/IGListKit/pull/123 Differential Revision: D4101594 Pulled By: rnystrom fbshipit-source-id: 820030358532b0878f6d9e9092834266c9260a38
2016-11-01 17:56:06 +00:00
8240C7F81DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.m in Sources */,
Support cells created from nibs Summary: I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended `IGListSingleSectionController` so that it can be used with nibs too. I don't know if you had this also in mind. - [x] I'm currently thinking about the best way to test these changes. - [x] I was not able to update the documentation (issue #55). - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/56 Reviewed By: dshahidehpour Differential Revision: D4023746 Pulled By: rnystrom fbshipit-source-id: 6a8b4cfb4dba38ea6e9870a9a4506288ee155cfe
2016-10-15 01:46:16 +00:00
26271C8A1DAE94E40073E116 /* IGTestSingleNibItemDataSource.m in Sources */,
IGListSingleSectionControllerDelegate: add deselect delegate method Summary: Added `-didDeselectSectionController:withObject:` to `IGListSingleSectionControllerDelegate`. Not sure if it makes sense to make it non-optional in 4.0.0 or not (#909) - I can add the [same note](https://github.com/Instagram/IGListKit/blob/0f04a073194033fbfc6f1d916fad83838042a7c0/Source/IGListBindingSectionControllerSelectionDelegate.h#L40) to the docs if it is - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/954 Differential Revision: D6164711 Pulled By: rnystrom fbshipit-source-id: aa8cfd2bb72a16cb525d875e2cad93888f13c641
2017-12-18 20:17:48 +00:00
6A9EB3611F841E5D0070C572 /* IGTestSingleWithoutDeselectionDelegate.m in Sources */,
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89781E010E6A00B1B9B4 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
88DF898A1E010F7000B1B9B4 /* IGListDiffTests.m in Sources */,
88DF89891E010F6500B1B9B4 /* IGListDiffSwiftTests.swift in Sources */,
882BC1321E0118CB0083B311 /* IGTestObject.m in Sources */,
fixup common files and podspec, #270 Summary: - Add missing common files - Fix podspec for common files - Pod install all examples Reviewed By: rnystrom Differential Revision: D4350871 fbshipit-source-id: 708ebe6ce66caed75af5b2ac18920dcf45567d16
2016-12-20 05:01:33 +00:00
0B3B93611E08E38C008390ED /* IGListBatchUpdateDataTests.m in Sources */,
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89881E010F5C00B1B9B4 /* IGListDiffResultTests.m in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152671DE227FA00AC9D2C /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
8837972D2022370600B94676 /* NSString+IGListDiffable.m in Sources */,
8837971D202235F200B94676 /* IGListMoveIndexPath.m in Sources */,
8837972B202236FF00B94676 /* NSNumber+IGListDiffable.m in Sources */,
883797272022366000B94676 /* IGListMoveIndex.m in Sources */,
883797252022365700B94676 /* IGListIndexSetResult.m in Sources */,
883797212022361F00B94676 /* IGListDiff.mm in Sources */,
883797232022364900B94676 /* IGListIndexPathResult.m in Sources */,
8837971F2022360700B94676 /* IGListBatchUpdateData.mm in Sources */,
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
);
runOnlyForDeploymentPostprocessing = 0;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXSourcesBuildPhase section */
/* Begin PBXTargetDependency section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1DF1DC51A0D009CE2B4 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 885FE1D31DC51A0D009CE2B4 /* IGListKit-tvOS */;
targetProxy = 885FE1DE1DC51A0D009CE2B4 /* PBXContainerItemProxy */;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B421D870D7F009E01F7 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 887D0B351D870D7E009E01F7 /* IGListKit */;
targetProxy = 887D0B411D870D7F009E01F7 /* PBXContainerItemProxy */;
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89831E010E6A00B1B9B4 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = DD3152661DE227FA00AC9D2C /* IGListKit-macOS */;
targetProxy = 88DF89821E010E6A00B1B9B4 /* PBXContainerItemProxy */;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End PBXTargetDependency section */
/* Begin XCBuildConfiguration section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1E51DC51A0D009CE2B4 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_IDENTITY = "";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
DEFINES_MODULE = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
DEVELOPMENT_TEAM = "";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
INFOPLIST_FILE = "$(SRCROOT)/Source/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = IGListKit;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
SDKROOT = appletvos;
SKIP_INSTALL = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
TARGETED_DEVICE_FAMILY = 3;
TVOS_DEPLOYMENT_TARGET = 9.0;
};
name = Debug;
};
885FE1E61DC51A0D009CE2B4 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_IDENTITY = "";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
DEFINES_MODULE = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
DEVELOPMENT_TEAM = "";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
INFOPLIST_FILE = "$(SRCROOT)/Source/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = IGListKit;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
SDKROOT = appletvos;
SKIP_INSTALL = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
TARGETED_DEVICE_FAMILY = 3;
TVOS_DEPLOYMENT_TARGET = 9.0;
};
name = Release;
};
885FE1E71DC51A0D009CE2B4 /* Debug */ = {
isa = XCBuildConfiguration;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
baseConfigurationReference = 1D6BFC11D5380CB8311E1029 /* Pods-IGListKit-tvOSTests.debug.xcconfig */;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
buildSettings = {
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
DEVELOPMENT_TEAM = "";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
INFOPLIST_FILE = Tests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
SDKROOT = appletvos;
Remove NSObject+IGListDiffable category Summary: Removing the category entirely (recreated for unit tests and examples). Went through and updated all of Instagram so we don't rely on the category and found a few models that needed cleaning up. Reviewed By: jessesquires Differential Revision: D4206552 fbshipit-source-id: ee8147e8872ea19f6c8bd8072df61eed5bffb6f3
2016-11-22 00:57:23 +00:00
SWIFT_OBJC_BRIDGING_HEADER = "Tests/IGListKitTests-Bridging-Header.h";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
SWIFT_VERSION = 4.0;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
TVOS_DEPLOYMENT_TARGET = 10.0;
};
name = Debug;
};
885FE1E81DC51A0D009CE2B4 /* Release */ = {
isa = XCBuildConfiguration;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
baseConfigurationReference = 08F0B0FD0690F4FC46DDF21B /* Pods-IGListKit-tvOSTests.release.xcconfig */;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
buildSettings = {
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
DEVELOPMENT_TEAM = "";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
INFOPLIST_FILE = Tests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
SDKROOT = appletvos;
Remove NSObject+IGListDiffable category Summary: Removing the category entirely (recreated for unit tests and examples). Went through and updated all of Instagram so we don't rely on the category and found a few models that needed cleaning up. Reviewed By: jessesquires Differential Revision: D4206552 fbshipit-source-id: ee8147e8872ea19f6c8bd8072df61eed5bffb6f3
2016-11-22 00:57:23 +00:00
SWIFT_OBJC_BRIDGING_HEADER = "Tests/IGListKitTests-Bridging-Header.h";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
SWIFT_VERSION = 4.0;
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
TVOS_DEPLOYMENT_TARGET = 10.0;
};
name = Release;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B481D870D7F009E01F7 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_NONNULL = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
Add Coveralls support and badge Summary: Adding Coverall support and badge in README. Waiting on tests. Fixes #37 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/110 Differential Revision: D4066685 Pulled By: rnystrom fbshipit-source-id: a9f148fe87e9d25c60afca88c02410898db9b10a
2016-10-24 00:22:19 +00:00
CLANG_ENABLE_CODE_COVERAGE = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_BOOL_CONVERSION = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_COMMA = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
CLANG_WARN_SUSPICIOUS_MOVE = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_SUSPICIOUS_MOVES = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = dwarf;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_DYNAMIC_NO_PIC = NO;
GCC_NO_COMMON_BLOCKS = YES;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PREPROCESSOR_DEFINITIONS = (
"DEBUG=1",
"$(inherited)",
);
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
Require newline across all targets Summary: Internal CI will error on this, adding to project. Closes https://github.com/Instagram/IGListKit/pull/817 Differential Revision: D5283517 Pulled By: rnystrom fbshipit-source-id: fed4f58b551a90f51a250f18b3c30b851f4f1953
2017-06-20 23:00:55 +00:00
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
Fix podspec for macOS support Summary: Closes https://github.com/Instagram/IGListKit/pull/330 Differential Revision: D4327087 Pulled By: jessesquires fbshipit-source-id: a63ad7770763d95de1333be130673732706b7e36
2016-12-14 17:30:09 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.8;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
TARGETED_DEVICE_FAMILY = "1,2";
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
};
name = Debug;
};
887D0B491D870D7F009E01F7 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_NONNULL = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
Add Coveralls support and badge Summary: Adding Coverall support and badge in README. Waiting on tests. Fixes #37 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/110 Differential Revision: D4066685 Pulled By: rnystrom fbshipit-source-id: a9f148fe87e9d25c60afca88c02410898db9b10a
2016-10-24 00:22:19 +00:00
CLANG_ENABLE_CODE_COVERAGE = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_BOOL_CONVERSION = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_COMMA = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
CLANG_WARN_SUSPICIOUS_MOVE = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CLANG_WARN_SUSPICIOUS_MOVES = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_NO_COMMON_BLOCKS = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
Require newline across all targets Summary: Internal CI will error on this, adding to project. Closes https://github.com/Instagram/IGListKit/pull/817 Differential Revision: D5283517 Pulled By: rnystrom fbshipit-source-id: fed4f58b551a90f51a250f18b3c30b851f4f1953
2017-06-20 23:00:55 +00:00
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
Fix podspec for macOS support Summary: Closes https://github.com/Instagram/IGListKit/pull/330 Differential Revision: D4327087 Pulled By: jessesquires fbshipit-source-id: a63ad7770763d95de1333be130673732706b7e36
2016-12-14 17:30:09 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.8;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
TARGETED_DEVICE_FAMILY = "1,2";
VALIDATE_PRODUCT = YES;
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
};
name = Release;
};
887D0B4B1D870D7F009E01F7 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
Extension only API flag Summary: Adds `APPLICATION_EXTENSION_API_ONLY = YES` to Xcode project. Closes https://github.com/Instagram/IGListKit/pull/79 Differential Revision: D4028543 Pulled By: rnystrom fbshipit-source-id: 203afacb5485dd4dc5897991d7981cf80f6da993
2016-10-17 02:43:27 +00:00
APPLICATION_EXTENSION_API_ONLY = YES;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
CLANG_ENABLE_MODULES = YES;
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CODE_SIGN_IDENTITY = "";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
DEFINES_MODULE = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
DEVELOPMENT_TEAM = "";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_WARN_SHADOW = YES;
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
GCC_WARN_UNUSED_PARAMETER = NO;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
INFOPLIST_FILE = "$(SRCROOT)/Source/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
OTHER_CFLAGS = (
"-Wambiguous-macro",
"-Wbool-conversion",
"-Wcomment",
"-Wconditional-uninitialized",
"-Wconstant-logical-operand",
"-Wcovered-switch-default",
"-Wdangling-else",
"-Wdeprecated-increment-bool",
"-Wdivision-by-zero",
"-Wduplicate-enum",
"-Wempty-body",
"-Wenum-compare",
"-Wenum-conversion",
"-Wformat",
"-Wformat-extra-args",
"-Wformat-security",
"-Wformat-zero-length",
"-Wignored-attributes",
"-Wignored-attributes",
"-Wimplicit-atomic-properties",
"-Wimplicit-fallthrough",
"-Wimplicit-retain-self",
"-Wincomplete-implementation",
"-Wloop-analysis",
"-Wmismatched-return-types",
"-Wnewline-eof",
"-Wnonnull",
"-Wnull-character",
"-Wobjc-method-access",
"-Wobjc-missing-super-calls",
"-Wreturn-type",
"-Wself-assign",
"-Wswitch",
"-Wswitch-bool",
"-Wswitch-enum",
"-Wunicode",
"-Wunknown-pragmas",
"-Wunused-const-variable",
"-Wunused-function",
"-Wunused-label",
"-Wunused-property-ivar",
"-Wunused-result",
"-Wunused-value",
Regen docs for 2.0 release. Close #181 Summary: Closes #181 Closes https://github.com/Instagram/IGListKit/pull/207 Differential Revision: D4216383 Pulled By: jessesquires fbshipit-source-id: 664c6d0f1cf82647cf8e2231cf35348b08351c9d
2016-11-21 23:36:26 +00:00
"-Wnullable-to-nonnull-conversion",
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
);
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
SDKROOT = iphoneos;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
SKIP_INSTALL = YES;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
SWIFT_VERSION = 3.0;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
name = Debug;
};
887D0B4C1D870D7F009E01F7 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
Extension only API flag Summary: Adds `APPLICATION_EXTENSION_API_ONLY = YES` to Xcode project. Closes https://github.com/Instagram/IGListKit/pull/79 Differential Revision: D4028543 Pulled By: rnystrom fbshipit-source-id: 203afacb5485dd4dc5897991d7981cf80f6da993
2016-10-17 02:43:27 +00:00
APPLICATION_EXTENSION_API_ONLY = YES;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
CLANG_ENABLE_MODULES = YES;
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
CODE_SIGN_IDENTITY = "";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
DEFINES_MODULE = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
DEVELOPMENT_TEAM = "";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_WARN_SHADOW = YES;
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
GCC_WARN_UNUSED_PARAMETER = NO;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
INFOPLIST_FILE = "$(SRCROOT)/Source/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
OTHER_CFLAGS = (
"-Wambiguous-macro",
"-Wbool-conversion",
"-Wcomment",
"-Wconditional-uninitialized",
"-Wconstant-logical-operand",
"-Wcovered-switch-default",
"-Wdangling-else",
"-Wdeprecated-increment-bool",
"-Wdivision-by-zero",
"-Wduplicate-enum",
"-Wempty-body",
"-Wenum-compare",
"-Wenum-conversion",
"-Wformat",
"-Wformat-extra-args",
"-Wformat-security",
"-Wformat-zero-length",
"-Wignored-attributes",
"-Wignored-attributes",
"-Wimplicit-atomic-properties",
"-Wimplicit-fallthrough",
"-Wimplicit-retain-self",
"-Wincomplete-implementation",
"-Wloop-analysis",
"-Wmismatched-return-types",
"-Wnewline-eof",
"-Wnonnull",
"-Wnull-character",
"-Wobjc-method-access",
"-Wobjc-missing-super-calls",
"-Wreturn-type",
"-Wself-assign",
"-Wswitch",
"-Wswitch-bool",
"-Wswitch-enum",
"-Wunicode",
"-Wunknown-pragmas",
"-Wunused-const-variable",
"-Wunused-function",
"-Wunused-label",
"-Wunused-property-ivar",
"-Wunused-result",
"-Wunused-value",
Regen docs for 2.0 release. Close #181 Summary: Closes #181 Closes https://github.com/Instagram/IGListKit/pull/207 Differential Revision: D4216383 Pulled By: jessesquires fbshipit-source-id: 664c6d0f1cf82647cf8e2231cf35348b08351c9d
2016-11-21 23:36:26 +00:00
"-Wnullable-to-nonnull-conversion",
Add stricter build flags Summary: Gets the `xcodeproj` in parity with our internal build settings. Fixes #211 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/224 Differential Revision: D4210413 Pulled By: rnystrom fbshipit-source-id: c820faf97ef04bc7cf7c369446d0e17829b6339b
2016-11-19 19:56:21 +00:00
);
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
SDKROOT = iphoneos;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
SKIP_INSTALL = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Fix intern syncing with xcodeproj
2016-10-11 19:24:47 +00:00
SWIFT_VERSION = 3.0;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
name = Release;
};
887D0B4E1D870D7F009E01F7 /* Debug */ = {
isa = XCBuildConfiguration;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
baseConfigurationReference = CA8726D7FF3608E20E9F7EC6 /* Pods-IGListKitTests.debug.xcconfig */;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
buildSettings = {
CLANG_ENABLE_MODULES = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
DEVELOPMENT_TEAM = "";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
INFOPLIST_FILE = Tests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Remove NSObject+IGListDiffable category Summary: Removing the category entirely (recreated for unit tests and examples). Went through and updated all of Instagram so we don't rely on the category and found a few models that needed cleaning up. Reviewed By: jessesquires Differential Revision: D4206552 fbshipit-source-id: ee8147e8872ea19f6c8bd8072df61eed5bffb6f3
2016-11-22 00:57:23 +00:00
SWIFT_OBJC_BRIDGING_HEADER = "Tests/IGListKitTests-Bridging-Header.h";
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
SWIFT_VERSION = 4.0;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
name = Debug;
};
887D0B4F1D870D7F009E01F7 /* Release */ = {
isa = XCBuildConfiguration;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
baseConfigurationReference = 9574C58371B7A46F62E9AC24 /* Pods-IGListKitTests.release.xcconfig */;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
buildSettings = {
CLANG_ENABLE_MODULES = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
DEVELOPMENT_TEAM = "";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
INFOPLIST_FILE = Tests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKitTests;
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
Remove NSObject+IGListDiffable category Summary: Removing the category entirely (recreated for unit tests and examples). Went through and updated all of Instagram so we don't rely on the category and found a few models that needed cleaning up. Reviewed By: jessesquires Differential Revision: D4206552 fbshipit-source-id: ee8147e8872ea19f6c8bd8072df61eed5bffb6f3
2016-11-22 00:57:23 +00:00
SWIFT_OBJC_BRIDGING_HEADER = "Tests/IGListKitTests-Bridging-Header.h";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Update project settings and fix errors Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
2017-10-26 18:14:11 +00:00
SWIFT_VERSION = 4.0;
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
};
name = Release;
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89841E010E6A00B1B9B4 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_IDENTITY = "-";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
COMBINE_HIDPI_IMAGES = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
DEVELOPMENT_TEAM = "";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
INFOPLIST_FILE = Tests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.12;
PRODUCT_BUNDLE_IDENTIFIER = "com.instagram.IGListKitTests-macOS";
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
SDKROOT = macosx;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
SWIFT_VERSION = 4.0;
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
};
name = Debug;
};
88DF89851E010E6A00B1B9B4 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_IDENTITY = "-";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
CODE_SIGN_STYLE = Manual;
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
COMBINE_HIDPI_IMAGES = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
DEVELOPMENT_TEAM = "";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_SHADOW = YES;
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
INFOPLIST_FILE = Tests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.12;
PRODUCT_BUNDLE_IDENTIFIER = "com.instagram.IGListKitTests-macOS";
PRODUCT_NAME = "$(TARGET_NAME)";
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
PROVISIONING_PROFILE_SPECIFIER = "";
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
SDKROOT = macosx;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
Update .travis.yml and lint.sh, try to fix #1060 and lint errors #trivial Summary: project: - fix file target membership issues in framework targets and test targets - fix private/internal header imports, which shouldn't be `<IGListKit/` apparently - fix static analyzer errors travis: - always install latest swiftlint - ~~don't cache bundler, attempts to fix #1060~~ - remove markdown link check swiftlint: - make script non-failing if *any* version of swiftlint is installed - warning if incorrect version is installed - fail if not installed - remove `scripts/generate_ci_yaml.rb`, we can just set the config file path directly Closes https://github.com/Instagram/IGListKit/pull/1068 Differential Revision: D6885575 Pulled By: rnystrom fbshipit-source-id: 51b7baa73feefcea71d870c1220d0382df484199
2018-02-02 21:14:16 +00:00
SWIFT_VERSION = 4.0;
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
};
name = Release;
};
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152AA1DE227FA00AC9D2C /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
APPLICATION_EXTENSION_API_ONLY = YES;
CLANG_ENABLE_MODULES = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CODE_SIGN_IDENTITY = "";
DEFINES_MODULE = YES;
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_WARN_SHADOW = YES;
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
GCC_WARN_UNUSED_PARAMETER = NO;
INFOPLIST_FILE = "$(SRCROOT)/Source/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Bump min macOS version to 10.11 #trivial Summary: Followup from #1068 The `NSIndexPath` methods we use **are not** available <10.11. In theory this has always been "broken" b/c older macOS versions would crash at runtime when trying to use these methods. Normally this would be breaking change, but I can't imagine anyone is using IGListKit on the mac targeting 10.10 and shipping a working app. cc jessesquires for thoughts This should be the last remaining item before we get a green badge. (note that 10.11 was released 9/30/15 which is about 2 weeks before the public IGListKit release) Closes https://github.com/Instagram/IGListKit/pull/1080 Differential Revision: D6894369 Pulled By: rnystrom fbshipit-source-id: e5992c7bba68b21704af6bc8fb889b5427266954
2018-02-03 16:17:22 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.11;
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
OTHER_CFLAGS = (
"-Wambiguous-macro",
"-Wbool-conversion",
"-Wcomment",
"-Wconditional-uninitialized",
"-Wconstant-logical-operand",
"-Wcovered-switch-default",
"-Wdangling-else",
"-Wdeprecated-increment-bool",
"-Wdivision-by-zero",
"-Wduplicate-enum",
"-Wempty-body",
"-Wenum-compare",
"-Wenum-conversion",
"-Wformat",
"-Wformat-extra-args",
"-Wformat-security",
"-Wformat-zero-length",
"-Wignored-attributes",
"-Wignored-attributes",
"-Wimplicit-atomic-properties",
"-Wimplicit-fallthrough",
"-Wimplicit-retain-self",
"-Wincomplete-implementation",
"-Wloop-analysis",
"-Wmismatched-return-types",
"-Wnewline-eof",
"-Wnonnull",
"-Wnull-character",
"-Wobjc-method-access",
"-Wobjc-missing-super-calls",
"-Wreturn-type",
"-Wself-assign",
"-Wswitch",
"-Wswitch-bool",
"-Wswitch-enum",
"-Wunicode",
"-Wunknown-pragmas",
"-Wunused-const-variable",
"-Wunused-function",
"-Wunused-label",
"-Wunused-property-ivar",
"-Wunused-result",
"-Wunused-value",
"-Wnullable-to-nonnull-conversion",
);
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = IGListKit;
SDKROOT = macosx;
SKIP_INSTALL = YES;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
SWIFT_VERSION = 3.0;
};
name = Debug;
};
DD3152AB1DE227FA00AC9D2C /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
APPLICATION_EXTENSION_API_ONLY = YES;
CLANG_ENABLE_MODULES = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CODE_SIGN_IDENTITY = "";
DEFINES_MODULE = YES;
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
GCC_WARN_SHADOW = YES;
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
GCC_WARN_UNUSED_PARAMETER = NO;
INFOPLIST_FILE = "$(SRCROOT)/Source/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Bump min macOS version to 10.11 #trivial Summary: Followup from #1068 The `NSIndexPath` methods we use **are not** available <10.11. In theory this has always been "broken" b/c older macOS versions would crash at runtime when trying to use these methods. Normally this would be breaking change, but I can't imagine anyone is using IGListKit on the mac targeting 10.10 and shipping a working app. cc jessesquires for thoughts This should be the last remaining item before we get a green badge. (note that 10.11 was released 9/30/15 which is about 2 weeks before the public IGListKit release) Closes https://github.com/Instagram/IGListKit/pull/1080 Differential Revision: D6894369 Pulled By: rnystrom fbshipit-source-id: e5992c7bba68b21704af6bc8fb889b5427266954
2018-02-03 16:17:22 +00:00
MACOSX_DEPLOYMENT_TARGET = 10.11;
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
OTHER_CFLAGS = (
"-Wambiguous-macro",
"-Wbool-conversion",
"-Wcomment",
"-Wconditional-uninitialized",
"-Wconstant-logical-operand",
"-Wcovered-switch-default",
"-Wdangling-else",
"-Wdeprecated-increment-bool",
"-Wdivision-by-zero",
"-Wduplicate-enum",
"-Wempty-body",
"-Wenum-compare",
"-Wenum-conversion",
"-Wformat",
"-Wformat-extra-args",
"-Wformat-security",
"-Wformat-zero-length",
"-Wignored-attributes",
"-Wignored-attributes",
"-Wimplicit-atomic-properties",
"-Wimplicit-fallthrough",
"-Wimplicit-retain-self",
"-Wincomplete-implementation",
"-Wloop-analysis",
"-Wmismatched-return-types",
"-Wnewline-eof",
"-Wnonnull",
"-Wnull-character",
"-Wobjc-method-access",
"-Wobjc-missing-super-calls",
"-Wreturn-type",
"-Wself-assign",
"-Wswitch",
"-Wswitch-bool",
"-Wswitch-enum",
"-Wunicode",
"-Wunknown-pragmas",
"-Wunused-const-variable",
"-Wunused-function",
"-Wunused-label",
"-Wunused-property-ivar",
"-Wunused-result",
"-Wunused-value",
"-Wnullable-to-nonnull-conversion",
);
PRODUCT_BUNDLE_IDENTIFIER = com.instagram.IGListKit;
PRODUCT_NAME = IGListKit;
SDKROOT = macosx;
SKIP_INSTALL = YES;
-Wshadow and warnings as errors for all targets Summary: Project settings match internal project gen settings. Was missing from tests. Issue fixed: #544 #545 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. Closes https://github.com/Instagram/IGListKit/pull/549 Differential Revision: D4701754 Pulled By: rnystrom fbshipit-source-id: f891c1db074a5e54994af3043fdc19c36cbbe371
2017-03-13 22:47:33 +00:00
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
SWIFT_VERSION = 3.0;
};
name = Release;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End XCBuildConfiguration section */
/* Begin XCConfigurationList section */
Add tvOS support. Close #118 Summary: Closes #118. - Add tvOS framework + test targets - Add shared scheme `IGListKit-tvOS` - Update `Podfile` and `.podspec` - Update `.travis.yml` - Update `CHANGELOG` - Update `README` - Run `pod install` and check-in updates - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes https://github.com/Instagram/IGListKit/pull/137 Differential Revision: D4101583 Pulled By: rnystrom fbshipit-source-id: f2736f16ad9f61ad5348c5e93571f3b752deec98
2016-10-29 21:39:18 +00:00
885FE1E91DC51A0D009CE2B4 /* Build configuration list for PBXNativeTarget "IGListKit-tvOS" */ = {
isa = XCConfigurationList;
buildConfigurations = (
885FE1E51DC51A0D009CE2B4 /* Debug */,
885FE1E61DC51A0D009CE2B4 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
885FE1EA1DC51A0D009CE2B4 /* Build configuration list for PBXNativeTarget "IGListKit-tvOSTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
885FE1E71DC51A0D009CE2B4 /* Debug */,
885FE1E81DC51A0D009CE2B4 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
887D0B301D870D7E009E01F7 /* Build configuration list for PBXProject "IGListKit" */ = {
isa = XCConfigurationList;
buildConfigurations = (
887D0B481D870D7F009E01F7 /* Debug */,
887D0B491D870D7F009E01F7 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
887D0B4A1D870D7F009E01F7 /* Build configuration list for PBXNativeTarget "IGListKit" */ = {
isa = XCConfigurationList;
buildConfigurations = (
887D0B4B1D870D7F009E01F7 /* Debug */,
887D0B4C1D870D7F009E01F7 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
887D0B4D1D870D7F009E01F7 /* Build configuration list for PBXNativeTarget "IGListKitTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
887D0B4E1D870D7F009E01F7 /* Debug */,
887D0B4F1D870D7F009E01F7 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
macOS support follow-up work, #270 Summary: Progress on #270. - Setup basic, empty example project - Setup test target and add tests that work for macOS - Update changelog - Update travis-ci Closes https://github.com/Instagram/IGListKit/pull/328 Differential Revision: D4325876 Pulled By: jessesquires fbshipit-source-id: 342963ce5103d3980c697655e1f1a9b6f3f1c520
2016-12-14 07:01:21 +00:00
88DF89861E010E6A00B1B9B4 /* Build configuration list for PBXNativeTarget "IGListKit-macOSTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
88DF89841E010E6A00B1B9B4 /* Debug */,
88DF89851E010E6A00B1B9B4 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
macOS support Summary: Added support for macOS. The macOS target includes only the core diffing functionality so `IGListDiff` can be used on macOS apps. I have not added the tests because I don't know how you're setting them up, maybe the same tests can be used by adding some `#if os(...)`s to the test files. I have tested integration on iOS, tvOS and macOS using both Carthage and Cocoapods. Closes https://github.com/Instagram/IGListKit/pull/235 Differential Revision: D4325423 Pulled By: jessesquires fbshipit-source-id: 871bf08410061306004872f5feb7a09d362b6bc1
2016-12-14 04:31:41 +00:00
DD3152A91DE227FA00AC9D2C /* Build configuration list for PBXNativeTarget "IGListKit-macOS" */ = {
isa = XCConfigurationList;
buildConfigurations = (
DD3152AA1DE227FA00AC9D2C /* Debug */,
DD3152AB1DE227FA00AC9D2C /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
Initial commit fbshipit-source-id: c38b897b9e2b87c782e0e01b0145d9189dc7f9d8
2016-09-07 22:37:59 +00:00
/* End XCConfigurationList section */
};
rootObject = 887D0B2D1D870D7E009E01F7 /* Project object */;
}
Reference in a new issue Copy permalink