Elgato_dark/DataDesigner
1
0
Fork 0
mirror of https://github.com/NVIDIA-NeMo/DataDesigner synced 2026-05-24 09:48:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

chore(engine): rename correction-step counter for clarity (#627)

Browse source 
The local counter `curr_num_correction_steps` in `ModelFacade.generate`
and `agenerate` was incremented before each parse attempt, so it
actually counted parse attempts (initial + corrections), not corrections
taken. The name suggested the latter, which made the surrounding
`<= max_correction_steps` check read like a possible off-by-one even
though the math worked out.

Rename it to `parse_attempts` and add a short comment describing the
semantics. Pure refactor: no behavior change.

Closes #371
This commit is contained in:
Nabin Mulepati 2026-05-11 09:29:03 -06:00 committed by GitHub
parent 320e723823
commit 405ddda698
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
packages/data-designer-engine/src/data_designer/engine/models/facade.py
View file

@ -320,7 +320,11 @@ class ModelFacade:
tool_schemas = None
tool_call_turns = 0
total_tool_calls = 0
curr_num_correction_steps = 0
# Counts parse attempts within the current conversation (initial attempt + corrections).
# The first parse is attempt 1, so `parse_attempts <= max_correction_steps` permits exactly
# `max_correction_steps` corrections after the initial attempt before falling through to
# restart-or-raise. Reset to 0 on each conversation restart.
parse_attempts = 0
curr_num_restarts = 0
mcp_facade = self._get_mcp_facade(tool_alias)
@ -367,7 +371,7 @@ class ModelFacade:
response = (completion_response.message.content or "").strip()
reasoning_trace = completion_response.message.reasoning_content
messages.append(ChatMessage.as_assistant(content=response, reasoning_content=reasoning_trace or None))
curr_num_correction_steps += 1
parse_attempts += 1
try:
output_obj = parser(response) # type: ignore - if not a string will cause a ParserException below
@ -379,12 +383,12 @@ class ModelFacade:
exc,
) from exc
if curr_num_correction_steps <= max_correction_steps:
if parse_attempts <= max_correction_steps:
# Add user message with error for correction
messages.append(ChatMessage.as_user(content=str(get_exception_primary_cause(exc))))
elif curr_num_restarts < max_conversation_restarts:
curr_num_correction_steps = 0
parse_attempts = 0
curr_num_restarts += 1
messages = deepcopy(restart_checkpoint)
tool_call_turns = checkpoint_tool_call_turns
@ -425,7 +429,8 @@ class ModelFacade:
tool_schemas = None
tool_call_turns = 0
total_tool_calls = 0
curr_num_correction_steps = 0
# See `generate` for a description of the parse-attempts counter semantics.
parse_attempts = 0
curr_num_restarts = 0
mcp_facade = self._get_mcp_facade(tool_alias)
@ -469,7 +474,7 @@ class ModelFacade:
response = (completion_response.message.content or "").strip()
reasoning_trace = completion_response.message.reasoning_content
messages.append(ChatMessage.as_assistant(content=response, reasoning_content=reasoning_trace or None))
curr_num_correction_steps += 1
parse_attempts += 1
try:
output_obj = parser(response)
@ -481,11 +486,11 @@ class ModelFacade:
exc,
) from exc
if curr_num_correction_steps <= max_correction_steps:
if parse_attempts <= max_correction_steps:
messages.append(ChatMessage.as_user(content=str(get_exception_primary_cause(exc))))
elif curr_num_restarts < max_conversation_restarts:
curr_num_correction_steps = 0
parse_attempts = 0
curr_num_restarts += 1
messages = deepcopy(restart_checkpoint)
tool_call_turns = checkpoint_tool_call_turns