mirror of
https://github.com/coleam00/Archon
synced 2026-04-21 13:37:41 +00:00
* refactor: extract providers from @archon/core into @archon/providers Move Claude and Codex provider implementations, factory, and SDK dependencies into a new @archon/providers package. This establishes a clean boundary: providers own SDK translation, core owns business logic. Key changes: - New @archon/providers package with zero-dep contract layer (types.ts) - @archon/workflows imports from @archon/providers/types — no mirror types - dag-executor delegates option building to providers via nodeConfig - IAgentProvider gains getCapabilities() for provider-agnostic warnings - @archon/core no longer depends on SDK packages directly - UnknownProviderError standardizes error shape across all surfaces Zero user-facing changes — same providers, same config, same behavior. * refactor: remove config type duplication and backward-compat re-exports Address review findings: - Move ClaudeProviderDefaults and CodexProviderDefaults to the @archon/providers/types contract layer as the single source of truth. @archon/core/config/config-types.ts now imports from there. - Remove provider re-exports from @archon/core (index.ts and types/). Consumers should import from @archon/providers directly. - Update @archon/server to depend on @archon/providers for MessageChunk. * refactor: move structured output validation into providers Each provider now normalizes its own structured output semantics: - Claude already yields structuredOutput from the SDK's native field - Codex now parses inline agent_message text as JSON when outputFormat is set, populating structuredOutput on the result chunk This eliminates the last provider === 'codex' branch from dag-executor, making it fully provider-agnostic. The dag-executor checks structuredOutput uniformly regardless of provider. Also removes the ClaudeCodexProviderDefaults deprecated alias — all consumers now use ClaudeProviderDefaults directly. * fix: address PR review — restore warnings, fix loop options, cleanup Critical fixes: - Restore MCP missing env vars user-facing warning (was silently dropped) - Restore Haiku + MCP tool search warning - Fix buildLoopNodeOptions to pass workflow-level nodeConfig (effort, thinking, betas, sandbox were silently lost for loop nodes) - Add TODO(#1135) comments documenting env-leak gate gap Cleanup: - Remove backward-compat type aliases from deps.ts (keep WorkflowTokenUsage) - Remove 26 unnecessary eslint-disable comments from test files - Trim internal helpers from providers barrel (withFirstMessageTimeout, getProcessUid, loadMcpConfig, buildSDKHooksFromYAML) - Add @archon/providers dep to CLI package.json - Fix 8 stale documentation paths pointing to deleted core/src/providers/ - Add E2E smoke test workflows for both Claude and Codex providers * fix: forward provider system warnings to users in dag-executor The dag-executor only forwarded system chunks starting with "MCP server connection failed:" — all other provider warnings (missing env vars, Haiku+MCP, structured output issues) were logged but never reached the user. Now forwards all system chunks starting with ⚠️ (the prefix providers use for user-actionable warnings). * fix: add providers package to Dockerfile and fix CI module resolution - Add packages/providers/ to all three Dockerfile stages (deps, production package.json copy, production source copy) - Replace wildcard export map (./*) with explicit subpath entries to fix module resolution in CI (bun workspace linking) * chore: update bun.lock for providers package exports
111 lines
4 KiB
JavaScript
111 lines
4 KiB
JavaScript
import eslint from '@eslint/js';
|
|
import tseslint from 'typescript-eslint';
|
|
import prettierConfig from 'eslint-config-prettier';
|
|
|
|
export default tseslint.config(
|
|
// Global ignores (applied to all configs)
|
|
{
|
|
ignores: [
|
|
'node_modules/**',
|
|
'packages/*/node_modules/**',
|
|
'packages/*/dist/**',
|
|
'dist/**',
|
|
'coverage/**',
|
|
'.agents/examples/**',
|
|
'packages/docs-web/**',
|
|
'workspace/**',
|
|
'worktrees/**',
|
|
'.claude/worktrees/**',
|
|
'.claude/skills/**',
|
|
'**/*.js',
|
|
'*.mjs',
|
|
'**/*.test.ts',
|
|
'**/src/test/**', // Test helper files (mock factories, fixtures)
|
|
'*.d.ts', // Root-level declaration files (not in tsconfig project scope)
|
|
'**/*.generated.d.ts', // Auto-generated declaration files (e.g. openapi-typescript output)
|
|
'packages/web/vite.config.ts', // Vite config doesn't need type-checked linting
|
|
'packages/web/components.json',
|
|
'packages/web/src/components/ui/**', // shadcn/ui auto-generated components
|
|
'packages/web/src/lib/utils.ts', // shadcn/ui utility file
|
|
],
|
|
},
|
|
|
|
// Base configs
|
|
eslint.configs.recommended,
|
|
...tseslint.configs.recommendedTypeChecked,
|
|
...tseslint.configs.strictTypeChecked,
|
|
...tseslint.configs.stylisticTypeChecked,
|
|
|
|
// Prettier integration
|
|
prettierConfig,
|
|
|
|
// Project-specific settings
|
|
{
|
|
files: ['packages/*/src/**/*.{ts,tsx}'],
|
|
languageOptions: {
|
|
parserOptions: {
|
|
projectService: true,
|
|
tsconfigRootDir: import.meta.dirname,
|
|
},
|
|
},
|
|
rules: {
|
|
// === ENFORCED RULES (errors) ===
|
|
'@typescript-eslint/explicit-function-return-type': 'error',
|
|
'@typescript-eslint/no-explicit-any': 'error',
|
|
'@typescript-eslint/no-unused-vars': [
|
|
'error',
|
|
{
|
|
argsIgnorePattern: '^_',
|
|
varsIgnorePattern: '^_',
|
|
caughtErrorsIgnorePattern: '^_',
|
|
},
|
|
],
|
|
quotes: ['error', 'single', { avoidEscape: true }],
|
|
semi: ['error', 'always'],
|
|
'@typescript-eslint/naming-convention': [
|
|
'error',
|
|
{
|
|
selector: 'interface',
|
|
format: ['PascalCase'],
|
|
custom: { regex: '^I?[A-Z]', match: true },
|
|
},
|
|
{ selector: 'typeAlias', format: ['PascalCase'] },
|
|
{ selector: 'function', format: ['camelCase', 'PascalCase'] },
|
|
{ selector: 'variable', format: ['camelCase', 'UPPER_CASE'] },
|
|
],
|
|
'@typescript-eslint/no-non-null-assertion': 'error',
|
|
|
|
// === DISABLED RULES ===
|
|
|
|
// --- Template/expression rules ---
|
|
// Numbers/booleans in template literals are valid JS (auto-converted to string)
|
|
'@typescript-eslint/restrict-template-expressions': 'off',
|
|
// Mixed operands in + are often intentional (string concatenation)
|
|
'@typescript-eslint/restrict-plus-operands': 'off',
|
|
|
|
// --- Defensive coding patterns ---
|
|
// Switch defaults, null checks, and defensive guards are valuable
|
|
'@typescript-eslint/no-unnecessary-condition': 'off',
|
|
// Env var checks need || for truthy evaluation (empty string = missing)
|
|
'@typescript-eslint/prefer-nullish-coalescing': 'off',
|
|
|
|
// --- External SDK interop (types are often `any` or incomplete) ---
|
|
'@typescript-eslint/no-unsafe-assignment': 'off',
|
|
'@typescript-eslint/no-unsafe-member-access': 'off',
|
|
'@typescript-eslint/no-unsafe-argument': 'off',
|
|
// Event handler patterns in SDKs often have promise mismatches
|
|
'@typescript-eslint/no-misused-promises': 'off',
|
|
'@typescript-eslint/no-floating-promises': 'off',
|
|
|
|
// --- Style preferences (not critical for type safety) ---
|
|
// Catch variable typing preference
|
|
'@typescript-eslint/use-unknown-in-catch-callback-variable': 'off',
|
|
// Allow using deprecated APIs during migration periods
|
|
'@typescript-eslint/no-deprecated': 'off',
|
|
// Empty async functions valid for interface compliance
|
|
'@typescript-eslint/require-await': 'off',
|
|
// Constructor style preference
|
|
'@typescript-eslint/consistent-generic-constructors': 'off',
|
|
},
|
|
}
|
|
);
|