From cd8e4ddf00d5fae0e74c3ad3902a575a6abc9866 Mon Sep 17 00:00:00 2001 From: Eakam <67077705+Eakam1007@users.noreply.github.com> Date: Tue, 1 Nov 2022 09:01:35 -0400 Subject: [PATCH] fix: disappearing hover effect on popover trigger (#1403) --- .../packages/appflowy_popover/lib/src/popover.dart | 14 +++----------- .../flowy_infra_ui/lib/style_widget/hover.dart | 2 +- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/frontend/app_flowy/packages/appflowy_popover/lib/src/popover.dart b/frontend/app_flowy/packages/appflowy_popover/lib/src/popover.dart index 6b666c278c..a08787df00 100644 --- a/frontend/app_flowy/packages/appflowy_popover/lib/src/popover.dart +++ b/frontend/app_flowy/packages/appflowy_popover/lib/src/popover.dart @@ -96,7 +96,6 @@ class Popover extends StatefulWidget { class PopoverState extends State { static final RootOverlayEntry _rootEntry = RootOverlayEntry(); final PopoverLink popoverLink = PopoverLink(); - Timer? _debounceEnterRegionAction; @override void initState() { @@ -175,16 +174,9 @@ class PopoverState extends State { return MouseRegion( onEnter: (event) { - _debounceEnterRegionAction = - Timer(const Duration(milliseconds: 200), () { - if (widget.triggerActions & PopoverTriggerFlags.hover != 0) { - showOverlay(); - } - }); - }, - onExit: (event) { - _debounceEnterRegionAction?.cancel(); - _debounceEnterRegionAction = null; + if (widget.triggerActions & PopoverTriggerFlags.hover != 0) { + showOverlay(); + } }, child: Listener( child: widget.child, diff --git a/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/hover.dart b/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/hover.dart index 5df1d56868..d6f3eeb6e8 100644 --- a/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/hover.dart +++ b/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/hover.dart @@ -51,7 +51,7 @@ class _FlowyHoverState extends State { return MouseRegion( cursor: widget.cursor != null ? widget.cursor! : SystemMouseCursors.click, opaque: false, - onEnter: (p) { + onHover: (p) { if (_onHover) return; if (widget.buildWhenOnHover?.call() ?? true) {